Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43284?usp=email )
Change subject: DIAMETER: Get Rid of DIAMETER_ConnHdlr_CT in several testsuites
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43284?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id88b88d2f3472e1f4daa8344ca1fc6d408edfb62
Gerrit-Change-Number: 43284
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 19 Aug 2026 07:41:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43263?usp=email )
Change subject: pyhss: adjust to debian packaging changes
......................................................................
pyhss: adjust to debian packaging changes
The Osmocom OBS is now building pyhss directly from upstream. Debian
packaging has been reworked there to use the --builtin-venv option of
dh_virtualenv:
https://github.com/nickvsnetworking/pyhss/commit/747be66b19dd40fc4bc9b060fe…
This had the side-effect that we can't source
/opt/venvs/pyhss/bin/activate anymore after the build to get the correct
PATH of the venv:
$ . /opt/venvs/pyhss/bin/activate
(pyhss) # echo $PATH
/usr/src/packages/BUILD/debian/pyhss/opt/venvs/pyhss/bin:…
Set the proper PATH directly instead of going through this script.
Change-Id: I094334e4879180adaa7825fe777b342f4db6ce73
---
M hlr/pyhss/run_in_venv.sh
M hss/pyhss/run_in_venv.sh
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/hlr/pyhss/run_in_venv.sh b/hlr/pyhss/run_in_venv.sh
index a145a7d..571c1d8 100755
--- a/hlr/pyhss/run_in_venv.sh
+++ b/hlr/pyhss/run_in_venv.sh
@@ -3,7 +3,7 @@
if [ "$TESTENV_INSTALL_DIR" = "/" ]; then
# Installed via debian package
- . /opt/venvs/pyhss/bin/activate
+ export PATH=/opt/venvs/pyhss/bin:"$PATH"
else
# Built with osmo-dev
. "$TESTENV_INSTALL_DIR"/venv/bin/activate
diff --git a/hss/pyhss/run_in_venv.sh b/hss/pyhss/run_in_venv.sh
index a145a7d..571c1d8 100755
--- a/hss/pyhss/run_in_venv.sh
+++ b/hss/pyhss/run_in_venv.sh
@@ -3,7 +3,7 @@
if [ "$TESTENV_INSTALL_DIR" = "/" ]; then
# Installed via debian package
- . /opt/venvs/pyhss/bin/activate
+ export PATH=/opt/venvs/pyhss/bin:"$PATH"
else
# Built with osmo-dev
. "$TESTENV_INSTALL_DIR"/venv/bin/activate
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43263?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I094334e4879180adaa7825fe777b342f4db6ce73
Gerrit-Change-Number: 43263
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43287?usp=email )
Change subject: saip BatchPersonalization: call rebuild_mandatory_services()
......................................................................
saip BatchPersonalization: call rebuild_mandatory_services()
Particular reason: when manipulating the 5G SUCI parameters, the
mandatory services get-identity, profile-a-x25519 and profile-b-p256 may
need to be reconfigured.
In general, it is a good idea to run these checks anyway.
Change-Id: I5e6eef0f1845a25cddb03af8d16c40e305bcdc1f
Jenkins: skip-card-test
---
M pySim/esim/saip/batch.py
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/87/43287/1
diff --git a/pySim/esim/saip/batch.py b/pySim/esim/saip/batch.py
index 6d3ded1..338c5d1 100644
--- a/pySim/esim/saip/batch.py
+++ b/pySim/esim/saip/batch.py
@@ -123,6 +123,8 @@
except Exception as e:
raise ValueError(f'{p.param_cls.get_name()} fed by {p.src.name}: {e}') from e
+ pes.rebuild_mandatory_services()
+
yield pes
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43287?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I5e6eef0f1845a25cddb03af8d16c40e305bcdc1f
Gerrit-Change-Number: 43287
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43289?usp=email )
Change subject: typo 'concetenation' in personalization.py
......................................................................
typo 'concetenation' in personalization.py
Change-Id: I51345db014335e8a70a7437a9cad5a3e47570a95
Jenkins: skip-card-test
---
M pySim/esim/saip/personalization.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/89/43289/1
diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py
index a73678f..6f88d52 100644
--- a/pySim/esim/saip/personalization.py
+++ b/pySim/esim/saip/personalization.py
@@ -1156,7 +1156,7 @@
class MilenageXoringConstants(BinaryParam, AlgoConfig):
"""XOR-ing constants c1,c2,c3,c4,c5 of Milenage, 128bit each. See 3GPP TS 35.206 Sections 2.3 + 5.3.
- Provided as octet-string concatenation of all 5 constants. The default value by 3GPP is the concetenation
+ Provided as octet-string concatenation of all 5 constants. The default value by 3GPP is the concatenation
of::
00000000000000000000000000000000
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43289?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I51345db014335e8a70a7437a9cad5a3e47570a95
Gerrit-Change-Number: 43289
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/43290?usp=email )
Change subject: ts_31_102.py: EF_SUCI_Calc_Info(TransparentEF): fix len test
......................................................................
ts_31_102.py: EF_SUCI_Calc_Info(TransparentEF): fix len test
while len(foo):
throws an exception when foo == None.
Instead doing
while foo:
fixes a problem when reading in empty SUCI calc info data, e.g. from
TS48v7.0_SAIP2.3_BERTLV_SUCI_NoRAMRFM.der.
Change-Id: Ia4e2356d0241d7a6ca399ba7e8be7f27ec836104
Jenkins: skip-card-test
---
M pySim/ts_31_102.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/90/43290/1
diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py
index b354b32..843f7c4 100644
--- a/pySim/ts_31_102.py
+++ b/pySim/ts_31_102.py
@@ -335,7 +335,7 @@
"""conversion method to generate list of {hnet_pubkey_identifier, hnet_pubkey} dicts
from flat [{hnet_pubkey_identifier: }, {net_pubkey: }, ...] list"""
out = []
- while len(l):
+ while l:
a = l.pop(0)
b = l.pop(0)
z = {**a, **b}
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/43290?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ia4e2356d0241d7a6ca399ba7e8be7f27ec836104
Gerrit-Change-Number: 43290
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>