Attention is currently required from: laforge, osmith, pespin.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43387?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by laforge, Code-Review+1 by osmith, Verified+1 by Jenkins Builder
Change subject: m3ua: Validate IE lengths of ASPTM & ASPSM messages [2/6]
......................................................................
m3ua: Validate IE lengths of ASPTM & ASPSM messages [2/6]
Since all IEs in APTM and ASPSM messages are Optional, and until
recently we only validated presence of mandatory IEs, there were no
related structs for such messages.
Now that we validate lengths of IEs, add the definitions for those
messages too.
Related: OS#7074
Reported-By: Tristan Madani <tristan(a)talencesecurity.com>
Change-Id: I27406eac5b82c1e6702961bb3482b0bf7fe4ff15
---
M src/m3ua.c
1 file changed, 64 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/87/43387/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43387?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I27406eac5b82c1e6702961bb3482b0bf7fe4ff15
Gerrit-Change-Number: 43387
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43399?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: sua: Do SUA specific SNM msg validation [4/6]
......................................................................
sua: Do SUA specific SNM msg validation [4/6]
SUA SNM messages contain IEs different than those of related M3UA SNM
messages. Until now it was fine because we only checked for mandatory
IEs, but it's not the case anymore.
Related: OS#7074
Reported-By: Tristan Madani <tristan(a)talencesecurity.com>
Change-Id: Iba32835035867175fa83f3c1e0639918b37432b5
---
M src/sua.c
1 file changed, 76 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/99/43399/2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43399?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Iba32835035867175fa83f3c1e0639918b37432b5
Gerrit-Change-Number: 43399
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Attention is currently required from: laforge, osmith, pespin.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43394?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review+1 by osmith, Code-Review+2 by laforge, Verified+1 by Jenkins Builder
The change is no longer submittable: Code-Review and Verified are unsatisfied now.
Change subject: xua_rkm: Validate IE lengths of M3UA RKM inner messages
......................................................................
xua_rkm: Validate IE lengths of M3UA RKM inner messages
SUA RKM is not yet implemented, and the existing functions are only
expected to be used by M3UA.
Related: OS#7074
Reported-By: Tristan Madani <tristan(a)talencesecurity.com>
Change-Id: Ibe7e446b1a537c0c09f8049add3460e37cdd58e8
---
M src/m3ua.c
M src/xua_internal.h
M src/xua_msg.c
M src/xua_msg.h
M src/xua_rkm.c
5 files changed, 101 insertions(+), 13 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/94/43394/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43394?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ibe7e446b1a537c0c09f8049add3460e37cdd58e8
Gerrit-Change-Number: 43394
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43396?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: xua_rkm: rx REG REQ: clean up Routing Context IE checks
......................................................................
xua_rkm: rx REG REQ: clean up Routing Context IE checks
RFC4666 3.6.1 clearly marks the IE as optional. Our exisitng logic also
expected that the routing key may not be there.
Validate existence of the IE and explicitly set local variable to 0
instead of relying on xua_msg_get_u32() returning 0 on failure.
Change-Id: I0dd6b2892f9ffa72880f98d03e13f0b354c47c61
---
M src/xua_rkm.c
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/96/43396/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43396?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I0dd6b2892f9ffa72880f98d03e13f0b354c47c61
Gerrit-Change-Number: 43396
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43395?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: xua_rkm: rx DEREG REQ: Fix potential read buffer overflow
......................................................................
xua_rkm: rx DEREG REQ: Fix potential read buffer overflow
The loop in the function was not taking into account cases like data
being non-multiple of 4.
Related: OS#7074
Reported-By: Tristan Madani <tristan(a)talencesecurity.com>
Change-Id: I861259b2bb57ce80167a8f2d1c1770b56dc09718
---
M src/xua_rkm.c
1 file changed, 21 insertions(+), 7 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/95/43395/4
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43395?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I861259b2bb57ce80167a8f2d1c1770b56dc09718
Gerrit-Change-Number: 43395
Gerrit-PatchSet: 4
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43397?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: xua_rkm: REG REQ: clean up Traffic Mode Type checks
......................................................................
xua_rkm: REG REQ: clean up Traffic Mode Type checks
Validate existence of the IE and explicitly set local variable to 0
instead of relying on xua_msg_get_u32() returning 0 on failure.
Change-Id: I4b07b0608eaf2e841f47f7c664e056152ca68f72
---
M src/xua_rkm.c
1 file changed, 17 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/97/43397/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43397?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I4b07b0608eaf2e841f47f7c664e056152ca68f72
Gerrit-Change-Number: 43397
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
Hello Jenkins Builder, laforge, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43398?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: xua_asp_fsm: ASP ACT: Avoid double lookup of Traffic Mode Type IE
......................................................................
xua_asp_fsm: ASP ACT: Avoid double lookup of Traffic Mode Type IE
Change-Id: Idc764d9d6f517cd28defaf226e6b0957cce92585
---
M src/xua_asp_fsm.c
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/98/43398/3
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43398?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Idc764d9d6f517cd28defaf226e6b0957cce92585
Gerrit-Change-Number: 43398
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email )
Change subject: Update README.md related to the current command line parameters
......................................................................
Update README.md related to the current command line parameters
Change-Id: I66b89db33676139c8746eb1f94133e14af6e1485
---
M README.md
1 file changed, 11 insertions(+), 11 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/03/43403/1
diff --git a/README.md b/README.md
index 2c7ba03..a920c09 100644
--- a/README.md
+++ b/README.md
@@ -2,8 +2,8 @@
onomondo-ipa is a C-based IoT Profile Assistant in the IoT Device (IPAd, see also SGP.31) implementation. The IPAd is an
element in the 3GPP IoT eSIM system as described in SGP.31 and SGP.32. It interfaces between the eUICC on one side,
-and the eIM (via HTTPS) on the other side. The implementation presented here can run on a regular Linux host. It can also be used
-as a library to add IPAd functionality to an IoT device that runs an RTOS.
+and the eIM (via HTTPS) on the other side. The implementation presented here can run on a regular Linux host. It can
+also be used as a library to add IPAd functionality to an IoT device that runs an RTOS.
This code currently implements SGP.32 v1.0, an early version
of the GSMA specifications which did never get used in production. The only SAS-SM accredited eUICCs
@@ -89,15 +89,15 @@
### Command-Line Options
-There are a number of command-line options supported. The most relevant options are:
+There are a number of command-line options and operations supported. The most relevant options are:
* `-r` specifies the PCSC reader number.
-* `-f` specifies the path to an initial eIM configuration file.
+* `add-initial-eim <PATH>` specifies the path to an initial eIM configuration file.
* `-I` omit verification of the SSL certificate of the eIM. This option makes the operation of onomondo-ipa insecure,
but may be helpful for testing and debugging in lab setups.
* `-E` enable the IoT eUICC emulation in case a regular consumer eUICC should be used.
-(use option -h to query the full list of parameters)
+(use option -h to query the full list of options and operation parameters)
### Initial Setup
@@ -112,15 +112,15 @@
Example: load the initial eIM configuration onto the eUICC in PCSC reader 2
```
-./src/ipa/ipa -r 2 -f ../contrib/sample_eim_cfg.ber
+./src/ipa/ipa -r 2 add-initial-eim ../contrib/sample_eim_cfg.ber
```
### Querying eIM Packages
-When onomondo-ipa is called without the `-f` parameter, it will read the eUICC configuration and the eidValue from the
-eUICC and use it to query the eIM for eIM packages. In case no eIM package is available (error code
-noEimPackageAvailable), onomondo-ipa will exit. This condition is technically not an error, it just means that currently
-no eIM package is available for the given eUICC / eidValue.
+When onomondo-ipa is called without the `add-initial-eim` operation parameter, it will read the eUICC configuration and
+the eidValue from the eUICC and use it to query the eIM for eIM packages. In case no eIM package is available (error
+code noEimPackageAvailable), onomondo-ipa will exit. This condition is technically not an error, it just means that
+currently no eIM package is available for the given eUICC / eidValue.
When there is an eIM package available for the given eUICC / eidValue, then onomondo-ipa will download it and execute
the requested procedure. Immediately after that, the next eIM package is requested and processed until the eIM returns
@@ -134,6 +134,6 @@
License
----------
-Copyright (c) 2025 Onomondo ApS & sysmocom - s.f.m.c. GmbH.
+Copyright (c) 2025-2026 Onomondo ApS & sysmocom - s.f.m.c. GmbH.
Licensed under the GNU Affero General Public License v3.0 only.
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43403?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I66b89db33676139c8746eb1f94133e14af6e1485
Gerrit-Change-Number: 43403
Gerrit-PatchSet: 1
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Attention is currently required from: jolly.
dexter has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email )
Change subject: V1.2: Add function ES10b.GetConnectivityParameters
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/ipa/libipa/ipad.c:
https://gerrit.osmocom.org/c/onomondo-ipa/+/43054/comment/fd63a29f_9e15eb51… :
PS9, Line 376: ;
I would recommend a log message like you did in https://gerrit.osmocom.org/c/onomondo-ipa/+/43055/8/src/ipa/libipa/esipa_pr…
IPA_LOGP_ESIPA("GetConnectivityParametersRequest", LERROR, "empty GetConnectivityParametersResponse response!\n");
--
To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43054?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-ipa
Gerrit-Branch: master
Gerrit-Change-Id: I075590e095dbbe05fa6cdb0a96d5b38c7a17ff78
Gerrit-Change-Number: 43054
Gerrit-PatchSet: 9
Gerrit-Owner: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Comment-Date: Wed, 26 Aug 2026 10:39:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes