August 2026 - gerrit-log - lists.osmocom.org

[XS] Change in onomondo-ipa[master]: Add missing Pepare Download error handling
by jolly 26 Aug '26

26 Aug '26

Attention is currently required from: jolly. Hello Jenkins Builder, dexter, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email to look at the new patch set (#5). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: Add missing Pepare Download error handling ...................................................................... Add missing Pepare Download error handling If Prepare Download on eUICC fails, an error code ist set. Be sure to check the error code and trigger session cancellation, if set. Related: SYS#8101 Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa --- M src/ipa/libipa/proc_prfle_dwnld.c 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/02/43302/5 -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43302?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I6f13a12c494be57d6a6f377567bf38b0235ec4aa Gerrit-Change-Number: 43302 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu>

1 0

[XS] Change in libosmo-sigtran[master]: sua: Rename msg_class to contain sua prefix
by pespin 26 Aug '26

26 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43405?usp=email ) Change subject: sua: Rename msg_class to contain sua prefix ...................................................................... sua: Rename msg_class to contain sua prefix Change-Id: Ib5e23bf1f98e658eb651b98ac6071639c817eae5 --- M src/sua.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/05/43405/1 diff --git a/src/sua.c b/src/sua.c index 7c6d57f..f11bc9e 100644 --- a/src/sua.c +++ b/src/sua.c @@ -136,7 +136,7 @@ { SUA_CL_CLDR, "CLDR" }, { 0, NULL } }; -static const struct xua_msg_class msg_class_cl = { +static const struct xua_msg_class sua_msg_class_cl = { .name = "CL", .msgt_names = sua_cl_msgt_names, .iei_names = sua_iei_names, @@ -200,7 +200,7 @@ { SUA_CO_COIT, "COIT" }, { 0, NULL } }; -static const struct xua_msg_class msg_class_co = { +static const struct xua_msg_class sua_msg_class_co = { .name = "CO", .msgt_names = sua_co_msgt_names, .iei_names = sua_iei_names, @@ -229,8 +229,8 @@ [SUA_MSGC_SNM] = &m3ua_msg_class_snm, [SUA_MSGC_ASPSM] = &m3ua_msg_class_aspsm, [SUA_MSGC_ASPTM] = &m3ua_msg_class_asptm, - [SUA_MSGC_CL] = &msg_class_cl, - [SUA_MSGC_CO] = &msg_class_co, + [SUA_MSGC_CL] = &sua_msg_class_cl, + [SUA_MSGC_CO] = &sua_msg_class_co, [SUA_MSGC_RKM] = &m3ua_msg_class_rkm, }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43405?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib5e23bf1f98e658eb651b98ac6071639c817eae5 Gerrit-Change-Number: 43405 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: m3ua: XFER,SNM,ASPSM: Add Missing iei_names refernece to log IE names
by pespin 26 Aug '26

26 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43406?usp=email ) Change subject: m3ua: XFER,SNM,ASPSM: Add Missing iei_names refernece to log IE names ...................................................................... m3ua: XFER,SNM,ASPSM: Add Missing iei_names refernece to log IE names Change-Id: Ifeca2f0e337cd5916110767a99d12c71c49b81fe --- M src/m3ua.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/06/43406/1 diff --git a/src/m3ua.c b/src/m3ua.c index b29cfcf..46e145b 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -159,6 +159,7 @@ static const struct xua_msg_class msg_class_xfer = { .name = "XFER", .msgt_names = m3ua_xfer_msgt_names, + .iei_names = m3ua_iei_names, .mand_ies = { MAND_IES(M3UA_XFER_DATA, data_mand_ies), }, @@ -195,6 +196,7 @@ const struct xua_msg_class m3ua_msg_class_snm = { .name = "SNM", .msgt_names = m3ua_snm_msgt_names, + .iei_names = m3ua_iei_names, .mand_ies = { MAND_IES(M3UA_SNM_DUNA, duna_mand_ies), MAND_IES(M3UA_SNM_DAVA, dava_mand_ies), @@ -218,6 +220,7 @@ const struct xua_msg_class m3ua_msg_class_aspsm = { .name = "ASPSM", .msgt_names = m3ua_aspsm_msgt_names, + .iei_names = m3ua_iei_names, }; /* ASPTM */ -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43406?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ifeca2f0e337cd5916110767a99d12c71c49b81fe Gerrit-Change-Number: 43406 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sua: Do SUA specific RKM msg validation [3/6]
by pespin 26 Aug '26

26 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43407?usp=email ) Change subject: sua: Do SUA specific RKM msg validation [3/6] ...................................................................... sua: Do SUA specific RKM msg validation [3/6] SUA MGMT ERR messages contain Network Appearance IE, which has different tag than related IE in M3UA. Until now it was fine because we only checked for mandatory IEs, but it's not the case anymore. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I97ae5683d8eee2c6d30ae49736ca3fffe33a665f --- M src/m3ua.c M src/sua.c M src/xua_internal.h 3 files changed, 32 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/07/43407/1 diff --git a/src/m3ua.c b/src/m3ua.c index f500883..efa650b 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -389,7 +389,7 @@ }; /* MGMT */ -static const struct xua_msg_part_class err_req_ies[] = { +static const struct xua_msg_part_class m3ua_err_req_ies[] = { M3UA_MSG_PART_CLASS_ERR_CODE(true), M3UA_MSG_PART_CLASS_ROUTE_CTX(false), M3UA_MSG_PART_CLASS_NET_APPEAR(false), @@ -397,14 +397,14 @@ M3UA_MSG_PART_CLASS_DIAG_INFO(false), XUA_MSG_PART_CLASS_EOF }; -static const struct xua_msg_part_class ntfy_req_ies[] = { +const struct xua_msg_part_class m3ua_ntfy_req_ies[] = { M3UA_MSG_PART_CLASS_STATUS(true), M3UA_MSG_PART_CLASS_ASP_ID(false), M3UA_MSG_PART_CLASS_ROUTE_CTX(false), M3UA_MSG_PART_CLASS_INFO_STRING(false), XUA_MSG_PART_CLASS_EOF }; -static const struct value_string m3ua_mgmt_msgt_names[] = { +const struct value_string m3ua_mgmt_msgt_names[] = { { M3UA_MGMT_ERR, "ERROR" }, { M3UA_MGMT_NTFY, "NOTIFY" }, { 0, NULL } @@ -414,8 +414,8 @@ .msgt_names = m3ua_mgmt_msgt_names, .iei_names = m3ua_iei_names, .ies = { - IES(M3UA_MGMT_ERR, err_req_ies), - IES(M3UA_MGMT_NTFY, ntfy_req_ies), + IES(M3UA_MGMT_ERR, m3ua_err_req_ies), + IES(M3UA_MGMT_NTFY, m3ua_ntfy_req_ies), }, }; diff --git a/src/sua.c b/src/sua.c index af4b1f3..ab84abe 100644 --- a/src/sua.c +++ b/src/sua.c @@ -185,6 +185,9 @@ #define SUA_MSG_PART_CLASS_CAUSE(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_CAUSE, (mandatory)) +#define SUA_MSG_PART_CLASS_NET_APPEARANCE(mandatory) \ + XUA_MSG_PART_CLASS_U32(SUA_IEI_NET_APPEARANCE, (mandatory)) + #define SUA_MSG_PART_CLASS_DATA(mandatory) \ XUA_MSG_PART_CLASS_UNBOUND(SUA_IEI_DATA, (mandatory)) @@ -376,13 +379,33 @@ }, }; +/* MGMT */ +/* ERR msg in SUA is almost same as M3UA, but "Network Appearance" IE has differnet TAG... */ +static const struct xua_msg_part_class sua_err_req_ies[] = { + SUA_MSG_PART_CLASS_ERR_CODE(true), + SUA_MSG_PART_CLASS_ROUTE_CTX(false), + SUA_MSG_PART_CLASS_NET_APPEARANCE(false), + SUA_MSG_PART_CLASS_AFFECTED_PC(false), + SUA_MSG_PART_CLASS_DIAG_INFO(false), + XUA_MSG_PART_CLASS_EOF +}; +static const struct xua_msg_class sua_msg_class_mgmt = { + .name = "MGMT", + .msgt_names = m3ua_mgmt_msgt_names, + .iei_names = sua_iei_names, + .ies = { + IES(SUA_MGMT_ERR, sua_err_req_ies), + IES(SUA_MGMT_NTFY, m3ua_ntfy_req_ies), + }, +}; + const struct xua_dialect xua_dialect_sua = { .name = "SUA", .ppid = SUA_PPID, .port = SUA_PORT, .log_subsys = DLSUA, .class = { - [SUA_MSGC_MGMT] = &m3ua_msg_class_mgmt, /* TODO: different than M3UA */ + [SUA_MSGC_MGMT] = &sua_msg_class_mgmt, [SUA_MSGC_SNM] = &m3ua_msg_class_snm, /* TODO: different than M3UA */ [SUA_MSGC_ASPSM] = &m3ua_msg_class_aspsm, /* Same as M3UA */ [SUA_MSGC_ASPTM] = &m3ua_msg_class_asptm, /* TODO: different than M3UA */ diff --git a/src/xua_internal.h b/src/xua_internal.h index 5195b35..bd18401 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -91,7 +91,10 @@ extern const struct xua_msg_class m3ua_msg_class_aspsm; extern const struct xua_msg_class m3ua_msg_class_asptm; +extern const struct xua_msg_part_class m3ua_ntfy_req_ies[]; + extern const struct value_string m3ua_snm_msgt_names[]; +extern const struct value_string m3ua_mgmt_msgt_names[]; extern const struct value_string m3ua_err_names[]; extern const struct value_string m3ua_ntfy_type_names[]; extern const struct value_string m3ua_ntfy_stchg_names[]; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43407?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I97ae5683d8eee2c6d30ae49736ca3fffe33a665f Gerrit-Change-Number: 43407 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sua: Do SUA specific ASPTM msg validation [5/6]
by pespin 26 Aug '26

26 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43408?usp=email ) Change subject: sua: Do SUA specific ASPTM msg validation [5/6] ...................................................................... sua: Do SUA specific ASPTM msg validation [5/6] SUA ASPTM ASP Activate message contain different IEs than those in the related M3UA message. Reuse M3UA structs when possible and define a new SUA structure for that message. Until now it was fine because we only checked for mandatory IEs, but it's not the case anymore. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: Ib35823b84398d43879268565e9557757f9a04c45 --- M src/m3ua.c M src/sua.c M src/xua_internal.h 3 files changed, 39 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/08/43408/1 diff --git a/src/m3ua.c b/src/m3ua.c index efa650b..79e654d 100644 --- a/src/m3ua.c +++ b/src/m3ua.c @@ -353,18 +353,19 @@ M3UA_MSG_PART_CLASS_INFO_STRING(false), XUA_MSG_PART_CLASS_EOF }; -static const struct xua_msg_part_class m3ua_asp_inact_ies[] = { +/* The following 3 msg structs are reused by SUA since it contains same IEs: */ +const struct xua_msg_part_class m3ua_asp_inact_ies[] = { M3UA_MSG_PART_CLASS_ROUTE_CTX(false), M3UA_MSG_PART_CLASS_INFO_STRING(false), XUA_MSG_PART_CLASS_EOF }; -static const struct xua_msg_part_class m3ua_asp_act_ack_ies[] = { +const struct xua_msg_part_class m3ua_asp_act_ack_ies[] = { M3UA_MSG_PART_CLASS_TRAF_MODE_TYP(false), M3UA_MSG_PART_CLASS_ROUTE_CTX(false), M3UA_MSG_PART_CLASS_INFO_STRING(false), XUA_MSG_PART_CLASS_EOF }; -static const struct xua_msg_part_class m3ua_asp_inact_ack_ies[] = { +const struct xua_msg_part_class m3ua_asp_inact_ack_ies[] = { M3UA_MSG_PART_CLASS_ROUTE_CTX(false), M3UA_MSG_PART_CLASS_INFO_STRING(false), XUA_MSG_PART_CLASS_EOF diff --git a/src/sua.c b/src/sua.c index 7573661..25e1ee8 100644 --- a/src/sua.c +++ b/src/sua.c @@ -138,6 +138,9 @@ #define SUA_MSG_PART_CLASS_DIAG_INFO(mandatory) \ XUA_MSG_PART_CLASS_UNBOUND(SUA_IEI_DIAG_INFO, (mandatory)) +#define SUA_MSG_PART_CLASS_TRAF_MODE_TYP(mandatory) \ + XUA_MSG_PART_CLASS_U32(SUA_IEI_TRAF_MODE_TYP, (mandatory)) + #define SUA_MSG_PART_CLASS_ERR_CODE(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_ERR_CODE, (mandatory)) @@ -194,6 +197,12 @@ #define SUA_MSG_PART_CLASS_USER_CAUSE(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_USER_CAUSE, (mandatory)) +#define SUA_MSG_PART_CLASS_DRN(mandatory) \ + XUA_MSG_PART_CLASS_U32(SUA_IEI_DRN, (mandatory)) + +#define SUA_MSG_PART_CLASS_TID(mandatory) \ + XUA_MSG_PART_CLASS_U32(SUA_IEI_TID, (mandatory)) + #define SUA_MSG_PART_CLASS_SMI(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_SMI, (mandatory)) @@ -278,6 +287,27 @@ }, }; +/* ASPTM: Only "ASP Active" IEs differ between SUA and M3UA: */ +static const struct xua_msg_part_class sua_asp_act_ies[] = { + SUA_MSG_PART_CLASS_TRAF_MODE_TYP(false), + SUA_MSG_PART_CLASS_ROUTE_CTX(false), + SUA_MSG_PART_CLASS_TID(false), + SUA_MSG_PART_CLASS_DRN(false), + SUA_MSG_PART_CLASS_INFO_STRING(false), + XUA_MSG_PART_CLASS_EOF +}; +const struct xua_msg_class sua_msg_class_asptm = { + .name = "ASPTM", + .msgt_names = m3ua_asptm_msgt_names, + .iei_names = sua_iei_names, + .ies = { + IES(SUA_ASPTM_ACTIVE, sua_asp_act_ies), + IES(SUA_ASPTM_INACTIVE, m3ua_asp_inact_ies), + IES(SUA_ASPTM_ACTIVE_ACK, m3ua_asp_act_ack_ies), + IES(SUA_ASPTM_INACTIVE_ACK, m3ua_asp_inact_ack_ies), + }, +}; + static const struct xua_msg_part_class cldt_ies[] = { SUA_MSG_PART_CLASS_ROUTE_CTX(true), SUA_MSG_PART_CLASS_PROTO_CLASS(true), @@ -483,7 +513,7 @@ [SUA_MSGC_MGMT] = &sua_msg_class_mgmt, [SUA_MSGC_SNM] = &sua_msg_class_snm, [SUA_MSGC_ASPSM] = &m3ua_msg_class_aspsm, /* Same as M3UA */ - [SUA_MSGC_ASPTM] = &m3ua_msg_class_asptm, /* TODO: different than M3UA */ + [SUA_MSGC_ASPTM] = &sua_msg_class_asptm, [SUA_MSGC_CL] = &sua_msg_class_cl, [SUA_MSGC_CO] = &sua_msg_class_co, [SUA_MSGC_RKM] = &m3ua_msg_class_rkm, /* TODO: different than M3UA */ diff --git a/src/xua_internal.h b/src/xua_internal.h index bd18401..5422161 100644 --- a/src/xua_internal.h +++ b/src/xua_internal.h @@ -92,9 +92,13 @@ extern const struct xua_msg_class m3ua_msg_class_asptm; extern const struct xua_msg_part_class m3ua_ntfy_req_ies[]; +extern const struct xua_msg_part_class m3ua_asp_inact_ies[]; +extern const struct xua_msg_part_class m3ua_asp_act_ack_ies[]; +extern const struct xua_msg_part_class m3ua_asp_inact_ack_ies[]; extern const struct value_string m3ua_snm_msgt_names[]; extern const struct value_string m3ua_mgmt_msgt_names[]; +extern const struct value_string m3ua_asptm_msgt_names[]; extern const struct value_string m3ua_err_names[]; extern const struct value_string m3ua_ntfy_type_names[]; extern const struct value_string m3ua_ntfy_stchg_names[]; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43408?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib35823b84398d43879268565e9557757f9a04c45 Gerrit-Change-Number: 43408 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: sua: Do SUA specific RKM msg validation [6/6]
by pespin 26 Aug '26

26 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43409?usp=email ) Change subject: sua: Do SUA specific RKM msg validation [6/6] ...................................................................... sua: Do SUA specific RKM msg validation [6/6] SUA RKM messages contain IEs different than those of related M3UA RKM messages. Until now it was fine because we only checked for mandatory IEs, but it's not the case anymore. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I0a1a9f22b3b3c0c5df200d3de08e4f8087be06f7 --- M src/sua.c 1 file changed, 43 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/09/43409/1 diff --git a/src/sua.c b/src/sua.c index 25e1ee8..b0717c0 100644 --- a/src/sua.c +++ b/src/sua.c @@ -158,6 +158,12 @@ /* SUA specific: */ +#define SUA_MSG_PART_CLASS_REG_RESULT(mandatory) \ + XUA_MSG_PART_CLASS(SUA_IEI_REG_RESULT, (mandatory), true, 0, XUA_MSG_PART_CLASS_MAX_LEN) + +#define SUA_MSG_PART_CLASS_DEREG_RESULT(mandatory) \ + XUA_MSG_PART_CLASS(SUA_IEI_DEREG_RESULT, (mandatory), true, 0, XUA_MSG_PART_CLASS_MAX_LEN) + #define SUA_MSG_PART_CLASS_HOP_CTR(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_S7_HOP_CTR, (mandatory)) @@ -176,6 +182,9 @@ #define SUA_MSG_PART_CLASS_RX_SEQ_NR(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_RX_SEQ_NR, (mandatory)) +#define SUA_MSG_PART_CLASS_ASP_CAPA(mandatory) \ + XUA_MSG_PART_CLASS_U32(SUA_IEI_ASP_CAPA, (mandatory)) + #define SUA_MSG_PART_CLASS_CREDIT(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_CREDIT, (mandatory)) @@ -197,6 +206,9 @@ #define SUA_MSG_PART_CLASS_USER_CAUSE(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_USER_CAUSE, (mandatory)) +#define SUA_MSG_PART_CLASS_ROUTING_KEY(mandatory) \ + XUA_MSG_PART_CLASS(SUA_IEI_ROUTING_KEY, (mandatory), true, 0, XUA_MSG_PART_CLASS_MAX_LEN) + #define SUA_MSG_PART_CLASS_DRN(mandatory) \ XUA_MSG_PART_CLASS_U32(SUA_IEI_DRN, (mandatory)) @@ -504,6 +516,36 @@ }, }; +/* RKM */ +static const struct xua_msg_part_class reg_req_ies[] = { + SUA_MSG_PART_CLASS_ROUTING_KEY(true), + SUA_MSG_PART_CLASS_ASP_CAPA(false), + XUA_MSG_PART_CLASS_EOF +}; +static const struct xua_msg_part_class reg_rsp_ies[] = { + SUA_MSG_PART_CLASS_REG_RESULT(true), + XUA_MSG_PART_CLASS_EOF +}; +static const struct xua_msg_part_class dereg_req_ies[] = { + SUA_MSG_PART_CLASS_ROUTE_CTX(true), + XUA_MSG_PART_CLASS_EOF +}; +static const struct xua_msg_part_class dereg_rsp_ies[] = { + SUA_MSG_PART_CLASS_DEREG_RESULT(true), + XUA_MSG_PART_CLASS_EOF +}; +const struct xua_msg_class sua_msg_class_rkm = { + .name = "RKM", + .msgt_names = m3ua_rkm_msgt_names, /* same as M3UA */ + .iei_names = sua_iei_names, + .ies = { + IES(SUA_RKM_REG_REQ, reg_req_ies), + IES(SUA_RKM_REG_RSP, reg_rsp_ies), + IES(SUA_RKM_DEREG_REQ, dereg_req_ies), + IES(SUA_RKM_DEREG_RSP, dereg_rsp_ies), + }, +}; + const struct xua_dialect xua_dialect_sua = { .name = "SUA", .ppid = SUA_PPID, @@ -516,7 +558,7 @@ [SUA_MSGC_ASPTM] = &sua_msg_class_asptm, [SUA_MSGC_CL] = &sua_msg_class_cl, [SUA_MSGC_CO] = &sua_msg_class_co, - [SUA_MSGC_RKM] = &m3ua_msg_class_rkm, /* TODO: different than M3UA */ + [SUA_MSGC_RKM] = &sua_msg_class_rkm, }, }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43409?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I0a1a9f22b3b3c0c5df200d3de08e4f8087be06f7 Gerrit-Change-Number: 43409 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4
by pespin 26 Aug '26

26 Aug '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43410?usp=email ) Change subject: mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4 ...................................................................... mtp3_rtpc: Fix potential assert getting rcxt_ie->len < 4 If an incoming message which contains an unbounded Routing Context IE, it may be that it comes malformed and hence len is < 4. In that case, xua_msg_part_get_u32() would have hit an ASSERT. Fix the problem by simply passing by the whole Routing Context (removing non-multiple of 4 potential churn at the end), since anyway we should be sending the same whole set of Routing Contexts we received. Change-Id: Ia0a8dd4907d6ad786e9cc257d299a1521dd45dee --- M src/mtp3_rtpc.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/10/43410/1 diff --git a/src/mtp3_rtpc.c b/src/mtp3_rtpc.c index 34d40e7..a1a8856 100644 --- a/src/mtp3_rtpc.c +++ b/src/mtp3_rtpc.c @@ -42,14 +42,14 @@ struct xua_msg *xua; struct xua_msg_part *rctx_ie; unsigned int num_rctx = 0; - uint32_t rctx = 0; + uint32_t *rctx_raw = NULL; uint32_t aff_pc = htonl(orig_xua->mtp.dpc); if ((rctx_ie = xua_msg_find_tag(orig_xua, M3UA_IEI_ROUTE_CTX))) { - rctx = xua_msg_part_get_u32(rctx_ie); - num_rctx = 1; + rctx_raw = (uint32_t *) rctx_ie->dat; + num_rctx = rctx_ie->len / sizeof(uint32_t); } - xua = m3ua_encode_duna(&rctx, num_rctx, &aff_pc, 1, + xua = m3ua_encode_duna(rctx_raw, num_rctx, &aff_pc, 1, "transfer prohibited (inaccessible SP)"); OSMO_ASSERT(xua); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia0a8dd4907d6ad786e9cc257d299a1521dd45dee Gerrit-Change-Number: 43410 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: xua_msg: Constify input xua_msg param
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43388?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+2 by laforge, Code-Review+2 by osmith, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: xua_msg: Constify input xua_msg param ...................................................................... xua_msg: Constify input xua_msg param Change-Id: I3641f9b2ab487ac32faa1872831ca249ce41ffb8 --- M src/xua_msg.c M src/xua_msg.h 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/88/43388/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3641f9b2ab487ac32faa1872831ca249ce41ffb8 Gerrit-Change-Number: 43388 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmo-sigtran[master]: xua: Validate IE lengths of incoming messages [1/6]
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: fixeria, laforge, osmith, pespin. Hello Jenkins Builder, fixeria, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review+2 by laforge, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: xua: Validate IE lengths of incoming messages [1/6] ...................................................................... xua: Validate IE lengths of incoming messages [1/6] Improve the data structures defining M3UA/SUA messages to also include expected min/max lengths of each IE in a given message. This way we already cover in one place validation of fixed length IEs. This patch is the first in a series of patches that go together, since now that more checks are done some message structure definitions need to be added in both M3UA and SUA. xua_dialect_check_all_ies_ext() is split into helper xua_dialect_check_all_ies_ext() because it will also be used directly when checking grouped IEs for RKM message Routing key and (De)Registration Result. Related: OS#7074 Reported-By: Tristan Madani <tristan(a)talencesecurity.com> Change-Id: I9b1ae0dbc324123790942c9e6068f6822e3bb957 --- M src/m3ua.c M src/sua.c M src/xua_msg.c M src/xua_msg.h 4 files changed, 435 insertions(+), 128 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/86/43386/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9b1ae0dbc324123790942c9e6068f6822e3bb957 Gerrit-Change-Number: 43386 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_msg: return M3UA_ERR in xua_dialect_check_all_mand_ies()
by pespin 26 Aug '26

26 Aug '26

Attention is currently required from: laforge, osmith, pespin. Hello Jenkins Builder, laforge, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review+2 by laforge, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: xua_msg: return M3UA_ERR in xua_dialect_check_all_mand_ies() ...................................................................... xua_msg: return M3UA_ERR in xua_dialect_check_all_mand_ies() This way we can provide better information to peer on what went wrong, specially since we'll be adding more checks in follow-up commits. Furthermore, the return values now become much clearer. Change-Id: I9df00f9b10f7341171912cf32e8ba57344ae8b4a --- M src/m3ua.c M src/sua.c M src/xua_msg.c 3 files changed, 10 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/89/43389/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9df00f9b10f7341171912cf32e8ba57344ae8b4a Gerrit-Change-Number: 43389 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log August 2026