August 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: TCAP: implement fallback routing when no TCAP ASP can be found.
by lynxis lazus 10 Aug '26

10 Aug '26

Attention is currently required from: daniel, laforge, pespin. Hello Jenkins Builder, daniel, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ...................................................................... TCAP: implement fallback routing when no TCAP ASP can be found. If a TCAP message from an ongoing session can't be routed by either the TCAP session cache or by the destination TID to a known ASP, allow to route the packet to a different destination. Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 --- M src/ss7_as.c M src/ss7_as.h M src/ss7_as_vty.c M src/tcap_as_loadshare.c M tests/vty/osmo_stp_test_tcap.vty 5 files changed, 77 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/08/43008/6 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 Gerrit-Change-Number: 43008 Gerrit-PatchSet: 6 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in simtrace2[master]: firmware: card_emu: use Di in the waiting time
by lynxis lazus 10 Aug '26

10 Aug '26

Attention is currently required from: Hoernchen, laforge. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43126?usp=email ) Change subject: firmware: card_emu: use Di in the waiting time ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I4263176d6073029d01f9ff5b11a6311617956af6 Gerrit-Change-Number: 43126 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Aug 2026 15:12:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in simtrace2[master]: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO
by lynxis lazus 10 Aug '26

10 Aug '26

Attention is currently required from: Hoernchen, laforge. lynxis lazus has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email ) Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d Gerrit-Change-Number: 43125 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 10 Aug 2026 15:12:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: fixup
by lynxis lazus 10 Aug '26

10 Aug '26

lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43199?usp=email ) Change subject: fixup ...................................................................... fixup Change-Id: I12fa9ca4ef8ad9a0f00681024c0036566435efb9 --- M tests/vty/osmo_stp_test_tcap.vty 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/99/43199/1 diff --git a/tests/vty/osmo_stp_test_tcap.vty b/tests/vty/osmo_stp_test_tcap.vty index 7ffff77..eda7a69 100644 --- a/tests/vty/osmo_stp_test_tcap.vty +++ b/tests/vty/osmo_stp_test_tcap.vty @@ -34,7 +34,7 @@ traffic-mode Specifies traffic mode of operation of the ASP within the AS sls-shift Shift SLS bits used during routing decision tcap-routing Enable TCAP-based routing when in traffic-mode loadshare - tcap-unroutable-sessions When receiving a TCAP Continue/End/Abort message where no ASP can be assosiated (either via session tracking or by TCAP range for dtid). How should this message handled. + tcap-unroutable-sessions When receiving a TCAP Continue/End/Abort message where no ASP can be assosiated (either via session tracking or by TCAP range for dtid). How should this message be handled. binding-table AS Loadshare binding table operations recovery-timeout Specifies RFC4666 recovery timer T(r) timeout qos-class Specity QoS Class of AS -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43199?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I12fa9ca4ef8ad9a0f00681024c0036566435efb9 Gerrit-Change-Number: 43199 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in libosmo-sigtran[master]: TCAP: implement fallback routing when no TCAP ASP can be found.
by lynxis lazus 10 Aug '26

10 Aug '26

Attention is currently required from: daniel, laforge, pespin. lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email ) Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ...................................................................... Patch Set 5: (5 comments) File src/ss7_as_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/25f65af5_63fc2… : PS4, Line 269: "When receiving a TCAP Continue/End/Abort message where no ASP can be assosiated (either via session tracking or by TCAP range for dtid). How should this message handled.\n" > "associated" […] Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/47496a2c_18a1b… : PS4, Line 547: const char *tcap_unroutable_str = get_value_string_or_null(osmo_ss7_as_tcap_unroutable_vals, > This only makes sense in SS7_AS_TCAP_UNROUTABLE_ROUTE_FALLBACK case afaiu, so better move this looku […] No, it is also used by LOAD_SHARE_AS. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/db6de5f8_5994f… : PS4, Line 469: struct osmo_mtp_transfer_param new_mtp = {}; > since you are copying orig_mtp just below, there's no need to zero-initialize the struct here. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/40e2431d_633f5… : PS4, Line 478: /*! When a TCAP MSU from an ongoing session (TCAP != Begin) could not routed either by the TCAP session tracking or > could not be routed. Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008/comment/7a4b63c6_63837… : PS4, Line 504: /* No ASP selection because the SCCP msg will be routed else where */ > elsewhere Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 Gerrit-Change-Number: 43008 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 10 Aug 2026 15:00:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-sigtran[master]: TCAP: implement fallback routing when no TCAP ASP can be found.
by pespin 10 Aug '26

10 Aug '26

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email ) Change subject: TCAP: implement fallback routing when no TCAP ASP can be found. ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Half of my comments where not yet addressed, plus it seems .vty file needs updating. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e4e634b38a1845c2ce62a3805ff91a530520d88 Gerrit-Change-Number: 43008 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Aug 2026 14:56:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmo-sigtran[master]: TCAP: Refactoring unroutable messages into own function
by pespin 10 Aug '26

10 Aug '26

Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007?usp=email ) Change subject: TCAP: Refactoring unroutable messages into own function ...................................................................... Patch Set 4: Code-Review+2 (2 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007/comment/d13181b4_2f6b9… : PS2, Line 608: rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); > no, because you also have to set the rc code. In general this function needs to be refactored. […] Done File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007/comment/e47aa92d_5c6f2… : PS3, Line 457: /*! When a TCAP MSU from an ongoing session (TCAP != Begin) could not routed either by the TCAP session tracking or > could not *be* routed. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43007?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib4d114273423730418458767d17b11de9bd815d4 Gerrit-Change-Number: 43007 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Aug 2026 14:55:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in simtrace2[master]: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO
by Hoernchen 10 Aug '26

10 Aug '26

Attention is currently required from: laforge, lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email ) Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO ...................................................................... Patch Set 2: (3 comments) File firmware/libcommon/source/mode_cardemu.c: https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/03ef4a4e_6aae3fb8?us… : PS1, Line 390: usart->US_FIDI = fidi & US_FIDI_FI_DI_RATIO_Msk; > I would rather use US_FIDI_FI_DI_RATIO(fidi) here. It is correct, but only works […] Done File firmware/libcommon/source/simtrace_iso7816.c: https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/10c6af66_414fd0f8?us… : PS1, Line 130: if (ratio > 0 && ratio <= US_FIDI_FI_DI_RATIO_Msk) { > Acknowledged Done https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/58bcc608_eb047620?us… : PS1, Line 137: usart->base->US_FIDI = (ratio & US_FIDI_FI_DI_RATIO_Msk); > see previous usage of US_FIDI_FI_DI_RATIO(fidi) Done -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d Gerrit-Change-Number: 43125 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 10 Aug 2026 14:44:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in simtrace2[master]: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO
by Hoernchen 10 Aug '26

10 Aug '26

Attention is currently required from: Hoernchen, laforge, lynxis lazus. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+1 by lynxis lazus, Verified+1 by Jenkins Builder Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO ...................................................................... firmware: use the full 11 bit US_FIDI.FI_DI_RATIO US_FIDI_FI_DI_RATIO_Msk is 0x7ff, cemu rejected >= 0x400 in emu_update_fidi() and masked with 0x3ff in card_emu_uart_update_fidi(), but update_fidi() used by the sniffer already used 0x7ff. -> ratios 1024..2047 are unusable in cemu, which is the entire upper half of ISO 7816-3 Table 7 at Di=1. A reader trying one of those in a PPS gets the proposal echoed and accepted, after which the card keeps transmitting at the old rate. FI_DI_RATIO is clock periods per bit -> larger ratio is a SLOWER link. The old check rejected slow values but accepted Fi=372/Di=64, ratio 5 !? Unify and use the register mask (= shifed by 0 so usable as value) and reject ratios that do not fit rather than truncating to garbage dividers. Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d --- M firmware/libcommon/source/card_emu.c M firmware/libcommon/source/mode_cardemu.c M firmware/libcommon/source/simtrace_iso7816.c 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/25/43125/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d Gerrit-Change-Number: 43125 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in simtrace2[master]: firmware: card_emu: use Di in the waiting time
by Hoernchen 10 Aug '26

10 Aug '26

Attention is currently required from: Hoernchen, laforge, lynxis lazus. Hello Jenkins Builder, laforge, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/simtrace2/+/43126?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Code-Review+2 by lynxis lazus, Verified+1 by Jenkins Builder The change is no longer submittable: Code-Review and Verified are unsatisfied now. Change subject: firmware: card_emu: use Di in the waiting time ...................................................................... firmware: card_emu: use Di in the waiting time ISO 7816-3 section 10.2 defines WT = WI x 960 x Fi/f seconds, store as etu, etu = Fi / (D x f) seconds, so the Fi cancels, but the D does not: WT [etu] = WI x 960 x D cemu dropped both (?!) -> WI x 960. The old comment explains why Fi can be dropped, which is right, but what about Di ?! sniffer gets it right (wt_wi * 960UL * wt_d), so the two state machines disagreed here again, by up to a factor of 64???!!?!!? This was fixed in osmo-ccid-firmware in 066489d in 2020 but not ported to st2. Additionally the waiting time was only recalculated at the end of the ATR, where D is still 1 by definition, so a PPS increasing D reprogrammed the baud rate but left the waiting time untouched??! etu duration shrinks with D by the same factor, wall clock WT is independent of D, which is the whole point. The old code decreased the waiting time by a factor of D: after a PPS to D=8 the card emitted its NULL procedure byte at ~0.09s instead of ~0.71s with a reader deadline of ~1.43s, and the inactivity timeout fires 8x too early, which probably led to unexplained wtime_exp errors. Update wt when WI becomes known (end of ATR) and where D changes (after the PPS response) + tests. Change-Id: I4263176d6073029d01f9ff5b11a6311617956af6 --- M firmware/libcommon/source/card_emu.c M firmware/test/card_emu_tests.c 2 files changed, 97 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/simtrace2 refs/changes/26/43126/2 -- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43126?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I4263176d6073029d01f9ff5b11a6311617956af6 Gerrit-Change-Number: 43126 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0