Attention is currently required from: laforge, lynxis lazus. Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email ) Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO ...................................................................... Patch Set 2: (3 comments) File firmware/libcommon/source/mode_cardemu.c: https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/03ef4a4e_6aae3fb8?usp... : PS1, Line 390: usart->US_FIDI = fidi & US_FIDI_FI_DI_RATIO_Msk;

I would rather use US_FIDI_FI_DI_RATIO(fidi) here. It is correct, but only works […] Done

File firmware/libcommon/source/simtrace_iso7816.c: https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/10c6af66_414fd0f8?usp... : PS1, Line 130: if (ratio > 0 && ratio <= US_FIDI_FI_DI_RATIO_Msk) {

Acknowledged Done

https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/58bcc608_eb047620?usp... : PS1, Line 137: usart->base->US_FIDI = (ratio & US_FIDI_FI_DI_RATIO_Msk);

see previous usage of US_FIDI_FI_DI_RATIO(fidi) Done

-- To view, visit https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: simtrace2 Gerrit-Branch: master Gerrit-Change-Id: I6211dd5be7c5c5d2150af2aa37a403b33e6d340d Gerrit-Change-Number: 43125 Gerrit-PatchSet: 2 Gerrit-Owner: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Mon, 10 Aug 2026 14:44:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: lynxis lazus <lynxis@fe80.eu>