Attention is currently required from: laforge, lynxis lazus.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/simtrace2/+/43125?usp=email )
Change subject: firmware: use the full 11 bit US_FIDI.FI_DI_RATIO ......................................................................
Patch Set 2:
(3 comments)
File firmware/libcommon/source/mode_cardemu.c:
https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/03ef4a4e_6aae3fb8?usp... : PS1, Line 390: usart->US_FIDI = fidi & US_FIDI_FI_DI_RATIO_Msk;
I would rather use US_FIDI_FI_DI_RATIO(fidi) here. It is correct, but only works […]
Done
File firmware/libcommon/source/simtrace_iso7816.c:
https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/10c6af66_414fd0f8?usp... : PS1, Line 130: if (ratio > 0 && ratio <= US_FIDI_FI_DI_RATIO_Msk) {
Acknowledged
Done
https://gerrit.osmocom.org/c/simtrace2/+/43125/comment/58bcc608_eb047620?usp... : PS1, Line 137: usart->base->US_FIDI = (ratio & US_FIDI_FI_DI_RATIO_Msk);
see previous usage of US_FIDI_FI_DI_RATIO(fidi)
Done