Attention is currently required from: jolly, pespin.
dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email )
Change subject: library/euicc: add ESipa JSON encoder/decoder module
......................................................................
Patch Set 5:
(1 comment)
File eim/eIM_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144/comment/7b6f7079_979c… :
PS4, Line 441: esipa_res := dec_EsipaMessageFromEimToIpa(response_http.response_binary.body);
> Isn't it enough o move the "if (mp_esipa_json == true)" here? […]
Thanks for your input. My first thought was to separate the ASN.1 and JSON code paths, but this creates a lot of code-dup in the receive functions. I have reworked this now.
The send functions are different enough so I think we can keep those as they are.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8b6a87f39ca23658d980d19cf257b8994ea1cecb
Gerrit-Change-Number: 43144
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 11 Aug 2026 07:37:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly, pespin.
Hello Jenkins Builder, jolly,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: library/euicc: add ESipa JSON encoder/decoder module
......................................................................
library/euicc: add ESipa JSON encoder/decoder module
In order to test an eIM (or IPAd), which uses the JSON ESipa bindings
instead of the ASN.1 ESipa bindings a set of encoder/decoder functions
is needed to generate/parse the JSON messages exchanged on the ESipa
interface
Change-Id: I8b6a87f39ca23658d980d19cf257b8994ea1cecb
Related: SYS#8100
---
M eim/eIM_Tests.cfg
M eim/eIM_Tests.ttcn
M eim/gen_links.sh
M library/euicc/RSPDefinitions_Types.ttcn
M library/euicc/SGP32Definitions_Types.ttcn
A library/euicc/esipa_Types_JSON.ttcn
6 files changed, 705 insertions(+), 43 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/44/43144/5
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I8b6a87f39ca23658d980d19cf257b8994ea1cecb
Gerrit-Change-Number: 43144
Gerrit-PatchSet: 5
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, laforge, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43182?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: eim_Tests: Add testcase to test ESipa/ES9+: CancelSession
......................................................................
eim_Tests: Add testcase to test ESipa/ES9+: CancelSession
The testsuite never sends or receives any messages related to ESipa/ES9+
CancelSession, let's implement a varinat of the "Cancel Session Procedure
for Indirect Profile Download" as described in SGP.32 section 3.2.3.3 to
increase the coverage accordingly.
Related: SYS#8100
Change-Id: Iadc9010fcf08de98f7d8c2a5c68bb5ff71bfb1f6
---
M eim/eIM_Tests.ttcn
1 file changed, 59 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/43182/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43182?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadc9010fcf08de98f7d8c2a5c68bb5ff71bfb1f6
Gerrit-Change-Number: 43182
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/43198?usp=email )
Change subject: jenkins-gerrit/comment_generate: fail on 0 passed
......................................................................
jenkins-gerrit/comment_generate: fail on 0 passed
Don't print the success message when zero jobs has passed. If this
happens, we have an internal error somewhere.
Change-Id: I1317f14c2f3f55f2a9b6581372c80edba33528db
---
M scripts/jenkins-gerrit/comment_generate.py
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, but someone else must approve
fixeria: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/scripts/jenkins-gerrit/comment_generate.py b/scripts/jenkins-gerrit/comment_generate.py
index fc8a8b1..1b3bfcd 100755
--- a/scripts/jenkins-gerrit/comment_generate.py
+++ b/scripts/jenkins-gerrit/comment_generate.py
@@ -212,6 +212,8 @@
summary += f"{len(jobs['passed'])} passed:\n"
summary += get_jobs_list_str(jobs["passed"])
+ if not jobs['passed']:
+ summary += "Zero jobs passed, internal script error?\n"
if "build" in pipeline and "deb" in pipeline and "rpm" in pipeline and \
not pipeline["build"]["passed"] and pipeline["deb"]["passed"] \
@@ -227,7 +229,7 @@
summary += "https://osmocom.org/projects/cellular-infrastructure/wiki/Linting\n"
summary += "\n"
- if jobs["failed"]:
+ if jobs["failed"] or not jobs['passed']:
summary += "Build Failed\n"
summary += "\n"
summary += f"Find the Retrigger button here:\n{build_url}\n"
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43198?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1317f14c2f3f55f2a9b6581372c80edba33528db
Gerrit-Change-Number: 43198
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>