dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42875?usp=email )
(
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
)Change subject: esipa_asn1_codec: add special handling for ProvideEimPackageResultResponse
......................................................................
esipa_asn1_codec: add special handling for ProvideEimPackageResultResponse
In SGP.32 V.1.2 ProvideEimPackageResultResponse is defined as a CHOICE.
This means that this struct now also requires special handling.
Change-Id: I859a175cc28a18ea9334d9b2cf233294fdc95b76
Related: SYS#8100
---
M src/esipa_asn1_codec.erl
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
diff --git a/src/esipa_asn1_codec.erl b/src/esipa_asn1_codec.erl
index 4102575..23cab53 100644
--- a/src/esipa_asn1_codec.erl
+++ b/src/esipa_asn1_codec.erl
@@ -28,6 +28,8 @@
'SGP32Definitions':encode('GetBoundProfilePackageResponseEsipa', EimToIpaChoice);
encode_eim_to_ipa({cancelSessionResponseEsipa, EimToIpaChoice}) ->
'SGP32Definitions':encode('CancelSessionResponseEsipa', EimToIpaChoice);
+encode_eim_to_ipa({provideEimPackageResultResponse, EimToIpaChoice}) ->
+ 'SGP32Definitions':encode('ProvideEimPackageResultResponse', EimToIpaChoice);
encode_eim_to_ipa(emptyResponse) ->
{ok, <<>>};
encode_eim_to_ipa(EimToIpa) ->
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42875?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I859a175cc28a18ea9334d9b2cf233294fdc95b76
Gerrit-Change-Number: 42875
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Attention is currently required from: dexter.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42875?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: esipa_asn1_codec: add special handling for ProvideEimPackageResultResponse
......................................................................
esipa_asn1_codec: add special handling for ProvideEimPackageResultResponse
In SGP.32 V.1.2 ProvideEimPackageResultResponse is defined as a CHOICE.
This means that this struct now also requires special handling.
Change-Id: I859a175cc28a18ea9334d9b2cf233294fdc95b76
Related: SYS#8100
---
M src/esipa_asn1_codec.erl
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/75/42875/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42875?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I859a175cc28a18ea9334d9b2cf233294fdc95b76
Gerrit-Change-Number: 42875
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Attention is currently required from: dexter.
Hello Jenkins Builder, fixeria, laforge,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/onomondo-eim/+/42876?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
The change is no longer submittable: Verified is unsatisfied now.
Change subject: esipa_asn1_handler: fix transactionId handling
......................................................................
esipa_asn1_handler: fix transactionId handling
The transactionId member is now called eimTransactionId. It is also
an optional member.
Change-Id: I1340e0c7aed091e8e5a5089ebd6e524512408cf7
Related: SYS#8100
---
M src/esipa_asn1_handler_utils.erl
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/76/42876/4
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42876?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I1340e0c7aed091e8e5a5089ebd6e524512408cf7
Gerrit-Change-Number: 42876
Gerrit-PatchSet: 4
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42945?usp=email )
Change subject: Bump version: 0.4.1
......................................................................
Patch Set 1: Verified+1
(1 comment)
Patchset:
PS1:
CI passed except for manuals, which is expected on 0.4.x as there is no contrib/jenkins_manuals.sh.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42945?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: osmith/0.4.1
Gerrit-Change-Id: I17c9806400a48b4cdf7be19a824e10c56620d655
Gerrit-Change-Number: 42945
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 08 Jul 2026 07:50:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes