July 2026 - gerrit-log - lists.osmocom.org

[S] Change in onomondo-eim[master]: esipa_asn1_handler: replace handle_asn1_notificationList
by dexter 08 Jul '26

08 Jul '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42950?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: esipa_asn1_handler: replace handle_asn1_notificationList ...................................................................... esipa_asn1_handler: replace handle_asn1_notificationList The helper function handle_asn1_notificationList can also be described using the comprehension syntax. Change-Id: Ia95f56998b4f7a8b0f9fce727d82dedc942e5aeb Related: SYS#8100 --- M src/esipa_asn1_handler.erl 1 file changed, 6 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/50/42950/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ia95f56998b4f7a8b0f9fce727d82dedc942e5aeb Gerrit-Change-Number: 42950 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: esipa_asn1_handler: use eimTransactionId in EimPackageResultResponseE...
by dexter 08 Jul '26

08 Jul '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42952?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: esipa_asn1_handler: use eimTransactionId in EimPackageResultResponseError ...................................................................... esipa_asn1_handler: use eimTransactionId in EimPackageResultResponseError EimPackageResultResponseError contains an eimTransactionId, let's use this eimTransactionId and add a dedicated handler function for the EimPackageResultResponseError to esipa_asn1_handler_utils Change-Id: Iadd852a7531f180618cf12b314170ceea3f97615 Related: SYS#8100 --- M src/esipa_asn1_handler.erl M src/esipa_asn1_handler_utils.erl 2 files changed, 17 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/52/42952/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Iadd852a7531f180618cf12b314170ceea3f97615 Gerrit-Change-Number: 42952 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-eim[master]: esipa_asn1_handler: use eimTransactionId for ipaEuiccDataResponse
by dexter 08 Jul '26

08 Jul '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42951?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: esipa_asn1_handler: use eimTransactionId for ipaEuiccDataResponse ...................................................................... esipa_asn1_handler: use eimTransactionId for ipaEuiccDataResponse The ipaEuiccDataResponse does currently not use the eimTransactionId, which was added with SGP.32 V.1.2, let's make use of the eimTransactionId and move the handler functionality to a dedicated helper function in esipa_asn_handler_utils. Change-Id: Ie414eef7fd5c8928dd611503f4dd8d67322c0e80 Related: SYS#8100 --- M src/esipa_asn1_handler.erl M src/esipa_asn1_handler_utils.erl M src/esipa_rest_utils.erl 3 files changed, 40 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/51/42951/2 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42951?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ie414eef7fd5c8928dd611503f4dd8d67322c0e80 Gerrit-Change-Number: 42951 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XL] Change in onomondo-eim[master]: mnesia_db: split functionality into dedicated modules
by dexter 08 Jul '26

08 Jul '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42946?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: mnesia_db: split functionality into dedicated modules ...................................................................... mnesia_db: split functionality into dedicated modules The mnesia_db module is responsible to handle three different tables with different scope. Let's split the functionality into separate modules to make the code easier to maintain. Change-Id: Ifc649337ab7ce7eb9dc602a1439293130f002f41 Related: SYS#8100 --- A include/mnesia_db_euicc.hrl A include/mnesia_db_rest.hrl A include/mnesia_db_work.hrl M src/crypto_utils.erl M src/esipa_asn1_handler.erl M src/esipa_asn1_handler_utils.erl M src/esipa_asn1_http_handler.erl M src/esipa_rest_utils.erl M src/mnesia_db.erl A src/mnesia_db_euicc.erl A src/mnesia_db_rest.erl A src/mnesia_db_work.erl M src/rest_handler.erl 13 files changed, 930 insertions(+), 854 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/46/42946/4 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ifc649337ab7ce7eb9dc602a1439293130f002f41 Gerrit-Change-Number: 42946 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[XL] Change in onomondo-eim[master]: mnesia_db: split functionality into dedicated modules
by Jenkins Builder 08 Jul '26

08 Jul '26

Attention is currently required from: dexter. Jenkins Builder has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42946?usp=email ) Change subject: mnesia_db: split functionality into dedicated modules ...................................................................... Patch Set 3: (2 comments) File src/mnesia_db_rest.erl: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42946/comment/8a9be05a_36a501af… : PS3, Line 225: % (hours, days), than this may mean that the REST API user lost interest. In this case the related items shoud be 'shoud' may be misspelled - perhaps 'should'? File src/mnesia_db_work.erl: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/onomondo-eim/+/42946/comment/e752619c_e183ae8d… : PS3, Line 211: % Update a work item that is in progress. This fuction updates the state (any user defined term) of the work item. 'fuction' may be misspelled - perhaps 'function'? -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ifc649337ab7ce7eb9dc602a1439293130f002f41 Gerrit-Change-Number: 42946 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Wed, 08 Jul 2026 10:31:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XL] Change in onomondo-eim[master]: mnesia_db: split functionality into dedicated modules
by dexter 08 Jul '26

08 Jul '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/onomondo-eim/+/42946?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: mnesia_db: split functionality into dedicated modules ...................................................................... mnesia_db: split functionality into dedicated modules The mnesia_db module is responsible to handle three different tables with different scope. Let's split the functionality into separate modules to make the code easier to maintain. Change-Id: Ifc649337ab7ce7eb9dc602a1439293130f002f41 Related: SYS#8100 --- A include/mnesia_db_euicc.hrl A include/mnesia_db_rest.hrl A include/mnesia_db_work.hrl M src/crypto_utils.erl M src/esipa_asn1_handler.erl M src/esipa_asn1_handler_utils.erl M src/esipa_asn1_http_handler.erl M src/esipa_rest_utils.erl M src/mnesia_db.erl A src/mnesia_db_euicc.erl A src/mnesia_db_rest.erl A src/mnesia_db_work.erl M src/rest_handler.erl 13 files changed, 930 insertions(+), 854 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/46/42946/3 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ifc649337ab7ce7eb9dc602a1439293130f002f41 Gerrit-Change-Number: 42946 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: esipa: supply eimTransactionId in profileDownloadTriggerRequest
by dexter 08 Jul '26

08 Jul '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42948?usp=email ) Change subject: esipa: supply eimTransactionId in profileDownloadTriggerRequest ...................................................................... esipa: supply eimTransactionId in profileDownloadTriggerRequest When we supply an eimTransactionId in profileDownloadTriggerRequest, the IPAd will echo the same eimTransactionId in the initiateAuthenticationRequestEsipa message. This allows the eIM to distinguish to which transaction (work) the received initiateAuthenticationRequestEsipa belongs. This was not possible before. The eIM had to rely soly on the PID of the sub process which is handling the HTTP connection. Change-Id: I822d6b2bb51498713739671804b173260e9a28a3 Related: SYS#8100 --- M src/esipa_asn1_handler.erl 1 file changed, 10 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/48/42948/1 diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl index 94389c7..1815499 100644 --- a/src/esipa_asn1_handler.erl +++ b/src/esipa_asn1_handler.erl @@ -19,7 +19,8 @@ %GSMA SGP.32, section 6.3.2.1 handle_asn1(Pid, {initiateAuthenticationRequestEsipa, EsipaReq}) -> - {_, _, WorkState} = mnesia_db_work:pickup(Pid, none), + EimTransactionId = maps:get(eimTransactionId, EsipaReq, none), + {_, _, WorkState} = mnesia_db_work:pickup(Pid, EimTransactionId), BaseUrl = maps:get(smdpAddress, EsipaReq), NewWorkState = WorkState#{smdpAddress => BaseUrl}, mnesia_db_work:update(Pid, NewWorkState), @@ -284,12 +285,16 @@ EsipaResp = case Work of {download, Order} -> - % The first time we see a TransactionId is in the SMDP+ response to the - % initiateAuthenticationRequest - {[{<<"download">>, {[{<<"activationCode">>, ActivationCode}]}}]} = Order, + % The first time we see a transactionId from the SM-DP+ is in the SM-DP+ response to the + % initiateAuthenticationRequest. Until this point we will use an eimTransactionId as a + % temporary identifier. + EimTransactionId = rand:bytes(16), + mnesia_db_work:bind(Pid, EimTransactionId), mnesia_db_work:update(Pid, #{}), + {[{<<"download">>, {[{<<"activationCode">>, ActivationCode}]}}]} = Order, {profileDownloadTriggerRequest, #{ - profileDownloadData => {activationCode, ActivationCode} + profileDownloadData => {activationCode, ActivationCode}, + eimTransactionId => EimTransactionId }}; {psmo, Order} -> EimTransactionId = rand:bytes(16), -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42948?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I822d6b2bb51498713739671804b173260e9a28a3 Gerrit-Change-Number: 42948 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: esipa: rename TransactionId to EimTransactionId where applicable
by dexter 08 Jul '26

08 Jul '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42947?usp=email ) Change subject: esipa: rename TransactionId to EimTransactionId where applicable ...................................................................... esipa: rename TransactionId to EimTransactionId where applicable In SGP.32 V.1.2 all TransactionIds which are generated by the eIM are called now called "eimTransactionId". Let's make sure that we name the EimTransactionId variables and atoms (eimTransactionId) accordingly. Change-Id: Ia97f96c27d5dc4405effd5266de4cdb797849699 Related: SYS#8100 --- M src/esipa_asn1_handler.erl M src/esipa_asn1_handler_utils.erl M src/esipa_rest_utils.erl 3 files changed, 18 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/47/42947/1 diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl index 82a4290..94389c7 100644 --- a/src/esipa_asn1_handler.erl +++ b/src/esipa_asn1_handler.erl @@ -292,12 +292,12 @@ profileDownloadData => {activationCode, ActivationCode} }}; {psmo, Order} -> - TransactionIdPsmo = rand:bytes(16), - mnesia_db_work:bind(Pid, TransactionIdPsmo), + EimTransactionId = rand:bytes(16), + mnesia_db_work:bind(Pid, EimTransactionId), EuiccPackageSigned = esipa_rest_utils:psmo_order_to_euiccPackageSigned( Order, EidValue, - TransactionIdPsmo + EimTransactionId ), case EuiccPackageSigned of error -> @@ -318,12 +318,12 @@ }} end; {eco, Order} -> - TransactionIdEco = rand:bytes(16), - mnesia_db_work:bind(Pid, TransactionIdEco), + EimTransactionId = rand:bytes(16), + mnesia_db_work:bind(Pid, EimTransactionId), EuiccPackageSigned = esipa_rest_utils:eco_order_to_euiccPackageSigned( Order, EidValue, - TransactionIdEco + EimTransactionId ), case EuiccPackageSigned of error -> diff --git a/src/esipa_asn1_handler_utils.erl b/src/esipa_asn1_handler_utils.erl index ac7d6f0..171f78b 100644 --- a/src/esipa_asn1_handler_utils.erl +++ b/src/esipa_asn1_handler_utils.erl @@ -8,7 +8,7 @@ -export([handle_euiccPackageResult/3]). -transactionId_from_euiccPackageResult(EuiccPackageResult) -> +eimTransactionId_from_euiccPackageResult(EuiccPackageResult) -> case EuiccPackageResult of {euiccPackageResultSigned, EuiccPackageResultSigned} -> EuiccPackageResultDataSigned = maps:get( @@ -24,7 +24,7 @@ none end. -process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq, TransactionId) -> +process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq, EimTransactionId) -> WorkBind = fun(Map) -> case maps:is_key(eimTransactionId, Map) of true -> @@ -35,7 +35,7 @@ end, CheckCounterValue = fun(Map) -> - {EidValue, _, _} = mnesia_db_work:pickup(Pid, TransactionId), + {EidValue, _, _} = mnesia_db_work:pickup(Pid, EimTransactionId), CounterValueIpad = maps:get(counterValue, Map), {ok, CounterValueEim} = mnesia_db_euicc:param_get(EidValue, counterValue), case CounterValueIpad of @@ -88,11 +88,11 @@ % Handle an EuiccPackageResult, this includes everything from the handling of the work items in mnesia_db, down to % signature checks and the generation of an appropriate outcome for the REST API. handle_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq) -> - TransactionId = transactionId_from_euiccPackageResult(EuiccPackageResult), - {EidValue, _, _} = mnesia_db_work:pickup(Pid, TransactionId), + EimTransactionId = eimTransactionId_from_euiccPackageResult(EuiccPackageResult), + {EidValue, _, _} = mnesia_db_work:pickup(Pid, EimTransactionId), case crypto_utils:verify_euiccPackageResultSigned(EuiccPackageResult, EidValue) of ok -> - process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq, TransactionId); + process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq, EimTransactionId); _ -> mnesia_db_work:finish( Pid, [{[{procedureError, euiccSignatureInvalid}]}], EsipaReq diff --git a/src/esipa_rest_utils.erl b/src/esipa_rest_utils.erl index 78939ab..e88c58b 100644 --- a/src/esipa_rest_utils.erl +++ b/src/esipa_rest_utils.erl @@ -183,7 +183,7 @@ error end. -format_euicc_EuiccPackageSigned(EuiccPackage, EidValue, TransactionId) -> +format_euicc_EuiccPackageSigned(EuiccPackage, EidValue, EimTransactionId) -> case EuiccPackage of error -> % The EuiccPackage was not generated properly @@ -195,13 +195,13 @@ eimId => list_to_binary(EimId), eidValue => EidValue, counterValue => CounterValue, - transactionId => TransactionId, + eimTransactionId => EimTransactionId, euiccPackage => EuiccPackage } end. % Generate an euiccPackageSigned from a PSMO Order (JSON REST API) -psmo_order_to_euiccPackageSigned(Order, EidValue, TransactionId) -> +psmo_order_to_euiccPackageSigned(Order, EidValue, EimTransactionId) -> Order2Psmo = fun(PsmoOrder) -> case PsmoOrder of {[{<<"enable">>, Psmo}]} -> @@ -244,7 +244,7 @@ error end, - format_euicc_EuiccPackageSigned(EuiccPackage, EidValue, TransactionId). + format_euicc_EuiccPackageSigned(EuiccPackage, EidValue, EimTransactionId). eco_to_asn_addEim(Eco) -> case Eco of @@ -289,7 +289,7 @@ end. % Generate an euiccPackageSigned from a eCO Order (JSON REST API) -eco_order_to_euiccPackageSigned(Order, EidValue, TransactionId) -> +eco_order_to_euiccPackageSigned(Order, EidValue, EimTransactionId) -> Order2Eco = fun(EcoOrder) -> case EcoOrder of {[{<<"addEim">>, Eco}]} -> @@ -322,7 +322,7 @@ error end, - format_euicc_EuiccPackageSigned(EuiccPackage, EidValue, TransactionId). + format_euicc_EuiccPackageSigned(EuiccPackage, EidValue, EimTransactionId). memberOrNil(Key, Map) -> case maps:is_key(Key, Map) of -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42947?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ia97f96c27d5dc4405effd5266de4cdb797849699 Gerrit-Change-Number: 42947 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: esipa_asn1_handler: replace handle_asn1_notificationList
by dexter 08 Jul '26

08 Jul '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42950?usp=email ) Change subject: esipa_asn1_handler: replace handle_asn1_notificationList ...................................................................... esipa_asn1_handler: replace handle_asn1_notificationList The helper function handle_asn1_notificationList can also be described using the comprehension syntax. Change-Id: Ia95f56998b4f7a8b0f9fce727d82dedc942e5aeb Related: SYS#8100 --- M src/esipa_asn1_handler.erl 1 file changed, 2 insertions(+), 9 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/50/42950/1 diff --git a/src/esipa_asn1_handler.erl b/src/esipa_asn1_handler.erl index 1815499..466461f 100644 --- a/src/esipa_asn1_handler.erl +++ b/src/esipa_asn1_handler.erl @@ -9,14 +9,6 @@ -export([handle_asn1/2]). -% Helper function to send out a list of notifications -handle_asn1_notificationList(_Pid, []) -> - ok; -handle_asn1_notificationList(Pid, NotificationList) -> - [PendingNotification | NotificationListTail] = NotificationList, - handle_asn1(Pid, {handleNotificationEsipa, {pendingNotification, PendingNotification}}), - handle_asn1_notificationList(Pid, NotificationListTail). - %GSMA SGP.32, section 6.3.2.1 handle_asn1(Pid, {initiateAuthenticationRequestEsipa, EsipaReq}) -> EimTransactionId = maps:get(eimTransactionId, EsipaReq, none), @@ -384,7 +376,8 @@ ), % then forward the notifications in the included notification list NotificationList = maps:get(notificationList, EPRAndNotifications), - handle_asn1_notificationList(Pid, NotificationList); + [handle_asn1(Pid, {handleNotificationEsipa, {pendingNotification, PendingNotification}}) || + PendingNotification <- NotificationList]; {ipaEuiccDataResponse, IpaEuiccDataResponse} -> % drive-by store the eUICC public key so that we can use it later to sign PSMOs or eCOs {EidValue, _, _} = mnesia_db_work:pickup(Pid, none), -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42950?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ia95f56998b4f7a8b0f9fce727d82dedc942e5aeb Gerrit-Change-Number: 42950 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: esipa_asn1_handler_utils: rename EsipaReq to Debuginfo
by dexter 08 Jul '26

08 Jul '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/42949?usp=email ) Change subject: esipa_asn1_handler_utils: rename EsipaReq to Debuginfo ...................................................................... esipa_asn1_handler_utils: rename EsipaReq to Debuginfo The parameter EsipaReq only exists because we pass it as Debuginfo to mnesia_db_work:finish. Let's rename it to "Debuginfo" in esipa_asn1_handler_utils as well to make clear what the purpose of this parameter is. Change-Id: I8115d382172989b9ef7ae7f97ce39520e3e2dd16 Related: SYS#8100 --- M src/esipa_asn1_handler_utils.erl 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/49/42949/1 diff --git a/src/esipa_asn1_handler_utils.erl b/src/esipa_asn1_handler_utils.erl index 171f78b..1b8039f 100644 --- a/src/esipa_asn1_handler_utils.erl +++ b/src/esipa_asn1_handler_utils.erl @@ -24,7 +24,7 @@ none end. -process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq, EimTransactionId) -> +process_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo, EimTransactionId) -> WorkBind = fun(Map) -> case maps:is_key(eimTransactionId, Map) of true -> @@ -83,18 +83,18 @@ [{[{euiccPackageErrorCode, undefinedError}]}] end, - mnesia_db_work:finish(Pid, Outcome, EsipaReq). + mnesia_db_work:finish(Pid, Outcome, Debuginfo). % Handle an EuiccPackageResult, this includes everything from the handling of the work items in mnesia_db, down to % signature checks and the generation of an appropriate outcome for the REST API. -handle_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq) -> +handle_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo) -> EimTransactionId = eimTransactionId_from_euiccPackageResult(EuiccPackageResult), {EidValue, _, _} = mnesia_db_work:pickup(Pid, EimTransactionId), case crypto_utils:verify_euiccPackageResultSigned(EuiccPackageResult, EidValue) of ok -> - process_euiccPackageResult(Pid, EuiccPackageResult, EsipaReq, EimTransactionId); + process_euiccPackageResult(Pid, EuiccPackageResult, Debuginfo, EimTransactionId); _ -> mnesia_db_work:finish( - Pid, [{[{procedureError, euiccSignatureInvalid}]}], EsipaReq + Pid, [{[{procedureError, euiccSignatureInvalid}]}], Debuginfo ) end. -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/42949?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I8115d382172989b9ef7ae7f97ce39520e3e2dd16 Gerrit-Change-Number: 42949 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log July 2026