Attention is currently required from: osmith.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email )
Change subject: rebar.config: use a fork of rebar3_diameter_compiler
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
> thanks! if upstream is already reviewing this and likely to merge soon, we could also wait another d […]
Yeah, let's wait a bit. If my PR gets merged quickly, we'll simply use the upstream.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I548a3fef6f8a23a548fb6376076b9d4a9345d692
Gerrit-Change-Number: 42962
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2026 13:24:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email )
Change subject: rebar.config: use a fork of rebar3_diameter_compiler
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
thanks! if upstream is already reviewing this and likely to merge soon, we could also wait another day and directly use upstream again. (I recommended switching to the fork before because I assumed it would take longer.)
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I548a3fef6f8a23a548fb6376076b9d4a9345d692
Gerrit-Change-Number: 42962
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2026 13:23:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, osmith.
Hello Jenkins Builder, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Code-Review-1 by osmith, Verified+1 by Jenkins Builder
Change subject: rebar.config: use a fork of rebar3_diameter_compiler
......................................................................
rebar.config: use a fork of rebar3_diameter_compiler
This fixes building on Erlang/OTP 29. A pull request [1] has been
submitted upstream. Once merged, we get switch back to upstream.
[1] https://github.com/carlosedp/rebar3_diameter_compiler/pull/28
Change-Id: I548a3fef6f8a23a548fb6376076b9d4a9345d692
---
M rebar.config
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/62/42962/2
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I548a3fef6f8a23a548fb6376076b9d4a9345d692
Gerrit-Change-Number: 42962
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/42963?usp=email )
Change subject: redmine: hide avatars
......................................................................
redmine: hide avatars
We aren't using gravatar or other 3rd party avatar services, and we
don't want the default avatars either as they can give the same color to
different users, making them look like the same user on first glance.
Related: SYS#8097#note-15
Change-Id: I136549e00f806a76704b354498083002fddb5b67
---
A redmine/0002-Hide-avatars.patch
M redmine/Dockerfile
2 files changed, 33 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/docker-playground refs/changes/63/42963/1
diff --git a/redmine/0002-Hide-avatars.patch b/redmine/0002-Hide-avatars.patch
new file mode 100644
index 0000000..429458c
--- /dev/null
+++ b/redmine/0002-Hide-avatars.patch
@@ -0,0 +1,30 @@
+From bedc707e3bf8b839e7b6e39467fed8806b7cad38 Mon Sep 17 00:00:00 2001
+From: Oliver Smith <osmith(a)sysmocom.de>
+Date: Thu, 9 Jul 2026 14:31:06 +0200
+Subject: [PATCH] Hide avatars
+
+We aren't using gravatar or other 3rd party avatar services, and we
+don't want the default avatars either as they can give the same color to
+different users, making them look like the same user on first glance.
+
+Related: SYS#8097#note-15
+---
+ app/assets/stylesheets/application.css | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/app/assets/stylesheets/application.css b/app/assets/stylesheets/application.css
+index c6656f70e..3d21a692f 100644
+--- a/app/assets/stylesheets/application.css
++++ b/app/assets/stylesheets/application.css
+@@ -2271,7 +2271,7 @@ img.filecontent.image {background-image: url(/transparent.png);}
+ span[role="img"].avatar {
+ font-family: 'Roboto', 'Helvetica Neue', Helvetica, Arial, sans-serif;
+ align-items: center;
+- display: inline-flex;
++ display: none;
+ font-size: calc(24px * .4);
+ justify-content: center;
+ user-select: none;
+--
+2.53.0
+
diff --git a/redmine/Dockerfile b/redmine/Dockerfile
index adcef31..5c6ef3e 100644
--- a/redmine/Dockerfile
+++ b/redmine/Dockerfile
@@ -26,6 +26,9 @@
ADD 0001-Set-session_store-to-active_record_store.patch /tmp/
RUN cd /usr/src/redmine && patch -p1 < /tmp/0001-Set-session_store-to-active_record_store.patch
+ADD 0002-Hide-avatars.patch /tmp/
+RUN cd /usr/src/redmine && patch -p1 < /tmp/0002-Hide-avatars.patch
+
ADD docker-entrypoint-osmo.sh /
ENTRYPOINT ["/docker-entrypoint-osmo.sh"]
CMD ["rails", "server", "-b", "0.0.0.0"]
--
To view, visit https://gerrit.osmocom.org/c/docker-playground/+/42963?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: docker-playground
Gerrit-Branch: master
Gerrit-Change-Id: I136549e00f806a76704b354498083002fddb5b67
Gerrit-Change-Number: 42963
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email )
Change subject: rebar.config: use a fork of rebar3_diameter_compiler
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File rebar.config:
https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962/comment/6ec95b05_20a7… :
PS1, Line 16: {git, "https://github.com/osmocom/rebar3_diameter_compiler.git", {branch, "main"}}}
Let's use a specific commit here to make sure this is reproducible when e.g. trying to bisect a change later.
```suggestion
{git, "https://github.com/osmocom/rebar3_diameter_compiler.git", {branch, "27e0a7f4f6ed8d0ca829d103dd35c85f21fff41b"}}}
```
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I548a3fef6f8a23a548fb6376076b9d4a9345d692
Gerrit-Change-Number: 42962
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 09 Jul 2026 12:11:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email )
Change subject: rebar.config: use a fork of rebar3_diameter_compiler
......................................................................
rebar.config: use a fork of rebar3_diameter_compiler
This fixes building on Erlang/OTP 29. A pull request [1] has been
submitted upstream. Once merged, we get switch back to upstream.
[1] https://github.com/carlosedp/rebar3_diameter_compiler/pull/28
Change-Id: I548a3fef6f8a23a548fb6376076b9d4a9345d692
---
M rebar.config
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/erlang/osmo-epdg refs/changes/62/42962/1
diff --git a/rebar.config b/rebar.config
index 68092a7..e72c956 100644
--- a/rebar.config
+++ b/rebar.config
@@ -13,7 +13,7 @@
{minimum_otp_vsn, "25.2.3"}.
{plugins, [
{rebar3_diameter_compiler,
- {git, "https://github.com/carlosedp/rebar3_diameter_compiler.git", {tag, "v0.8.1"}}}
+ {git, "https://github.com/osmocom/rebar3_diameter_compiler.git", {branch, "main"}}}
]}.
{xref_checks, [undefined_function_calls, undefined_functions,
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/42962?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: erlang/osmo-epdg
Gerrit-Branch: master
Gerrit-Change-Id: I548a3fef6f8a23a548fb6376076b9d4a9345d692
Gerrit-Change-Number: 42962
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>