April 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by falconia 30 Apr '26

30 Apr '26

Attention is currently required from: fixeria, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email ) Change subject: nokia: add support for Flexi Multiradio ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/18ddad62_80864acb?usp… : PS3, Line 2082: int abis_nokia_rcvmsg(struct msgb *msg) > Was the function leaking memory before this change? Yes, exactly that. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:28:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: nokia: make Rx diversity configurable
by pespin 30 Apr '26

30 Apr '26

Attention is currently required from: falconia, fixeria. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email ) Change subject: nokia: make Rx diversity configurable ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/1be6d269_fecb9bff?usp… : PS3, Line 1214: fu_config[len + 7] = bts->nokia.rx_diversity; how was this being set to 1 (the old default you mentioned) before this patch? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 Gerrit-Change-Number: 42714 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:24:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bsc[master]: nokia vty: change help strings away from "*Site"
by pespin 30 Apr '26

30 Apr '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email ) Change subject: nokia vty: change help strings away from "*Site" ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42713?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I55556b7b5aa5bc6efcbee815e9011497a933697c Gerrit-Change-Number: 42713 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:21:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bsc[master]: nokia: add support for Flexi Multiradio
by pespin 30 Apr '26

30 Apr '26

Attention is currently required from: falconia, fixeria. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email ) Change subject: nokia: add support for Flexi Multiradio ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/cfdb68a1_a1b13272?usp… : PS3, Line 2082: int abis_nokia_rcvmsg(struct msgb *msg) It seems this function is now freeing the msg in error paths, while it wasn't before. Do you mind explaining this change? Was the function leaking memory before this change? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc Gerrit-Change-Number: 42712 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:21:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bsc[master]: nokia skip-reset: make consistent with other vty settings
by pespin 30 Apr '26

30 Apr '26

Attention is currently required from: falconia. pespin has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42718?usp=email ) Change subject: nokia skip-reset: make consistent with other vty settings ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42718?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ie8cdac51f82185e2d4f37a8da00acba633670052 Gerrit-Change-Number: 42718 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:15:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: cosmetic: Rename TCAP Being->Begin
by daniel 30 Apr '26

30 Apr '26

daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42721?usp=email ) Change subject: cosmetic: Rename TCAP Being->Begin ...................................................................... cosmetic: Rename TCAP Being->Begin Change-Id: I19de8da6ee72a04365896c7fb7730be4f3ea01d4 --- M stp/STP_Tests_TCAP.ttcn 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/21/42721/1 diff --git a/stp/STP_Tests_TCAP.ttcn b/stp/STP_Tests_TCAP.ttcn index 9a5eae3..d7c45dc 100644 --- a/stp/STP_Tests_TCAP.ttcn +++ b/stp/STP_Tests_TCAP.ttcn @@ -307,7 +307,7 @@ { var template (value) TCMessage tcap_msg; - /* TCAP Being: O -> T */ + /* TCAP Begin: O -> T */ tcap_msg := ts_TCAP_Begin(o_tid); f_asp_tx_tcap_exp(tcap_msg, o_asp_idx, t_asp_idx); @@ -747,7 +747,7 @@ { var template (value) TCMessage tcap_msg; - /* TCAP Being: O -> T */ + /* TCAP Begin: O -> T */ tcap_msg := ts_TCAP_Begin(o_tid); f_asp_tx_tcap_exp_any(tcap_msg, o_asp_idx); @@ -808,7 +808,7 @@ f_tcap_loadshare_register(2, 0, 99, 3, 100, 199); /* send a TCAP message with oTID 250 (no range available) */ - /* TCAP Being: O -> T */ + /* TCAP Begin: O -> T */ tcap_msg := ts_TCAP_Begin(otid); f_asp_tx_tcap(tcap_msg, 0); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42721?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I19de8da6ee72a04365896c7fb7730be4f3ea01d4 Gerrit-Change-Number: 42721 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Make TCAP tests more realistic
by daniel 30 Apr '26

30 Apr '26

Attention is currently required from: fixeria, lynxis lazus, pespin. Hello Jenkins Builder, fixeria, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: stp: Make TCAP tests more realistic ...................................................................... stp: Make TCAP tests more realistic * Use a TCAP id outside of the TCAP routing range for the M3UA TCAP id. * Test both directions IPA -> M3UA and M3UA -> IPA. * Test TCAP routing with a different called address answering Change-Id: Ia807c2b26e5188b700365650311cabc0f9095674 Related: SYS#5423 --- M stp/STP_Tests_TCAP.ttcn M stp/expected-results.xml 2 files changed, 161 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/42683/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia807c2b26e5188b700365650311cabc0f9095674 Gerrit-Change-Number: 42683 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: Make TCAP tests more realistic
by daniel 30 Apr '26

30 Apr '26

Attention is currently required from: fixeria, lynxis lazus, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683?usp=email ) Change subject: stp: Make TCAP tests more realistic ...................................................................... Patch Set 2: (2 comments) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683/comment/ef0efcbf_723a… : PS1, Line 341: /* TCAP Being: O -> T */ > Begin Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683/comment/fc94f0e5_b073… : PS1, Line 854: control > Likewise, please update `expected-results.xml` when adding/removing/renaming TCs. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia807c2b26e5188b700365650311cabc0f9095674 Gerrit-Change-Number: 42683 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Apr 2026 14:18:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Test TCAP routing with a different called address answering
by daniel 30 Apr '26

30 Apr '26

daniel has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email ) Change subject: stp: Test TCAP routing with a different called address answering ...................................................................... Abandoned Merged into https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42683 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d586b17b767219d20646f7cd1b59d6719cdbcdb Gerrit-Change-Number: 42682 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: stp: Test TCAP routing with a different called address answering
by daniel 30 Apr '26

30 Apr '26

Attention is currently required from: fixeria, lynxis lazus, pespin. daniel has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email ) Change subject: stp: Test TCAP routing with a different called address answering ...................................................................... Patch Set 1: (3 comments) Patchset: PS1: > Please also update `expected-results.xml`. Done File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682/comment/02c688fa_36f6… : PS1, Line 275: OCT4 t_tid, integer alt_asp_idx := -1) > numberings for all PC, routes etc. […] I ended up not needing this anyway so I'll just dodge this particular bike shed by removing it https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682/comment/2f3c9531_9503… : PS1, Line 385: The answer is sent from a different point code than the request dpc */ > "is sent" here is a bit ambiguous. Sent from who to where? I'd better describe it: […] That doesn't really make more sense to me tbh. It's reworded slighly in the other commit in TC_tcap_loadshare_m3ua_to_ipa(). Abandoning this change since this test case is removed/changed anyway. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42682?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6d586b17b767219d20646f7cd1b59d6719cdbcdb Gerrit-Change-Number: 42682 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 30 Apr 2026 14:15:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026