April 2026 - gerrit-log - lists.osmocom.org

[L] Change in libosmocore[master]: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement
by pespin 20 Apr '26

20 Apr '26

Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email ) Change subject: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: Patch LGTM, but I feat the test will trigger eventually non-deterministic results based on read/write internal buffers in the OS. ACK to making a patch release. BTW, it would make sense to move the code block " Fill up empty buffers in dequeued msghdr with buffers from the next msghdr" into a helper function, and actually optimize it to move multiple msgs from the same next msghdr in a tight loop instead of 1 by 1. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia96e25d11d8d683fa9dd0c56bdac257992edd782 Gerrit-Change-Number: 42638 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 20 Apr 2026 08:07:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: s1gw/rest: PfcpAssocInfo: field 'lrts' is mandatory
by fixeria 18 Apr '26

18 Apr '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42491?usp=email ) Change subject: s1gw/rest: PfcpAssocInfo: field 'lrts' is mandatory ...................................................................... s1gw/rest: PfcpAssocInfo: field 'lrts' is mandatory Change-Id: I332e95a32935e0c8da99e600e8d30af14bd36b16 Related: osmo-s1gw.git Ic766ebc56ce1810fc27cb49ddcac50bc94e539d9 --- M s1gw/S1GW_REST_Types.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/s1gw/S1GW_REST_Types.ttcn b/s1gw/S1GW_REST_Types.ttcn index 696df3d..21f4f31 100644 --- a/s1gw/S1GW_REST_Types.ttcn +++ b/s1gw/S1GW_REST_Types.ttcn @@ -65,7 +65,7 @@ PfcpAssocState state, /* Current association state */ charstring laddr, /* Local (bind) IP address */ charstring raddr, /* Remote (connect) IP address */ - integer lrts optional, /* Local Recovery TimeStamp */ + integer lrts, /* Local Recovery TimeStamp */ integer rrts optional /* Remote Recovery TimeStamp */ }; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42491?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I332e95a32935e0c8da99e600e8d30af14bd36b16 Gerrit-Change-Number: 42491 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in libosmocore[master]: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement
by fixeria 17 Apr '26

17 Apr '26

Attention is currently required from: jolly, laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email ) Change subject: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia96e25d11d8d683fa9dd0c56bdac257992edd782 Gerrit-Change-Number: 42638 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 17 Apr 2026 21:44:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[XS] Change in pysim[master]: requirements: ensure safe version of PyYAML >= 5.4 (CVE-2020-1747)
by laforge 17 Apr '26

17 Apr '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42626?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: requirements: ensure safe version of PyYAML >= 5.4 (CVE-2020-1747) ...................................................................... requirements: ensure safe version of PyYAML >= 5.4 (CVE-2020-1747) PyYAML versions 5.1–5.3.1 are vulnerable to CVE-2020-1747, which allows arbitrary code execution through yaml.FullLoader. While PyYAML 5.4+ patches this, the dependency specification (pyyaml >= 5.1) doesn't guarantee a safe version. Let's increase the requirement to version 5.4 to ensure a safe version of is used. This patch is based on suggestions from: "YanTong C <chyeyantong03(a)gmail.com>" Change-Id: I901c76c59e9c1bab030eab81038e04a475b32510 --- M README.md M requirements.txt M setup.py 3 files changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved fixeria: Looks good to me, but someone else must approve diff --git a/README.md b/README.md index 8773356..7768b63 100644 --- a/README.md +++ b/README.md @@ -97,7 +97,7 @@ - pyscard - pyserial - pytlv - - pyyaml >= 5.1 + - pyyaml >= 5.4 - smpp.pdu (from `github.com/hologram-io/smpp.pdu`) - termcolor diff --git a/requirements.txt b/requirements.txt index 4ceec45..9088f16 100644 --- a/requirements.txt +++ b/requirements.txt @@ -6,7 +6,7 @@ construct>=2.10.70 bidict pyosmocom>=0.0.12 -pyyaml>=5.1 +pyyaml>=5.4 termcolor colorlog pycryptodomex diff --git a/setup.py b/setup.py index be81122..614d80b 100644 --- a/setup.py +++ b/setup.py @@ -26,7 +26,7 @@ "construct >= 2.10.70", "bidict", "pyosmocom >= 0.0.12", - "pyyaml >= 5.1", + "pyyaml >= 5.4", "termcolor", "colorlog", "pycryptodomex", -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42626?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I901c76c59e9c1bab030eab81038e04a475b32510 Gerrit-Change-Number: 42626 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: octsim: usb_descriptor: reduce IRQ endpoint max packet size to 4 bytes
by Hoernchen 17 Apr '26

17 Apr '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42619?usp=email ) Change subject: octsim: usb_descriptor: reduce IRQ endpoint max packet size to 4 bytes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > err, nevermind, it's 16 for hs. ...but wait a second, we're a fs device, but this is the hs number? that would allocate a bit more than needed... -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I615ff16d9bc0e8d39156015e41b4abe4502aaca1 Gerrit-Change-Number: 42619 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 17 Apr 2026 15:53:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ccid-firmware[master]: octsim: usb_descriptor: reduce IRQ endpoint max packet size to 4 bytes
by Hoernchen 17 Apr '26

17 Apr '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42619?usp=email ) Change subject: octsim: usb_descriptor: reduce IRQ endpoint max packet size to 4 bytes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > If you're worried about scheduling set bInterval to the recommended value by the ccid spec, which is […] err, nevermind, it's 16 for hs. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I615ff16d9bc0e8d39156015e41b4abe4502aaca1 Gerrit-Change-Number: 42619 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 17 Apr 2026 15:48:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[XS] Change in osmo-ccid-firmware[master]: octsim: usb_descriptor: reduce IRQ endpoint max packet size to 4 bytes
by Hoernchen 17 Apr '26

17 Apr '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42619?usp=email ) Change subject: octsim: usb_descriptor: reduce IRQ endpoint max packet size to 4 bytes ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > As I understand the IRQs on USB, the EP size is relevant for scheduling the bus and the bus will res […] If you're worried about scheduling set bInterval to the recommended value by the ccid spec, which is 255 - it's sim card presence after all, not something that changes rapidly... -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42619?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I615ff16d9bc0e8d39156015e41b4abe4502aaca1 Gerrit-Change-Number: 42619 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Fri, 17 Apr 2026 15:46:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hoernchen <ewild(a)sysmocom.de> Comment-In-Reply-To: lynxis lazus <lynxis(a)fe80.eu>

1 0

[L] Change in libosmocore[master]: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement
by fixeria 17 Apr '26

17 Apr '26

Attention is currently required from: laforge. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email ) Change subject: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > this definitely sounds like a patch release? Ack, I can tag one when this patch is merged. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia96e25d11d8d683fa9dd0c56bdac257992edd782 Gerrit-Change-Number: 42638 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 17 Apr 2026 14:57:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[L] Change in libosmocore[master]: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement
by laforge 17 Apr '26

17 Apr '26

Attention is currently required from: fixeria. laforge has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email ) Change subject: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: this definitely sounds like a patch release? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia96e25d11d8d683fa9dd0c56bdac257992edd782 Gerrit-Change-Number: 42638 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Apr 2026 14:54:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in libosmocore[master]: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement
by jolly 17 Apr '26

17 Apr '26

Attention is currently required from: fixeria. jolly has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email ) Change subject: osmo_io: iofd_txqueue_dequeue(): fix double next->io_len decrement ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/42638?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia96e25d11d8d683fa9dd0c56bdac257992edd782 Gerrit-Change-Number: 42638 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 17 Apr 2026 14:40:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log April 2026