Attention is currently required from: Timur Davydov, fixeria.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42691?usp=email )
Change subject: trx: factor out burst submission into helper
......................................................................
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42691?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I7ce61bee4ca7ca50ef190982f1a0e4ce57c8c838
Gerrit-Change-Number: 42691
Gerrit-PatchSet: 6
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Thu, 30 Apr 2026 15:48:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, pespin.
falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email )
Change subject: nokia: make Rx diversity configurable
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/fdf90017_3f17cee3?usp… :
PS3, Line 1214: fu_config[len + 7] = bts->nokia.rx_diversity;
> how was this being set to 1 (the old default you mentioned) before this patch?
Through hard-coded bits in `bts_config_2[]` array. Dietar Spaar contributed the original Nokia BTS support (Site family) in 2011; it looks like he had access to a real Nokia BSC driving these BTS, and he took a capture of the E1 interface. All those config arrays hard-coded in `bts_nokia_site.c` are basically a replay of that captured config session from 2011 (you can even see a date & time IE in there, with 2011 dates); some IEs are then selectively patched to make a few settings changeable, but others are always replayed verbatim.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12
Gerrit-Change-Number: 42714
Gerrit-PatchSet: 3
Gerrit-Owner: falconia <falcon(a)freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Apr 2026 15:36:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: daniel.
pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42721?usp=email )
Change subject: cosmetic: Rename TCAP Being->Begin
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42721?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I19de8da6ee72a04365896c7fb7730be4f3ea01d4
Gerrit-Change-Number: 42721
Gerrit-PatchSet: 1
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 30 Apr 2026 15:35:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: Timur Davydov, laforge.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email )
Change subject: build: make sched_* usage optional
......................................................................
Patch Set 6:
(1 comment)
File src/common/main.c:
https://gerrit.osmocom.org/c/osmo-bts/+/42690/comment/2a187156_f8641a53?usp… :
PS6, Line 314: #ifdef HAVE_SCHED_SETSCHEDULER
since rt_prio can't be set by command line above, this if block cannot be ever entered. Hence you need to move the ifdef to cover the entire "if rtp_prio != -1" block.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42690?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5af357c1e2074fa1e05ac6bc20af8535c474d906
Gerrit-Change-Number: 42690
Gerrit-PatchSet: 6
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Thu, 30 Apr 2026 15:33:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Timur Davydov, fixeria, laforge.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email )
Change subject: trx: add JSON stats export for WebSDR API
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
As mentioned in the osmo-trx similar commit, I doubt this has to be merged into the repository. We already provide VTY/CTRL/stats interfaces in osmocom programs, converting to other formats is the duty of external tools/software/code.
Let's see others' opinions.
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42704?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ifb82adfab879a65ecd222c45e06551983aa90a0f
Gerrit-Change-Number: 42704
Gerrit-PatchSet: 8
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Thu, 30 Apr 2026 15:30:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: Timur Davydov.
pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email )
Change subject: build: detect pthread_setname_np and sched_* APIs, guard usage
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File CommonLibs/Threads.cpp:
https://gerrit.osmocom.org/c/osmo-trx/+/42654/comment/5885e203_eb006d70?usp… :
PS1, Line 39:
> Good catch, thanks. I’ll add the missing #include "config.h" to all files with HAVE_ stuff is added.
In general config.h has to be set as the first include in the file, so it sets stuff which in turn can be used by other headers.
--
To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42654?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Gerrit-Change-Id: Ic3f1492544439d88c5e6683330c6696de1c2f85b
Gerrit-Change-Number: 42654
Gerrit-PatchSet: 2
Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com>
Gerrit-Comment-Date: Thu, 30 Apr 2026 15:28:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>