Attention is currently required from: fixeria, pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email ) Change subject: nokia: make Rx diversity configurable ...................................................................... Patch Set 3: (1 comment) File src/osmo-bsc/bts_nokia_site.c: https://gerrit.osmocom.org/c/osmo-bsc/+/42714/comment/fdf90017_3f17cee3?usp=... : PS3, Line 1214: fu_config[len + 7] = bts->nokia.rx_diversity;

how was this being set to 1 (the old default you mentioned) before this patch? Through hard-coded bits in `bts_config_2[]` array. Dietar Spaar contributed the original Nokia BTS support (Site family) in 2011; it looks like he had access to a real Nokia BSC driving these BTS, and he took a capture of the E1 interface. All those config arrays hard-coded in `bts_nokia_site.c` are basically a replay of that captured config session from 2011 (you can even see a date & time IE in there, with 2011 dates); some IEs are then selectively patched to make a few settings changeable, but others are always replayed verbatim.

-- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42714?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I73bd91b717a8c8b338bacb6ed9db73bb07245c12 Gerrit-Change-Number: 42714 Gerrit-PatchSet: 3 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Thu, 30 Apr 2026 15:36:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>