March 2026 - gerrit-log - lists.osmocom.org

[S] Change in ...osmo-s1gw[master]: doc/manuals: update MmeItem related info
by osmith 17 Mar '26

17 Mar '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42369?usp=email ) Change subject: doc/manuals: update MmeItem related info ...................................................................... Patch Set 3: Code-Review-1 (1 comment) Patchset: PS3: both files were added in previous patches in this series that are not merged yet, so it should be squashed into those patches IMHO -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42369?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I0b8115fe6342a80bf1eb99bd6ad210492a013947 Gerrit-Change-Number: 42369 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:34:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[L] Change in ...osmo-s1gw[master]: doc/manuals: merge doc/osmo-s1gw-cli.md
by osmith 17 Mar '26

17 Mar '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email ) Change subject: doc/manuals: merge doc/osmo-s1gw-cli.md ...................................................................... Patch Set 4: (2 comments) File doc/manuals/chapters/cli.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368/comment/2e3ede62_888b… : PS4, Line 34: is so much verbosity useful? this all needs to be kept in sync with changes to the program File doc/manuals/chapters/rest.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368/comment/4d47c891_f3d7… : PS4, Line 290: === Interactive CLI (`osmo-s1gw-cli`) this was just added in the previous patch, not great for code review :\ -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Ic2556f6add9c6a24f6da03f4388d7f86dde0c5dc Gerrit-Change-Number: 42368 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:29:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[L] Change in ...osmo-s1gw[master]: doc/manuals: document the REST interface
by osmith 17 Mar '26

17 Mar '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367?usp=email ) Change subject: doc/manuals: document the REST interface ...................................................................... Patch Set 4: (2 comments) File doc/manuals/chapters/rest.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367/comment/36352d7c_74bf… : PS4, Line 294: filtering : (`CMD | grep ...`), and output redirection (`CMD > FILE`). piping into grep or redirecting into a file are not features of this program, these are features of the shell that could be done with wget $RESTURL as well. I would remove that. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367/comment/14684598_d2bb… : PS4, Line 299: Here it might also make sense to just refer to `osmo-s1gw-cli -h` instead of duplicating the help in the manual (and having to keep it updated in both places)? -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42367?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I8bc9183fff8f65db71554ee26369db9bdb61b78a Gerrit-Change-Number: 42367 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:26:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in ...osmo-s1gw[master]: doc/manuals: document GTP-U KPI monitoring
by osmith 17 Mar '26

17 Mar '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42366?usp=email ) Change subject: doc/manuals: document GTP-U KPI monitoring ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42366?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I2709cd545bfd6c8f6e34358caf9d372c02dd5c3e Gerrit-Change-Number: 42366 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:20:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in ...osmo-s1gw[master]: doc/manuals: document the metrics
by osmith 17 Mar '26

17 Mar '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email ) Change subject: doc/manuals: document the metrics ...................................................................... Patch Set 4: (3 comments) File doc/manuals/chapters/metrics.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/542970d8_68be… : PS4, Line 5: https://github.com/Feuerlabs/exometer_core[exometer_core] library. Two "OsmoS1GW exposes internal metrics using the https://github.com/Feuerlabs/exometer_core[exometer_core] library." this seems unnecessary, given that it is mentioned in e.g. the configuration section already. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/0345ea47_9750… : PS4, Line 25: is this explanation of how the stats are stored internally useful to the user? https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365/comment/7f319630_1d75… : PS4, Line 68: | `s1ap.proxy.in_pkt.erab_setup_req` | E-RAB SETUP REQUEST PDUs How about: ```suggestion | `s1ap.proxy.in_pkt.erab_setup_req` | Received E-RAB SETUP REQUEST PDUs ``` Same for all below with in_pkt. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42365?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: Iacfefd387d0cd26eebbbeba0cd37efa78f90bb46 Gerrit-Change-Number: 42365 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:16:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: ara_m: fix exceptions not being raised properly
by fixeria 17 Mar '26

17 Mar '26

Attention is currently required from: dexter. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/pysim/+/42379?usp=email ) Change subject: ara_m: fix exceptions not being raised properly ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42379?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id799c264447e22887edcd2dc7eb991cf0af1bbfc Gerrit-Change-Number: 42379 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:14:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: transceiver: split control command handling from socket I/O
by Jenkins Builder 17 Mar '26

17 Mar '26

Attention is currently required from: pespin. Jenkins Builder has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email ) Change subject: transceiver: split control command handling from socket I/O ...................................................................... Patch Set 5: (1 comment) File Transceiver52M/Transceiver.h: Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-trx/+/42410/comment/e13053ea_5b69ad95?usp… : PS5, Line 220: int ctrl_cmd_handle(int chan, const char *buffer, char *response, size_t response_size); please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42410?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I5413aa511e951522270c75635e89448395fc429e Gerrit-Change-Number: 42410 Gerrit-PatchSet: 5 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:10:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in osmo-ttcn3-hacks[master]: 5gc: Introduce test TC_ran_initiated_qos_flow_mobility
by fixeria 17 Mar '26

17 Mar '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42417?usp=email ) Change subject: 5gc: Introduce test TC_ran_initiated_qos_flow_mobility ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42417?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1a1df29fa254496990d3d9099b3072433468ecb1 Gerrit-Change-Number: 42417 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:09:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-trx[master]: proto_trxd: add helpers to prepare burst indication packets
by Timur Davydov 17 Mar '26

17 Mar '26

Attention is currently required from: fixeria, pespin. Timur Davydov has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email ) Change subject: proto_trxd: add helpers to prepare burst indication packets ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > Can you re-arrange the commit order to put this commit before the one actually using the public func […] I've rearranged the commits accordingly. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42357?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: Ie94a1df4879cbf6056cd05c9621c46db1ed972fd Gerrit-Change-Number: 42357 Gerrit-PatchSet: 3 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:09:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in ...osmo-s1gw[master]: doc/manuals: add overview, document running and configuration
by osmith 17 Mar '26

17 Mar '26

Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email ) Change subject: doc/manuals: add overview, document running and configuration ...................................................................... Patch Set 4: (8 comments) File README.md: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/4215086b_47ca… : PS4, Line 131: `make install` deploys a complete ERTS release together with a convenience the edits in this line until the end of this section don't seem like improvements to me, it just adds more LLM style with mdashes and verbosity IMHO. File doc/manuals/chapters/overview.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/306782c9_c824… : PS4, Line 9: , i.e. radio base stations seems unnecessary, people reading this should be familiar with what an eNodeB is, so I suggest to remove that https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/a43ed260_875d… : PS4, Line 38: ---- instead of such ascii art diagrams, we typically use graphviz graphs in manuals: https://gitea.osmocom.org/cellular-infrastructure/osmo-hlr/src/commit/459ae… File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/7495f2c9_9736… : PS4, Line 32: Useful for testing new features or bug fixes before they are formally released. Given that this is project specific documentation, I would remove above block starting with "Two package feeds are available". This is on the wiki page as well, with additional information, and then we have one less location where we potentially need to update this information, e.g. if we added a third feed at some point. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/f60869db_f2ab… : PS4, Line 97: | `BINDIR` | Installation directory for executables | `/usr/bin` side note: other Osmocom programs "make install" to /usr/local by default https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/8b7ba778_4353… : PS4, Line 107: Running `make install` (typically as root, or with `DESTDIR` set for This is very verbose. Do we need to explain where every single file goes here? This also means it needs to be updated when we should add additional files. IMHO saying that the user needs to run `make install`, and maybe also describing that there is `DESTDIR`, is enough. (also this doesn't render properly: https://nextcloud.sysmocom.de/s/FYMZ2rpe3aRKQYm) https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/02186ffd_88a2… : PS4, Line 128: ==== The `osmo-s1gw` Bootstrap Script This is also very verbose. Do we need this section at all? We could also briefly refer to running `osmo-s1gw -h` for more information, then we don't need to update the help text in two places when making changes to the arguments. https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/1203b10a_0ba6… : PS4, Line 198: Wireshark and are tagged with the application name `OsmoS1GW`. why is this worth mentioning? " and are tagged with the application name `OsmoS1GW`." -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: erlang/osmo-s1gw Gerrit-Branch: master Gerrit-Change-Id: I4ceca069866d7191ef2b153af95a20cb522bffeb Gerrit-Change-Number: 42364 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Mar 2026 11:08:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026