March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ccid-firmware[master]: Revert "clang-format: set ColumnLimit: 0"
by Hoernchen 21 Mar '26

21 Mar '26

Attention is currently required from: fixeria, laforge, osmith. Hoernchen has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335?usp=email ) Change subject: Revert "clang-format: set ColumnLimit: 0" ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335/comment/a50a270c_4f… : PS1, Line 11: Reason for revert: we don't want clang-format to actively generate arbitrarily long line lengths. > I see now that this comes from https://gerrit.osmocom. […] Well we can either have a coding style, see the other proposed formatting patch chain, or we can decide not to have a coding style because every other line has a different lenght for no reason. As the other patchset shows if someone really really wants manually indented and formatted fsm stuff or usb descriptor arrays wrapping that with clang format on/off works just fine. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42335?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I49111af334e6967a9c3a63ccb9d179df444d63bb Gerrit-Change-Number: 42335 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Sat, 21 Mar 2026 15:54:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: irq: make default IRQ handler Dummy_Handler weak
by Hoernchen 21 Mar '26

21 Mar '26

Attention is currently required from: lynxis lazus. Hoernchen has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email ) Change subject: irq: make default IRQ handler Dummy_Handler weak ...................................................................... Patch Set 2: Code-Review-2 (1 comment) Patchset: PS2: I disagree strongly because I do not want a funky error prone chain of redirected symbols pointing to a now weak symbol, we are not writing libraries or frameworks, we are writing emebdded software, and the last thing I need are weak symbols with linker "oopsie woopesies" because due tue some other mishap the weak symbol was silently used and not overridden by something else and no one noticed anything. We want a handler, so either we have a handler, or a compile failure, and not schroedingers mystery firmware that compiles no matter what and that might or might not contain the function we are looking for. I can very well remember a funny parameter that allowed the simtrace firmware to build with missing symbols, that was really not fun to debug at the time because at runtime it called 0. -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42224?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I544e9c84dd538bb744fb799904adc58f9d850465 Gerrit-Change-Number: 42224 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Sat, 21 Mar 2026 15:50:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: ts_31_102: EF_5G_PROSE_UIR: fix copy-pasted inner class name
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42387?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ts_31_102: EF_5G_PROSE_UIR: fix copy-pasted inner class name ...................................................................... ts_31_102: EF_5G_PROSE_UIR: fix copy-pasted inner class name Change-Id: I460e5ad70f35026d0d794271a4aef17323c14dfb --- M pySim/ts_31_102.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index 7d06acf..2f7b945 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1326,7 +1326,7 @@ pass class FiveGDdnmfCtfAddrForUploading(BER_TLV_IE, tag=0x97): pass - class ProSeConfigDataForUeToNetworkRelayUE(BER_TLV_IE, tag=0xa0, + class ProSeConfigDataForUsageInfoReporting(BER_TLV_IE, tag=0xa0, nested=[EF_5G_PROSE_DD.ValidityTimer, CollectionPeriod, ReportingWindow, ReportingIndicators, @@ -1336,7 +1336,7 @@ desc='5G ProSe configuration data for usage information reporting', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, **kwargs) # contains TLV structure despite being TransparentEF, not BER-TLV ?!? - self._tlv = EF_5G_PROSE_UIR.ProSeConfigDataForUeToNetworkRelayUE + self._tlv = EF_5G_PROSE_UIR.ProSeConfigDataForUsageInfoReporting # TS 31.102 Section 4.4.13.8 (Rel 18) class EF_5G_PROSE_U2URU(TransparentEF): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42387?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I460e5ad70f35026d0d794271a4aef17323c14dfb Gerrit-Change-Number: 42387 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: cdma_ruim: fix inaccurate comment for EF_AD
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42388?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: cdma_ruim: fix inaccurate comment for EF_AD ...................................................................... cdma_ruim: fix inaccurate comment for EF_AD Change-Id: I71ea27fd30e44685ff35f49843072ca392995973 --- M pySim/cdma_ruim.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/cdma_ruim.py b/pySim/cdma_ruim.py index 7bfebae..6b71251 100644 --- a/pySim/cdma_ruim.py +++ b/pySim/cdma_ruim.py @@ -131,7 +131,7 @@ desc='Administrative Data', size=(3, None), **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) self._construct = Struct( - # Byte 1: Display Condition + # Byte 1: MS operation mode 'ms_operation_mode'/Enum(Byte, self.OP_MODE), # Bytes 2-3: Additional information 'additional_info'/Bytes(2), -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42388?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I71ea27fd30e44685ff35f49843072ca392995973 Gerrit-Change-Number: 42388 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: ts_31_102: fix description for EF_5GS3GPPLOCI
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42386?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ts_31_102: fix description for EF_5GS3GPPLOCI ...................................................................... ts_31_102: fix description for EF_5GS3GPPLOCI Change-Id: I9cf3adfce65090fedb3f0fd33c9b3d15a2c5fb8c --- M pySim/ts_31_102.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/ts_31_102.py b/pySim/ts_31_102.py index a93f1e8..7d06acf 100644 --- a/pySim/ts_31_102.py +++ b/pySim/ts_31_102.py @@ -1058,7 +1058,7 @@ # TS 31.102 Section 4.4.11.2 (Rel 15) class EF_5GS3GPPLOCI(TransparentEF): def __init__(self, fid='4f01', sfid=0x01, name='EF.5GS3GPPLOCI', size=(20, 20), - desc='5S 3GP location information', **kwargs): + desc='5GS 3GPP location information', **kwargs): super().__init__(fid, sfid=sfid, name=name, desc=desc, size=size, **kwargs) upd_status_constr = Enum( Byte, updated=0, not_updated=1, roaming_not_allowed=2) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42386?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I9cf3adfce65090fedb3f0fd33c9b3d15a2c5fb8c Gerrit-Change-Number: 42386 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: esim/saip: raise an exception properly
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42389?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: esim/saip: raise an exception properly ...................................................................... esim/saip: raise an exception properly Change-Id: Ia3749c02120fdc16e556214d0461cbeca032447b --- M pySim/esim/saip/__init__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index bdbbccf..9fa1d28 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -441,7 +441,7 @@ elif k == 'fillFileContent': stream.write(v) else: - return ValueError("Unknown key '%s' in tuple list" % k) + raise ValueError("Unknown key '%s' in tuple list" % k) return stream.getvalue() def file_content_to_tuples(self, optimize:bool = False) -> List[Tuple]: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42389?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia3749c02120fdc16e556214d0461cbeca032447b Gerrit-Change-Number: 42389 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: ara_m: fix undefined variable used in a format-string
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42380?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ara_m: fix undefined variable used in a format-string ...................................................................... ara_m: fix undefined variable used in a format-string Change-Id: I310a5d461bae2b5e4d8e07097000b079c23aa0f6 --- M pySim/ara_m.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified daniel: Looks good to me, approved diff --git a/pySim/ara_m.py b/pySim/ara_m.py index aa41268..e1c26f6 100644 --- a/pySim/ara_m.py +++ b/pySim/ara_m.py @@ -361,7 +361,7 @@ ar_do_content += [{'apdu_ar_do': {'generic_access_rule': 'always'}}] elif opts.apdu_filter: if len(opts.apdu_filter) % 16: - raise ValueError('Invalid non-modulo-16 length of APDU filter: %d' % len(do)) + raise ValueError(f'Invalid non-modulo-16 length of APDU filter: {len(opts.apdu_filter)}') offset = 0 apdu_filter = [] while offset < len(opts.apdu_filter): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42380?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I310a5d461bae2b5e4d8e07097000b079c23aa0f6 Gerrit-Change-Number: 42380 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: sms: fix flags_construct in SMS_DELIVER
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42381?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: sms: fix flags_construct in SMS_DELIVER ...................................................................... sms: fix flags_construct in SMS_DELIVER * field `tp_rp` appears at bit positions 7 and 5 ** bit 7 should be `tp_rp` (Reply Path) ** bit 5 should be `tp_sri` (Status Report Indication) * field `tp_lp` is completely missing ** should be at bit position 3 Change-Id: I0274849f0fa07281b5e050af429ffda7d249f9e8 --- M pySim/sms.py 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/sms.py b/pySim/sms.py index aefc874..62601b0 100644 --- a/pySim/sms.py +++ b/pySim/sms.py @@ -169,8 +169,14 @@ class SMS_DELIVER(SMS_TPDU): """Representation of a SMS-DELIVER T-PDU. This is the Network to MS/UE (downlink) direction.""" - flags_construct = BitStruct('tp_rp'/Flag, 'tp_udhi'/Flag, 'tp_rp'/Flag, 'tp_sri'/Flag, - Padding(1), 'tp_mms'/Flag, 'tp_mti'/BitsInteger(2)) + flags_construct = BitStruct('tp_rp'/Flag, + 'tp_udhi'/Flag, + 'tp_sri'/Flag, + Padding(1), + 'tp_lp'/Flag, + 'tp_mms'/Flag, + 'tp_mti'/BitsInteger(2)) + def __init__(self, **kwargs): kwargs['tp_mti'] = 0 super().__init__(**kwargs) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42381?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I0274849f0fa07281b5e050af429ffda7d249f9e8 Gerrit-Change-Number: 42381 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: ota: OtaAlgo{Crypt,Auth}: fix algo_auth vs algo_crypt
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42382?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ota: OtaAlgo{Crypt,Auth}: fix algo_auth vs algo_crypt ...................................................................... ota: OtaAlgo{Crypt,Auth}: fix algo_auth vs algo_crypt * OtaAlgoCrypt.from_keyset() searches by `otak.algo_crypt` but the error message prints `otak.algo_auth`. Should be `otak.algo_crypt` instead. * OtaAlgoAuth.__init__() checks `algo_auth` but the error message prints `algo_crypt`. Should be `otak.algo_auth` instead. Change-Id: Ia636fffaeadc68e3f6d5b65d477e753834c95895 --- M pySim/ota.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve daniel: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/ota.py b/pySim/ota.py index fbb9d45..3d2da15 100644 --- a/pySim/ota.py +++ b/pySim/ota.py @@ -221,12 +221,12 @@ for subc in cls.__subclasses__(): if subc.enum_name == otak.algo_crypt: return subc(otak) - raise ValueError('No implementation for crypt algorithm %s' % otak.algo_auth) + raise ValueError('No implementation for crypt algorithm %s' % otak.algo_crypt) class OtaAlgoAuth(OtaAlgo, abc.ABC): def __init__(self, otak: OtaKeyset): if self.enum_name != otak.algo_auth: - raise ValueError('Cannot use algorithm %s with key for %s' % (self.enum_name, otak.algo_crypt)) + raise ValueError('Cannot use algorithm %s with key for %s' % (self.enum_name, otak.algo_auth)) super().__init__(otak) def sign(self, data:bytes) -> bytes: -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42382?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia636fffaeadc68e3f6d5b65d477e753834c95895 Gerrit-Change-Number: 42382 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: utils: dec_plmn(): remove redundant call
by fixeria 21 Mar '26

21 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42383?usp=email ) ( 3 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: utils: dec_plmn(): remove redundant call ...................................................................... utils: dec_plmn(): remove redundant call Change-Id: Ic95c3992ed57eb8fee952ec2dc7f092dd7689579 --- M pySim/utils.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: daniel: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/pySim/utils.py b/pySim/utils.py index 1fdcefe..0417366 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -139,7 +139,6 @@ def dec_plmn(threehexbytes: Hexstr) -> dict: res = {'mcc': "0", 'mnc': "0"} - dec_mcc_from_plmn_str(threehexbytes) res['mcc'] = dec_mcc_from_plmn_str(threehexbytes) res['mnc'] = dec_mnc_from_plmn_str(threehexbytes) return res -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42383?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ic95c3992ed57eb8fee952ec2dc7f092dd7689579 Gerrit-Change-Number: 42383 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026