Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email )
Change subject: doc/manuals: merge doc/osmo-s1gw-cli.md
......................................................................
Patch Set 5:
(1 comment)
File doc/manuals/chapters/cli.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368/comment/44f6fd2c_3f04… :
PS5, Line 6: filtering
: (`CMD | grep ...`), and output redirection (`CMD > FILE`).
piping into grep or redirecting into a file are not features of this program, these are features of the shell that could be done with wget $RESTURL as well. I would remove that.
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42368?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic2556f6add9c6a24f6da03f4388d7f86dde0c5dc
Gerrit-Change-Number: 42368
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Mar 2026 08:11:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email )
Change subject: doc/manuals: add overview, document running and configuration
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
File doc/manuals/chapters/running.adoc:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364/comment/329094d3_d55e… :
PS4, Line 128: ==== The `osmo-s1gw` Bootstrap Script
> I see no problem with explaining what the bootstrap script does and including the help message here. […]
Acknowledged
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/42364?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: I4ceca069866d7191ef2b153af95a20cb522bffeb
Gerrit-Change-Number: 42364
Gerrit-PatchSet: 5
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 18 Mar 2026 08:03:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>