March 2026 - gerrit-log - lists.osmocom.org

[M] Change in pysim[master]: test_configurable_parameters.py: add tests for new parameters
by neels 03 Mar '26

03 Mar '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42262?usp=email ) Change subject: test_configurable_parameters.py: add tests for new parameters ...................................................................... test_configurable_parameters.py: add tests for new parameters For: SmspTpScAddr MilenageRotation MilenageXoringConstants TuakNrOfKeccak Change-Id: Iecbea14fe31a9ee08d871dcde7f295d26d7bd001 --- M tests/unittests/test_configurable_parameters.py 1 file changed, 65 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/62/42262/1 diff --git a/tests/unittests/test_configurable_parameters.py b/tests/unittests/test_configurable_parameters.py index fa6437f..8d31f8a 100755 --- a/tests/unittests/test_configurable_parameters.py +++ b/tests/unittests/test_configurable_parameters.py @@ -202,6 +202,71 @@ val=io.BytesIO(b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16'), expect_clean_val=b'\x01\x02\x03\x04\x05\x06\x07\x08\x09\x10\x11\x12\x13\x14\x15\x16', expect_val='01020304050607080910111213141516'), + + Paramtest(param_cls=p13n.SmspTpScAddr, + val='+1234567', + expect_clean_val=(True, '1234567'), + expect_val='+1234567'), + Paramtest(param_cls=p13n.SmspTpScAddr, + val=1234567, + expect_clean_val=(False, '1234567'), + expect_val='1234567'), + + Paramtest(param_cls=p13n.TuakNumberOfKeccak, + val='123', + expect_clean_val=123, + expect_val='123'), + Paramtest(param_cls=p13n.TuakNumberOfKeccak, + val=123, + expect_clean_val=123, + expect_val='123'), + + Paramtest(param_cls=p13n.MilenageRotationConstants, + val='0a 0b 0c 01 02', + expect_clean_val=b'\x0a\x0b\x0c\x01\x02', + expect_val='0a0b0c0102'), + Paramtest(param_cls=p13n.MilenageRotationConstants, + val=b'\x0a\x0b\x0c\x01\x02', + expect_clean_val=b'\x0a\x0b\x0c\x01\x02', + expect_val='0a0b0c0102'), + Paramtest(param_cls=p13n.MilenageRotationConstants, + val=bytearray(b'\x0a\x0b\x0c\x01\x02'), + expect_clean_val=b'\x0a\x0b\x0c\x01\x02', + expect_val='0a0b0c0102'), + + Paramtest(param_cls=p13n.MilenageXoringConstants, + val='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' + ' bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' + ' cccccccccccccccccccccccccccccccc' + ' 11111111111111111111111111111111' + ' 22222222222222222222222222222222', + expect_clean_val=b'\xaa' * 16 + + b'\xbb' * 16 + + b'\xcc' * 16 + + b'\x11' * 16 + + b'\x22' * 16, + expect_val='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' + 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' + 'cccccccccccccccccccccccccccccccc' + '11111111111111111111111111111111' + '22222222222222222222222222222222'), + Paramtest(param_cls=p13n.MilenageXoringConstants, + val=b'\xaa' * 16 + + b'\xbb' * 16 + + b'\xcc' * 16 + + b'\x11' * 16 + + b'\x22' * 16, + expect_clean_val=b'\xaa' * 16 + + b'\xbb' * 16 + + b'\xcc' * 16 + + b'\x11' * 16 + + b'\x22' * 16, + expect_val='aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa' + 'bbbbbbbbbbbbbbbbbbbbbbbbbbbbbbbb' + 'cccccccccccccccccccccccccccccccc' + '11111111111111111111111111111111' + '22222222222222222222222222222222'), + ] for sdkey_cls in ( -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42262?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iecbea14fe31a9ee08d871dcde7f295d26d7bd001 Gerrit-Change-Number: 42262 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: add comment about not updating existing key_usage_qualifier
by neels 03 Mar '26

03 Mar '26

neels has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/42263?usp=email ) Change subject: add comment about not updating existing key_usage_qualifier ...................................................................... add comment about not updating existing key_usage_qualifier Change-Id: Ie23ae5fde17be6b37746784bf1601b4d0874397a --- M pySim/esim/saip/personalization.py 1 file changed, 5 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/63/42263/1 diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index de6e6ce..617e936 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -678,6 +678,11 @@ ) pe.add_key(key) else: + # A key of this KVN and ID already exists in the profile. + + # Keep the key_usage_qualifier as it was in the profile, so skip this here: + # key.key_usage_qualifier = cls.key_usage_qual + key.key_components = set_components @classmethod -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42263?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie23ae5fde17be6b37746784bf1601b4d0874397a Gerrit-Change-Number: 42263 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, implement batch personalization
by neels 03 Mar '26

03 Mar '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/40096?usp=email ) Change subject: personalization: add param_source.py, implement batch personalization ...................................................................... Abandoned I've made a mistake when squashing two commits, as a result this patch became I01ae40a06605eb205bfb409189fcd2b3a128855a now -- sorry about that -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I497c60c101ea0eea980e8b1a4b1f36c0eda39002 Gerrit-Change-Number: 40096 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by neels 03 Mar '26

03 Mar '26

Attention is currently required from: laforge. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email to look at the new patch set (#6). Change subject: personalization: add param_source.py, add batch.py ...................................................................... personalization: add param_source.py, add batch.py Implement pySim.esim.saip.batch.BatchPersonalization, generating N eSIM profiles from a preset configuration. Batch parameters can be fed by a constant, incrementing, random or from CSV rows: add pySim.esim.saip.param_source.* classes to feed such input to each of the BatchPersonalization's ConfigurableParameter instances. Related: SYS#6768 Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a --- A pySim/esim/saip/batch.py A pySim/esim/saip/param_source.py 2 files changed, 291 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/45/41845/6 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 6 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: improve Imsi,Iccid.get_values_from_pes()
by neels 03 Mar '26

03 Mar '26

neels has abandoned this change. ( https://gerrit.osmocom.org/c/pysim/+/41917?usp=email ) Change subject: improve Imsi,Iccid.get_values_from_pes() ...................................................................... Abandoned was squashed -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I40c888e81fc3172d5abbd5fc49029e5f7cf720ab Gerrit-Change-Number: 41917 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[M] Change in pysim[master]: personalization: implement reading back values from a PES
by neels 03 Mar '26

03 Mar '26

Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email ) Change subject: personalization: implement reading back values from a PES ...................................................................... Patch Set 10: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/40198/comment/1581bd2d_13550247?usp=em… : PS9, Line 54: def file_tuples_content_as_bytes(l: List[Tuple]) -> Optional[bytes]: > this is not used anymore now, and should be removed. […] oof thx how did i miss that -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Gerrit-Change-Number: 40198 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Mar 2026 23:32:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[L] Change in pysim[master]: personalization: add param_source.py, add batch.py
by neels 03 Mar '26

03 Mar '26

Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/41845?usp=email ) Change subject: personalization: add param_source.py, add batch.py ...................................................................... Patch Set 5: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/41845/comment/7543ff56_b5018ae1?usp=em… : PS4, Line 20: from typing import List, Tuple, Generator > why is it imported here if I don't find any existing or newly-introduced code using it? belonged to subsequent patch... -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I01ae40a06605eb205bfb409189fcd2b3a128855a Gerrit-Change-Number: 41845 Gerrit-PatchSet: 5 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Mar 2026 23:32:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: MilenageRotationConstants: set example_input to 3GPP default
by neels 03 Mar '26

03 Mar '26

Attention is currently required from: laforge. neels has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/42123?usp=email ) Change subject: MilenageRotationConstants: set example_input to 3GPP default ...................................................................... Patch Set 3: (1 comment) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/42123/comment/7303b678_311ae4d8?usp=em… : PS2, Line 355: > this is not a milenage rotation constant? Maybe slipped in by accident? Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I36a9434b2f96d26d710f489d5afce1f0ef05bba1 Gerrit-Change-Number: 42123 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Tue, 03 Mar 2026 23:31:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: personalization: implement reading back values from a PES
by neels 03 Mar '26

03 Mar '26

Attention is currently required from: neels. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email to look at the new patch set (#10). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: personalization: implement reading back values from a PES ...................................................................... personalization: implement reading back values from a PES Implement get_values_from_pes(), the reverse direction of apply_val(): read back and return values from a ProfileElementSequence. Implement for all ConfigurableParameter subclasses. Future: SdKey.get_values_from_pes() is reading pe.decoded[], which works fine, but I07dfc378705eba1318e9e8652796cbde106c6a52 will change this implementation to use the higher level ProfileElementSD members. Implementation detail: Implement get_values_from_pes() as classmethod that returns a generator. Subclasses should yield all occurences of their parameter in a given PES. For example, the ICCID can appear in multiple places. Iccid.get_values_from_pes() yields all of the individual values. A set() of the results quickly tells whether the PES is consistent. Rationales for reading back values: This allows auditing an eSIM profile, particularly for producing an output.csv from a batch personalization (that generated lots of random key material which now needs to be fed to an HLR...). Reading back from a binary result is more reliable than storing the values that were fed into a personalization. By auditing final DER results with this code, I discovered: - "oh, there already was some key material in my UPP template." - "all IMSIs ended up the same, forgot to set up the parameter." - the SdKey.apply() implementations currently don't work, see I07dfc378705eba1318e9e8652796cbde106c6a52 for a fix. Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 --- M pySim/esim/saip/personalization.py 1 file changed, 150 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/98/40198/10 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463 Gerrit-Change-Number: 40198 Gerrit-PatchSet: 10 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

[XS] Change in pysim[master]: MilenageRotationConstants: set example_input to 3GPP default
by neels 03 Mar '26

03 Mar '26

Attention is currently required from: neels. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/42123?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: MilenageRotationConstants: set example_input to 3GPP default ...................................................................... MilenageRotationConstants: set example_input to 3GPP default Change-Id: I36a9434b2f96d26d710f489d5afce1f0ef05bba1 --- M pySim/esim/saip/personalization.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/23/42123/3 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42123?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I36a9434b2f96d26d710f489d5afce1f0ef05bba1 Gerrit-Change-Number: 42123 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026