March 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: OBS: pyhss_download_deps: add python 3.14
by osmith 30 Mar '26

30 Mar '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ci/+/42518?usp=email ) Change subject: OBS: pyhss_download_deps: add python 3.14 ...................................................................... OBS: pyhss_download_deps: add python 3.14 Download binary package dependencies for python 3.14 too, so we can build the package for Ubuntu 26.04. Related: OS#6983 Related: https://gitea.osmocom.org/osmocom/pyhss/commit/2125f52c5eb1b3e66b1ebe2febad… Change-Id: Ic23d52c081f68fb8d6f7d9e370883236ca9bf35f --- M scripts/obs/data/pyhss_download_deps.sh 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve osmith: Looks good to me, approved diff --git a/scripts/obs/data/pyhss_download_deps.sh b/scripts/obs/data/pyhss_download_deps.sh index 7dfd5d9..b8b2b64 100644 --- a/scripts/obs/data/pyhss_download_deps.sh +++ b/scripts/obs/data/pyhss_download_deps.sh @@ -24,6 +24,7 @@ 3.11 3.12 3.13 + 3.14 " # See e.g. https://pypi.org/project/SQLAlchemy/#files local platform -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic23d52c081f68fb8d6f7d9e370883236ca9bf35f Gerrit-Change-Number: 42518 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ci[master]: OBS: pyhss_download_deps: add python 3.14
by osmith 30 Mar '26

30 Mar '26

Attention is currently required from: pespin. osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42518?usp=email ) Change subject: OBS: pyhss_download_deps: add python 3.14 ...................................................................... Patch Set 2: Code-Review+2 (1 comment) Patchset: PS2: trivial, submitting with just 1 review -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42518?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ic23d52c081f68fb8d6f7d9e370883236ca9bf35f Gerrit-Change-Number: 42518 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 10:22:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown
by pespin 30 Mar '26

30 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email ) Change subject: stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown ...................................................................... stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown Related tests already exist for M3UA and M3UA_TCP, but were missing for IPA ASPs. Change-Id: Ie30de6caa3e2b680aff9e50898e63f615b526500 Related: OS#6752 --- M stp/STP_Tests_IPA.ttcn M stp/expected-results.xml 2 files changed, 113 insertions(+), 4 deletions(-) Approvals: fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/stp/STP_Tests_IPA.ttcn b/stp/STP_Tests_IPA.ttcn index 0a5b56c..431bdd4 100644 --- a/stp/STP_Tests_IPA.ttcn +++ b/stp/STP_Tests_IPA.ttcn @@ -76,6 +76,13 @@ var IpaConfigs g_ipa_configs; } +private altstep as_IPA_wait_tcp_conn_closed(integer idx) runs on IPA_CT { + var ASP_IPA_Event evt; + [] IPA_CTRL[idx].receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_DOWN)) -> value evt { + log("Peer closed conn: ", evt) + } +} + friend function ipa_build_configs(template (omit) Misc_Helpers.ro_charstring asps := omit) return IpaConfigs { @@ -182,6 +189,28 @@ } } +private function f_IPA_close(integer i) runs on IPA_CT { + var Result res; + if (vc_IPA[i] == null) { + log("Not close()ing ipacfg := ", g_ipa_configs[i], " (not connected)"); + /* not connected */ + return; + } + vc_IPA[i].stop; + vc_IPA[i] := null; +} + +private function f_clear_ipa() runs on IPA_CT { + var integer i; + + log("Clearing IPA..."); + + for (i := 0; i < lengthof(g_ipa_configs); i:=i+1) { + f_IPA_close(i); + } + setverdict(pass, "IPA cleared"); +} + friend function f_connect_ipa(integer idx, boolean exp_act := true) runs on IPA_CT { vc_IPA[idx].start(IPA_Emulation.main_client(mp_stp_ipa_ip, g_ipa_configs[idx].remote_port, @@ -196,13 +225,16 @@ } } -friend function f_listen_ipa(integer idx) runs on IPA_CT { - vc_IPA[idx].start(IPA_Emulation.main_server(mp_local_ipa_ip, - g_ipa_configs[idx].local_port)); +private function f_start_ipa_server(integer idx) runs on IPA_CT { + vc_IPA[idx].start(IPA_Emulation.main_server(mp_local_ipa_ip, g_ipa_configs[idx].local_port)); +} + +friend function f_listen_ipa(integer idx, float to_val := 10.0) runs on IPA_CT { + f_start_ipa_server(idx); /* wait for incoming connection to IPA port before proceeding */ var integer st := 0; - timer T := 10.0; + timer T := to_val; T.start; alt { [st == 0] IPA_CTRL[idx].receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_UP)) { @@ -221,6 +253,22 @@ } } +/* Make sure no new conn is attemptent from the peer during the specified time frame: */ +private function f_exp_no_ipa_conn(integer idx, float to_val := 10.0) runs on IPA_CT { + timer T; + + T.start(to_val); + alt { + [] IPA_CTRL[idx].receive(tr_ASP_IPA_EV(ASP_IPA_EVENT_UP)) { + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Got unexpected connection to IPA[", idx, "] Port")); + } + [] T.timeout { + setverdict(pass); + } + } +} + /* "accept-asp-connections pre-configured" and client from unknown ASP source * (but known AS/ipa_unit_name) */ testcase TC_unknown_client_nodynamic() runs on IPA_CT { @@ -681,6 +729,62 @@ } } +/* Test administrative state, VTY "[no] shutdown" */ +testcase TC_ipa_tcp_srv_adm_shutdown() runs on IPA_CT { + var Misc_Helpers.ro_charstring asps := { "ipa-asp-override-sender" }; + var IpaConfigs ipa_configs := ipa_build_configs(asps); + f_init_ipa(ipa_configs := ipa_configs); + f_connect_ipa(0); + + f_sleep(1.0); + f_vty_cs7_ipa_asp_cmd(ipa_configs[0], "shutdown"); + log("ASP should now be DOWN") + as_IPA_wait_tcp_conn_closed(0); + f_clear_ipa(); + f_init_ipa(ipa_configs := ipa_configs); + + f_sleep(1.0); + /* Make sure SCTP conn will be closed when we connect to it. */ + log("Connecting to ASP (expect closed):"); + f_connect_ipa(0, exp_act := false); + f_clear_ipa(); + + /* Now let the ASP be active again, it should allow us to reconnect: */ + f_vty_cs7_ipa_asp_cmd(ipa_configs[0], "no shutdown"); + log("Connecting to ASP (expect success):"); + f_init_ipa(ipa_configs := ipa_configs); + f_connect_ipa(0); + setverdict(pass); +} + +/* Test administrative state, VTY "[no] shutdown" */ +testcase TC_ipa_tcp_cli_adm_shutdown() runs on IPA_CT { + var PortEvent pev; + var Misc_Helpers.ro_charstring asps := { "ipa-asp-client0" }; + var IpaConfigs ipa_configs := ipa_build_configs(asps); + + f_init_ipa(ipa_configs := ipa_configs); + f_listen_ipa(0); + f_sleep(1.0); + f_vty_cs7_ipa_asp_cmd(ipa_configs[0], "shutdown"); + log("ASP should now be DOWN") + as_IPA_wait_tcp_conn_closed(0); + f_clear_ipa(); + + /* Wait for a while to make sure ASP doesn't reconnect to us: */ + f_init_ipa(ipa_configs := ipa_configs); + f_start_ipa_server(0); + f_exp_no_ipa_conn(0, to_val := 10.0); + f_clear_ipa(); + + /* Now let the ASP be active again, it should reconnect to us: */ + f_vty_cs7_ipa_asp_cmd(ipa_configs[0], "no shutdown"); + log("Waiting for client ASP to reconnect to us"); + f_init_ipa(ipa_configs := ipa_configs); + f_listen_ipa(0); + setverdict(pass); +} + testcase TC_beat() runs on IPA_CT { var Misc_Helpers.ro_charstring asps := { "ipa-asp-override-sender" }; var IpaConfigs ipa_configs := ipa_build_configs(asps); @@ -775,6 +879,9 @@ execute( TC_unknown_client_dynamic_combinedlset_loadshare() ); execute( TC_inaccessible_sp() ); + execute( TC_ipa_tcp_srv_adm_shutdown() ); + execute( TC_ipa_tcp_cli_adm_shutdown() ); + execute( TC_beat() ); execute( TC_beat_timeout() ); execute( TC_clnt_beat_timeout() ); diff --git a/stp/expected-results.xml b/stp/expected-results.xml index 44f5ced..2dfe5b1 100644 --- a/stp/expected-results.xml +++ b/stp/expected-results.xml @@ -66,6 +66,8 @@ <testcase classname='STP_Tests_IPA' name='TC_combinedlset_loadshare' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_unknown_client_dynamic_combinedlset_loadshare' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_inaccessible_sp' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_ipa_tcp_srv_adm_shutdown' time='MASKED'/> + <testcase classname='STP_Tests_IPA' name='TC_ipa_tcp_cli_adm_shutdown' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_beat_timeout' time='MASKED'/> <testcase classname='STP_Tests_IPA' name='TC_clnt_beat_timeout' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie30de6caa3e2b680aff9e50898e63f615b526500 Gerrit-Change-Number: 42520 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown
by fixeria 30 Mar '26

30 Mar '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email ) Change subject: stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie30de6caa3e2b680aff9e50898e63f615b526500 Gerrit-Change-Number: 42520 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 09:56:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: struct trx_power_params: fix inaccurate comment
by fixeria 30 Mar '26

30 Mar '26

fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42525?usp=email ) Change subject: struct trx_power_params: fix inaccurate comment ...................................................................... struct trx_power_params: fix inaccurate comment Change-Id: I1bdb7fab24fee28dbeac0ed05e13f650e08c98e9 Fixes: 4c632421 ("bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED") --- M include/osmo-bts/tx_power.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/25/42525/1 diff --git a/include/osmo-bts/tx_power.h b/include/osmo-bts/tx_power.h index 52c02f5..6327c62 100644 --- a/include/osmo-bts/tx_power.h +++ b/include/osmo-bts/tx_power.h @@ -60,7 +60,7 @@ struct osmo_timer_list step_timer; /* call-back called when target is reached */ ramp_compl_cb_t compl_cb; - /* set to true after compl_cb has been called (ramp target confirmed by hardware) */ + /* set to true just before compl_cb is called (ramp target confirmed by hardware) */ bool complete; } ramp; }; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42525?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I1bdb7fab24fee28dbeac0ed05e13f650e08c98e9 Gerrit-Change-Number: 42525 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: osmo-bts-trx: rx_rach_fn(): remove redundant fall-back
by fixeria 30 Mar '26

30 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42523?usp=email ) Change subject: osmo-bts-trx: rx_rach_fn(): remove redundant fall-back ...................................................................... osmo-bts-trx: rx_rach_fn(): remove redundant fall-back Condition `synch_seq != RACH_SYNCH_SEQ_TS0` is unlikely to be true, given that no other synch. sequences are defined by 3GPP TS 45.002. Even if this happens for whatever reason (e.g. a bug), assigning `synch_seq` to `RACH_SYNCH_SEQ_TS0` is not needed, as `synch_seq` is never read after the switch statement. The logging message is not useful either, since we already print the synch. seq. above. Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 --- M src/osmo-bts-trx/sched_lchan_rach.c 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/osmo-bts-trx/sched_lchan_rach.c b/src/osmo-bts-trx/sched_lchan_rach.c index c92dfe2..a4a01a9 100644 --- a/src/osmo-bts-trx/sched_lchan_rach.c +++ b/src/osmo-bts-trx/sched_lchan_rach.c @@ -186,12 +186,6 @@ case RACH_SYNCH_SEQ_TS0: default: - /* Fall-back to the default TS0 if needed */ - if (synch_seq != RACH_SYNCH_SEQ_TS0) { - LOGL1SB(DL1P, LOGL_DEBUG, l1ts, bi, "Falling-back to the default TS0\n"); - synch_seq = RACH_SYNCH_SEQ_TS0; - } - rc = gsm0503_rach_decode_ber(&ra, bi->burst + RACH_EXT_TAIL_LEN + RACH_SYNCH_SEQ_LEN, trx->bts->bsic, &n_errors, &n_bits_total); if (rc) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42523?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I4cdc03dc6631ca17d13a3067ad03020e3e97eab1 Gerrit-Change-Number: 42523 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED
by fixeria 30 Mar '26

30 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42524?usp=email ) Change subject: bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED ...................................................................... bts_shutdown_fsm: fix spurious RAMP_COMPL events in WAIT_TRX_CLOSED With multiple TRXes ramping down in lockstep, both their final ramp-timer callbacks fire back-to-back in the same event loop pass, setting p_total_cur_mdBm to the target value for both before any async hardware acknowledgement arrives. When the first SETPOWER ack returns and fires ramp_down_compl_cb() for TRX0, the remaining-TRX check in st_wait_ramp_down_compl() inspects p_total_cur_mdBm for TRX1 and finds it already at the target - concluding that all TRXes are done. The FSM then transitions to WAIT_TRX_CLOSED, and the second ack (for TRX1) fires ramp_down_compl_cb() into the wrong state, producing: BTS_SHUTDOWN(...){WAIT_TRX_CLOSED}: Event BTS_SHUTDOWN_EV_TRX_RAMP_COMPL not permitted The root cause is that p_total_cur_mdBm is a *requested* value set in the timer callback, not a confirmed one. The hardware confirmation arrives asynchronously via power_trx_change_compl() -> power_ramp_do_step(), which is also where compl_cb() is invoked. Fix by adding a 'complete' flag to trx_power_params.ramp that is: * cleared when _power_ramp_start() begins a new ramp, and * set just before compl_cb() is called in power_ramp_do_step() The shutdown FSM remaining-TRX count then checks !ramp.complete instead of comparing p_total_cur_mdBm against the target, correctly reflecting which TRXes have actually received hardware confirmation of ramp completion. Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 --- M include/osmo-bts/tx_power.h M src/common/bts_shutdown_fsm.c M src/common/tx_power.c 3 files changed, 6 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/include/osmo-bts/tx_power.h b/include/osmo-bts/tx_power.h index 73134c8..52c02f5 100644 --- a/include/osmo-bts/tx_power.h +++ b/include/osmo-bts/tx_power.h @@ -1,6 +1,7 @@ #pragma once #include <stdint.h> +#include <stdbool.h> #include <osmocom/core/timer.h> /* our unit is 'milli dB" or "milli dBm", i.e. 1/1000 of a dB(m) */ @@ -59,6 +60,8 @@ struct osmo_timer_list step_timer; /* call-back called when target is reached */ ramp_compl_cb_t compl_cb; + /* set to true after compl_cb has been called (ramp target confirmed by hardware) */ + bool complete; } ramp; }; diff --git a/src/common/bts_shutdown_fsm.c b/src/common/bts_shutdown_fsm.c index 13a0e1d..a8c8f9d 100644 --- a/src/common/bts_shutdown_fsm.c +++ b/src/common/bts_shutdown_fsm.c @@ -110,7 +110,7 @@ llist_for_each_entry(trx, &bts->trx_list, list) { if (trx->mo.nm_state.operational == NM_OPSTATE_ENABLED && - trx->power_params.p_total_cur_mdBm > BTS_SHUTDOWN_POWER_RAMP_TGT) + !trx->power_params.ramp.complete) remaining++; } diff --git a/src/common/tx_power.c b/src/common/tx_power.c index 1e026dd..575fe2f 100644 --- a/src/common/tx_power.c +++ b/src/common/tx_power.c @@ -210,6 +210,7 @@ /* we had finished in last loop iteration */ if (!first && tpp->ramp.attenuation_mdB == 0) { + tpp->ramp.complete = true; if (tpp->ramp.compl_cb) tpp->ramp.compl_cb(trx); return; @@ -261,6 +262,7 @@ /* set the new target */ tpp->p_total_tgt_mdBm = p_total_tgt_mdBm; tpp->ramp.compl_cb = ramp_compl_cb; + tpp->ramp.complete = false; if (skip_ramping) { /* Jump straight to the target power */ -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42524?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia71393e871187d6b44b7f520eb421bab354aafd1 Gerrit-Change-Number: 42524 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: osmo-bts-trx: rx_data_fn(): fix copy-paste in comment
by fixeria 30 Mar '26

30 Mar '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/42522?usp=email ) Change subject: osmo-bts-trx: rx_data_fn(): fix copy-paste in comment ...................................................................... osmo-bts-trx: rx_data_fn(): fix copy-paste in comment Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea --- M src/osmo-bts-trx/sched_lchan_xcch.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/osmo-bts-trx/sched_lchan_xcch.c b/src/osmo-bts-trx/sched_lchan_xcch.c index 0580d33..38e1f1a 100644 --- a/src/osmo-bts-trx/sched_lchan_xcch.c +++ b/src/osmo-bts-trx/sched_lchan_xcch.c @@ -117,8 +117,7 @@ /* When SACCH Repetition is active, we may try to decode the * current SACCH block by including the information from the - * information from the previous SACCH block. See also: - * 3GPP TS 44.006, section 11.2 */ + * previous SACCH block. See also 3GPP TS 44.006, section 11.2 */ if (rep_sacch) { add_sbits(BUFPOS(bursts_p, 0), BUFPOS(bursts_p, 4)); rc = gsm0503_xcch_decode(l2, BUFPOS(bursts_p, 0), &n_errors, &n_bits_total); -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42522?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ibf35c468310a690fd873cf968bb2c44b493ca5ea Gerrit-Change-Number: 42522 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown
by osmith 30 Mar '26

30 Mar '26

Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email ) Change subject: stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown ...................................................................... Patch Set 2: (1 comment) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520/comment/f4249de6_3292… : PS1, Line 196: /* not connected */ > doesn't hurt either :) Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie30de6caa3e2b680aff9e50898e63f615b526500 Gerrit-Change-Number: 42520 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 08:41:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown
by pespin 30 Mar '26

30 Mar '26

Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email ) Change subject: stp: STP_Tests_IPA: Introduce tests TC_ipa_tcp_{cli,srv}_adm_shutdown ...................................................................... Patch Set 2: (1 comment) File stp/STP_Tests_IPA.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520/comment/fb686a1a_9e03… : PS1, Line 196: /* not connected */ > this comment seems redundant with the log msg above doesn't hurt either :) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42520?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie30de6caa3e2b680aff9e50898e63f615b526500 Gerrit-Change-Number: 42520 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 30 Mar 2026 08:40:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026