Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42284?usp=email )
Change subject: repo-install-test: run for debian 13 too
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42284?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1db9de8c740d5167e4813ece36f422b27aed5111
Gerrit-Change-Number: 42284
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 06 Mar 2026 12:22:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40199?usp=email )
Change subject: personalization: allow reading back multiple values from PES
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
As far as I understand, this patch only extends the patch from before so that we can read back multiple values. (I also see that this patch fixes some unrelated things from the patch before) Maybe it makes sense to squash both patches into one?
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40199/comment/2be3fe1e_9d30e01f?usp=em… :
PS10, Line 209: def get_values_from_pes(cls, pes: ProfileElementSequence) -> Generator:
Ah, ok here you fix the comment chars. Should be ok then.
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40199?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Iecb68af7c216c6b9dc3add469564416b6f37f7b2
Gerrit-Change-Number: 40199
Gerrit-PatchSet: 10
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: dexter <pmaier(a)sysmocom.de>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 06 Mar 2026 12:07:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: neels.
dexter has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/40198?usp=email )
Change subject: personalization: implement reading back values from a PES
......................................................................
Patch Set 11: Code-Review+1
(5 comments)
Patchset:
PS11:
I think this patch looks ok. I would recommend to look at decimal_hex_to_str() a bit more closely to make sure it actually does the right thing.
File pySim/esim/saip/personalization.py:
https://gerrit.osmocom.org/c/pysim/+/40198/comment/37303680_0841eeb4?usp=em… :
PS11, Line 209: def get_values_from_pes(cls, pes: ProfileElementSequence) -> Generator:
As far as I understand ''' just marks a multiline comment, but shouldn't this be a doctstring?
https://gerrit.osmocom.org/c/pysim/+/40198/comment/df8adf24_6dd87150?usp=em… :
PS11, Line 290: def decimal_hex_to_str(cls, val):
also have not seen single quotes as comment chars before...
https://gerrit.osmocom.org/c/pysim/+/40198/comment/7ddc4bfe_68a1a8c5?usp=em… :
PS11, Line 292: if isinstance(val, bytes):
Is it always ensured that we won't get sometimes bytes and sometimes bytearrays?
https://gerrit.osmocom.org/c/pysim/+/40198/comment/501ac867_7f438d57?usp=em… :
PS11, Line 297: val = unrpad(val, c)
You are sure that you want to turn val to ascii, like "4141" => "AA"? (am a bit confused since the method name suggests more that the input should be a hexstring or a bytearray with decimal digits and the output should be a string with the same digits.)
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/40198?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I234fc4317f0bdc1a486f0cee4fa432c1dce9b463
Gerrit-Change-Number: 40198
Gerrit-PatchSet: 11
Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 06 Mar 2026 11:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes