March 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-asf4-dfu[master]: Improve comments on errata 2.6.10
by mschramm 02 Mar '26

02 Mar '26

Attention is currently required from: lynxis lazus. mschramm has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email ) Change subject: Improve comments on errata 2.6.10 ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: The point here is: there is no such facility nor even a concept of a 'low-priority' WDT in this Cortex-M4F, therefore it can not be started, and hence your comment is simply wrong. This rather reads like a typo/thinko from the errata workaround where they want to have the WDT initialized w/ "low(est) period" . -- To view, visit https://gerrit.osmocom.org/c/osmo-asf4-dfu/+/42168?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-asf4-dfu Gerrit-Branch: master Gerrit-Change-Id: I3c35f590a4e43d778e70f2f377e0d470c3a652b2 Gerrit-Change-Number: 42168 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: mschramm <mschramm(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 02 Mar 2026 10:47:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bts[master]: tch: fix RTP clock not ticking for unhandled payload types
by pespin 02 Mar '26

02 Mar '26

Attention is currently required from: Thorkell Thorkelsson, fixeria. pespin has posted comments on this change by Thorkell Thorkelsson. ( https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email ) Change subject: tch: fix RTP clock not ticking for unhandled payload types ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42244?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I202522ea6f83d77872a2f84d9a2622b87e829a0c Gerrit-Change-Number: 42244 Gerrit-PatchSet: 5 Gerrit-Owner: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Thorkell Thorkelsson <thorkellmanithorkelsson(a)gmail.com> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Mar 2026 10:46:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-asn1-tcap[master]: Introduce API osmo_asn1_tcap_TCMessage_decode()
by pespin 02 Mar '26

02 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42238?usp=email ) Change subject: Introduce API osmo_asn1_tcap_TCMessage_decode() ...................................................................... Introduce API osmo_asn1_tcap_TCMessage_decode() This new API allows passing a talloc context where all memory is allocated by asn1c code is allocated. Related: SYS#5423 Related: OS#6965 Change-Id: I02923afb3936a1acf6643def27528e35e4b03e86 --- A TODO-RELEASE M include/osmocom/tcap/asn_internal.h M include/osmocom/tcap/tcap.h M src/Makefile.am M src/tcap.c 5 files changed, 25 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE new file mode 100644 index 0000000..9312dbd --- /dev/null +++ b/TODO-RELEASE @@ -0,0 +1,10 @@ +# When cleaning up this file: bump API version in corresponding Makefile.am and rename corresponding debian/lib*.install +# according to https://osmocom.org/projects/cellular-infrastructure/wiki/Make_a_new_release +# In short: https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info… +# LIBVERSION=c:r:a +# If the library source code has changed at all since the last update, then increment revision: c:r + 1:a. +# If any interfaces have been added, removed, or changed since the last update: c + 1:0:a. +# If any interfaces have been added since the last public release: c:r:a + 1. +# If any interfaces have been removed or changed since the last public release: c:r:0. +#library what description / commit summary line +libosmo-asn1-tcap add osmo_asn1_tcap_TCMessage_decode() diff --git a/include/osmocom/tcap/asn_internal.h b/include/osmocom/tcap/asn_internal.h index f4337d3..18e493f 100644 --- a/include/osmocom/tcap/asn_internal.h +++ b/include/osmocom/tcap/asn_internal.h @@ -35,7 +35,7 @@ #define ASN1C_ENVIRONMENT_VERSION 923 /* Compile-time version */ int get_asn1c_environment_version(void); /* Run-time version */ -extern void *tcap_talloc_asn1_ctx; +extern __thread void *tcap_talloc_asn1_ctx; #define CALLOC(nmemb, size) talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size)) #define MALLOC(size) talloc_size(tcap_talloc_asn1_ctx, size) #define REALLOC(oldptr, size) talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size) diff --git a/include/osmocom/tcap/tcap.h b/include/osmocom/tcap/tcap.h index 309f283..c7db4ab 100644 --- a/include/osmocom/tcap/tcap.h +++ b/include/osmocom/tcap/tcap.h @@ -6,6 +6,8 @@ #include <osmocom/tcap/TCAP_TCMessage.h> -int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len); +int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len) OSMO_DEPRECATED("Use osmo_asn1_tcap_TCMessage_decode() instead"); + +int osmo_asn1_tcap_TCMessage_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len, void *talloc_ctx); void osmo_asn1_tcap_TCMessage_free_contents(struct TCAP_TCMessage *tcapmsg); diff --git a/src/Makefile.am b/src/Makefile.am index 42089af..78d8d0d 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -243,7 +243,7 @@ ../../move-asn1-header-files.sh osmocom/tcap $(ASN_MODULE_INC) #Patch mem alloc defines to use talloc: sed -i "s/#define\tASN_INTERNAL_H/#define\tASN_INTERNAL_H\n#include <talloc.h>/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h - sed -i "s/#define\tCALLOC/extern void *tcap_talloc_asn1_ctx;\n#define\tCALLOC/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/#define\tCALLOC/extern __thread void *tcap_talloc_asn1_ctx;\n#define\tCALLOC/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h sed -i "s/calloc(nmemb, size)/talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size))/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h sed -i "s/malloc(size)/talloc_size(tcap_talloc_asn1_ctx, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h sed -i "s/realloc(oldptr, size)/talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h diff --git a/src/tcap.c b/src/tcap.c index f5303ac..0957faa 100644 --- a/src/tcap.c +++ b/src/tcap.c @@ -26,7 +26,7 @@ #include <osmocom/tcap/asn_codecs.h> #include <osmocom/tcap/TCAP_TCMessage.h> -void *tcap_talloc_asn1_ctx; +__thread void *tcap_talloc_asn1_ctx; int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len) { @@ -41,6 +41,15 @@ return 0; } +int osmo_asn1_tcap_TCMessage_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len, void *talloc_ctx) +{ + int rc; + tcap_talloc_asn1_ctx = talloc_ctx; + rc = osmo_asn1_tcap_decode(tcapmsg, data, data_len); + tcap_talloc_asn1_ctx = NULL; + return rc; +} + void osmo_asn1_tcap_TCMessage_free_contents(struct TCAP_TCMessage *tcapmsg) { ASN_STRUCT_FREE_CONTENTS_ONLY(asn_DEF_TCAP_TCMessage, tcapmsg); -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42238?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I02923afb3936a1acf6643def27528e35e4b03e86 Gerrit-Change-Number: 42238 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in libosmo-asn1-tcap[master]: Add README.md
by pespin 02 Mar '26

02 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42216?usp=email ) Change subject: Add README.md ...................................................................... Add README.md Change-Id: Ie3fa506cb9b40992cebe6942ea833a2e49ba2680 --- A README.md 1 file changed, 68 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/README.md b/README.md new file mode 100644 index 0000000..b73eefe --- /dev/null +++ b/README.md @@ -0,0 +1,68 @@ +libosmo-asn1-tcap +================= + +This repository contains C-language routing to encode and decode TCAP (ITU Q.771-Q.775). + +Homepage +-------- + +The official homepage of the project is +https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap/ + +GIT Repository +-------------- + +You can clone from the official libosmo-asn1-tcap.git repository using + + git clone https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap/ + +There is a web interface at <https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap/> + +Mailing List +------------ + +Discussions related to libosmo-asn1-tcap are happening on the +openbsc(a)lists.osmocom.org mailing list, please see +https://lists.osmocom.org/mailman/listinfo/openbsc for subscription +options and the list archive. + +Please observe the [Osmocom Mailing List +Rules](https://osmocom.org/projects/cellular-infrastructure/wiki/Mailing_List_Rules) +when posting. + +Contributing +------------ + +Our coding standards are described at +https://osmocom.org/projects/cellular-infrastructure/wiki/Coding_standards + +We use a Gerrit based patch submission/review process for managing +contributions. Please see +https://osmocom.org/projects/cellular-infrastructure/wiki/Gerrit for +more details + +The current patch queue for libosmo-asn1-tcap can be seen at +https://gerrit.osmocom.org/#/q/project:libosmo-asn1-tcap+status:open + + +Generating asn1c code +--------------------- + +The upstream fork maintained by a big contributor +[mouse07410](https://github.com/mouse07410/asn1c) of asn1c is used to generate +TCAP code from from ASN.1 files present in the asn/ directory. + +In order to regenerate the code, one shall adjust the ASN1C_SKELETON_PATH and +ASN1C_BIN_PATH in configure.ac to point to the built & installed asn1c from +mouse07410 (usually `vlm_master` branch). Last generated code was built using +commit hash 2c065550a5a0d08636cad64f4b067c1dcba2f339. + +Then, do the usual `autoreconf -fi && ./configure`, using a buildir != srcdir +(important, in order to avoid ending up with temporary files in srcdir and +making it difficult to stash the relevant changes). + +Finally, run `make -C src/ regen`, which will regenerate the files and copy over +the skeletons, with git possibly showing changes in the following paths: +- include/osmocom/tcap/ +- src/gen/ +- src/skel/ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42216?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ie3fa506cb9b40992cebe6942ea833a2e49ba2680 Gerrit-Change-Number: 42216 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-asn1-tcap[master]: Makefile.am: Avoid removing tcap.h during make -C src/ regen
by pespin 02 Mar '26

02 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42217?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Makefile.am: Avoid removing tcap.h during make -C src/ regen ...................................................................... Makefile.am: Avoid removing tcap.h during make -C src/ regen That header is ours and is the public entry towards the library. Change-Id: I89a34ef61e6f74ba7482a5abcf55404c157a14fb --- M src/Makefile.am 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/src/Makefile.am b/src/Makefile.am index ef91d4b..6c2f830 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -210,7 +210,9 @@ regen: regenerate-from-asn1-source regenerate-from-asn1-source: - rm -f $(top_srcdir)/src/gen/*.c $(top_srcdir)/include/osmocom/tcap/*.h + rm -f $(top_srcdir)/src/gen/*.c +# Remove all .h files except our tcap.h: + find $(top_srcdir)/include/osmocom/tcap/ -type f -name '*.h' -type f -not -name 'tcap.h' -delete ASN1C_PREFIX="TCAP_" ${ASN1C_BIN_PATH} \ -S $(ASN1C_SKELETON_PATH) \ -D $(top_srcdir)/src/gen \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42217?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I89a34ef61e6f74ba7482a5abcf55404c157a14fb Gerrit-Change-Number: 42217 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-asn1-tcap[master]: Use talloc to allocate asn1c decoded structs
by pespin 02 Mar '26

02 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Use talloc to allocate asn1c decoded structs This commit adds talloc support but will still use talloc NULL context everywhere when allocating memory. This is already useful since it allows programs enabling null context tracking to get a report of memory usage. Related: SYS#5423 Related: OS#6965 Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 --- M configure.ac M debian/control M include/osmocom/tcap/asn_internal.h M libosmo-asn1-tcap.pc.in M src/Makefile.am M src/tcap.c M tests/parse/Makefile.am 7 files changed, 27 insertions(+), 8 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/configure.ac b/configure.ac index 5082daf..28aa608 100644 --- a/configure.ac +++ b/configure.ac @@ -31,6 +31,8 @@ AC_SUBST([ASN_MODULE_CFLAGS]) +PKG_CHECK_MODULES(TALLOC, [talloc >= 2.1.0]) + # The following test is taken from WebKit's webkit.m4 saved_CFLAGS="$CFLAGS" CFLAGS="$CFLAGS -fvisibility=hidden " diff --git a/debian/control b/debian/control index 2dee434..52ffffe 100644 --- a/debian/control +++ b/debian/control @@ -10,6 +10,7 @@ git, libtool, pkg-config, + libtalloc-dev (>= 2.1.0) Standards-Version: 3.9.6 Vcs-Browser: https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap Vcs-Git: https://gitea.osmocom.org/ss7-in-c/libosmo-asn1-tcap @@ -25,7 +26,9 @@ Package: libosmo-asn1-tcap-dev Section: libdevel Architecture: any -Depends: libosmo-asn1-tcap1 (= ${binary:Version}), ${misc:Depends} +Depends: libosmo-asn1-tcap1 (= ${binary:Version}), + libtalloc-dev (>= 2.1.0), + ${misc:Depends} Multi-Arch: same Description: Development headers for utility library for ASN.1 of TCAP (SS7) diff --git a/include/osmocom/tcap/asn_internal.h b/include/osmocom/tcap/asn_internal.h index bf5b510..f4337d3 100644 --- a/include/osmocom/tcap/asn_internal.h +++ b/include/osmocom/tcap/asn_internal.h @@ -7,6 +7,7 @@ */ #ifndef ASN_INTERNAL_H #define ASN_INTERNAL_H +#include <talloc.h> #ifndef __EXTENSIONS__ #define __EXTENSIONS__ /* for Sun */ #endif @@ -34,10 +35,11 @@ #define ASN1C_ENVIRONMENT_VERSION 923 /* Compile-time version */ int get_asn1c_environment_version(void); /* Run-time version */ -#define CALLOC(nmemb, size) calloc(nmemb, size) -#define MALLOC(size) malloc(size) -#define REALLOC(oldptr, size) realloc(oldptr, size) -#define FREEMEM(ptr) free(ptr) +extern void *tcap_talloc_asn1_ctx; +#define CALLOC(nmemb, size) talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size)) +#define MALLOC(size) talloc_size(tcap_talloc_asn1_ctx, size) +#define REALLOC(oldptr, size) talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size) +#define FREEMEM(ptr) talloc_free(ptr) #define asn_debug_indent 0 #define ASN_DEBUG_INDENT_ADD(i) do{}while(0) diff --git a/libosmo-asn1-tcap.pc.in b/libosmo-asn1-tcap.pc.in index 17971a1..80dd622 100644 --- a/libosmo-asn1-tcap.pc.in +++ b/libosmo-asn1-tcap.pc.in @@ -6,5 +6,6 @@ Name: ASN.1 library for TCAP protocol (SS7) Description: C Utility Library Version: @VERSION@ +Requires.private: talloc Libs: -L${libdir} -losmo-asn1-tcap Cflags: -I${includedir}/ diff --git a/src/Makefile.am b/src/Makefile.am index 6c2f830..42089af 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1,4 +1,4 @@ -AM_CFLAGS = -I$(top_srcdir)/include/ -I$(top_srcdir)/src/skel $(ASN_MODULE_CFLAGS) +AM_CFLAGS = -I$(top_srcdir)/include/ -I$(top_srcdir)/src/skel $(ASN_MODULE_CFLAGS) $(TALLOC_CFLAGS) SKEL_SRC = \ skel/ANY.c \ @@ -201,6 +201,8 @@ libosmo_asn1_tcap_la_LDFLAGS = -version-info $(LIBVERSION) -no-undefined -export-symbols-regex '^osmo_' +libosmo_asn1_tcap_la_LIBADD = $(TALLOC_LIBS) + libosmo_asn1_tcap_la_SOURCES = \ tcap.c \ $(ASN_MODULE_SRC) @@ -239,6 +241,13 @@ # #include <...> in *.c and *.h files cd $(top_srcdir)/src/gen && \ ../../move-asn1-header-files.sh osmocom/tcap $(ASN_MODULE_INC) +#Patch mem alloc defines to use talloc: + sed -i "s/#define\tASN_INTERNAL_H/#define\tASN_INTERNAL_H\n#include <talloc.h>/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/#define\tCALLOC/extern void *tcap_talloc_asn1_ctx;\n#define\tCALLOC/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/calloc(nmemb, size)/talloc_zero_size(tcap_talloc_asn1_ctx, (nmemb) * (size))/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/malloc(size)/talloc_size(tcap_talloc_asn1_ctx, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/realloc(oldptr, size)/talloc_realloc_size(tcap_talloc_asn1_ctx, oldptr, size)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h + sed -i "s/free(ptr)/talloc_free(ptr)/g" $(top_srcdir)/include/osmocom/tcap/asn_internal.h # Move skeleton *.c files to src/skel rm -rf $(top_srcdir)/src/skel mkdir $(top_srcdir)/src/skel diff --git a/src/tcap.c b/src/tcap.c index 68c7d9c..f5303ac 100644 --- a/src/tcap.c +++ b/src/tcap.c @@ -26,6 +26,8 @@ #include <osmocom/tcap/asn_codecs.h> #include <osmocom/tcap/TCAP_TCMessage.h> +void *tcap_talloc_asn1_ctx; + int osmo_asn1_tcap_decode(struct TCAP_TCMessage *tcapmsg, const uint8_t *data, size_t data_len) { diff --git a/tests/parse/Makefile.am b/tests/parse/Makefile.am index 821865d..1a449fe 100644 --- a/tests/parse/Makefile.am +++ b/tests/parse/Makefile.am @@ -1,8 +1,8 @@ AM_CPPFLAGS = $(all_includes) -I$(top_srcdir)/include -I$(top_srcdir)/src -AM_CFLAGS = -Wall +AM_CFLAGS = -Wall $(TALLOC_CFLAGS) AM_LDFLAGS = -no-install -LDADD = $(top_builddir)/src/.libs/libosmo-asn1-tcap.a +LDADD = $(top_builddir)/src/.libs/libosmo-asn1-tcap.a $(TALLOC_LIBS) check_PROGRAMS = \ tcap_parse_test \ -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-asn1-tcap[master]: tests: Use mem alloc macro instead of direct calloc() call
by pespin 02 Mar '26

02 Mar '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42218?usp=email ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: tests: Use mem alloc macro instead of direct calloc() call ...................................................................... tests: Use mem alloc macro instead of direct calloc() call This way we make sure the proper function to alloc is called. Change-Id: Ia9c7cf1f958f273dd7a5e23cf7633e45fa9d577f --- M tests/parse/tcap_parse_test.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/tests/parse/tcap_parse_test.c b/tests/parse/tcap_parse_test.c index 6a52cea..0f44963 100644 --- a/tests/parse/tcap_parse_test.c +++ b/tests/parse/tcap_parse_test.c @@ -30,7 +30,7 @@ { asn_dec_rval_t rc; struct TCAP_TCMessage *tcapmsg; - tcapmsg = calloc(1, sizeof(*tcapmsg)); + tcapmsg = CALLOC(1, sizeof(*tcapmsg)); printf("Basic TCAP decode testing.\n"); -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42218?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: Ia9c7cf1f958f273dd7a5e23cf7633e45fa9d577f Gerrit-Change-Number: 42218 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-asn1-tcap[master]: Use talloc to allocate asn1c decoded structs
by pespin 02 Mar '26

02 Mar '26

Attention is currently required from: daniel, lynxis lazus, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email ) Change subject: Use talloc to allocate asn1c decoded structs ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-asn1-tcap/+/42219?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-asn1-tcap Gerrit-Branch: master Gerrit-Change-Id: I6d885527caa5b60011b4fac341b93026ab1833d9 Gerrit-Change-Number: 42219 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 02 Mar 2026 10:36:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ccid-firmware[master]: clang-format: set ColumnLimit: 0
by osmith 02 Mar '26

02 Mar '26

osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email ) Change subject: clang-format: set ColumnLimit: 0 ...................................................................... clang-format: set ColumnLimit: 0 While our coding style says "we accept line lengths of up to 120 characters", in practice we oftentimes end up preferring longer lines (e.g. due to having comments at the end, or to keep them consistent with similar but shorter lines). The checkpatch config has already been adjusted to just ignore the line length completely. Adjust the clang-format config to do the same. Related: osmo-ci I88fd86ac550fddb3017aeceb647c3d9e75367372 Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 --- M .clang-format 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/.clang-format b/.clang-format index 4de65a5..e1b8d44 100644 --- a/.clang-format +++ b/.clang-format @@ -52,7 +52,7 @@ #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0 BreakAfterJavaFieldAnnotations: false BreakStringLiterals: false -ColumnLimit: 120 +ColumnLimit: 0 CommentPragmas: '^ IWYU pragma:' #CompactNamespaces: false # Unknown to clang-format-4.0 ConstructorInitializerAllOnOneLineOrOnePerLine: false -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 Gerrit-Change-Number: 42227 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ccid-firmware[master]: clang-format: set ColumnLimit: 0
by fixeria 02 Mar '26

02 Mar '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email ) Change subject: clang-format: set ColumnLimit: 0 ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42227?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ccid-firmware Gerrit-Branch: master Gerrit-Change-Id: I1f0d511d90a0725f195e08dd6a99eb3d55bd6fc1 Gerrit-Change-Number: 42227 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Mar 2026 07:56:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log March 2026