laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-cbc/+/42034?usp=email )
Change subject: Fix typos
......................................................................
Fix typos
Change-Id: I107154f0cc7c240ea143397a5f7b655cc48ee9b8
---
M README.md
M doc/manuals/chapters/cbc-apitool.adoc
M doc/manuals/chapters/configuration.adoc
M src/cbc_data.c
M src/cbc_main.c
M src/cbc_message.c
M src/cbc_peer.c
M src/cbc_vty.c
M src/cbsp_link.c
M src/cbsp_msg.c
M src/cbsp_smscb_peer_fsm.c
M src/charset.c
M src/rest_api.c
M src/rest_it_op.c
M src/sbcap_link.c
M src/sbcap_msg.c
16 files changed, 19 insertions(+), 19 deletions(-)
Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/README.md b/README.md
index 04d35f3..0904c2f 100644
--- a/README.md
+++ b/README.md
@@ -72,7 +72,7 @@
Generating asn1c code
---------------------
-Upstream master as1nc from [vlm](https://github.com/vlm/asn1c) [doesn't support
+Upstream master asn1c from [vlm](https://github.com/vlm/asn1c) [doesn't support
APER encoding](https://github.com/vlm/asn1c/issues/452). Nevertheless, the
upstream fork maintained by a big contributor
[mouse07410](https://github.com/mouse07410/asn1c) does support it, and it is
@@ -85,11 +85,11 @@
commit hash 08b293e8aa342d465d26805d1d66f3595b2ce261.
Then, do the usual `autoreconf -fi && ./configure`, using a buildir != srcdir
-(important, in order to avoid ending up with tempotary files in srcdir and
+(important, in order to avoid ending up with temporary files in srcdir and
making it difficult to stash the relevant changes).
Finally, run `make -C src/ regen`, which will regenerate the files and copy over
-the skeletons, with git possibily showing changes in the following paths:
+the skeletons, with git possibly showing changes in the following paths:
- include/osmocom/sbcap/
- src/sbcap/gen/
- src/sbcap/skel/
diff --git a/doc/manuals/chapters/cbc-apitool.adoc b/doc/manuals/chapters/cbc-apitool.adoc
index fc435a6..dd8f4d9 100644
--- a/doc/manuals/chapters/cbc-apitool.adoc
+++ b/doc/manuals/chapters/cbc-apitool.adoc
@@ -5,7 +5,7 @@
to demonstrate the use of the ECBE REST interface (<<ecbe>>) from the
command line.
-It uses the python3 standard librariy `requests` in order to issue ECBE
+It uses the python3 standard library `requests` in order to issue ECBE
API request over HTTP towards osmo-cbc.
`cbc-apitool.py` has a couple of sub-commands, each of which offer
diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc
index 98cf4d1..78e0424 100644
--- a/doc/manuals/chapters/configuration.adoc
+++ b/doc/manuals/chapters/configuration.adoc
@@ -87,7 +87,7 @@
The default port number for the SBc-AP server is 29168, according to the SBc-AP
specification. It uses SCTP payload protocol identifier 24.
-In order to make use of SCTP muti-homing capabilitites, simply configure several
+In order to make use of SCTP multi-homing capabilities, simply configure several
IP addresses when configuring SBc-AP.
.Example: Configure SCTP server mode and allow arbitrary MMEs to connect
diff --git a/src/cbc_data.c b/src/cbc_data.c
index 16efc88..a8b86f3 100644
--- a/src/cbc_data.c
+++ b/src/cbc_data.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>
* All Rights Reserved
diff --git a/src/cbc_main.c b/src/cbc_main.c
index 09dbaed..561f0cd 100644
--- a/src/cbc_main.c
+++ b/src/cbc_main.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019-2021 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/cbc_message.c b/src/cbc_message.c
index f17ab75..463061b 100644
--- a/src/cbc_message.c
+++ b/src/cbc_message.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
@@ -45,7 +45,7 @@
switch (cbcmsg->scope) {
case CBC_MSG_SCOPE_PLMN:
return true;
- /* FIXME: differnt scopes */
+ /* FIXME: different scopes */
default:
OSMO_ASSERT(0);
}
diff --git a/src/cbc_peer.c b/src/cbc_peer.c
index a277204..a3e4537 100644
--- a/src/cbc_peer.c
+++ b/src/cbc_peer.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/cbc_vty.c b/src/cbc_vty.c
index 0ac9268..6152ab3 100644
--- a/src/cbc_vty.c
+++ b/src/cbc_vty.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019-2021 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/cbsp_link.c b/src/cbsp_link.c
index 6b355df..df29e56 100644
--- a/src/cbsp_link.c
+++ b/src/cbsp_link.c
@@ -375,7 +375,7 @@
osmo_fsm_inst_dispatch(link->fi, CBSP_LINK_E_CMD_CLOSE, NULL);
} else {
osmo_stream_srv_destroy(link->srv_conn);
- /* Same as waht's done for cli is done for srv in closed_cb() */
+ /* Same as what's done for cli is done for srv in closed_cb() */
}
}
diff --git a/src/cbsp_msg.c b/src/cbsp_msg.c
index de8d852..7008ce9 100644
--- a/src/cbsp_msg.c
+++ b/src/cbsp_msg.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/cbsp_smscb_peer_fsm.c b/src/cbsp_smscb_peer_fsm.c
index 001b822..90d0561 100644
--- a/src/cbsp_smscb_peer_fsm.c
+++ b/src/cbsp_smscb_peer_fsm.c
@@ -134,7 +134,7 @@
break;
case CBC_CELL_ID_CGI:
u->global = cci->u.cgi;
- printf("u->gobal: %s\n", osmo_hexdump((uint8_t *) &u->global, sizeof(u->global)));
+ printf("u->global: %s\n", osmo_hexdump((uint8_t *) &u->global, sizeof(u->global)));
break;
case CBC_CELL_ID_LAC_CI:
u->lac_and_ci = cci->u.lac_and_ci;
diff --git a/src/charset.c b/src/charset.c
index 2ca4aa3..14d9d40 100644
--- a/src/charset.c
+++ b/src/charset.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/rest_api.c b/src/rest_api.c
index 6834dca..4d78cc7 100644
--- a/src/rest_api.c
+++ b/src/rest_api.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019-2021 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/rest_it_op.c b/src/rest_it_op.c
index 1110a3a..46d77d2 100644
--- a/src/rest_it_op.c
+++ b/src/rest_it_op.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/sbcap_link.c b/src/sbcap_link.c
index f8d8a09..04df0e4 100644
--- a/src/sbcap_link.c
+++ b/src/sbcap_link.c
@@ -439,7 +439,7 @@
osmo_fsm_inst_dispatch(link->fi, SBcAP_LINK_E_CMD_CLOSE, NULL);
} else {
osmo_stream_srv_destroy(link->srv_conn);
- /* Same as waht's done for cli is done for srv in closed_cb() */
+ /* Same as what's done for cli is done for srv in closed_cb() */
}
}
diff --git a/src/sbcap_msg.c b/src/sbcap_msg.c
index f9fa70a..64ba8b3 100644
--- a/src/sbcap_msg.c
+++ b/src/sbcap_msg.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>
* All Rights Reserved
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/42034?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I107154f0cc7c240ea143397a5f7b655cc48ee9b8
Gerrit-Change-Number: 42034
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1008(a)gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42048?usp=email )
Change subject: vty: Allow configuring xua server in ASP mode
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42048?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I9b07d2c96404b7b86c51fd9c7bab5e52a2343ade
Gerrit-Change-Number: 42048
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 13:50:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42047?usp=email )
Change subject: vty: Allow configuring xua timers in ASP mode
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42047?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I3801d10175f42c13e6f7994e1e4da8e7c99e8e16
Gerrit-Change-Number: 42047
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 13:50:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42044?usp=email )
Change subject: cosmetic: xua_rkm: Improve description of adding ASP to AS
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42044?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I57c6a810e081b0968cf2dc24357214a4cebe533b
Gerrit-Change-Number: 42044
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 13:50:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42040?usp=email )
Change subject: cosmetic: Fix typo in comment
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42040?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: If5adb80baaae78cae7164e1f85c53195eafa6e3e
Gerrit-Change-Number: 42040
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 13:49:36 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes