February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: doc: fix default 'max-initial' value
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: Hoernchen, laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email ) Change subject: doc: fix default 'max-initial' value ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I don't know, hence why I'm asking to somebody else to review 😊 For the record, I found the commit changing the value from 23 dBm to 0 dBm: https://gerrit.osmocom.org/c/osmo-bts/+/2231 ``` commit bbe90fd6511c9a0abdb5f41d13c5ab0135b903f7 Author: Harald Welte <laforge(a)gnumonks.org> Date: Fri Mar 24 10:41:04 2017 +0100 sysmobts: Don't start with 0dBm TRX output power before ramping In case a system has a high-gain external PA (like a 40dB PA) connected externally, we cannot simply switch the transceiver to 0 dBm in trx_init() only to then start the ramping at much lower levels once the PHJ completes in trx_init_compl_cb(). The result would be a short 0 + 40 dBm spike followed by later ramping. We want to avoid that spike, particularly its associated inrush current, so let's bring up the board with smething very conservative like -50 dBm, and then ramp from there. Change-Id: I0ad91fce64f65e0213c9fcfde3390ace519055db Fixes: SYS#3259 ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 Gerrit-Change-Number: 42031 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 09:41:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_asp_fsm: Remove duplicated role field
by pespin 04 Feb '26

04 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42038?usp=email ) Change subject: xua_asp_fsm: Remove duplicated role field ...................................................................... xua_asp_fsm: Remove duplicated role field The role is actually taken from the asp object, and it's not expected to change during its lifetime, so there's no really a need to keep a copy of it. Simplify the code by using the asp role everywhere. Change-Id: Ia6de131ce50f07261736645fe5b2ed1ad39eb01b --- M src/ss7_asp.c M src/ss7_xua_srv.c M src/xua_asp_fsm.c M src/xua_asp_fsm.h 4 files changed, 19 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/38/42038/1 diff --git a/src/ss7_asp.c b/src/ss7_asp.c index 161e070..4ca1fb4 100644 --- a/src/ss7_asp.c +++ b/src/ss7_asp.c @@ -915,7 +915,7 @@ osmo_ss7_asp_remove_default_lm(asp); } - if ((rc = xua_asp_fsm_start(asp, asp->cfg.role, LOGL_DEBUG)) < 0) + if ((rc = xua_asp_fsm_start(asp, LOGL_DEBUG)) < 0) return rc; OSMO_ASSERT(asp->fi); diff --git a/src/ss7_xua_srv.c b/src/ss7_xua_srv.c index 85906b7..deb1808 100644 --- a/src/ss7_xua_srv.c +++ b/src/ss7_xua_srv.c @@ -178,7 +178,7 @@ oxs->cfg.local.host_cnt); ss7_asp_peer_set_hosts(&asp->cfg.remote, asp, &hostbuf_ptr, 1); - if ((rc = xua_asp_fsm_start(asp, asp->cfg.role, LOGL_DEBUG)) < 0) { + if ((rc = xua_asp_fsm_start(asp, LOGL_DEBUG)) < 0) { talloc_free(sock_name); osmo_ss7_asp_destroy(asp); return rc; diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index f70e313..580a298 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -86,8 +86,6 @@ struct xua_asp_fsm_priv { /* pointer back to ASP to which we belong */ struct osmo_ss7_asp *asp; - /* Role (ASP/SG/IPSP) */ - enum osmo_ss7_asp_role role; /* routing context[s]: list of 32bit integers */ /* ACTIVE: traffic mode type, tid label, drn label ? */ @@ -515,12 +513,13 @@ #define ENSURE_ASP_OR_IPSP(fi, event) \ do { \ struct xua_asp_fsm_priv *_xafp = fi->priv; \ - if (_xafp->role != OSMO_SS7_ASP_ROLE_ASP && \ - _xafp->role != OSMO_SS7_ASP_ROLE_IPSP) { \ + enum osmo_ss7_asp_role _role = _xafp->asp->cfg.role; \ + if (_role != OSMO_SS7_ASP_ROLE_ASP && \ + _role != OSMO_SS7_ASP_ROLE_IPSP) { \ LOGPFSML(fi, LOGL_ERROR, "event %s not permitted " \ "in role %s\n", \ osmo_fsm_event_name(fi->fsm, event), \ - get_value_string(osmo_ss7_asp_role_names, _xafp->role));\ + get_value_string(osmo_ss7_asp_role_names, _role));\ return; \ } \ } while(0) @@ -528,12 +527,13 @@ #define ENSURE_SG_OR_IPSP(fi, event) \ do { \ struct xua_asp_fsm_priv *_xafp = fi->priv; \ - if (_xafp->role != OSMO_SS7_ASP_ROLE_SG && \ - _xafp->role != OSMO_SS7_ASP_ROLE_IPSP) { \ + enum osmo_ss7_asp_role _role = _xafp->asp->cfg.role; \ + if (_role != OSMO_SS7_ASP_ROLE_SG && \ + _role != OSMO_SS7_ASP_ROLE_IPSP) { \ LOGPFSML(fi, LOGL_ERROR, "event %s not permitted " \ "in role %s\n", \ osmo_fsm_event_name(fi->fsm, event), \ - get_value_string(osmo_ss7_asp_role_names, _xafp->role));\ + get_value_string(osmo_ss7_asp_role_names, _role));\ return; \ } \ } while(0) @@ -959,22 +959,19 @@ .cleanup = xua_asp_fsm_cleanup, }; -static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp, - enum osmo_ss7_asp_role role, int log_level); +static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp, int log_level); /*! \brief Start a new ASP finite state machine for given ASP (stored in asp->fi) * \param[in] asp Application Server Process for which to start FSM - * \param[in] role Role (ASP, SG, IPSP) of this FSM * \param[in] log_level Logging Level for ASP FSM logging * \returns 0 on success; negative on error */ -int xua_asp_fsm_start(struct osmo_ss7_asp *asp, - enum osmo_ss7_asp_role role, int log_level) +int xua_asp_fsm_start(struct osmo_ss7_asp *asp, int log_level) { struct osmo_fsm_inst *fi; struct xua_asp_fsm_priv *xafp; if (asp->cfg.proto == OSMO_SS7_ASP_PROT_IPA) - return ipa_asp_fsm_start(asp, role, log_level); + return ipa_asp_fsm_start(asp, log_level); /* allocate as child of AS? */ fi = osmo_fsm_inst_alloc(&xua_asp_fsm, asp, NULL, log_level, asp->cfg.name); @@ -986,7 +983,6 @@ osmo_fsm_inst_term(fi, OSMO_FSM_TERM_ERROR, NULL); return -ENOMEM; } - xafp->role = role; xafp->asp = asp; osmo_timer_setup(&xafp->t_beat.timer, xua_t_beat_cb, fi); @@ -1026,8 +1022,6 @@ struct ipa_asp_fsm_priv { /* pointer back to ASP to which we belong */ struct osmo_ss7_asp *asp; - /* Role (ASP/SG/IPSP) */ - enum osmo_ss7_asp_role role; /* Structure holding parsed data of the IPA CCM ID exchange */ struct ipaccess_unit *ipa_unit; @@ -1146,7 +1140,7 @@ switch (event) { case XUA_ASP_E_M_ASP_UP_REQ: case XUA_ASP_E_SCTP_EST_IND: - if (iafp->role == OSMO_SS7_ASP_ROLE_SG) { + if (iafp->asp->cfg.role == OSMO_SS7_ASP_ROLE_SG) { /* Server: Transmit IPA ID GET + Wait for Response */ if (fd >= 0) { ipa_ccm_send_id_req(fd); @@ -1407,7 +1401,7 @@ * It will be applied to PDUs received from the IPA socket. */ _ipa_asp_pick_unused_sls(iafp->asp, as); /* Now that the AS is known, start the client side: */ - if (iafp->role == OSMO_SS7_ASP_ROLE_ASP && fi->state == IPA_ASP_S_DOWN) { + if (iafp->asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP && fi->state == IPA_ASP_S_DOWN) { LOGPFSML(fi, LOGL_NOTICE, "Bringing up ASP now once it has been assigned to an AS\n"); osmo_fsm_inst_dispatch(fi, XUA_ASP_E_M_ASP_UP_REQ, NULL); } @@ -1522,11 +1516,9 @@ /*! \brief Start a new ASP finite state machine for given ASP (stored on asp->fi) * \param[in] asp Application Server Process for which to start FSM - * \param[in] role Role (ASP, SG, IPSP) of this FSM * \param[in] log_level Logging Level for ASP FSM logging * \returns 0 on success; negative on error */ -static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp, - enum osmo_ss7_asp_role role, int log_level) +static int ipa_asp_fsm_start(struct osmo_ss7_asp *asp, int log_level) { struct osmo_fsm_inst *fi; struct ipa_asp_fsm_priv *iafp; @@ -1557,7 +1549,7 @@ } else { /* ASP in client mode will be brought up when this ASP is added * to an AS, see XUA_ASP_E_AS_ASSIGNED. */ - if (role == OSMO_SS7_ASP_ROLE_ASP) { + if (asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP) { LOGPFSML(fi, LOGL_NOTICE, "ASP is not assigned to any AS. ASP bring up delayed\n"); can_start = false; } @@ -1565,7 +1557,6 @@ /* asp->ipa.sls will be assigned together with AS unit_name during XUA_ASP_E_AS_ASSIGNED. */ } - iafp->role = role; iafp->asp = asp; iafp->ipa_unit = talloc_zero(iafp, struct ipaccess_unit); iafp->ipa_unit->unit_name = talloc_strdup(iafp->ipa_unit, unit_name); @@ -1576,7 +1567,7 @@ /* Attach FSM to ASP: */ asp->fi = fi; - if (can_start && role == OSMO_SS7_ASP_ROLE_ASP) + if (can_start && asp->cfg.role == OSMO_SS7_ASP_ROLE_ASP) osmo_fsm_inst_dispatch(fi, XUA_ASP_E_M_ASP_UP_REQ, NULL); return 0; diff --git a/src/xua_asp_fsm.h b/src/xua_asp_fsm.h index ab19e36..61a43a1 100644 --- a/src/xua_asp_fsm.h +++ b/src/xua_asp_fsm.h @@ -42,5 +42,4 @@ extern struct osmo_fsm xua_asp_fsm; extern struct osmo_fsm ipa_asp_fsm; -int xua_asp_fsm_start(struct osmo_ss7_asp *asp, - enum osmo_ss7_asp_role role, int log_level); +int xua_asp_fsm_start(struct osmo_ss7_asp *asp, int log_level); -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42038?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ia6de131ce50f07261736645fe5b2ed1ad39eb01b Gerrit-Change-Number: 42038 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: doc: fix default 'max-initial' value
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: Hoernchen, fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email ) Change subject: doc: fix default 'max-initial' value ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Why should it be 23 dBm in the first place? 0 dB looks like a reasonable default. […] I don't know, hence why I'm asking to somebody else to review 😊 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 Gerrit-Change-Number: 42031 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 08:13:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: doc: fix default 'max-initial' value
by fixeria 04 Feb '26

04 Feb '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email ) Change subject: doc: fix default 'max-initial' value ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @laforge@gnumonks. […] Why should it be 23 dBm in the first place? 0 dB looks like a reasonable default. 23 dBm is ~200 mW, which is the maximum Tx power of USRP B2xx. This is also the default assumed Tx power of osmo-bts-trx before the actual value is known. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 Gerrit-Change-Number: 42031 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 08:12:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-cbc[master]: smscb_peer_fsm: Replace printf with debug log
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: matanp. pespin has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-cbc/+/42036?usp=email ) Change subject: smscb_peer_fsm: Replace printf with debug log ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/42036?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I026da3797a025d79f500f742e97139fbc5bbbcad Gerrit-Change-Number: 42036 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Feb 2026 08:09:10 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-cbc[master]: sbcap: Remove duplicated cli connection destroy
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: matanp. pespin has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-cbc/+/42035?usp=email ) Change subject: sbcap: Remove duplicated cli connection destroy ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/42035?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I8809738955fb90e546b2adb8bb0722b15f464d26 Gerrit-Change-Number: 42035 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Feb 2026 08:08:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-cbc[master]: Fix typos
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: matanp. pespin has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-cbc/+/42034?usp=email ) Change subject: Fix typos ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/42034?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I107154f0cc7c240ea143397a5f7b655cc48ee9b8 Gerrit-Change-Number: 42034 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Feb 2026 08:08:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: osmo-bts-trx: add missing \n to a logging message
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42032?usp=email ) Change subject: osmo-bts-trx: add missing \n to a logging message ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42032?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5b3091b5ed96e28ae056272398c5eddbdef4b8b5 Gerrit-Change-Number: 42032 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 07:47:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bts[master]: doc: fix default 'max-initial' value
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email ) Change subject: doc: fix default 'max-initial' value ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: @laforge@gnumonks.org do we want to keep the default as 0 or should the code fixed to be 23? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006 Gerrit-Change-Number: 42031 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 04 Feb 2026 07:47:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[M] Change in libosmocore[master]: Add Emscripten build support and JS callback logging backend
by pespin 04 Feb '26

04 Feb '26

Attention is currently required from: Timur Davydov, fixeria, laforge, neels, osmith. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email ) Change subject: Add Emscripten build support and JS callback logging backend ...................................................................... Patch Set 26: (2 comments) File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/05b17747_9b375ccc?… : PS25, Line 47: char subsys_buf[16]; > This is kept at 16 bytes for consistency with `logging_gsmtap.c` […] That's due to "struct gsmtap_osmocore_log_hdr" being "char subsys[16]" because it's sent as fixed size over the wire. It may make sense to look at emscripten.h or on_log_wrapper() API doc to see if there's another limitation in your case. In practice 16 is fine, just mentioning in case you want to look at it. In any case, we tend to better use C style comments "/\* \*/" in osmocom code. File src/core/logging_emscripten.c: https://gerrit.osmocom.org/c/libosmocore/+/41813/comment/ccc0bb60_bf465a68?… : PS26, Line 45: const int msgLen = MAX_LOG_SIZE; Simply drop the variable and use MAX_LOG_SIZE directly, otherwise you are simply duplicating stuff and making code more complex for no good reason. char msg[MAX_LOG_SIZE]; rc = vsnprintf(msg, sizeof(msg), format, ap); if (rc <= 0) return; if (rc >= sizeof(msg)) rc = sizeof(msg) - 1; /* Drop newline at the end if exists: */ if (msg[rc - 1] == '\n') msg[rc - 1] = '\0'; -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41813?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia8d5f4bb6570b5e055826f3a051e5e5896866e31 Gerrit-Change-Number: 41813 Gerrit-PatchSet: 26 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Wed, 04 Feb 2026 07:45:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: Timur Davydov <dtv.comp(a)gmail.com>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026