Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email )
Change subject: bts: f_verify_ramp_up(): fix RxLev / dBm mixup
......................................................................
Patch Set 2:
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022/comment/28830f85_b700… :
PS2, Line 2804: Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
> Next time you review my patches please don't tell me to avoid changing the formatting of these ;)
Just to be clear, adding dBm units makes the strings even longer. I could have kept these clumsy `log2str()` constructs, but editing and reading them gets even harder as the amount of arguments grows. Hence I changed to `setverdict(fail, ...)`.
But since this is mostly your code, I can revert back to using `log2str()` if you prefer.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I818d18d6e0711247b73ee1f336133e2ed3f6e2cb
Gerrit-Change-Number: 42022
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 07:44:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email )
Change subject: bts: f_verify_ramp_up(): fix RxLev / dBm mixup
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File bts/BTS_Tests.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022/comment/d07e83ae_5516… :
PS2, Line 2804: Misc_Helpers.f_shutdown(__BFILE__, __LINE__);
Next time you review my patches please don't tell me to avoid changing the formatting of these ;)
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42022?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I818d18d6e0711247b73ee1f336133e2ed3f6e2cb
Gerrit-Change-Number: 42022
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 07:29:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42020?usp=email )
Change subject: bts: f_TC_acch_overpower(): use f_wait_ramp_up()
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42020?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Id9b8bfc70cb26508e12ccd2b142bb458a3912c09
Gerrit-Change-Number: 42020
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 07:25:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42037?usp=email )
Change subject: bts: limit stderr logging to ERROR to avoid long write() to ext4 fs
......................................................................
bts: limit stderr logging to ERROR to avoid long write() to ext4 fs
Commit c3ab9ec33f37c6837fb8bcb0fa0bbd2e98781fb7 already decreased
verbosity to NOTICE, but that's not enough since we still get plenty of
logging and hence plenty of long write()s during test execution.
Let's try decreasing to ERROR and see if that's enough for now to
stabilize the tests.
Change-Id: I41982fd83a9f46609464afb6b7242240063d4d91
---
M bts/osmo-bts.cfg
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/37/42037/1
diff --git a/bts/osmo-bts.cfg b/bts/osmo-bts.cfg
index 7ac38a1..b2f5190 100644
--- a/bts/osmo-bts.cfg
+++ b/bts/osmo-bts.cfg
@@ -16,7 +16,7 @@
logging print category-hex 0
logging print level 1
!
- logging level set-all notice
+ logging level set-all error
!Disabled due to stderr redirect to ext4 filesystem creating long writes of >500ms (OS#6794):
!logging level rsl info
!logging level meas info
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42037?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I41982fd83a9f46609464afb6b7242240063d4d91
Gerrit-Change-Number: 42037
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
matanp has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-cbc/+/42034?usp=email )
Change subject: Fix typos
......................................................................
Fix typos
Change-Id: I107154f0cc7c240ea143397a5f7b655cc48ee9b8
---
M README.md
M doc/manuals/chapters/cbc-apitool.adoc
M doc/manuals/chapters/configuration.adoc
M src/cbc_data.c
M src/cbc_main.c
M src/cbc_message.c
M src/cbc_peer.c
M src/cbc_vty.c
M src/cbsp_link.c
M src/cbsp_msg.c
M src/cbsp_smscb_peer_fsm.c
M src/charset.c
M src/rest_api.c
M src/rest_it_op.c
M src/sbcap_link.c
M src/sbcap_msg.c
16 files changed, 19 insertions(+), 19 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-cbc refs/changes/34/42034/1
diff --git a/README.md b/README.md
index 04d35f3..0904c2f 100644
--- a/README.md
+++ b/README.md
@@ -72,7 +72,7 @@
Generating asn1c code
---------------------
-Upstream master as1nc from [vlm](https://github.com/vlm/asn1c) [doesn't support
+Upstream master asn1c from [vlm](https://github.com/vlm/asn1c) [doesn't support
APER encoding](https://github.com/vlm/asn1c/issues/452). Nevertheless, the
upstream fork maintained by a big contributor
[mouse07410](https://github.com/mouse07410/asn1c) does support it, and it is
@@ -85,11 +85,11 @@
commit hash 08b293e8aa342d465d26805d1d66f3595b2ce261.
Then, do the usual `autoreconf -fi && ./configure`, using a buildir != srcdir
-(important, in order to avoid ending up with tempotary files in srcdir and
+(important, in order to avoid ending up with temporary files in srcdir and
making it difficult to stash the relevant changes).
Finally, run `make -C src/ regen`, which will regenerate the files and copy over
-the skeletons, with git possibily showing changes in the following paths:
+the skeletons, with git possibly showing changes in the following paths:
- include/osmocom/sbcap/
- src/sbcap/gen/
- src/sbcap/skel/
diff --git a/doc/manuals/chapters/cbc-apitool.adoc b/doc/manuals/chapters/cbc-apitool.adoc
index fc435a6..dd8f4d9 100644
--- a/doc/manuals/chapters/cbc-apitool.adoc
+++ b/doc/manuals/chapters/cbc-apitool.adoc
@@ -5,7 +5,7 @@
to demonstrate the use of the ECBE REST interface (<<ecbe>>) from the
command line.
-It uses the python3 standard librariy `requests` in order to issue ECBE
+It uses the python3 standard library `requests` in order to issue ECBE
API request over HTTP towards osmo-cbc.
`cbc-apitool.py` has a couple of sub-commands, each of which offer
diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc
index 98cf4d1..78e0424 100644
--- a/doc/manuals/chapters/configuration.adoc
+++ b/doc/manuals/chapters/configuration.adoc
@@ -87,7 +87,7 @@
The default port number for the SBc-AP server is 29168, according to the SBc-AP
specification. It uses SCTP payload protocol identifier 24.
-In order to make use of SCTP muti-homing capabilitites, simply configure several
+In order to make use of SCTP multi-homing capabilities, simply configure several
IP addresses when configuring SBc-AP.
.Example: Configure SCTP server mode and allow arbitrary MMEs to connect
diff --git a/src/cbc_data.c b/src/cbc_data.c
index 16efc88..a8b86f3 100644
--- a/src/cbc_data.c
+++ b/src/cbc_data.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>
* All Rights Reserved
diff --git a/src/cbc_main.c b/src/cbc_main.c
index 09dbaed..561f0cd 100644
--- a/src/cbc_main.c
+++ b/src/cbc_main.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019-2021 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/cbc_message.c b/src/cbc_message.c
index f17ab75..463061b 100644
--- a/src/cbc_message.c
+++ b/src/cbc_message.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
@@ -45,7 +45,7 @@
switch (cbcmsg->scope) {
case CBC_MSG_SCOPE_PLMN:
return true;
- /* FIXME: differnt scopes */
+ /* FIXME: different scopes */
default:
OSMO_ASSERT(0);
}
diff --git a/src/cbc_peer.c b/src/cbc_peer.c
index a277204..a3e4537 100644
--- a/src/cbc_peer.c
+++ b/src/cbc_peer.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/cbc_vty.c b/src/cbc_vty.c
index 0ac9268..6152ab3 100644
--- a/src/cbc_vty.c
+++ b/src/cbc_vty.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019-2021 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/cbsp_link.c b/src/cbsp_link.c
index 6b355df..df29e56 100644
--- a/src/cbsp_link.c
+++ b/src/cbsp_link.c
@@ -375,7 +375,7 @@
osmo_fsm_inst_dispatch(link->fi, CBSP_LINK_E_CMD_CLOSE, NULL);
} else {
osmo_stream_srv_destroy(link->srv_conn);
- /* Same as waht's done for cli is done for srv in closed_cb() */
+ /* Same as what's done for cli is done for srv in closed_cb() */
}
}
diff --git a/src/cbsp_msg.c b/src/cbsp_msg.c
index de8d852..7008ce9 100644
--- a/src/cbsp_msg.c
+++ b/src/cbsp_msg.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/cbsp_smscb_peer_fsm.c b/src/cbsp_smscb_peer_fsm.c
index 001b822..90d0561 100644
--- a/src/cbsp_smscb_peer_fsm.c
+++ b/src/cbsp_smscb_peer_fsm.c
@@ -134,7 +134,7 @@
break;
case CBC_CELL_ID_CGI:
u->global = cci->u.cgi;
- printf("u->gobal: %s\n", osmo_hexdump((uint8_t *) &u->global, sizeof(u->global)));
+ printf("u->global: %s\n", osmo_hexdump((uint8_t *) &u->global, sizeof(u->global)));
break;
case CBC_CELL_ID_LAC_CI:
u->lac_and_ci = cci->u.lac_and_ci;
diff --git a/src/charset.c b/src/charset.c
index 2ca4aa3..14d9d40 100644
--- a/src/charset.c
+++ b/src/charset.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/rest_api.c b/src/rest_api.c
index 6834dca..4d78cc7 100644
--- a/src/rest_api.c
+++ b/src/rest_api.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019-2021 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/rest_it_op.c b/src/rest_it_op.c
index 1110a3a..46d77d2 100644
--- a/src/rest_it_op.c
+++ b/src/rest_it_op.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2019 by Harald Welte <laforge(a)gnumonks.org>
* All Rights Reserved
diff --git a/src/sbcap_link.c b/src/sbcap_link.c
index f8d8a09..04df0e4 100644
--- a/src/sbcap_link.c
+++ b/src/sbcap_link.c
@@ -439,7 +439,7 @@
osmo_fsm_inst_dispatch(link->fi, SBcAP_LINK_E_CMD_CLOSE, NULL);
} else {
osmo_stream_srv_destroy(link->srv_conn);
- /* Same as waht's done for cli is done for srv in closed_cb() */
+ /* Same as what's done for cli is done for srv in closed_cb() */
}
}
diff --git a/src/sbcap_msg.c b/src/sbcap_msg.c
index f9fa70a..64ba8b3 100644
--- a/src/sbcap_msg.c
+++ b/src/sbcap_msg.c
@@ -1,4 +1,4 @@
-/* Osmocom CBC (Cell Broacast Centre) */
+/* Osmocom CBC (Cell Broadcast Centre) */
/* (C) 2022 by sysmocom - s.f.m.c. GmbH <info(a)sysmocom.de>
* All Rights Reserved
--
To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/42034?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-cbc
Gerrit-Branch: master
Gerrit-Change-Id: I107154f0cc7c240ea143397a5f7b655cc48ee9b8
Gerrit-Change-Number: 42034
Gerrit-PatchSet: 1
Gerrit-Owner: matanp <matan1008(a)gmail.com>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email )
Change subject: osmo-bts-trx: apply 'max-initial' value before POWERON
......................................................................
osmo-bts-trx: apply 'max-initial' value before POWERON
Not applying this value before powering the transceiver on results
in transmission at full Tx power for a certain amount of time before
the power ramping begins.
Change-Id: Iff03d4dcb74f67629a59c8d6f8bb60929d9f6ddd
Related: OS#6939
---
M src/osmo-bts-trx/l1_if.h
M src/osmo-bts-trx/trx_provision_fsm.c
2 files changed, 9 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/42033/1
diff --git a/src/osmo-bts-trx/l1_if.h b/src/osmo-bts-trx/l1_if.h
index 0180499..7ecd33e 100644
--- a/src/osmo-bts-trx/l1_if.h
+++ b/src/osmo-bts-trx/l1_if.h
@@ -97,6 +97,8 @@
bool nomtxpower_sent;
bool nomtxpower_acked;
+ bool setpower_sent;
+
bool maxdly_valid;
int maxdly;
bool maxdly_sent;
diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c
index 4aa0783..d0fe82a 100644
--- a/src/osmo-bts-trx/trx_provision_fsm.c
+++ b/src/osmo-bts-trx/trx_provision_fsm.c
@@ -130,6 +130,8 @@
l1h->config.nomtxpower_sent = false;
l1h->config.nomtxpower_acked = false;
+ l1h->config.setpower_sent = false;
+
l1h->config.maxdly_sent = false;
l1h->config.maxdlynb_sent = false;
@@ -173,6 +175,11 @@
l1h->config.txtune_sent = true;
l1h->config.txtune_acked = false;
}
+ if (!l1h->config.setpower_sent) {
+ int initial_mdBm = power_ramp_initial_power_mdBm(pinst->trx);
+ bts_model_change_power(pinst->trx, initial_mdBm);
+ l1h->config.setpower_sent = true;
+ }
if (l1h->config.txtune_acked) {
/* After TXTUNE is sent to TRX, get the tx nominal power
* (which may vary precisly on band/arfcn. Avoid sending
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42033?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Iff03d4dcb74f67629a59c8d6f8bb60929d9f6ddd
Gerrit-Change-Number: 42033
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42032?usp=email )
Change subject: osmo-bts-trx: add missing \n to a logging message
......................................................................
osmo-bts-trx: add missing \n to a logging message
Change-Id: I5b3091b5ed96e28ae056272398c5eddbdef4b8b5
---
M src/osmo-bts-trx/trx_provision_fsm.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/32/42032/1
diff --git a/src/osmo-bts-trx/trx_provision_fsm.c b/src/osmo-bts-trx/trx_provision_fsm.c
index 7ed617a..4aa0783 100644
--- a/src/osmo-bts-trx/trx_provision_fsm.c
+++ b/src/osmo-bts-trx/trx_provision_fsm.c
@@ -204,7 +204,7 @@
l1h->config.setformat_sent = true;
if (plink->u.osmotrx.trxd_pdu_ver_max == 0) {
LOGPPHI(pinst, DL1C, LOGL_INFO,
- "No need to negotiate max TRXD version 0");
+ "No need to negotiate max TRXD version 0\n");
l1h->config.trxd_pdu_ver_use = 0;
l1h->config.setformat_acked = true;
} else {
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42032?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I5b3091b5ed96e28ae056272398c5eddbdef4b8b5
Gerrit-Change-Number: 42032
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email )
Change subject: doc: fix default 'max-initial' value
......................................................................
doc: fix default 'max-initial' value
The default value is set in gsm_bts_trx_alloc() and it's actually 0.
Change-Id: I178e0664f6818d0eda15701b57bb030916b06006
---
M doc/manuals/chapters/configuration.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/31/42031/1
diff --git a/doc/manuals/chapters/configuration.adoc b/doc/manuals/chapters/configuration.adoc
index f6ca75e..ddaa113 100644
--- a/doc/manuals/chapters/configuration.adoc
+++ b/doc/manuals/chapters/configuration.adoc
@@ -197,7 +197,7 @@
configuration file.
De-activating power-ramping can be performed by setting the max-initial value
-to the nominal power. The default max-initial value is 23 dBm.
+to the nominal power. The default max-initial value is 0 dBm.
==== Running multiple instances
--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/42031?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I178e0664f6818d0eda15701b57bb030916b06006
Gerrit-Change-Number: 42031
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>