pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42044?usp=email )
Change subject: cosmetic: xua_rkm: Improve description of adding ASP to AS
......................................................................
cosmetic: xua_rkm: Improve description of adding ASP to AS
Change-Id: I57c6a810e081b0968cf2dc24357214a4cebe533b
---
M src/xua_rkm.c
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/src/xua_rkm.c b/src/xua_rkm.c
index cf4e508..038098f 100644
--- a/src/xua_rkm.c
+++ b/src/xua_rkm.c
@@ -308,7 +308,10 @@
}
}
- /* Success: Add just-create AS to connected ASP + report success */
+ /* Make sure ASP is associated to AS:
+ * - If AS was just created
+ * - If we just learned through RKM that this ASP is serving this AS (rctx)
+ */
if (ss7_as_add_asp(as, asp) < 0) {
LOGPASP(asp, DLSS7, LOGL_ERROR, "RKM: Cannot associate ASP to AS %s\n", as->cfg.name);
msgb_append_reg_res(resp, rk_id, M3UA_RKM_REG_ERR_INSUFF_RESRC, 0);
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42044?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I57c6a810e081b0968cf2dc24357214a4cebe533b
Gerrit-Change-Number: 42044
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42041?usp=email )
Change subject: tcap: Log vty msg in CS7_ROLE_SG
......................................................................
tcap: Log vty msg in CS7_ROLE_SG
This code was placed in the wrong section, since tcap features can only
be enabled in SG mode (STP).
Change-Id: I77cf19bdc8fa29dd4a28773ac0f954850cd76e1b
---
M src/ss7_as_vty.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
laforge: Looks good to me, but someone else must approve
Jenkins Builder: Verified
daniel: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
diff --git a/src/ss7_as_vty.c b/src/ss7_as_vty.c
index 2d919bb..80359aa 100644
--- a/src/ss7_as_vty.c
+++ b/src/ss7_as_vty.c
@@ -684,6 +684,7 @@
"'point-code override dpc PC' configured in its routing-key. Fix your config!%s",
as->cfg.name, VTY_NEWLINE);
}
+ } else {
#ifdef WITH_TCAP_LOADSHARING
if (as->cfg.loadshare.tcap.enabled && as->cfg.mode != OSMO_SS7_AS_TMOD_LOADSHARE)
vty_out(vty, "%% AS '%s' TCAP routing is enabled, but only works in traffic-mode loadshare!%s",
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42041?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I77cf19bdc8fa29dd4a28773ac0f954850cd76e1b
Gerrit-Change-Number: 42041
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Attention is currently required from: jolly, laforge.
Hello Jenkins Builder, jolly,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42049?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: fix wait time extension handling
......................................................................
fix wait time extension handling
wait time ext byte was mishandled as sw1 and sw2, which broke transfers that took a long time, i.e. crypto ops during esim interactions.
Closes: SYS#7869
Change-Id: I7527a4337ae857b9b2a4e982606fac770e677d73
---
M ccid_common/iso7816_fsm.c
1 file changed, 14 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/49/42049/4
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42049?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I7527a4337ae857b9b2a4e982606fac770e677d73
Gerrit-Change-Number: 42049
Gerrit-PatchSet: 4
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Attention is currently required from: Hoernchen, jolly.
Hello Jenkins Builder, jolly,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42049?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review+1 by jolly
Change subject: fix wait time extension handling
......................................................................
fix wait time extension handling
wait time ext byte was mishandled as sw1 and sw2, which broke transfers that took a long time, i.e. crypto ops during esim interactions.
Closes: SYS#7869
Change-Id: I7527a4337ae857b9b2a4e982606fac770e677d73
---
M ccid_common/iso7816_fsm.c
1 file changed, 26 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/49/42049/3
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42049?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I7527a4337ae857b9b2a4e982606fac770e677d73
Gerrit-Change-Number: 42049
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Attention: jolly <andreas(a)eversberg.eu>
Attention is currently required from: Hoernchen.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42049?usp=email
to look at the new patch set (#2).
Change subject: fix wait time extension handling
......................................................................
fix wait time extension handling
Closes: SYS#7869
Change-Id: I7527a4337ae857b9b2a4e982606fac770e677d73
---
M ccid_common/iso7816_fsm.c
1 file changed, 26 insertions(+), 14 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ccid-firmware refs/changes/49/42049/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/42049?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I7527a4337ae857b9b2a4e982606fac770e677d73
Gerrit-Change-Number: 42049
Gerrit-PatchSet: 2
Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <laforge(a)osmocom.org>
Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de>
Attention is currently required from: osmith.
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-dev/+/42016?usp=email )
Change subject: sanitize.opts: Add missing osmo-pcap project
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
I have no permissions to +2 and merge stuff in this project apparently.
--
To view, visit https://gerrit.osmocom.org/c/osmo-dev/+/42016?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-dev
Gerrit-Branch: master
Gerrit-Change-Id: I637215c325c28604c9e021dfac8d066238b9f38c
Gerrit-Change-Number: 42016
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 04 Feb 2026 14:19:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No