February 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-sigtran[master]: xua_asp_fsm: Remove obvious comments
by pespin 13 Feb '26

13 Feb '26

Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42116?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: xua_asp_fsm: Remove obvious comments ...................................................................... xua_asp_fsm: Remove obvious comments Those can already be interpretred directly by the ENSURE_* macros. No need to clog the file with more lines describing stuff. Change-Id: Idec06646c48fbce4cbe200e88f987dfb3e9d5a39 --- M src/xua_asp_fsm.c 1 file changed, 0 insertions(+), 18 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/16/42116/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42116?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Idec06646c48fbce4cbe200e88f987dfb3e9d5a39 Gerrit-Change-Number: 42116 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_default_lm_fsm: Submit RKM REG REQ for all AS in ASP
by pespin 13 Feb '26

13 Feb '26

Attention is currently required from: laforge. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42113?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: xua_default_lm_fsm: Submit RKM REG REQ for all AS in ASP ...................................................................... xua_default_lm_fsm: Submit RKM REG REQ for all AS in ASP So far only the first rctx (AS) was being registered. This fixes RKM for ASPs serving multiple AS in ASP/IPSP role. Relted: OS#6943 Change-Id: I932c1b05dfd37fd7b89adea0d1ea59a5dc6138b4 --- M src/xua_default_lm_fsm.c 1 file changed, 15 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/13/42113/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I932c1b05dfd37fd7b89adea0d1ea59a5dc6138b4 Gerrit-Change-Number: 42113 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org>

1 0

[M] Change in libosmo-sigtran[master]: Allow configuring local ASP Identifier
by pespin 13 Feb '26

13 Feb '26

Attention is currently required from: daniel, laforge. Hello Jenkins Builder, daniel, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by daniel, Verified+1 by Jenkins Builder Change subject: Allow configuring local ASP Identifier ...................................................................... Allow configuring local ASP Identifier If configured, it will be transmitted during ASP UP and ASP UP ACK. This may be needed if facing an SG/IPSP peer who requires ASP Identifier to be set. Related: OS#6953 Change-Id: Ib94d542f940e13d5c007bc3319e7dde65cf81f12 --- M src/ss7_asp.h M src/ss7_asp_vty.c M src/xua_asp_fsm.c M tests/vty/osmo_stp_test.vty M tests/vty/ss7_asp_test.vty 5 files changed, 55 insertions(+), 29 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/15/42115/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib94d542f940e13d5c007bc3319e7dde65cf81f12 Gerrit-Change-Number: 42115 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: cosmetic: xua_as_fsm: Fix mixed brace/no-brace blocks in if/else
by pespin 13 Feb '26

13 Feb '26

Attention is currently required from: pespin. Hello Jenkins Builder, daniel, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42118?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: cosmetic: xua_as_fsm: Fix mixed brace/no-brace blocks in if/else ...................................................................... cosmetic: xua_as_fsm: Fix mixed brace/no-brace blocks in if/else Change-Id: Ibfd818d354c09409b04b392853f544a220de3a72 --- M src/xua_as_fsm.c 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/18/42118/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42118?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ibfd818d354c09409b04b392853f544a220de3a72 Gerrit-Change-Number: 42118 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_asp_fsm: Validate remote ASP Id matching config in SG role
by pespin 13 Feb '26

13 Feb '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: xua_asp_fsm: Validate remote ASP Id matching config in SG role ...................................................................... xua_asp_fsm: Validate remote ASP Id matching config in SG role The node in SG role really doesn't have an ASP Id of its own (it is never sent over the wire). Hence, use the "asp-identifier <N>" VTY config in SG role to require the ASP to identify itself with a given ASP identifier. Related: OS#6953 Change-Id: I3e22439aa7e22f7a6113b093c44ace6745c808b9 --- M src/xua_asp_fsm.c 1 file changed, 27 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/19/42119/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42119?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I3e22439aa7e22f7a6113b093c44ace6745c808b9 Gerrit-Change-Number: 42119 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmo-sigtran[master]: xua_default_lm_fsm: Submit RKM REG REQ for all AS in ASP
by pespin 13 Feb '26

13 Feb '26

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42113?usp=email ) Change subject: xua_default_lm_fsm: Submit RKM REG REQ for all AS in ASP ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42113/comment/a85d03ac_7b86e… : PS1, Line 9: thre > the Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42113?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I932c1b05dfd37fd7b89adea0d1ea59a5dc6138b4 Gerrit-Change-Number: 42113 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Fri, 13 Feb 2026 08:50:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[M] Change in libosmo-sigtran[master]: Allow configuring local ASP Identifier
by pespin 13 Feb '26

13 Feb '26

Attention is currently required from: daniel, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115?usp=email ) Change subject: Allow configuring local ASP Identifier ...................................................................... Patch Set 1: (2 comments) File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115/comment/731f7364_bae3b… : PS1, Line 233: * 'The "ASP Identifier Required" error is sent by an SGP in > shouldn't this entire "#if 0" block removed now? Done https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115/comment/a3371fca_37a48… : PS1, Line 251: /* TODO: RFC 4666 3.5.2: > shouldn't this entire "#if 0" block removed now? Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/42115?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Ib94d542f940e13d5c007bc3319e7dde65cf81f12 Gerrit-Change-Number: 42115 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Feb 2026 08:50:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmo-abis[master]: Add CAS channel support
by laforge 12 Feb '26

12 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email ) Change subject: Add CAS channel support ...................................................................... Add CAS channel support CAS is currently supported by e1d driver only. Change-Id: I81cc89e01bb4207dc899ab28f24a131f24b61c9c --- M TODO-RELEASE M include/osmocom/abis/e1_input.h M src/e1_input.c M src/input/e1d.c 4 files changed, 46 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index d07457d..5664f80 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -8,3 +8,7 @@ # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line libosmotrau add osmo_amrt_fill_with_dhf() +libosmoabis ABI break added field to struct e1inp_driver (field added at the end) +libosmoabis ABI break added field to struct input_signal_data (field added at the end) +libosmoabis added New API function: e1inp_ts_set_cas() +libosmoabis added New API signal: S_L_INP_LINE_CAS diff --git a/include/osmocom/abis/e1_input.h b/include/osmocom/abis/e1_input.h index 66985ea..244d0a4 100644 --- a/include/osmocom/abis/e1_input.h +++ b/include/osmocom/abis/e1_input.h @@ -195,6 +195,10 @@ /* Optional callback to perform driver specific initialization when the line is created. */ int (*line_create)(struct e1inp_line *line); + + /* Set CAS bits to transmit in TS16, that are associated with given time slot */ + int (*set_cas)(struct e1inp_ts *ts, uint8_t bits, bool query_rx); + }; struct e1inp_line_ops { @@ -274,6 +278,7 @@ S_L_INP_LINE_SA_BITS, S_L_INP_LINE_LOF, S_L_INP_LINE_NOLOF, + S_L_INP_LINE_CAS, }; extern const struct value_string e1inp_signal_names[]; @@ -344,6 +349,12 @@ */ int e1inp_ts_set_sa_bits(struct e1inp_line *line, uint8_t sa_bits); +/* + * configure CAS bits on TS16 that are associated to given TS, if supported by driver + * cas (MSB to LSB): 0000ABCD + */ +int e1inp_ts_set_cas(struct e1inp_ts *ts, uint8_t bits, bool query_rx); + /* obtain a string identifier/name for the given timeslot */ void e1inp_ts_name(char *out, size_t out_len, const struct e1inp_ts *ts); @@ -403,6 +414,7 @@ uint8_t sa_bits; struct gsm_bts_trx *trx; struct e1inp_line *line; + uint8_t cas; }; int abis_sendmsg(struct msgb *msg); diff --git a/src/e1_input.c b/src/e1_input.c index 066a572..c5ee38f 100644 --- a/src/e1_input.c +++ b/src/e1_input.c @@ -527,6 +527,16 @@ return driver->set_sa_bits(line, sa_bits); } +int e1inp_ts_set_cas(struct e1inp_ts *ts, uint8_t bits, bool query_rx) +{ + struct e1inp_driver *driver; + + driver = ts->line->driver; + if (!driver->set_cas) + return -ENOTSUP; + return driver->set_cas(ts, bits, query_rx); +} + static int e1inp_line_use_cb(struct osmo_use_count_entry *use_count_entry, int32_t old_use_count, const char *file, int file_line) { diff --git a/src/input/e1d.c b/src/input/e1d.c index dd4e9fe..978b8cb 100644 --- a/src/input/e1d.c +++ b/src/input/e1d.c @@ -93,6 +93,7 @@ struct e1inp_line *e1_line; struct input_signal_data isd; int signal; + struct osmo_e1dp_cas_bits *cas; memset(&isd, 0, sizeof(isd)); @@ -133,6 +134,13 @@ if (len < 1) return; isd.sa_bits = *data; + case E1DP_EVT_CAS: + signal = S_L_INP_LINE_CAS; + cas = (struct osmo_e1dp_cas_bits *)data; + if (len < sizeof(*cas)) + return; + isd.cas = cas->bits; + isd.ts_nr = ts; break; default: /* Ignore all other events. */ @@ -844,10 +852,22 @@ return osmo_e1dp_client_set_sa_bits(g_e1d, e1d_intf, e1d_line, sa_bits); } +static int set_cas(struct e1inp_ts *ts, uint8_t bits, bool query_rx) +{ + /* we use higher 4 bits for interface, lower 4 bits for line, + * resulting in max. 16 interfaces with 16 lines each */ + uint8_t e1d_intf = (ts->line->port_nr >> 4) & 0xF; + uint8_t e1d_line = ts->line->port_nr & 0xF; + struct osmo_e1dp_cas_bits cas = { bits, query_rx }; + + return osmo_e1dp_client_set_cas(g_e1d, e1d_intf, e1d_line, ts->num, &cas); +} + struct e1inp_driver e1d_driver = { .name = "e1d", .want_write = e1d_want_write, .set_sa_bits = set_sa_bits, + .set_cas = set_cas, .line_update = e1d_line_update, .line_create = e1d_line_create, }; -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I81cc89e01bb4207dc899ab28f24a131f24b61c9c Gerrit-Change-Number: 41140 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in libosmo-abis[master]: Add CAS channel support
by laforge 12 Feb '26

12 Feb '26

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email ) Change subject: Add CAS channel support ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I81cc89e01bb4207dc899ab28f24a131f24b61c9c Gerrit-Change-Number: 41140 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Feb 2026 16:45:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject
by laforge 12 Feb '26

12 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email ) Change subject: msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject ...................................................................... msc: f_tc_ho_inter_bsc0(): catch BSSMAP HandoverRequiredReject It may happen that the target BSC is not yet connected to the MSC. In this case the MSC rejects handover with HandoverRequiredReject. Let's catch this PDU to make the verdict cleaner in such case. Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 Related: OS#6951 --- M msc/MSC_Tests.ttcn 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index 5464355..17fac68 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -6043,12 +6043,19 @@ /* Now the action goes on in f_tc_ho_inter_bsc1() */ /* MSC forwards the RR Handover Command to old BSS */ - var PDU_BSSAP ho_command; - RAN_CONN.receive(tr_BSSMAP_HandoverCommand) -> value ho_command; + var PDU_BSSAP pdu_bssap; + alt { + [] RAN_CONN.receive(tr_BSSMAP_HandoverCommand) -> value pdu_bssap { + log("Rx HandoverCommand: ", pdu_bssap); + RAN_CONN.receive(tr_BSSMAP_HandoverSucceeded) -> value pdu_bssap; + log("Rx HandoverSucceeded: ", pdu_bssap); + } + [] RAN_CONN.receive(tr_BSSMAP_HandoverRequiredReject) -> value pdu_bssap { + setverdict(fail, "Rx HandoverRequiredReject: ", pdu_bssap); + Misc_Helpers.f_shutdown(__BFILE__, __LINE__); + } + } - log("GOT HandoverCommand", ho_command); - - RAN_CONN.receive(tr_BSSMAP_HandoverSucceeded); /* f_tc_ho_inter_bsc1() completes Handover, then expecting a Clear here. */ f_expect_clear(); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42106?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I5ba98e323e0c7794554ccb115d7697ad03ccbfa5 Gerrit-Change-Number: 42106 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026