February 2026 - gerrit-log - lists.osmocom.org

[L] Change in libosmocore[master]: Implement log file target using osmo_io
by jolly 02 Feb '26

02 Feb '26

Attention is currently required from: fixeria, osmith, pespin. jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41925?usp=email ) Change subject: Implement log file target using osmo_io ...................................................................... Patch Set 17: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ieb6420246454ef59442b1fd7b1d14e2c00fa69a5 Gerrit-Change-Number: 41925 Gerrit-PatchSet: 17 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 13:31:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: Use same queue length for gsmtap_log and gsmtap_file
by pespin 02 Feb '26

02 Feb '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41980?usp=email ) Change subject: Use same queue length for gsmtap_log and gsmtap_file ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41980?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I3772d291f97626ee325731f3515a5110eda70d3d Gerrit-Change-Number: 41980 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 12:51:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: vty: Use osmo_fd_{write,read}_enable() API helper
by fixeria 02 Feb '26

02 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41985?usp=email ) Change subject: vty: Use osmo_fd_{write,read}_enable() API helper ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icba439fb33a29626ffce9ca1d61d30e88426f526 Gerrit-Change-Number: 41985 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 12:50:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: assignment_fsm: Fix use-after-free of lchan->conn
by fixeria 02 Feb '26

02 Feb '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42010?usp=email ) Change subject: assignment_fsm: Fix use-after-free of lchan->conn ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifbb9a61cd8a40d953ef5c2b52f9be9ef0dffefa4 Gerrit-Change-Number: 42010 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 12:49:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-bsc[master]: assignment_fsm: Fix use-after-free of lchan->conn
by pespin 02 Feb '26

02 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42010?usp=email ) Change subject: assignment_fsm: Fix use-after-free of lchan->conn ...................................................................... assignment_fsm: Fix use-after-free of lchan->conn Scenario: * A DYNAMIC/OSMOCOM TS in PDCH mode is selected to be used for TCH/F, hence the TS is being switched to TCH/F: RF Channel Release is being transmitted and waiting to receive RF Channel release ACK. Hence, lchan is in state LCHAN_ST_WAIT_TS_READY, and there's a conn with an assignment FSM pointing to it in conn->assignment.new_lchan. lchan->conn also points to the related conn. * The BSSMAP SCCP link goes down (link lost), which will terminate the conn->fi of all conns related to the MSC peer going down. During that teardown, first gscon_pre_term()->gscon_release_lchans()-> assignment_reset() is called, which sets conn->assignment.new_lchan=NULL and calls lchan_release(). This path leaves conn->assignment.new_lchan->conn untouched! * Later in the call path, when finally the bsc_subscr is put() to 0 references and associated lchan gets its lchan_forget_conn() called, it will access lchan->conn which was not freed in the previous step mentioned above during assignment_reset(). This patch fixes the issue by adding a lchan_forget_conn() after the lchan_release() in assignment_reset(), to make sure the conn is no longer user by the lchan afterwards. Related: OS#6936 Change-Id: Ifbb9a61cd8a40d953ef5c2b52f9be9ef0dffefa4 --- M src/osmo-bsc/assignment_fsm.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/10/42010/1 diff --git a/src/osmo-bsc/assignment_fsm.c b/src/osmo-bsc/assignment_fsm.c index f0a2781..e5392f6 100644 --- a/src/osmo-bsc/assignment_fsm.c +++ b/src/osmo-bsc/assignment_fsm.c @@ -127,6 +127,7 @@ struct gsm_lchan *lchan = conn->assignment.new_lchan; conn->assignment.new_lchan = NULL; lchan_release(lchan, false, true, RSL_ERR_EQUIPMENT_FAIL, NULL); + lchan_forget_conn(lchan); } if (conn->assignment.created_ci_for_msc) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/42010?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ifbb9a61cd8a40d953ef5c2b52f9be9ef0dffefa4 Gerrit-Change-Number: 42010 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: logging_file: Clean log_target_file_reopen()
by pespin 02 Feb '26

02 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email ) Change subject: logging_file: Clean log_target_file_reopen() ...................................................................... logging_file: Clean log_target_file_reopen() Move specific assert for wq further below. Do early return to get rid of extra indentation. Change-Id: Ibcb50320ad80b034115cccc3b7ab90501ac1d091 --- M src/core/logging_file.c 1 file changed, 19 insertions(+), 18 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved osmith: Looks good to me, but someone else must approve fixeria: Looks good to me, but someone else must approve diff --git a/src/core/logging_file.c b/src/core/logging_file.c index 99a797c..413a0a7 100644 --- a/src/core/logging_file.c +++ b/src/core/logging_file.c @@ -52,34 +52,35 @@ struct osmo_wqueue *wq; int rc; - OSMO_ASSERT(target->type == LOG_TGT_TYPE_FILE || target->type == LOG_TGT_TYPE_STDERR); - OSMO_ASSERT(target->tgt_file.out || target->tgt_file.wqueue); + OSMO_ASSERT(target->type == LOG_TGT_TYPE_FILE || + target->type == LOG_TGT_TYPE_STDERR); if (target->type == LOG_TGT_TYPE_STDERR) return -ENOTSUP; - if (target->tgt_file.out) { + if (target->tgt_file.out) { /* stream mode */ fclose(target->tgt_file.out); target->tgt_file.out = fopen(target->tgt_file.fname, "a"); if (!target->tgt_file.out) return -errno; - } else { - wq = target->tgt_file.wqueue; - if (wq->bfd.fd >= 0) { - osmo_fd_unregister(&wq->bfd); - close(wq->bfd.fd); - wq->bfd.fd = -1; - } - - rc = open(target->tgt_file.fname, O_WRONLY|O_APPEND|O_CREAT|O_NONBLOCK, 0660); - if (rc < 0) - return -errno; - wq->bfd.fd = rc; - rc = osmo_fd_register(&wq->bfd); - if (rc < 0) - return rc; + return 0; } + OSMO_ASSERT(target->tgt_file.wqueue); + wq = target->tgt_file.wqueue; + if (wq->bfd.fd >= 0) { + osmo_fd_unregister(&wq->bfd); + close(wq->bfd.fd); + wq->bfd.fd = -1; + } + + rc = open(target->tgt_file.fname, O_WRONLY|O_APPEND|O_CREAT|O_NONBLOCK, 0660); + if (rc < 0) + return -errno; + wq->bfd.fd = rc; + rc = osmo_fd_register(&wq->bfd); + if (rc < 0) + return rc; return 0; } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcb50320ad80b034115cccc3b7ab90501ac1d091 Gerrit-Change-Number: 41971 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org>

1 0

[S] Change in libosmocore[master]: osmo_io: Introduce API osmo_iofd_get_txqueue_max_length()
by pespin 02 Feb '26

02 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41987?usp=email ) Change subject: osmo_io: Introduce API osmo_iofd_get_txqueue_max_length() ...................................................................... osmo_io: Introduce API osmo_iofd_get_txqueue_max_length() Change-Id: I92526aa554fc87734fae3fac0ad650d17bf52bb5 --- M include/osmocom/core/osmo_io.h M src/core/libosmocore.map M src/core/osmo_io.c 3 files changed, 12 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/include/osmocom/core/osmo_io.h b/include/osmocom/core/osmo_io.h index 525c23c..c92492c 100644 --- a/include/osmocom/core/osmo_io.h +++ b/include/osmocom/core/osmo_io.h @@ -233,6 +233,7 @@ void osmo_iofd_set_alloc_info(struct osmo_io_fd *iofd, unsigned int size, unsigned int headroom); void osmo_iofd_set_txqueue_max_length(struct osmo_io_fd *iofd, unsigned int size); +unsigned int osmo_iofd_get_txqueue_max_length(const struct osmo_io_fd *iofd); void *osmo_iofd_get_data(const struct osmo_io_fd *iofd); void osmo_iofd_set_data(struct osmo_io_fd *iofd, void *data); diff --git a/src/core/libosmocore.map b/src/core/libosmocore.map index cb79843..f6e15f0 100644 --- a/src/core/libosmocore.map +++ b/src/core/libosmocore.map @@ -273,6 +273,7 @@ osmo_iofd_set_name; osmo_iofd_set_name_f; osmo_iofd_get_priv_nr; +osmo_iofd_get_txqueue_max_length; osmo_iofd_init; osmo_iofd_mode_names; osmo_iofd_ops; diff --git a/src/core/osmo_io.c b/src/core/osmo_io.c index 514d592..3cd9dc5 100644 --- a/src/core/osmo_io.c +++ b/src/core/osmo_io.c @@ -1147,6 +1147,16 @@ iofd->tx_queue.max_length = max_length; } + +/*! Get the maximum number of messages enqueued for sending. + * \param[in] iofd the file descriptor + * \returns the maximum size of the transmit queue + */ +unsigned int osmo_iofd_get_txqueue_max_length(const struct osmo_io_fd *iofd) +{ + return iofd->tx_queue.max_length; +} + /*! Retrieve the associated user-data from an osmo_io_fd. * * A call to this function will return the opaque user data pointer which was specified previously -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I92526aa554fc87734fae3fac0ad650d17bf52bb5 Gerrit-Change-Number: 41987 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Lb: Handle SCCP N-NOTICE.ind
by pespin 02 Feb '26

02 Feb '26

Attention is currently required from: daniel, fixeria, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email ) Change subject: Lb: Handle SCCP N-NOTICE.ind ...................................................................... Patch Set 2: (1 comment) File src/osmo-bsc/lb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/41992/comment/a3d9fbd7_040f39c9?usp… : PS1, Line 173: MSC > MSC? Aren't we talking to SMLC here? Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I689bf2f2c4311fbc1da92f02c27078a1c00dda1a Gerrit-Change-Number: 41992 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 09:36:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-bsc[master]: Lb: Handle SCCP N-NOTICE.ind
by pespin 02 Feb '26

02 Feb '26

Attention is currently required from: daniel, fixeria, neels, pespin. Hello Jenkins Builder, daniel, fixeria, neels, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by fixeria, Verified+1 by Jenkins Builder Change subject: Lb: Handle SCCP N-NOTICE.ind ...................................................................... Lb: Handle SCCP N-NOTICE.ind Change-Id: I689bf2f2c4311fbc1da92f02c27078a1c00dda1a --- M src/osmo-bsc/lb.c 1 file changed, 49 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/92/41992/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I689bf2f2c4311fbc1da92f02c27078a1c00dda1a Gerrit-Change-Number: 41992 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>

1 0

[S] Change in libosmocore[master]: osmo_io: Introduce API osmo_iofd_get_txqueue_max_length()
by fixeria 02 Feb '26

02 Feb '26

Attention is currently required from: daniel, jolly, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41987?usp=email ) Change subject: osmo_io: Introduce API osmo_iofd_get_txqueue_max_length() ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41987?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I92526aa554fc87734fae3fac0ad650d17bf52bb5 Gerrit-Change-Number: 41987 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 09:30:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026