February 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bsc[master]: Lb: Handle SCCP N-NOTICE.ind
by fixeria 02 Feb '26

02 Feb '26

Attention is currently required from: daniel, neels, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email ) Change subject: Lb: Handle SCCP N-NOTICE.ind ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/osmo-bsc/lb.c: https://gerrit.osmocom.org/c/osmo-bsc/+/41992/comment/5d47bf52_4ea3bafc?usp… : PS1, Line 173: MSC MSC? Aren't we talking to SMLC here? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/41992?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I689bf2f2c4311fbc1da92f02c27078a1c00dda1a Gerrit-Change-Number: 41992 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 09:30:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: logging_file: Clean log_target_file_reopen()
by pespin 02 Feb '26

02 Feb '26

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email ) Change subject: logging_file: Clean log_target_file_reopen() ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41971?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibcb50320ad80b034115cccc3b7ab90501ac1d091 Gerrit-Change-Number: 41971 Gerrit-PatchSet: 7 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Feb 2026 08:54:34 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-cbc[master]: rest_api: Fix encoded payload length check
by pespin 02 Feb '26

02 Feb '26

Attention is currently required from: laforge, matanp. pespin has posted comments on this change by matanp. ( https://gerrit.osmocom.org/c/osmo-cbc/+/41997?usp=email ) Change subject: rest_api: Fix encoded payload length check ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-cbc/+/41997?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-cbc Gerrit-Branch: master Gerrit-Change-Id: I4224102dd924dfded59e3a489079d02ca0237983 Gerrit-Change-Number: 41997 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1008(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: matanp <matan1008(a)gmail.com> Gerrit-Comment-Date: Mon, 02 Feb 2026 08:48:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc
by pespin 02 Feb '26

02 Feb '26

Attention is currently required from: laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email ) Change subject: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc ...................................................................... Patch Set 1: (1 comment) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995/comment/fee8285d_79ef… : PS1, Line 11: teared > not improtant: "torn down" Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb98e4d907feaafdaf3f5bf044c0c50b6d943d01 Gerrit-Change-Number: 41995 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 02 Feb 2026 08:45:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc
by pespin 02 Feb '26

02 Feb '26

Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by laforge Change subject: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc ...................................................................... bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc The SMLC is not needed at all in that test. In fact, we want it to not be available. Starting it now within that test, where the BSC Lb link is torn down (f_vty_enable_smlc(false)) may create race conditions where the SMLC ttcn3 code (BSSMAP_LE_Emulation) will try to get the RESET procedure ongoing, which the BSC SCCP stack may reject (SCCP UDTS) due to the SCCP User being unbound during the VTY command above to disable the Lb Link. Change-Id: Idb98e4d907feaafdaf3f5bf044c0c50b6d943d01 --- M bsc/BSC_Tests.ttcn 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/41995/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb98e4d907feaafdaf3f5bf044c0c50b6d943d01 Gerrit-Change-Number: 41995 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: BSSAP_LE_Emulation: Handle N-PCSTATE.ind to wait for peer availability
by pespin 02 Feb '26

02 Feb '26

Attention is currently required from: osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41967?usp=email ) Change subject: BSSAP_LE_Emulation: Handle N-PCSTATE.ind to wait for peer availability ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a40d1ddcd3a7dbde9f6c8b51439e9ab4d1da469 Gerrit-Change-Number: 41967 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 08:44:36 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmocore[master]: logging: Also Avoid infinite loop/deadlock in log_check_level()
by pespin 02 Feb '26

02 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41986?usp=email ) Change subject: logging: Also Avoid infinite loop/deadlock in log_check_level() ...................................................................... logging: Also Avoid infinite loop/deadlock in log_check_level() A LOG() macro being called inside an already-logging path will first call log_check_level() before calling osmo_vlogp(). Since calling happens with the mutex hold, it has been seen to deadlock in eg. osmo-hnbgw. Change-Id: I0098629b335b3aa174b49fd79c33d22b04bc4785 --- M src/core/logging.c 1 file changed, 9 insertions(+), 1 deletion(-) Approvals: jolly: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/src/core/logging.c b/src/core/logging.c index 60634af..db5433e 100644 --- a/src/core/logging.c +++ b/src/core/logging.c @@ -753,7 +753,8 @@ if (OSMO_UNLIKELY(log_thread_state.logging_active)) { /* Avoid re-entrant logging: If logging to log target generates * extra logging (eg. an error log line due to some wqueue being full), - * we may end up in an infinite loop. */ + * we may end up in an infinite loop, or deadlock trying to re-acquire + * this same lock. */ return; } log_thread_state.logging_active = true; @@ -1397,6 +1398,13 @@ /* TODO: The following could/should be cached (update on config) */ + if (OSMO_UNLIKELY(log_thread_state.logging_active)) { + /* Avoid re-entrant logging: If logging to log target generates + * extra logging (eg. an error log line due to some wqueue being full), + * we may end up in an infinite loop, or deadlock trying to re-acquire + * this same lock. */ + return 0; + } log_tgt_mutex_lock(); llist_for_each_entry(tar, &osmo_log_target_list, entry) { -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41986?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0098629b335b3aa174b49fd79c33d22b04bc4785 Gerrit-Change-Number: 41986 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[L] Change in osmo-e1d[master]: Add Channel-Associated Signalling (CAS) support
by pespin 02 Feb '26

02 Feb '26

Attention is currently required from: jolly, tnt. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email ) Change subject: Add Channel-Associated Signalling (CAS) support ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972 Gerrit-Change-Number: 41139 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Comment-Date: Mon, 02 Feb 2026 08:43:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in libosmo-abis[master]: Add CAS channel support
by laforge 02 Feb '26

02 Feb '26

Attention is currently required from: jolly, pespin. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email ) Change subject: Add CAS channel support ...................................................................... Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-abis/+/41140?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-abis Gerrit-Branch: master Gerrit-Change-Id: I81cc89e01bb4207dc899ab28f24a131f24b61c9c Gerrit-Change-Number: 41140 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 08:42:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[L] Change in osmo-e1d[master]: Add Channel-Associated Signalling (CAS) support
by laforge 02 Feb '26

02 Feb '26

Attention is currently required from: jolly, pespin, tnt. laforge has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email ) Change subject: Add Channel-Associated Signalling (CAS) support ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File src/mux_demux.c: https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/46b929be_4b90375b?usp… : PS3, Line 397: if (!line->cas.rx.buf_valid[line->cas.rx.frame_count + 14] || > I do not need to iterate over all time slots, because the CAS event is already triggered in the rece […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972 Gerrit-Change-Number: 41139 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: tnt <tnt(a)246tNt.com> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: tnt <tnt(a)246tNt.com> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 08:39:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026