February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-ci[master]: Osmocom_OBS_sync: fix failing on new scmsync tag
by pespin 09 Feb '26

09 Feb '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42087?usp=email ) Change subject: Osmocom_OBS_sync: fix failing on new scmsync tag ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2d2ce3a2eeda9a0ed7ce7c7de54293081b44f4e Gerrit-Change-Number: 42087 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:58:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.esim.saip: Fix docstring warnings:
by laforge 09 Feb '26

09 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42078?usp=email ) Change subject: pySim.esim.saip: Fix docstring warnings: ...................................................................... pySim.esim.saip: Fix docstring warnings: this fixes the following two warnings: pySim/esim/saip/__init__.py:docstring of pySim.esim.saip.FsNode.walk:1: WARNING: Inline strong start-string without end-string. [docutils] pySim/esim/saip/__init__.py:docstring of pySim.esim.saip.FsNodeDF.walk:1: WARNING: Inline strong start-string without end-string. [docutils] Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 --- M pySim/esim/saip/__init__.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/pySim/esim/saip/__init__.py b/pySim/esim/saip/__init__.py index 6962ee8..a50e86f 100644 --- a/pySim/esim/saip/__init__.py +++ b/pySim/esim/saip/__init__.py @@ -2004,7 +2004,7 @@ return x def walk(self, fn, **kwargs): - """call 'fn(self, **kwargs) for the File.""" + """call 'fn(self, ``**kwargs``) for the File.""" return [fn(self, **kwargs)] class FsNodeEF(FsNode): @@ -2094,7 +2094,7 @@ return cur def walk(self, fn, **kwargs): - """call 'fn(self, **kwargs) for the DF and recursively for all children.""" + """call 'fn(self, ``**kwargs``) for the DF and recursively for all children.""" ret = super().walk(fn, **kwargs) for c in self.children.values(): ret += c.walk(fn, **kwargs) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 Gerrit-Change-Number: 42078 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[S] Change in pysim[master]: pysim.utils.decomposeATR: Fix docutils warning
by laforge 09 Feb '26

09 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42079?usp=email ) Change subject: pysim.utils.decomposeATR: Fix docutils warning ...................................................................... pysim.utils.decomposeATR: Fix docutils warning pySim/utils.py:docstring of pySim.utils.decomposeATR:9: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] Change-Id: Ifda4ba15014ba97634fd5bd5c9b19d9110f4670e --- M pySim/utils.py 1 file changed, 11 insertions(+), 9 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pySim/utils.py b/pySim/utils.py index 7d8e3fa..1fdcefe 100644 --- a/pySim/utils.py +++ b/pySim/utils.py @@ -631,15 +631,17 @@ Returns: dictionary of field and values - >>> decomposeATR("3B A7 00 40 18 80 65 A2 08 01 01 52") - { 'T0': {'value': 167}, - 'TB': {1: {'value': 0}}, - 'TC': {2: {'value': 24}}, - 'TD': {1: {'value': 64}}, - 'TS': {'value': 59}, - 'atr': [59, 167, 0, 64, 24, 128, 101, 162, 8, 1, 1, 82], - 'hb': {'value': [128, 101, 162, 8, 1, 1, 82]}, - 'hbn': 7} + Example:: + + >>> decomposeATR("3B A7 00 40 18 80 65 A2 08 01 01 52") + { 'T0': {'value': 167}, + 'TB': {1: {'value': 0}}, + 'TC': {2: {'value': 24}}, + 'TD': {1: {'value': 64}}, + 'TS': {'value': 59}, + 'atr': [59, 167, 0, 64, 24, 128, 101, 162, 8, 1, 1, 82], + 'hb': {'value': [128, 101, 162, 8, 1, 1, 82]}, + 'hbn': 7} """ ATR_PROTOCOL_TYPE_T0 = 0 atr_txt = normalizeATR(atr_txt) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42079?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ifda4ba15014ba97634fd5bd5c9b19d9110f4670e Gerrit-Change-Number: 42079 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring error
by laforge 09 Feb '26

09 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42080?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring error ...................................................................... pySim.esim.saip.personalization: Fix docstring error pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.MilenageXoringConstants:4: ERROR: Unexpected indentation. [docutils] Change-Id: If6ae360b7f74c095fa9075ae9aa988440496e6de --- M pySim/esim/saip/personalization.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index 54aaa43..c61675f 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -640,12 +640,14 @@ class MilenageXoringConstants(BinaryParam, AlgoConfig): """XOR-ing constants c1,c2,c3,c4,c5 of Milenage, 128bit each. See 3GPP TS 35.206 Sections 2.3 + 5.3. Provided as octet-string concatenation of all 5 constants. The default value by 3GPP is the concetenation - of: + of:: + 00000000000000000000000000000000 00000000000000000000000000000001 00000000000000000000000000000002 00000000000000000000000000000004 00000000000000000000000000000008 + """ name = 'MilenageXOR' algo_config_key = 'xoringConstants' -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6ae360b7f74c095fa9075ae9aa988440496e6de Gerrit-Change-Number: 42080 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring errors + warnings
by laforge 09 Feb '26

09 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/42081?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring errors + warnings ...................................................................... pySim.esim.saip.personalization: Fix docstring errors + warnings pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:27: ERROR: Unexpected indentation. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:29: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:34: ERROR: Unexpected indentation. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:35: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:52: ERROR: Unexpected indentation. [docutils] pysim/pySim/esim/saip/personalization.py:docstring of pySim.esim.saip.personalization.ConfigurableParameter:53: WARNING: Block quote ends without a blank line; unexpected unindent. [docutils] Change-Id: I3918308856c3a1a5e6e90561c3e2a6b88040670d --- M pySim/esim/saip/personalization.py 1 file changed, 27 insertions(+), 26 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim/esim/saip/personalization.py b/pySim/esim/saip/personalization.py index c61675f..8bf9a70 100644 --- a/pySim/esim/saip/personalization.py +++ b/pySim/esim/saip/personalization.py @@ -69,40 +69,41 @@ Usage examples, by example of Iccid: - 1) use a ConfigurableParameter instance, with .input_value and .value state: + 1) use a ConfigurableParameter instance, with .input_value and .value state:: - iccid = Iccid() - try: - iccid.input_value = '123456789012345678' - iccid.validate() - except ValueError: - print(f"failed to validate {iccid.name} == {iccid.input_value}") + iccid = Iccid() + try: + iccid.input_value = '123456789012345678' + iccid.validate() + except ValueError: + print(f"failed to validate {iccid.name} == {iccid.input_value}") - pes = ProfileElementSequence.from_der(der_data_from_file) - try: - iccid.apply(pes) - except ValueError: - print(f"failed to apply {iccid.name} := {iccid.input_value}") + pes = ProfileElementSequence.from_der(der_data_from_file) + try: + iccid.apply(pes) + except ValueError: + print(f"failed to apply {iccid.name} := {iccid.input_value}") - changed_der = pes.to_der() + changed_der = pes.to_der() - 2) use a ConfigurableParameter class, without state: + 2) use a ConfigurableParameter class, without state:: - cls = Iccid - input_val = '123456789012345678' + cls = Iccid + input_val = '123456789012345678' - try: - clean_val = cls.validate_val(input_val) - except ValueError: - print(f"failed to validate {cls.get_name()} = {input_val}") + try: + clean_val = cls.validate_val(input_val) + except ValueError: + print(f"failed to validate {cls.get_name()} = {input_val}") - pes = ProfileElementSequence.from_der(der_data_from_file) - try: - cls.apply_val(pes, clean_val) - except ValueError: - print(f"failed to apply {cls.get_name()} = {input_val}") + pes = ProfileElementSequence.from_der(der_data_from_file) + try: + cls.apply_val(pes, clean_val) + except ValueError: + print(f"failed to apply {cls.get_name()} = {input_val}") - changed_der = pes.to_der() + changed_der = pes.to_der() + """ # A subclass can set an explicit string as name (like name = "PIN1"). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3918308856c3a1a5e6e90561c3e2a6b88040670d Gerrit-Change-Number: 42081 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[M] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring errors + warnings
by laforge 09 Feb '26

09 Feb '26

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42081?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring errors + warnings ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3918308856c3a1a5e6e90561c3e2a6b88040670d Gerrit-Change-Number: 42081 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:50:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.esim.saip.personalization: Fix docstring error
by laforge 09 Feb '26

09 Feb '26

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42080?usp=email ) Change subject: pySim.esim.saip.personalization: Fix docstring error ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42080?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: If6ae360b7f74c095fa9075ae9aa988440496e6de Gerrit-Change-Number: 42080 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:50:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: pySim.esim.saip: Fix docstring warnings:
by laforge 09 Feb '26

09 Feb '26

Attention is currently required from: fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/42078?usp=email ) Change subject: pySim.esim.saip: Fix docstring warnings: ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42078?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id7debf9296923b735f76623808cee68967a1ece7 Gerrit-Change-Number: 42078 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:50:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: Osmocom_OBS_sync: fix failing on new scmsync tag
by fixeria 09 Feb '26

09 Feb '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/42087?usp=email ) Change subject: Osmocom_OBS_sync: fix failing on new scmsync tag ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/42087?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: Ia2d2ce3a2eeda9a0ed7ce7c7de54293081b44f4e Gerrit-Change-Number: 42087 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 09 Feb 2026 12:47:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in pysim[master]: es2p.py: also allow 18 digit ICCID
by laforge 09 Feb '26

09 Feb '26

laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/40341?usp=email ) Change subject: es2p.py: also allow 18 digit ICCID ...................................................................... es2p.py: also allow 18 digit ICCID While at it, also use tuples (const) instead of lists (var). Tweaked-by: nhofmeyr(a)sysmocom.de (docstring, tuples) Change-Id: Iaa6e710132e3f4c6cecc5ff786922f6c0fcfb54e --- M pySim/esim/es2p.py 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved diff --git a/pySim/esim/es2p.py b/pySim/esim/es2p.py index 36a3a0c..ff0c64e 100644 --- a/pySim/esim/es2p.py +++ b/pySim/esim/es2p.py @@ -33,7 +33,7 @@ class param: class Iccid(ApiParamString): - """String representation of 19 or 20 digits, where the 20th digit MAY optionally be the padding + """String representation of 18 to 20 digits, where the 20th digit MAY optionally be the padding character F.""" @classmethod def _encode(cls, data): @@ -46,7 +46,7 @@ @classmethod def verify_encoded(cls, data): - if len(data) not in [19, 20]: + if len(data) not in (18, 19, 20): raise ValueError('ICCID (%s) length (%u) invalid' % (data, len(data))) @classmethod @@ -59,7 +59,7 @@ @classmethod def verify_decoded(cls, data): data = str(data) - if len(data) not in [19, 20]: + if len(data) not in (18, 19, 20): raise ValueError('ICCID (%s) length (%u) invalid' % (data, len(data))) if len(data) == 19: decimal_part = data -- To view, visit https://gerrit.osmocom.org/c/pysim/+/40341?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Iaa6e710132e3f4c6cecc5ff786922f6c0fcfb54e Gerrit-Change-Number: 40341 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026