February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in libosmocore[master]: vty: Use osmo_fd_{write,read}_enable() API helper
by pespin 02 Feb '26

02 Feb '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41985?usp=email ) Change subject: vty: Use osmo_fd_{write,read}_enable() API helper ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icba439fb33a29626ffce9ca1d61d30e88426f526 Gerrit-Change-Number: 41985 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 16:04:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmocore[master]: vty: Use osmo_fd_{write,read}_enable() API helper
by jolly 02 Feb '26

02 Feb '26

Attention is currently required from: pespin. jolly has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/41985?usp=email ) Change subject: vty: Use osmo_fd_{write,read}_enable() API helper ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Icba439fb33a29626ffce9ca1d61d30e88426f526 Gerrit-Change-Number: 41985 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 16:03:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: deps/Makefile: Fetch M3UA/MTP3/SCCP back from upstream
by pespin 02 Feb '26

02 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42014?usp=email ) Change subject: deps/Makefile: Fetch M3UA/MTP3/SCCP back from upstream ...................................................................... deps/Makefile: Fetch M3UA/MTP3/SCCP back from upstream Patches in our fork have been merged and hence we can point back to upstream. Related: OS#6907 Change-Id: I1bcc6ddcd9f55866965f12fd3771ce6a8659d141 --- M deps/Makefile 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/14/42014/1 diff --git a/deps/Makefile b/deps/Makefile index 3fed0d3..c125a15 100644 --- a/deps/Makefile +++ b/deps/Makefile @@ -8,6 +8,8 @@ OSMOGITEA:=https://gitea.osmocom.org/ttcn3 ECLIPSEGITLAB_REPOS= titan.Libraries.TCCUsefulFunctions \ + titan.ProtocolEmulations.M3UA \ + titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSAPP_v7.3.0 \ titan.ProtocolModules.DIAMETER_ProtocolModule_Generator \ titan.ProtocolModules.DNS \ @@ -42,6 +44,7 @@ titan.TestPorts.HTTPmsg \ titan.TestPorts.IPL4asp \ titan.TestPorts.LANL2asp \ + titan.TestPorts.MTP3asp \ titan.TestPorts.PCAPasp \ titan.TestPorts.PIPEasp \ titan.TestPorts.SIPmsg \ @@ -51,9 +54,6 @@ titan.TestPorts.UNIX_DOMAIN_SOCKETasp OSMOGITHUB_REPOS= titan.TestPorts.SCTPasp \ - titan.TestPorts.MTP3asp \ - titan.ProtocolEmulations.M3UA \ - titan.ProtocolEmulations.SCCP \ titan.ProtocolModules.BSSGP_v13.0.0 OSMOGERRIT_REPOS= osmo-uecups -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1bcc6ddcd9f55866965f12fd3771ce6a8659d141 Gerrit-Change-Number: 42014 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bsc: expected-results.xml: Add missing test BSC_Tests.TC_lcs_loc_req_...
by pespin 02 Feb '26

02 Feb '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42013?usp=email ) Change subject: bsc: expected-results.xml: Add missing test BSC_Tests.TC_lcs_loc_req_without_smlc ...................................................................... bsc: expected-results.xml: Add missing test BSC_Tests.TC_lcs_loc_req_without_smlc Change-Id: Iebae79d8b70d1200b45b9f86b1e0d63b9c52b952 --- M bsc/expected-results.xml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/13/42013/1 diff --git a/bsc/expected-results.xml b/bsc/expected-results.xml index 7569056..90b613d 100644 --- a/bsc/expected-results.xml +++ b/bsc/expected-results.xml @@ -249,6 +249,7 @@ <testcase classname='BSC_Tests' name='TC_emerg_call_and_lcs_loc_req' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_emerg_call_and_lcs_loc_req_early_lchan_rel_ind' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_emerg_call_and_lcs_loc_req_early_lchan_conn_fail' time='MASKED'/> + <testcase classname='BSC_Tests' name='TC_lcs_loc_req_without_smlc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_no_msc' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_refuse_chan_act_to_vamos' time='MASKED'/> <testcase classname='BSC_Tests' name='TC_refuse_mode_modif_to_vamos' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/42013?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iebae79d8b70d1200b45b9f86b1e0d63b9c52b952 Gerrit-Change-Number: 42013 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in libosmo-sigtran[master]: sccp_scrc: Improve logging unable to find SCCP user
by fixeria 02 Feb '26

02 Feb '26

Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41991?usp=email ) Change subject: sccp_scrc: Improve logging unable to find SCCP user ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/41991?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I9277624a260ee2f94f8cd059211aff53cfb50574 Gerrit-Change-Number: 41991 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 14:14:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: BSSAP_LE_Emulation: Handle N-PCSTATE.ind to wait for peer availability
by pespin 02 Feb '26

02 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41967?usp=email ) Change subject: BSSAP_LE_Emulation: Handle N-PCSTATE.ind to wait for peer availability ...................................................................... BSSAP_LE_Emulation: Handle N-PCSTATE.ind to wait for peer availability Take the chance to explicitly log and discard other .ind primitives which would otherwise block the processing of messages. Related: OS#6907 Change-Id: I6a40d1ddcd3a7dbde9f6c8b51439e9ab4d1da469 --- M library/BSSAP_LE_CodecPort.ttcn M library/BSSAP_LE_Emulation.ttcn 2 files changed, 71 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified fixeria: Looks good to me, but someone else must approve diff --git a/library/BSSAP_LE_CodecPort.ttcn b/library/BSSAP_LE_CodecPort.ttcn index 418e55a..3e82cab 100644 --- a/library/BSSAP_LE_CodecPort.ttcn +++ b/library/BSSAP_LE_CodecPort.ttcn @@ -375,7 +375,7 @@ ASP_SCCP_N_RESET_ind -> ASP_SCCP_N_RESET_ind: simple; ASP_SCCP_N_RESET_cfm -> ASP_SCCP_N_RESET_cfm: simple; ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple; - ASP_SCCP_N_PCSTATE_ind -> -: discard)" + ASP_SCCP_N_PCSTATE_ind -> ASP_SCCP_N_PCSTATE_ind: simple)" } diff --git a/library/BSSAP_LE_Emulation.ttcn b/library/BSSAP_LE_Emulation.ttcn index 15930d5..1786af5 100644 --- a/library/BSSAP_LE_Emulation.ttcn +++ b/library/BSSAP_LE_Emulation.ttcn @@ -371,6 +371,12 @@ var BSSAP_LE_N_CONNECT_cfm conn_cfm; var BSSAP_LE_N_DATA_ind data_ind; var BSSAP_LE_N_DISCONNECT_ind disc_ind; + + var ASP_SCCP_N_RESET_ind n_reset_ind; + var ASP_SCCP_N_RESET_cfm n_reset_cfm; + var ASP_SCCP_N_STATE_ind n_state_ind; + var ASP_SCCP_N_PCSTATE_ind n_pcstate_ind; + var BSSAP_LE_Conn_Req creq; var PDU_BSSAP_LE bssap; var BSSAP_LE_N_UNITDATA_req bssap_ud; @@ -427,6 +433,24 @@ f_handle_userData(vc_conn, conn_cfm.userData); } } + + /* SCCP -> Client: N-RESET.ind */ + [] BSSAP_LE.receive(ASP_SCCP_N_RESET_ind:?) -> value n_reset_ind { + log("Discard ", n_reset_ind) + } + /* SCCP -> Client: N-RESET.cfm */ + [] BSSAP_LE.receive(ASP_SCCP_N_RESET_cfm:?) -> value n_reset_cfm { + log("Discard ", n_reset_cfm) + } + /* SCCP -> Client: N-STATE.ind */ + [] BSSAP_LE.receive(ASP_SCCP_N_STATE_ind:?) -> value n_state_ind { + log("Discard ", n_state_ind) + } + /* SCCP -> Client: N-PCSTATE.ind */ + [] BSSAP_LE.receive(ASP_SCCP_N_PCSTATE_ind:?) -> value n_pcstate_ind { + log("Discard ", n_pcstate_ind) + } + [] CLIENT.receive(PDU_BSSAP_LE:?) -> value bssap sender vc_conn { var integer conn_id := f_conn_id_by_comp(vc_conn); /* send it to dispatcher */ @@ -506,6 +530,49 @@ f_ML3_patch_seq_nr(seq_nr, enc_l3); } +function f_bssap_le_wait_sccp_peer_available(BSSAP_LE_CODEC_PT pt, integer peer_pc, float timeout_sec := 3.0) +{ + timer T; + var ASP_SCCP_N_PCSTATE_ind n_pcstate_ind; + var boolean rx_explicit_down := false; + + log("Waiting for SCCP peer PC=", peer_pc, " to become available"); + T.start(timeout_sec); + + alt { + [] pt.receive(t_ASP_N_PCSTATE_ind(?, ?, *, *)) -> value n_pcstate_ind { + var integer aff_pc := bit2int(n_pcstate_ind.affectedSP); + if (aff_pc != peer_pc) { + log("Waiting for SCCP peer PC=", peer_pc, ": Rx N-PCSTATE.ind for another peer PC=", aff_pc, ", ",n_pcstate_ind); + repeat; + } + if (n_pcstate_ind.spStatus == SCCP_PAR_SP_Status_accessible and + n_pcstate_ind.remSCCPStatus == SCCP_PAR_Remote_SCCP_Status_available) { + log("SCCP peer PC=", aff_pc," is now available"); + /* All peer is available, we are done */ + T.stop; + return; + } + log("SCCP peer PC=", aff_pc," is NOT available: ", n_pcstate_ind); + rx_explicit_down := true; + repeat; + } + [] pt.receive { + log("Waiting for SCCP peer PC=", peer_pc, ": Discarding message"); + repeat; + } + [] T.timeout { + if (rx_explicit_down) { + /* explicitly unavailable:*/ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Timeout waiting for SCCP peer PC=", peer_pc)); + } + /* Done, assume PCs for which we didn't receive an explicit "unavailable" are actually available. */ + } + } + log("Done waiting for SCCP peer PC=", peer_pc); +} + function main(BssapLeOps ops, charstring id) runs on BSSAP_LE_Emulation_CT { g_ran_id := id; @@ -514,6 +581,9 @@ f_expect_table_init(); if (isvalue(ops.sccp_addr_peer) and isvalue(ops.sccp_addr_local)) { + if (ispresent(ops.sccp_addr_peer.signPointCode)) { + f_bssap_le_wait_sccp_peer_available(BSSAP_LE, bit2int(ops.sccp_addr_peer.signPointCode)); + } f_bssap_le_reset(ops.sccp_addr_peer, ops.sccp_addr_local); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41967?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a40d1ddcd3a7dbde9f6c8b51439e9ab4d1da469 Gerrit-Change-Number: 41967 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability
by pespin 02 Feb '26

02 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968?usp=email ) Change subject: RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability ...................................................................... RAN_Emulation: Handle N-PCSTATE.ind to wait for peer availability Take the chance to explicitly log and discard other .ind primitives which would otherwise block the processing of messages. Change-Id: I86b481fca9b7be84f3cda9fbce83e60820fe7fc1 Related: OS#6907 --- M bsc/BSC_Tests.ttcn M library/BSSAP_CodecPort.ttcn M library/RAN_Emulation.ttcnpp M library/ranap/RANAP_CodecPort.ttcn M msc/MSC_Tests.ttcn 5 files changed, 150 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved Jenkins Builder: Verified diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index db70bd5..6890073 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1038,6 +1038,9 @@ setverdict(fail, "Timeout of T_guard"); mtc.stop; } + [] BSSAP.receive(t_ASP_N_PCSTATE_ind(?, ?, *, *)) { + repeat; + } /* always respond with RESET ACK to RESET */ [] BSSAP.receive(tr_BSSAP_UNITDATA_ind(?, ?, tr_BSSMAP_Reset(g_osmux_enabled_cn))) -> value ud_ind { BSSAP.send(ts_BSSAP_UNITDATA_req(ud_ind.callingAddress, ud_ind.calledAddress, @@ -1222,6 +1225,7 @@ } connect(self:BSSAP, g_bssap[bssap_idx].sccpa.vc_SCCP:SCCP_SP_PORT); f_sccp_adapter_start(g_bssap[bssap_idx].sccpa); + f_bssap_wait_sccp_peer_available(BSSAP, bit2int(g_bssap[bssap_idx].sccpa.sccp_addr_peer.signPointCode)); f_legacy_bssap_reset(); } } diff --git a/library/BSSAP_CodecPort.ttcn b/library/BSSAP_CodecPort.ttcn index ce9248e..23000e2 100644 --- a/library/BSSAP_CodecPort.ttcn +++ b/library/BSSAP_CodecPort.ttcn @@ -406,7 +406,7 @@ ASP_SCCP_N_RESET_ind -> ASP_SCCP_N_RESET_ind: simple; ASP_SCCP_N_RESET_cfm -> ASP_SCCP_N_RESET_cfm: simple; ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple; - ASP_SCCP_N_PCSTATE_ind -> -: discard)" + ASP_SCCP_N_PCSTATE_ind -> ASP_SCCP_N_PCSTATE_ind: simple)" } diff --git a/library/RAN_Emulation.ttcnpp b/library/RAN_Emulation.ttcnpp index 3b3e6bd..d308355 100644 --- a/library/RAN_Emulation.ttcnpp +++ b/library/RAN_Emulation.ttcnpp @@ -961,6 +961,12 @@ var BSSAP_N_CONNECT_cfm conn_cfm; var BSSAP_N_DATA_ind data_ind; var BSSAP_N_DISCONNECT_ind disc_ind; + + var ASP_SCCP_N_RESET_ind n_reset_ind; + var ASP_SCCP_N_RESET_cfm n_reset_cfm; + var ASP_SCCP_N_STATE_ind n_state_ind; + var ASP_SCCP_N_PCSTATE_ind n_pcstate_ind; + var BSSAP_Conn_Req creq; var PDU_BSSAP bssap; var BSSAP_N_UNITDATA_req bssap_ud; @@ -1017,6 +1023,24 @@ f_handle_userData_BSSAP(vc_conn, conn_cfm.userData); } } + + /* SCCP -> Client: N-RESET.ind */ + [] BSSAP.receive(ASP_SCCP_N_RESET_ind:?) -> value n_reset_ind { + log("Discard ", n_reset_ind) + } + /* SCCP -> Client: N-RESET.cfm */ + [] BSSAP.receive(ASP_SCCP_N_RESET_cfm:?) -> value n_reset_cfm { + log("Discard ", n_reset_cfm) + } + /* SCCP -> Client: N-STATE.ind */ + [] BSSAP.receive(ASP_SCCP_N_STATE_ind:?) -> value n_state_ind { + log("Discard ", n_state_ind) + } + /* SCCP -> Client: N-PCSTATE.ind */ + [] BSSAP.receive(ASP_SCCP_N_PCSTATE_ind:?) -> value n_pcstate_ind { + log("Discard ", n_pcstate_ind) + } + [] CLIENT.receive(PDU_BSSAP:?) -> value bssap sender vc_conn { var integer conn_id := f_conn_id_by_comp(vc_conn); /* send it to dispatcher */ @@ -1087,6 +1111,12 @@ var RANAP_N_CONNECT_cfm rconn_cfm; var RANAP_N_DATA_ind rdata_ind; var RANAP_N_DISCONNECT_ind rdisc_ind; + + var ASP_SCCP_N_RESET_ind n_reset_ind; + var ASP_SCCP_N_RESET_cfm n_reset_cfm; + var ASP_SCCP_N_STATE_ind n_state_ind; + var ASP_SCCP_N_PCSTATE_ind n_pcstate_ind; + var RANAP_Conn_Req creq; var RANAP_PDU ranap; var RANAP_N_UNITDATA_req ranap_ud; @@ -1152,6 +1182,23 @@ } } + /* SCCP -> Client: N-RESET.ind */ + [] RANAP.receive(ASP_SCCP_N_RESET_ind:?) -> value n_reset_ind { + log("Discard ", n_reset_ind) + } + /* SCCP -> Client: N-RESET.cfm */ + [] RANAP.receive(ASP_SCCP_N_RESET_cfm:?) -> value n_reset_cfm { + log("Discard ", n_reset_cfm) + } + /* SCCP -> Client: N-STATE.ind */ + [] RANAP.receive(ASP_SCCP_N_STATE_ind:?) -> value n_state_ind { + log("Discard ", n_state_ind) + } + /* SCCP -> Client: N-PCSTATE.ind */ + [] RANAP.receive(ASP_SCCP_N_PCSTATE_ind:?) -> value n_pcstate_ind { + log("Discard ", n_pcstate_ind) + } + [] CLIENT.receive(RANAP_PDU:?) -> value ranap sender vc_conn { var integer conn_id := f_conn_id_by_comp(vc_conn); /* send it to dispatcher */ @@ -1339,6 +1386,96 @@ } } +#ifdef RAN_EMULATION_BSSAP +function f_bssap_wait_sccp_peer_available(BSSAP_CODEC_PT pt, integer peer_pc, float timeout_sec := 3.0) +{ + timer T; + var ASP_SCCP_N_PCSTATE_ind n_pcstate_ind; + var boolean rx_explicit_down := false; + + log("Waiting for SCCP peer PC=", peer_pc, " to become available"); + T.start(timeout_sec); + + alt { + [] pt.receive(t_ASP_N_PCSTATE_ind(?, ?, *, *)) -> value n_pcstate_ind { + var integer aff_pc := bit2int(n_pcstate_ind.affectedSP); + if (aff_pc != peer_pc) { + log("Waiting for SCCP peer PC=", peer_pc, ": Rx N-PCSTATE.ind for another peer PC=", aff_pc, ", ",n_pcstate_ind); + repeat; + } + if (n_pcstate_ind.spStatus == SCCP_PAR_SP_Status_accessible and + n_pcstate_ind.remSCCPStatus == SCCP_PAR_Remote_SCCP_Status_available) { + log("SCCP peer PC=", aff_pc," is now available"); + /* All peer is available, we are done */ + T.stop; + return; + } + log("SCCP peer PC=", aff_pc," is NOT available: ", n_pcstate_ind); + rx_explicit_down := true; + repeat; + } + [] pt.receive { + log("Waiting for SCCP peer PC=", peer_pc, ": Discarding message"); + repeat; + } + [] T.timeout { + if (rx_explicit_down) { + /* explicitly unavailable:*/ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Timeout waiting for SCCP peer PC=", peer_pc)); + } + /* Done, assume PCs for which we didn't receive an explicit "unavailable" are actually available. */ + } + } + log("Done waiting for SCCP peer PC=", peer_pc); +} +#endif + +#ifdef RAN_EMULATION_RANAP +function f_ranap_wait_sccp_peer_available(RANAP_CODEC_PT pt, integer peer_pc, float timeout_sec := 3.0) +{ + timer T; + var ASP_SCCP_N_PCSTATE_ind n_pcstate_ind; + var boolean rx_explicit_down := false; + + log("Waiting for SCCP peer PC=", peer_pc, " to become available"); + T.start(timeout_sec); + + alt { + [] pt.receive(t_ASP_N_PCSTATE_ind(?, ?, *, *)) -> value n_pcstate_ind { + var integer aff_pc := bit2int(n_pcstate_ind.affectedSP); + if (aff_pc != peer_pc) { + log("Waiting for SCCP peer PC=", peer_pc, ": Rx N-PCSTATE.ind for another peer PC=", aff_pc, ", ",n_pcstate_ind); + repeat; + } + if (n_pcstate_ind.spStatus == SCCP_PAR_SP_Status_accessible and + n_pcstate_ind.remSCCPStatus == SCCP_PAR_Remote_SCCP_Status_available) { + log("SCCP peer PC=", aff_pc," is now available"); + /* All peer is available, we are done */ + T.stop; + return; + } + log("SCCP peer PC=", aff_pc," is NOT available: ", n_pcstate_ind); + rx_explicit_down := true; + repeat; + } + [] pt.receive { + log("Waiting for SCCP peer PC=", peer_pc, ": Discarding message"); + repeat; + } + [] T.timeout { + if (rx_explicit_down) { + /* explicitly unavailable:*/ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Timeout waiting for SCCP peer PC=", peer_pc)); + } + /* Done, assume PCs for which we didn't receive an explicit "unavailable" are actually available. */ + } + } + log("Done waiting for SCCP peer PC=", peer_pc); +} +#endif + function main(RanOps ops, charstring id) runs on RAN_Emulation_CT { g_ran_id := id; @@ -1350,11 +1487,17 @@ select (g_ran_ops.protocol) { #ifdef RAN_EMULATION_BSSAP case (RAN_PROTOCOL_BSSAP) { + if (ispresent(ops.sccp_addr_peer.signPointCode)) { + f_bssap_wait_sccp_peer_available(BSSAP, bit2int(ops.sccp_addr_peer.signPointCode)); + } f_bssap_reset(ops.sccp_addr_peer, ops.sccp_addr_local); } #endif #ifdef RAN_EMULATION_RANAP case (RAN_PROTOCOL_RANAP) { + if (ispresent(ops.sccp_addr_peer.signPointCode)) { + f_ranap_wait_sccp_peer_available(RANAP, bit2int(ops.sccp_addr_peer.signPointCode)); + } f_ranap_reset(ops.sccp_addr_peer, ops.sccp_addr_local, ops.grnc_id); } #endif diff --git a/library/ranap/RANAP_CodecPort.ttcn b/library/ranap/RANAP_CodecPort.ttcn index 084d1cf..8d8ead5 100644 --- a/library/ranap/RANAP_CodecPort.ttcn +++ b/library/ranap/RANAP_CodecPort.ttcn @@ -405,7 +405,7 @@ ASP_SCCP_N_RESET_ind -> ASP_SCCP_N_RESET_ind: simple; ASP_SCCP_N_RESET_cfm -> ASP_SCCP_N_RESET_cfm: simple; ASP_SCCP_N_STATE_ind -> ASP_SCCP_N_STATE_ind: simple; - ASP_SCCP_N_PCSTATE_ind -> -: discard)" + ASP_SCCP_N_PCSTATE_ind -> ASP_SCCP_N_PCSTATE_ind: simple)" } diff --git a/msc/MSC_Tests.ttcn b/msc/MSC_Tests.ttcn index c85a458..51d8755 100644 --- a/msc/MSC_Tests.ttcn +++ b/msc/MSC_Tests.ttcn @@ -2310,8 +2310,7 @@ f_init_bssap_direct(); f_sccp_adapter_start(g_bssap[0].sccpa); - - f_sleep(3.0); + f_bssap_wait_sccp_peer_available(BSSAP_DIRECT, bit2int(g_bssap[0].sccpa.sccp_addr_peer.signPointCode)); /* Make a blind connection attemt, to trigger the deadlock condition */ BSSAP_DIRECT.send(ts_BSSAP_CONNECT_req(g_bssap[0].sccpa.sccp_addr_peer, g_bssap[0].sccpa.sccp_addr_own, 1, omit)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41968?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I86b481fca9b7be84f3cda9fbce83e60820fe7fc1 Gerrit-Change-Number: 41968 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc
by pespin 02 Feb '26

02 Feb '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email ) Change subject: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc ...................................................................... bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc The SMLC is not needed at all in that test. In fact, we want it to not be available. Starting it now within that test, where the BSC Lb link is torn down (f_vty_enable_smlc(false)) may create race conditions where the SMLC ttcn3 code (BSSMAP_LE_Emulation) will try to get the RESET procedure ongoing, which the BSC SCCP stack may reject (SCCP UDTS) due to the SCCP User being unbound during the VTY command above to disable the Lb Link. Change-Id: Idb98e4d907feaafdaf3f5bf044c0c50b6d943d01 --- M bsc/BSC_Tests.ttcn 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn index 6890073..d95a8c5 100644 --- a/bsc/BSC_Tests.ttcn +++ b/bsc/BSC_Tests.ttcn @@ -1258,7 +1258,9 @@ * \param nr_msc Number of virtual MSCs to bring up to connect to osmo-bsc. */ function f_init(integer nr_bts := NUM_BTS, boolean handler_mode := false, - integer nr_msc := 1, integer nr_mgw := 1, float guard_timeout := 30.0) runs on test_CT { + integer nr_msc := 1, integer nr_mgw := 1, + boolean enable_smlc := mp_enable_lcs_tests, + float guard_timeout := 30.0) runs on test_CT { var integer bssap_idx; if (g_initialized) { @@ -1286,7 +1288,7 @@ f_bssap_idx_init(bssap_idx); } - if (mp_enable_lcs_tests) { + if (enable_smlc) { if (handler_mode) { f_bssap_le_adapter_init(g_bssap_le, mp_bssap_le_cfg, "VirtSMLC", SMLC_BssapLeOps); } else { @@ -4102,7 +4104,7 @@ connect(vc_conn:RSL2_PROC, bts[2][0].rsl.vc_RSL:RSL_PROC); } connect(vc_conn:RAN_CONN, g_bssap[bssap_idx].vc_RAN:CLIENT); - if (mp_enable_lcs_tests) { + if (isvalue(g_bssap_le)) { connect(vc_conn:BSSAP_LE, g_bssap_le.vc_BSSAP_LE:CLIENT); connect(vc_conn:BSSAP_LE_PROC, g_bssap_le.vc_BSSAP_LE:PROC); } @@ -11036,7 +11038,6 @@ f_sleep(1.0); f_establish_fully(omit, omit); - f_bssap_le_register_imsi(g_pars.imsi, omit); RAN_CONN.send(valueof(ts_BSSMAP_Perform_Location_Request(ts_BSSMAP_Imsi(g_pars.imsi), ts_CellId_CGI('262'H, '42'H, 23, 42)))); @@ -11054,7 +11055,7 @@ var MSC_ConnHdlr vc_conn; var TestHdlrParams pars := f_gen_test_hdlr_pars(); - f_init(1, true); + f_init(1, true, enable_smlc := false); f_vty_enable_smlc(false); f_sleep(1.0); vc_conn := f_start_handler(refers(f_tc_lcs_loc_req_without_smlc), pars); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb98e4d907feaafdaf3f5bf044c0c50b6d943d01 Gerrit-Change-Number: 41995 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc
by fixeria 02 Feb '26

02 Feb '26

Attention is currently required from: daniel, laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email ) Change subject: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc ...................................................................... Patch Set 2: Code-Review+2 (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995/comment/9b042431_4fd5… : PS2, Line 4107: isvalue > Yes that would be fine too, but isvalue() works well too and it's already used above, so I preferred […] Acknowledged -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb98e4d907feaafdaf3f5bf044c0c50b6d943d01 Gerrit-Change-Number: 41995 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 14:12:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc
by pespin 02 Feb '26

02 Feb '26

Attention is currently required from: daniel, fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email ) Change subject: bsc: Don't start virtual SMLC in TC_lcs_loc_req_without_smlc ...................................................................... Patch Set 2: (1 comment) File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995/comment/deb9a54e_2788… : PS2, Line 4107: isvalue > `isbound()`? Yes that would be fine too, but isvalue() works well too and it's already used above, so I preferred keeping consistency. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41995?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idb98e4d907feaafdaf3f5bf044c0c50b6d943d01 Gerrit-Change-Number: 41995 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Comment-Date: Mon, 02 Feb 2026 14:10:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026