February 2026 - gerrit-log - lists.osmocom.org

[XS] Change in dahdi-linux[master]: dahdi-base: Use strncpy instead of strncat for beginning of buffer
by laforge 01 Feb '26

01 Feb '26

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email ) Change subject: dahdi-base: Use strncpy instead of strncat for beginning of buffer ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I539167b46f265d3c8e6dc52c978f39d58c37405f Gerrit-Change-Number: 42000 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: dahdi-base: Use strncpy instead of strncat for beginning of buffer
by laforge 01 Feb '26

01 Feb '26

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email ) Change subject: dahdi-base: Use strncpy instead of strncat for beginning of buffer ...................................................................... Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I539167b46f265d3c8e6dc52c978f39d58c37405f Gerrit-Change-Number: 42000 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 01 Feb 2026 10:40:51 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in dahdi-linux[master]: dahdi_base.c: Avoid unnecessary strlen call when with strncat.
by laforge 01 Feb '26

01 Feb '26

laforge has removed a vote from this change. ( https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email ) Change subject: dahdi_base.c: Avoid unnecessary strlen call when with strncat. ...................................................................... Removed Verified-1 by Jenkins Builder (1000002) -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: deleteVote Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Idd3e6145682e276abb9bc67029df974197bf8b1b Gerrit-Change-Number: 41999 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: dahdi_base.c: Avoid unnecessary strlen call when with strncat.
by laforge 01 Feb '26

01 Feb '26

laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email ) Change subject: dahdi_base.c: Avoid unnecessary strlen call when with strncat. ...................................................................... Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Idd3e6145682e276abb9bc67029df974197bf8b1b Gerrit-Change-Number: 41999 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Comment-Date: Sun, 01 Feb 2026 10:40:39 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in dahdi-linux[master]: WIP: attempt to introduce tracepoints to dahdi (trunkdev)
by laforge 01 Feb '26

01 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42008?usp=email ) Change subject: WIP: attempt to introduce tracepoints to dahdi (trunkdev) ...................................................................... WIP: attempt to introduce tracepoints to dahdi (trunkdev) Change-Id: I800cdd6f6d44752ebf2171e8beeb8fd646e00774 --- M drivers/dahdi/trunkdev/trunkdev.c A include/dahdi/dahdi_trace.h 2 files changed, 50 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/08/42008/1 diff --git a/drivers/dahdi/trunkdev/trunkdev.c b/drivers/dahdi/trunkdev/trunkdev.c index 6518109..1d5a8a5 100644 --- a/drivers/dahdi/trunkdev/trunkdev.c +++ b/drivers/dahdi/trunkdev/trunkdev.c @@ -63,6 +63,9 @@ } dahdi; }; +#define CREATE_TRACE_POINTS +#include <dahdi/dahdi_trace.h> + /* process one incoming E1 frame (32 bytes; one for each TS) */ static void _span_demux_one_frame(struct dahdi_trunkdev *td, const uint8_t *data) { @@ -202,6 +205,8 @@ * _dahdi_receive() via _span_demux_one_frame(), this would lead to re-entrancy */ BUG_ON(is_master); + trace_trunkdev_tick(td); + /* trigger transmission + reception of E1 frames */ for (i = 0; i < DAHDI_CHUNKSIZE; i++) { uint8_t frame[32]; @@ -537,9 +542,10 @@ if (rc < 0) { /* insufficient data available */ if (file->f_flags & O_NONBLOCK) { - if (copied == 0) + if (copied == 0) { + trace_trunkdev_read_eagain(td); return -EAGAIN; - else + } else return copied; } /* blocking wait for frames in FIFO or for device disappearing */ diff --git a/include/dahdi/dahdi_trace.h b/include/dahdi/dahdi_trace.h new file mode 100644 index 0000000..0a4443a --- /dev/null +++ b/include/dahdi/dahdi_trace.h @@ -0,0 +1,42 @@ + +#if !defined(_TRACE_DAHDI_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_DAHDI_H + +#include <linux/tracepoint.h> + +#undef TRACE_SYSTEM +#define TRACE_SYSTEM dahdi + +TRACE_EVENT(trunkdev_tick, + TP_PROTO(struct dahdi_trunkdev *td), + TP_ARGS(td), + TP_STRUCT__entry( + __array( char, name, 40 ) + ), + TP_fast_assign( + strscpy(__entry->name, td->dahdi.span.name, 40); + ), + TP_printk("name: %s", __entry->name) +); + +TRACE_EVENT(trunkdev_read_eagain, + TP_PROTO(struct dahdi_trunkdev *td), + TP_ARGS(td), + TP_STRUCT__entry( + __array( char, name, 40 ) + ), + TP_fast_assign( + strscpy(__entry->name, td->dahdi.span.name, 40); + ), + TP_printk("name: %s", __entry->name) +); + +#endif + +#undef TRACE_INCLUDE_PATH +#define TRACE_INCLUDE_PATH dahdi +#undef TRACE_INCLUDE_FILE +#define TRACE_INCLUDE_FILE dahdi_trace + +/* This part must be outside protection */ +#include <trace/define_trace.h> -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42008?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I800cdd6f6d44752ebf2171e8beeb8fd646e00774 Gerrit-Change-Number: 42008 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: dahdi-base: Use strncpy instead of strncat for beginning of buffer
by laforge 01 Feb '26

01 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email ) Change subject: dahdi-base: Use strncpy instead of strncat for beginning of buffer ...................................................................... dahdi-base: Use strncpy instead of strncat for beginning of buffer This fixes a build failure I observe with kernel v6.2: from dahdi-linux/drivers/dahdi/dahdi-base.c:40: ./include/linux/fortify-string.h:388:32: note: expected ‘char *’ but argument is of type ‘long unsigned int’ 388 | char *strncat(char * const POS p, const char * const POS q, __kernel_size_t count) | ~~~~~~~~~~~~~~~~~^ make[2]: *** [scripts/Makefile.build:252: dahdi-linux/drivers/dahdi/dahdi-base.o] Error 1 Change-Id: I539167b46f265d3c8e6dc52c978f39d58c37405f --- M drivers/dahdi/dahdi-base.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/00/42000/1 diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 6411e52..a0238e6 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -5449,7 +5449,7 @@ */ continue; } - strncat(vi.echo_canceller, ec_name, space); + strncpy(vi.echo_canceller, ec_name, space); space -= strlen(ec_name); if (space < 1) break; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42000?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I539167b46f265d3c8e6dc52c978f39d58c37405f Gerrit-Change-Number: 42000 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: wctdb24xxp/xhfc.c: Fix uninitialized variable
by laforge 01 Feb '26

01 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42001?usp=email ) Change subject: wctdb24xxp/xhfc.c: Fix uninitialized variable ...................................................................... wctdb24xxp/xhfc.c: Fix uninitialized variable This fixes a compiler error when building for kernel v6.2: In function ‘xhfc_getreg’, inlined from ‘b400m_probe’ at dahdi-linux/drivers/dahdi/wctdm24xxp/xhfc.c:2563:7: dahdi-linux/drivers/dahdi/wctdm24xxp/xhfc.c:624:12: error: ‘x’ is used uninitialized [-Werror=uninitialized] 624 | if (*lastreg != (unsigned char)addr) { | ^ dahdi-linux/drivers/dahdi/wctdm24xxp/xhfc.c: In function ‘b400m_probe’: dahdi-linux/drivers/dahdi/wctdm24xxp/xhfc.c:2557:27: note: ‘x’ was declared here 2557 | unsigned char id, x; | ^ Change-Id: I49ca7825ab238333b7d55b0ce5cae5e9e92a2cfb --- M drivers/dahdi/wctdm24xxp/xhfc.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/01/42001/1 diff --git a/drivers/dahdi/wctdm24xxp/xhfc.c b/drivers/dahdi/wctdm24xxp/xhfc.c index d37fbd5..3fd2a96 100644 --- a/drivers/dahdi/wctdm24xxp/xhfc.c +++ b/drivers/dahdi/wctdm24xxp/xhfc.c @@ -2554,7 +2554,7 @@ static int b400m_probe(struct wctdm *wc, int modpos) { - unsigned char id, x; + unsigned char id, x = 0; struct b400m *b4; unsigned long flags; int chiprev; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I49ca7825ab238333b7d55b0ce5cae5e9e92a2cfb Gerrit-Change-Number: 42001 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: dahdi_base.c: Avoid unnecessary strlen call when with strncat.
by laforge 01 Feb '26

01 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email ) Change subject: dahdi_base.c: Avoid unnecessary strlen call when with strncat. ...................................................................... dahdi_base.c: Avoid unnecessary strlen call when with strncat. It is not necessary to call strlen on the destination buffer when calling strncat. Resolves: #89 Change-Id: Idd3e6145682e276abb9bc67029df974197bf8b1b --- M drivers/dahdi/dahdi-base.c 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/99/41999/1 diff --git a/drivers/dahdi/dahdi-base.c b/drivers/dahdi/dahdi-base.c index 0aa1de7..6411e52 100644 --- a/drivers/dahdi/dahdi-base.c +++ b/drivers/dahdi/dahdi-base.c @@ -5449,14 +5449,12 @@ */ continue; } - strncat(vi.echo_canceller + strlen(vi.echo_canceller), - ec_name, space); + strncat(vi.echo_canceller, ec_name, space); space -= strlen(ec_name); if (space < 1) break; if (cur->list.next && (cur->list.next != &ecfactory_list)) { - strncat(vi.echo_canceller + strlen(vi.echo_canceller), - ", ", space); + strncat(vi.echo_canceller, ", ", space); space -= 2; if (space < 1) break; -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/41999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Idd3e6145682e276abb9bc67029df974197bf8b1b Gerrit-Change-Number: 41999 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in dahdi-linux[master]: dahdi_dummy: Use hrtimer_setup on kernels >= 6.15.0.
by laforge 01 Feb '26

01 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42004?usp=email ) Change subject: dahdi_dummy: Use hrtimer_setup on kernels >= 6.15.0. ...................................................................... dahdi_dummy: Use hrtimer_setup on kernels >= 6.15.0. Kernel commit 908a1d775422ba2e27a5e33d0c130b522419e121 introduced hrtimer_setup to eventually replace hrtimer_init, which was done in kernel commit 9779489a31d77a7b9cb6f20d2d2caced4e29dbe6. Accordingly, we now use the new setup process on newer kernels. Resolves: #93 Change-Id: Ied0bdb1e32c30cff9208fd181efe7f494e230964 --- M drivers/dahdi/dahdi_dummy.c 1 file changed, 5 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/04/42004/1 diff --git a/drivers/dahdi/dahdi_dummy.c b/drivers/dahdi/dahdi_dummy.c index b1004d9..44cd3ba 100644 --- a/drivers/dahdi/dahdi_dummy.c +++ b/drivers/dahdi/dahdi_dummy.c @@ -229,12 +229,14 @@ #if defined(USE_HIGHRESTIMER) printk(KERN_DEBUG "dahdi_dummy: Trying to load High Resolution Timer\n"); +#if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 15, 0) + hrtimer_setup(&zaptimer, dahdi_dummy_hr_int, CLOCK_MONOTONIC, HRTIMER_MODE_REL); +#else hrtimer_init(&zaptimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL); - printk(KERN_DEBUG "dahdi_dummy: Initialized High Resolution Timer\n"); - /* Set timer callback function */ zaptimer.function = dahdi_dummy_hr_int; - +#endif /* LINUX_VERSION_CODE */ + printk(KERN_DEBUG "dahdi_dummy: Initialized High Resolution Timer\n"); printk(KERN_DEBUG "dahdi_dummy: Starting High Resolution Timer\n"); hrtimer_start(&zaptimer, ktime_set(0, DAHDI_TIME_NS), HRTIMER_MODE_REL); printk(KERN_INFO "dahdi_dummy: High Resolution Timer started, good to go\n"); -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: Ied0bdb1e32c30cff9208fd181efe7f494e230964 Gerrit-Change-Number: 42004 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

[M] Change in dahdi-linux[master]: disable loader for the hardware echo canceller as it breaks on >= 6.15
by laforge 01 Feb '26

01 Feb '26

laforge has uploaded this change for review. ( https://gerrit.osmocom.org/c/dahdi-linux/+/42002?usp=email ) Change subject: disable loader for the hardware echo canceller as it breaks on >= 6.15 ...................................................................... disable loader for the hardware echo canceller as it breaks on >= 6.15 Temporary disable loader for the hardware echo canceler on systems with modern kernels. Since Kernel 6.15 (https://github.com/torvalds/linux/commit/0b10177114d1e434af850b377cf5e6620d…) all objtool failures are fatal and linking dahdi_vpmadt032_loader.o fails: https: //github.com/asterisk/dahdi-linux/issues/80 https: //github.com/asterisk/dahdi-linux/issues/97 Change-Id: I85ca443e98ce7f289a9207172407ca03cead8e90 --- M drivers/dahdi/Kbuild 1 file changed, 31 insertions(+), 31 deletions(-) git pull ssh://gerrit.osmocom.org:29418/dahdi-linux refs/changes/02/42002/1 diff --git a/drivers/dahdi/Kbuild b/drivers/dahdi/Kbuild index 4d05f12..48a4d58 100644 --- a/drivers/dahdi/Kbuild +++ b/drivers/dahdi/Kbuild @@ -135,40 +135,40 @@ # VPMADT032 Loader ############################################################################### -dahdi_vpmadt032_loader-objs := vpmadt032_loader/dahdi_vpmadt032_loader.o - -ifneq ($(DAHDI_ARCH),) - ifneq ($(wildcard $(src)/vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o_shipped),) - $(shell touch $(KBUILD_EXTMOD)/vpmadt032_loader/.vpmadt032_$(DAHDI_ARCH).o.cmd) - VPMADT032_LOADER_PRESENT=yes - dahdi_vpmadt032_loader-objs += vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o - obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_VPMADT032_LOADER) += dahdi_vpmadt032_loader.o - endif -endif - -# FIXME: This workaround should not be necessary, but for some reason the rule -# '$(obj)/%: $(src)/%_shipped' from linux.git scripts/Makefile.lib doesn't -# cover this anymore. -vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o: $(src)/vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o_shipped - $(call cmd,copy) - +#dahdi_vpmadt032_loader-objs := vpmadt032_loader/dahdi_vpmadt032_loader.o +# +#ifneq ($(DAHDI_ARCH),) +# ifneq ($(wildcard $(src)/vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o_shipped),) +# $(shell touch $(KBUILD_EXTMOD)/vpmadt032_loader/.vpmadt032_$(DAHDI_ARCH).o.cmd) +# VPMADT032_LOADER_PRESENT=yes +# dahdi_vpmadt032_loader-objs += vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o +# obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_VPMADT032_LOADER) += dahdi_vpmadt032_loader.o +# endif +#endif +# +## FIXME: This workaround should not be necessary, but for some reason the rule +## '$(obj)/%: $(src)/%_shipped' from linux.git scripts/Makefile.lib doesn't +## cover this anymore. +#vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o: $(src)/vpmadt032_loader/vpmadt032_$(DAHDI_ARCH).o_shipped +# $(call cmd,copy) +# ############################################################################### # HPEC Support ############################################################################### - -dahdi_echocan_hpec-objs := hpec/dahdi_echocan_hpec.o -CFLAGS_dahdi_echocan_hpec.o := -I$(src)/hpec - -ifneq ($(DAHDI_ARCH),) - ifneq ($(wildcard $(src)/hpec/hpec_$(DAHDI_ARCH).o_shipped),) - HPEC_PRESENT=yes - dahdi_echocan_hpec-objs += hpec/hpec_$(DAHDI_ARCH).o - endif -endif - -ifeq ($(HPEC_PRESENT),yes) -obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_ECHOCAN_HPEC) += dahdi_echocan_hpec.o -endif +# +#dahdi_echocan_hpec-objs := hpec/dahdi_echocan_hpec.o +#CFLAGS_dahdi_echocan_hpec.o := -I$(src)/hpec +# +#ifneq ($(DAHDI_ARCH),) +# ifneq ($(wildcard $(src)/hpec/hpec_$(DAHDI_ARCH).o_shipped),) +# HPEC_PRESENT=yes +# dahdi_echocan_hpec-objs += hpec/hpec_$(DAHDI_ARCH).o +# endif +#endif +# +#ifeq ($(HPEC_PRESENT),yes) +#obj-$(DAHDI_BUILD_ALL)$(CONFIG_DAHDI_ECHOCAN_HPEC) += dahdi_echocan_hpec.o +#endif hostprogs-y := makefw -- To view, visit https://gerrit.osmocom.org/c/dahdi-linux/+/42002?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: dahdi-linux Gerrit-Branch: master Gerrit-Change-Id: I85ca443e98ce7f289a9207172407ca03cead8e90 Gerrit-Change-Number: 42002 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <laforge(a)osmocom.org>

1 0

2026

2025

2024

2023

2022

gerrit-log February 2026