lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: refactor and cleanup tcap state
by pespin 12 Nov '26

12 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email ) Change subject: tcap_as_loadshare: refactor and cleanup tcap state ...................................................................... Patch Set 2: Code-Review+1 (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/cf237d52_52285… : PS1, Line 1101: /** Remove an ASP from TCAP loadsharing. Also called when ASP FSM goes down (IPA disconnect) > In general I agree, but in the end, as long we suspect an 1:1 mapping between AS and ASPs, the code […] Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Nov 2026 15:10:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: refactor and cleanup tcap state
by lynxis 12 Nov '26

12 Nov '26
Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tcap_as_loadshare: refactor and cleanup tcap state ...................................................................... tcap_as_loadshare: refactor and cleanup tcap state Ensures also static configured ASP will reset its TCAP state, when the IPA connection goes down. Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 --- M src/tcap_as_loadshare.c M src/tcap_as_loadshare.h M src/xua_asp_fsm.c 3 files changed, 33 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/03/44003/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: fix typo in comment
by lynxis 12 Nov '26

12 Nov '26
Attention is currently required from: lynxis. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44004?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: tcap_as_loadshare: fix typo in comment ...................................................................... tcap_as_loadshare: fix typo in comment Change-Id: I5feb805cc609c55adc1bb31b4b3479e1005959e3 --- M src/tcap_as_loadshare.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/04/44004/2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44004?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I5feb805cc609c55adc1bb31b4b3479e1005959e3 Gerrit-Change-Number: 44004 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[M] Change in libosmo-sigtran[master]: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN
by lynxis 12 Nov '26

12 Nov '26
Attention is currently required from: pespin. Hello Jenkins Builder, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN ...................................................................... tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN With MT_TID_ACCEPT_NEW_TRANS a TCAP loadsharing ASP can control if it receives new TCAP transactions (TCAP Begin messages). When disabled, a TCAP loadsharing ASP will still receive TCAP transaction inside their TCAP range as well transaction associated via transaction tracking. Related: SYS#8283 Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 --- M src/ss7_asp.c M src/ss7_asp.h M src/tcap_as_loadshare.c M src/tcap_as_loadshare.h M src/tcap_as_loadshare_vty.c 5 files changed, 101 insertions(+), 7 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/99/43999/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 Gerrit-Change-Number: 43999 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" fea...
by lynxis 12 Nov '26

12 Nov '26
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email ) Change subject: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" feature ...................................................................... Patch Set 1: (4 comments) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/5c42d9d3_c763… : PS1, Line 467: private function f_tcap_loadshare_register_new_trans( > This function looks like a "let's put a single function I could call twice into one more complex one […] I don't get it. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/e60048c6_d23c… : PS1, Line 1074: testcase TC_tcap_loadshare_ipa_tcap_new_trans_register() runs on TCAP_CT { > AFAIU this test is a subset of the one below, so we can probably remove it. Yes, this is a part of another tests. But I like to test the basics before going into complex testing. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/ede48dc3_8b00… : PS1, Line 1109: var integer dtid := ((rand_tid + i) mod 99); > why the mod 99 here? isn't that directly routing the packets to the "new_trans true" ASP? Because the dtid should be in the range of `asp-ipa-loadshare-0-0`. Even it is also supported to not have it, this is closer to the actual use case of this feature. Having it outside of the planed range could be also a useful test as well dtid > 299 https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/74c96210_9bd3… : PS1, Line 1111: f_asp_tx_tcap_m3ua_ipa_transaction(0, 2, int2oct(otid, 4), int2oct(dtid, 4)); > It would be great to test also from tcap_asps[1] ("asp-m3ua-loadshare-0-1"). Ok, but this test is only doing an incoming test -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I948e95e66bdafadf01020e9e97ac50a04b78ec50 Gerrit-Change-Number: 44005 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Nov 2026 13:32:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in libosmo-sigtran[master]: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN
by lynxis 12 Nov '26

12 Nov '26
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email ) Change subject: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN ...................................................................... Patch Set 2: (5 comments) File src/ss7_asp.h: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/b7d1730f_8a7fd… : PS2, Line 108: /* is this ASP is available for new TCAP sessions (Begin) */ > "is this ASP available" or "Whether this ASP is available" Done File src/ss7_asp.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/c6a55b2b_ba006… : PS2, Line 782: #ifdef WITH_TCAP_LOADSHARING > I'd prefer having a default "prohibit_new_trans = false" or "new_incoming_trans_blocked" or similar, […] If you think it's more readable. I move the single line into a function. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/41969130_078f1… : PS2, Line 985: goto out; > aren't we missing a Tx NACK here? yes, but actually we need to fix this in general. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/35b3e66a_88dad… : PS2, Line 990: asp->tcap.enabled = true; > enabled should be done by ADD_RANGE like before imho? […] It depends how you would like to use this feature. IMHO: I can argue for both cases. Do you want to have TCAP nodes without a range? Because with the trasaction tracking this also works. https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/bc3cadfc_08990… : PS2, Line 993: LOGPASP(asp, DLTCAP, LOGL_INFO, "TCAP New transaction command: ASP will receive new TCAP transactions\n"); > multiple lines Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 Gerrit-Change-Number: 43999 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Nov 2026 13:12:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: reset tcap.enabled after cleaning ASP up
by lynxis 12 Nov '26

12 Nov '26
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email ) Change subject: tcap_as_loadshare: reset tcap.enabled after cleaning ASP up ...................................................................... Patch Set 1: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/6d130d30_ceb9c… : PS1, Line 1101: /** Remove an ASP from TCAP loadsharing. Also called when ASP FSM goes down (IPA disconnect) > This should be strictly called when "An AS becomes dissassociated from an ASP, ie. […] In general I agree, but in the end, as long we suspect an 1:1 mapping between AS and ASPs, the code path is the same. Maybe we can discuss this via jitsi? -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Nov 2026 12:48:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[L] Change in osmo-ttcn3-hacks[master]: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases
by dexter 12 Nov '26

12 Nov '26
Attention is currently required from: jolly, laforge, pespin. Hello Jenkins Builder, jolly, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email to look at the new patch set (#11). The following approvals got outdated and were removed: Code-Review+1 by jolly, Verified+1 by Jenkins Builder Change subject: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases ...................................................................... eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases GSMA SGP.33-3 describes a number of testcases. Let's pick a subset of useful testcases and add those to the testsuite. Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e Related: SYS#8203 --- M eim/eIM_Tests.ttcn M eim/prepare.sh 2 files changed, 731 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/04/43904/11 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e Gerrit-Change-Number: 43904 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de>
1 0
0 0
[L] Change in osmo-ttcn3-hacks[master]: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases
by dexter 12 Nov '26

12 Nov '26
Attention is currently required from: jolly, laforge, pespin. dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email ) Change subject: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases ...................................................................... Patch Set 11: (1 comment) File eim/eIM_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904/comment/d4608523_99ef… : PS7, Line 1241: private function f_TC_eIM_AuthenticateClient_ErrorCases_Error_Invalid_SM_DPp_pb_certificate(charstring id) > I suggest to do some preperation (called by testenv), like this: […] Thanks. I have now added such a re-alignmant to prepare.sh with this patch. So now the patch should pass all the TTCN3 tests. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e Gerrit-Change-Number: 43904 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Nov 2026 12:33:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: jolly <andreas(a)eversberg.eu> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>
1 0
0 0
[L] Change in onomondo-eim[master]: contrib/sample_ssl_certs: add scripts to generate SSL certificates
by jolly 12 Nov '26

12 Nov '26
Attention is currently required from: dexter, laforge. jolly has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/44033?usp=email ) Change subject: contrib/sample_ssl_certs: add scripts to generate SSL certificates ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/44033?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ie75293e5177ccacc45e11d85ef526159e999b7bb Gerrit-Change-Number: 44033 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Nov 2026 10:09:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 38
  • 39
  • 40
  • 41
  • 42
  • 43
  • 44
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.