[M] Change in osmo-ttcn3-hacks[master]: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" fea...
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email ) Change subject: stp: STP_Tests_TCAP: add TC to test the "accept new transactions" feature ...................................................................... Patch Set 1: (4 comments) File stp/STP_Tests_TCAP.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/5c42d9d3_c763f... : PS1, Line 467: private function f_tcap_loadshare_register_new_trans(
This function looks like a "let's put a single function I could call twice into one more complex one […] I don't get it.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/e60048c6_d23c9... : PS1, Line 1074: testcase TC_tcap_loadshare_ipa_tcap_new_trans_register() runs on TCAP_CT {
AFAIU this test is a subset of the one below, so we can probably remove it. Yes, this is a part of another tests. But I like to test the basics before going into complex testing.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/ede48dc3_8b005... : PS1, Line 1109: var integer dtid := ((rand_tid + i) mod 99);
why the mod 99 here? isn't that directly routing the packets to the "new_trans true" ASP? Because the dtid should be in the range of `asp-ipa-loadshare-0-0`. Even it is also supported to not have it, this is closer to the actual use case of this feature. Having it outside of the planed range could be also a useful test as well dtid > 299
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005/comment/74c96210_9bd36... : PS1, Line 1111: f_asp_tx_tcap_m3ua_ipa_transaction(0, 2, int2oct(otid, 4), int2oct(dtid, 4));
It would be great to test also from tcap_asps[1] ("asp-m3ua-loadshare-0-1"). Ok, but this test is only doing an incoming test
-- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44005?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I948e95e66bdafadf01020e9e97ac50a04b78ec50 Gerrit-Change-Number: 44005 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Nov 2026 13:32:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de>
participants (1)
-
lynxis