lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[XS] Change in osmo-ttcn3-hacks[master]: pcu: fix TC_n3103_max_t3169 and TC_n3105_max_t3195
by osmith 13 Nov '26

13 Nov '26
Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44067?usp=email ) Change subject: pcu: fix TC_n3103_max_t3169 and TC_n3105_max_t3195 ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I079421b85460c43754c0b5b5e3b8ed92cf95fc31 Gerrit-Change-Number: 44067 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Nov 2026 08:21:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: library: fix [T.running] T.timeout alt guards
by osmith 13 Nov '26

13 Nov '26
Attention is currently required from: fixeria. osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44066?usp=email ) Change subject: library: fix [T.running] T.timeout alt guards ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I263fe10359dc81e1fcf68690930bad7941ad3174 Gerrit-Change-Number: 44066 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 13 Nov 2026 08:20:48 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: pcu: fix TC_n3103_max_t3169 and TC_n3105_max_t3195
by pespin 12 Nov '26

12 Nov '26
Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44067?usp=email ) Change subject: pcu: fix TC_n3103_max_t3169 and TC_n3105_max_t3195 ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I079421b85460c43754c0b5b5e3b8ed92cf95fc31 Gerrit-Change-Number: 44067 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Nov 2026 19:35:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: library: fix [T.running] T.timeout alt guards
by pespin 12 Nov '26

12 Nov '26
Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44066?usp=email ) Change subject: library: fix [T.running] T.timeout alt guards ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I263fe10359dc81e1fcf68690930bad7941ad3174 Gerrit-Change-Number: 44066 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 12 Nov 2026 19:34:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: library: fix [T.running] T.timeout alt guards
by fixeria 12 Nov '26

12 Nov '26
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44066?usp=email ) Change subject: library: fix [T.running] T.timeout alt guards ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I263fe10359dc81e1fcf68690930bad7941ad3174 Gerrit-Change-Number: 44066 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 12 Nov 2026 16:43:57 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: pcu: fix TC_n3103_max_t3169 and TC_n3105_max_t3195
by fixeria 12 Nov '26

12 Nov '26
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44067?usp=email ) Change subject: pcu: fix TC_n3103_max_t3169 and TC_n3105_max_t3195 ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I079421b85460c43754c0b5b5e3b8ed92cf95fc31 Gerrit-Change-Number: 44067 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Thu, 12 Nov 2026 16:43:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: pcu: fix TC_n3103_max_t3169 and TC_n3105_max_t3195
by fixeria 12 Nov '26

12 Nov '26
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44067?usp=email ) Change subject: pcu: fix TC_n3103_max_t3169 and TC_n3105_max_t3195 ...................................................................... pcu: fix TC_n3103_max_t3169 and TC_n3105_max_t3195 Both tests rely on [T.running] T.timeout to leave the alt, which can never match since TITAN 11.2.0 re-evaluates guards on every snapshot (see titan.core commit 4ca840ba5, #747). The tests then loop on dummy/empty blocks until T_guard expires. Drop the redundant guards. Change-Id: I079421b85460c43754c0b5b5e3b8ed92cf95fc31 Fixes: OS#7109 --- M pcu/PCU_Tests.ttcn 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/67/44067/1 diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 98fbbf6..c5db98a 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1673,7 +1673,7 @@ } [] as_ms_rx_ignore_dummy(ms, nr); [] as_pcuif_rx_ignore_empty(nr); - [T_3169.running] T_3169.timeout { + [] T_3169.timeout { log("T_3169 timeout"); /* Done in alt, wait for pending RTS initiated previously in * above case before continuing (expect /* Dummy block): */ @@ -2055,7 +2055,7 @@ /* We may already receive idle blocks before our own TTCN3 timer * triggers due to the TBF being released. Keep going until our T_3195 triggers. */ [N3105 == N3105_MAX] as_pcuif_rx_ignore_empty(nr); - [T_3195.running] T_3195.timeout { + [] T_3195.timeout { log("T_3195 timeout"); /* Done in alt, wait for pending RTS initiated previously in * above case before continuing (expect empty block): */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44067?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I079421b85460c43754c0b5b5e3b8ed92cf95fc31 Gerrit-Change-Number: 44067 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: library: fix [T.running] T.timeout alt guards
by fixeria 12 Nov '26

12 Nov '26
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44066?usp=email ) Change subject: library: fix [T.running] T.timeout alt guards ...................................................................... library: fix [T.running] T.timeout alt guards Since titan.core commit 4ca840ba5 ("Fixed alts and altsteps to re- evaluate guard expressions and variable initial values after every new snapshot", #747), first released in 11.2.0, boolean guards are re-evaluated on every snapshot. TIMER::running() uses the current time, while TIMER::timeout() uses the snapshot time, so as soon as the timer expires the guard [T.running] becomes false and the T.timeout branch can never be selected. The guard is redundant anyway: the timeout operation on a timer that is not running simply does not match. Remove it. Change-Id: I263fe10359dc81e1fcf68690930bad7941ad3174 --- M bts/BTS_Tests.ttcn M library/BSSGP_Emulation.ttcnpp M library/NS_Emulation.ttcnpp 3 files changed, 6 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/66/44066/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index c9aff76..cd77e3a 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2431,7 +2431,7 @@ [] RSL.receive(tr_RSL_MEAS_RES(?)) -> value rsl { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Received unexpected MEAS RES ", rsl)); } - [g_Tmeas_exp.running] g_Tmeas_exp.timeout { + [] g_Tmeas_exp.timeout { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, "Didn't receive expected measurement result") } } diff --git a/library/BSSGP_Emulation.ttcnpp b/library/BSSGP_Emulation.ttcnpp index d01c7a2..371eecf 100644 --- a/library/BSSGP_Emulation.ttcnpp +++ b/library/BSSGP_Emulation.ttcnpp @@ -459,7 +459,7 @@ } } } - [g_T2.running] g_T2.timeout { + [] g_T2.timeout { setverdict(fail, "Timeout waiting for BVC-RESET-ACK on BVCI=0"); BSCP.send(f_BnsUdReq(ts_BSSGP_STATUS(udi.bvci, BSSGP_CAUSE_BVCI_UNKNOWN, udi.bssgp), 0, 0)); g_T2.start; @@ -1115,10 +1115,10 @@ f_ptp_change_state(BVC_S_BLOCKED); } /* Re-transmit BLOCK / UNBLOCK on T1 timeout */ - [g_T1.running and not g_t1_waits_for_block_ack] g_T1.timeout { + [not g_t1_waits_for_block_ack] g_T1.timeout { f_ptp_sendUnblock(); } - [g_T1.running and g_t1_waits_for_block_ack] g_T1.timeout { + [g_t1_waits_for_block_ack] g_T1.timeout { f_ptp_sendBlock(g_last_block_cause); } diff --git a/library/NS_Emulation.ttcnpp b/library/NS_Emulation.ttcnpp index 0ed022a..d1700f8 100644 --- a/library/NS_Emulation.ttcnpp +++ b/library/NS_Emulation.ttcnpp @@ -781,13 +781,13 @@ } /* transition to DEAD if t_alive times out */ - [Tns_alive.running] Tns_alive.timeout { + [] Tns_alive.timeout { log("Tns-alive expired: changing to DEAD_BLOCKED + starting Tns-test"); f_change_state(NSVC_S_DEAD_BLOCKED); Tns_test.start; } - [Tns_test.running] Tns_test.timeout { + [] Tns_test.timeout { log("Tns-test expired: sending NS-ALIVE"); f_sendAlive(); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44066?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I263fe10359dc81e1fcf68690930bad7941ad3174 Gerrit-Change-Number: 44066 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: refactor and cleanup tcap state
by pespin 12 Nov '26

12 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email ) Change subject: tcap_as_loadshare: refactor and cleanup tcap state ...................................................................... Patch Set 2: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/6a243d59_09005… : PS2, Line 1112: void tcap_asp_down(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp) This is IMHO wrong: The asp_down should not have a specific AS being passed. Because the ASP state only changes independently of ASs. Hence, remove the "as" param here, and in tcap_cleanup_state(), change the logic to iterare over all ASs of an ASP when the param as=NULL is passed. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Nov 2026 15:18:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[M] Change in libosmo-sigtran[master]: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN
by pespin 12 Nov '26

12 Nov '26
Attention is currently required from: lynxis. pespin has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email ) Change subject: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN ...................................................................... Patch Set 3: (4 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/e39eedee_745c1… : PS2, Line 985: goto out; > yes, but actually we need to fix this in general. What do you mean? why not sending it here? https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/97984f87_427a1… : PS2, Line 990: asp->tcap.enabled = true; > It depends how you would like to use this feature. […] I'd leave it as before and simply add a new message which can be sent before enabling it, this follows better backward compatibility imho. File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/e655ef4d_88262… : PS3, Line 264: assoc->asp->tcap.enabled && assoc->asp->tcap.accept_new_trans) Please put the added condition into a new line. File src/tcap_as_loadshare_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/92983017_cfaa3… : PS3, Line 161: if (!assoc->asp->tcap.enabled || !osmo_ss7_asp_active(assoc->asp)) it probably makes sense to also print the inactive ones and add a column which prints "ACTIVE" | "INACT" (have a look at already existing vty show commands to use same terminology). -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 Gerrit-Change-Number: 43999 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Thu, 12 Nov 2026 15:16:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis <lynxis(a)fe80.eu>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 37
  • 38
  • 39
  • 40
  • 41
  • 42
  • 43
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.