lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[M] Change in libosmo-sigtran[master]: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN
by lynxis 17 Nov '26

17 Nov '26
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email ) Change subject: tcap_as_loadshare: add TCAP IPA MT_TID_ACCEPT_NEW_TRAN ...................................................................... Patch Set 4: (2 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/4ceb498e_c9979… : PS2, Line 985: goto out; > Ok, do you mind submitting an extra patch fixing it? I added another commit. File src/tcap_as_loadshare_vty.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999/comment/20692938_5ea4c… : PS3, Line 161: if (!assoc->asp->tcap.enabled || !osmo_ss7_asp_active(assoc->asp)) > Then if there's can't be an inactive ASP, why doing the call to "!osmo_ss7_asp_active(assoc->asp)" ? I don't know, how we handle the different states. When a ASP is down and when it's inactive and when it's removed. But at least here only active ASP should be considered to receive traffic. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43999?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Id4e7bb022a0c8b52369f6ded2729cf6cf8679556 Gerrit-Change-Number: 43999 Gerrit-PatchSet: 4 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 15:54:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: refactor and cleanup tcap state
by lynxis 17 Nov '26

17 Nov '26
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email ) Change subject: tcap_as_loadshare: refactor and cleanup tcap state ...................................................................... Patch Set 2: (2 comments) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/9e7b7ff9_819d6… : PS2, Line 1112: void tcap_asp_down(struct osmo_ss7_as *as, struct osmo_ss7_asp *asp) > ACK, but still from API/event point of view, this looks like the wrong approach imho. […] I implemented it differently. I don't agree with you about having a function with an optional AS ptr and you loop over all AS. File src/xua_asp_fsm.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003/comment/ee1392ef_18518… : PS2, Line 472: tcap_asp_down(as, asp); > Move this block above outside the llist_for_each_entry_safe() loop. Done -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I4c748eb0fab83e0198637101a890ae4094e50116 Gerrit-Change-Number: 44003 Gerrit-PatchSet: 2 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 15:50:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: lynxis <lynxis(a)fe80.eu>
1 0
0 0
[XS] Change in libosmocore[master]: tests/socket: Fix typo in assert
by osmith 17 Nov '26

17 Nov '26
Attention is currently required from: fixeria, laforge, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/44097?usp=email ) Change subject: tests/socket: Fix typo in assert ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id4c52478b15ae6d518b88aa8e25b5c629017860f Gerrit-Change-Number: 44097 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 15:38:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: sepp: Adapt to newer open5gs behavior
by osmith 17 Nov '26

17 Nov '26
Attention is currently required from: fixeria, pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email ) Change subject: sepp: Adapt to newer open5gs behavior ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93f7cb08bd2c68005835fc25ec47858db4fa85ab Gerrit-Change-Number: 44095 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 15:38:03 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmocore[master]: tests/socket: Fix typo in assert
by pespin 17 Nov '26

17 Nov '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/44097?usp=email ) Change subject: tests/socket: Fix typo in assert ...................................................................... tests/socket: Fix typo in assert Related: Coverity CID#566068 Fixes: f485047b5704d8a67df71a96bc0f0838130e8657 Change-Id: Id4c52478b15ae6d518b88aa8e25b5c629017860f --- M tests/socket/socket_test.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/97/44097/1 diff --git a/tests/socket/socket_test.c b/tests/socket/socket_test.c index ed315b3..a103db5 100644 --- a/tests/socket/socket_test.c +++ b/tests/socket/socket_test.c @@ -463,7 +463,7 @@ rc = osmo_sockaddr_pton("0.0.0.0", sa); OSMO_ASSERT(rc == 1); - OSMO_ASSERT(osa.u.sa.sa_family = AF_INET); + OSMO_ASSERT(osa.u.sa.sa_family == AF_INET); OSMO_ASSERT(osa.u.sin.sin_addr.s_addr == 0); rc = osmo_sockaddr_pton("255.255.255.255", sa); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id4c52478b15ae6d518b88aa8e25b5c629017860f Gerrit-Change-Number: 44097 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: sepp: Adapt to newer open5gs behavior
by pespin 17 Nov '26

17 Nov '26
Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, osmith, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Verified+1 by Jenkins Builder Change subject: sepp: Adapt to newer open5gs behavior ...................................................................... sepp: Adapt to newer open5gs behavior We should let the SEPP register with the NRF before attempting to negoatiate with it. Add a specific test to check the scenario when negotiating is done without prior NRF registering. Also, since SEPP may not re-register later on again with NRF once it was already registered, Make the NRF handling path in f_TC_security_cap_negotiation_server() optional. Related: https://github.com/open5gs/open5gs/pull/4985#issuecomment-6916101644 Change-Id: I93f7cb08bd2c68005835fc25ec47858db4fa85ab --- M sepp/ConnHdlr.ttcn M sepp/SEPP_Tests.ttcn M sepp/expected-results.xml 3 files changed, 46 insertions(+), 12 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/95/44095/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93f7cb08bd2c68005835fc25ec47858db4fa85ab Gerrit-Change-Number: 44095 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: sepp: Adapt to newer open5gs behavior
by pespin 17 Nov '26

17 Nov '26
Attention is currently required from: fixeria, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email ) Change subject: sepp: Adapt to newer open5gs behavior ...................................................................... Patch Set 1: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095/comment/a34d392d_0d2f… : PS1, Line 9: SEEP > SEPP? Done File sepp/SEPP_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095/comment/a5a8f194_b5c8… : PS1, Line 159: shoulds > ```suggestion […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93f7cb08bd2c68005835fc25ec47858db4fa85ab Gerrit-Change-Number: 44095 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 15:33:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: RemSIM/server: Add test to verify maintenance mapping
by jolly 17 Nov '26

17 Nov '26
Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43838?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: RemSIM/server: Add test to verify maintenance mapping ...................................................................... RemSIM/server: Add test to verify maintenance mapping While have a regular mapping, add a maintenance mapping to a different client but to the same bank/slot. Expect the regular mapping to be suspended while the maintenance mapping exist. After maintenance mapping is deleted, expect the regular mapping to be resumed. Related: SYS#8159 Change-Id: I091dfe999b5b3473c67d6874ca31d238ee75b70e --- M remsim/RSRES.ttcn M remsim/RemsimServer_Tests.ttcn 2 files changed, 142 insertions(+), 13 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/38/43838/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43838?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I091dfe999b5b3473c67d6874ca31d238ee75b70e Gerrit-Change-Number: 43838 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: ipad: Fix sporadic test failures
by jolly 17 Nov '26

17 Nov '26
Attention is currently required from: jolly. Hello Jenkins Builder, dexter, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44096?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: ipad: Fix sporadic test failures ...................................................................... ipad: Fix sporadic test failures After ipad has retrieved data from SIM card, it request package from eIM. Therefore the test case registers an HTTP server to receive the package request: f_es10x_init(); <- SIM card process f_http_register(); <- HTTP server registration This leads to a race condition, where the HTTP server emulation is partly initialized, while the request is received. This results in dropping the received request. It is not forwarded and the testsuite times out. The solution is to register the HTTP server before the ipad is started and is retrieving data from SIM card. This test could be reproduced by delaying the HTTP server initialization. Change-Id: I3693352dca648de910f15cdda2e16f618452c8db --- M ipad/IPAd_Tests.ttcn 1 file changed, 10 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/96/44096/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3693352dca648de910f15cdda2e16f618452c8db Gerrit-Change-Number: 44096 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: RemSIM/server: Expand maintenance mapping test with timeout
by jolly 17 Nov '26

17 Nov '26
Attention is currently required from: fixeria, jolly. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43839?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: RemSIM/server: Expand maintenance mapping test with timeout ...................................................................... RemSIM/server: Expand maintenance mapping test with timeout Expand the previous test by adding a timeout. Instead of removing the maintenance mapping via REST API, wait until timeout and expect the mapping to be removed automatically. Related: SYS#8159 Change-Id: Iab27eb51ef51fafc2cdef8aee7dc96892fb613fd --- M remsim/RemsimServer_Tests.ttcn 1 file changed, 26 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/39/43839/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43839?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iab27eb51ef51fafc2cdef8aee7dc96892fb613fd Gerrit-Change-Number: 43839 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 19
  • 20
  • 21
  • 22
  • 23
  • 24
  • 25
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.