lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[XS] Change in libosmocore[master]: tests: Run tuak_test in the testsuite
by Josh Shilts 16 Nov '26

16 Nov '26
Josh Shilts has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/44092?usp=email ) Change subject: tests: Run tuak_test in the testsuite ...................................................................... tests: Run tuak_test in the testsuite tests/auth/tuak_test is built and has a .ok file, but testsuite.at had no entry for it since the test was added in 8bd9d5d7, so make check never ran it. Change-Id: I88ef855377108df9868fba29f7cd5783eb445f31 --- M tests/testsuite.at 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/92/44092/1 diff --git a/tests/testsuite.at b/tests/testsuite.at index aec8747..b17c5da 100644 --- a/tests/testsuite.at +++ b/tests/testsuite.at @@ -131,6 +131,12 @@ AT_CHECK([$abs_top_builddir/tests/auth/xor2g_test], [0], [expout], [ignore]) AT_CLEANUP +AT_SETUP([auth_tuak]) +AT_KEYWORDS([auth_tuak]) +cat $abs_srcdir/auth/tuak_test.ok > expout +AT_CHECK([$abs_top_builddir/tests/auth/tuak_test], [0], [expout], [ignore]) +AT_CLEANUP + AT_SETUP([comp128]) AT_KEYWORDS([comp128]) cat $abs_srcdir/comp128/comp128_test.ok > expout -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44092?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I88ef855377108df9868fba29f7cd5783eb445f31 Gerrit-Change-Number: 44092 Gerrit-PatchSet: 1 Gerrit-Owner: Josh Shilts <joshuashilts(a)gmail.com>
1 0
0 0
[M] Change in osmo-gsm-manuals[master]: sigtran-osmocom.adoc: Describe tcap-aware loadshare
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: daniel, lynxis. laforge has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email ) Change subject: sigtran-osmocom.adoc: Describe tcap-aware loadshare ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: @dwillmann@sysmocom.de - ping? This patch is waiting for feedback since august. Please check your patches in gerrit more often -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/42190?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I58979e8f6c5156706b1016069eaaf2801ec9311b Gerrit-Change-Number: 42190 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 16:37:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[M] Change in pysim[master]: pysim-smpp2sim: Add support for a TCP connection through proact channel
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: daniel, lynxis. laforge has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/pysim/+/43093?usp=email ) Change subject: pysim-smpp2sim: Add support for a TCP connection through proact channel ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: can someone (ideally @dwillmann@sysmocom.de possibly with assistance from @pmaier@sysmocom.de) look into the actual problem? It's somewhat sad if we have a patch that has positive code review is stale for almost 4 months -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43093?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Idc1f0c75d89ccd879dc9588b7a0b8688b6f76a66 Gerrit-Change-Number: 43093 Gerrit-PatchSet: 2 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: lynxis <lynxis(a)fe80.eu> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 16:36:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: ggsn: Accept deletePDPContextRequest for dangling contexts from ggsn
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: daniel, fixeria, lynxis. laforge has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44022?usp=email ) Change subject: ggsn: Accept deletePDPContextRequest for dangling contexts from ggsn ...................................................................... Patch Set 1: Code-Review-1 (1 comment) Patchset: PS1: > If those tests failing is acceptable, then those tests should be reworked to tear down resources cle […] I agree. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44022?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I1116c8e7a9640003458f837fe8f948cfe55fd6c9 Gerrit-Change-Number: 44022 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: lynxis <lynxis(a)fe80.eu> Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: daniel <dwillmann(a)sysmocom.de> Gerrit-Attention: lynxis <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 16 Nov 2026 16:33:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
1 0
0 0
[L] Change in osmo-ttcn3-hacks[master]: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: dexter, jolly, pespin. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email ) Change subject: eIM_Tests: add a subset of SGP.33-3/SGP.23 testcases ...................................................................... Patch Set 11: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ide8fdec56eca4d4577baedfacd2a6a675d9c0e6e Gerrit-Change-Number: 43904 Gerrit-PatchSet: 11 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Nov 2026 16:28:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-netif[master]: stream_cli: fix this API for AF_UNIX sockets
by laforge 16 Nov '26

16 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/44065?usp=email ) Change subject: stream_cli: fix this API for AF_UNIX sockets ...................................................................... stream_cli: fix this API for AF_UNIX sockets Osmocom Stream Client and Server functional layers provided by this library are primarily used for TCP and SCTP over IP, but they also support AF_UNIX local sockets. stream_srv does work for AF_UNIX and has been used successfully in that application, but stream_cli exhibits a bug: it passes both SOCK_F_CONNECT and SOCK_F_BIND to osmo_sock_unix_init(), but having both of these flags set is invalid for the latter API. The correct course is to pass only SOCK_F_CONNECT when initializing an AF_UNIX socket in the client role - fix it. Change-Id: I80e1c697377946ee93cb2939ab7e8914deb824f9 --- M src/stream_cli.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified pespin: Looks good to me, but someone else must approve diff --git a/src/stream_cli.c b/src/stream_cli.c index a8b5fa6..0f911b7 100644 --- a/src/stream_cli.c +++ b/src/stream_cli.c @@ -1260,7 +1260,7 @@ switch (cli->sk_domain) { case AF_UNIX: - ret = osmo_sock_unix_init(cli->sk_type, 0, cli->addr[0], OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_BIND|OSMO_SOCK_F_NONBLOCK); + ret = osmo_sock_unix_init(cli->sk_type, 0, cli->addr[0], OSMO_SOCK_F_CONNECT|OSMO_SOCK_F_NONBLOCK); break; case AF_INET: case AF_INET6: -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/44065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I80e1c697377946ee93cb2939ab7e8914deb824f9 Gerrit-Change-Number: 44065 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-netif[master]: stream_cli: fix this API for AF_UNIX sockets
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: falconia, fixeria. laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/44065?usp=email ) Change subject: stream_cli: fix this API for AF_UNIX sockets ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/44065?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I80e1c697377946ee93cb2939ab7e8914deb824f9 Gerrit-Change-Number: 44065 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: falconia <falcon(a)freecalypso.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Nov 2026 16:27:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[L] Change in osmo-ttcn3-hacks[master]: Introduce nssf testsuite
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: fixeria, osmith, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44068?usp=email ) Change subject: Introduce nssf testsuite ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44068?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49c271104f668c59ef7d4a010846a16dd169c0a8 Gerrit-Change-Number: 44068 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Nov 2026 16:26:33 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[S] Change in osmo-upf[master]: vty: Use libosmocore defines for IPv4 and IPv6 addresses
by laforge 16 Nov '26

16 Nov '26
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/44091?usp=email ) Change subject: vty: Use libosmocore defines for IPv4 and IPv6 addresses ...................................................................... vty: Use libosmocore defines for IPv4 and IPv6 addresses Change-Id: I25cad316739600dce6c5c31e1a813c614c399f3f --- M src/osmo-pfcp-tool/pfcp_tool_vty.c M src/osmo-upf/upf_vty.c M tests/upf.vty 3 files changed, 13 insertions(+), 12 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/src/osmo-pfcp-tool/pfcp_tool_vty.c b/src/osmo-pfcp-tool/pfcp_tool_vty.c index 7f68ccf..ccaaa8a 100644 --- a/src/osmo-pfcp-tool/pfcp_tool_vty.c +++ b/src/osmo-pfcp-tool/pfcp_tool_vty.c @@ -42,9 +42,9 @@ }; DEFUN(c_local_addr, c_local_addr_cmd, - "local-addr IP_ADDR", + "local-addr " VTY_IPV46_CMD, "Set the local IP address to bind on for PFCP; see also 'listen'\n" - "IP address\n") + "IPv4 address\n" "IPv6 address\n") { if (g_pfcp_tool->ep != NULL) { vty_out(vty, "Already listening on %s%s", diff --git a/src/osmo-upf/upf_vty.c b/src/osmo-upf/upf_vty.c index 5636cbd..1ce6cc0 100644 --- a/src/osmo-upf/upf_vty.c +++ b/src/osmo-upf/upf_vty.c @@ -76,19 +76,18 @@ } DEFUN(cfg_pfcp_local_addr, cfg_pfcp_local_addr_cmd, - "local-addr IP_ADDR", + "local-addr " VTY_IPV46_CMD, "Set the local IP address to bind on for PFCP\n" - "IP address\n") + "IPv4 address\n" "IPv6 address\n") { osmo_talloc_replace_string(g_upf, &pfcp_vty.local_addr, argv[0]); return CMD_SUCCESS; } DEFUN(cfg_pfcp_node_id, cfg_pfcp_node_id_cmd, - "node-id (IP_ADDR|FQDN)", + "node-id (" VTY_IPV4_CMD "|" VTY_IPV6_CMD "|FQDN)", "Set the local Node ID to transmit over PFCP\n" - "IPv4 or IPv6 address\n" - "FQDN\n") + "IPv4 address\n" "IPv6 address\n" "FQDN\n") { osmo_talloc_replace_string(g_upf, &pfcp_vty.node_id, argv[0]); return CMD_SUCCESS; diff --git a/tests/upf.vty b/tests/upf.vty index 88ce626..275e232 100644 --- a/tests/upf.vty +++ b/tests/upf.vty @@ -6,16 +6,18 @@ OsmoUPF(config)# pfcp OsmoUPF(config-pfcp)# list ... - local-addr IP_ADDR - node-id (IP_ADDR|FQDN) + local-addr (A.B.C.D|X:X::X:X) + node-id (A.B.C.D|X:X::X:X|FQDN) OsmoUPF(config-pfcp)# local-addr? local-addr Set the local IP address to bind on for PFCP OsmoUPF(config-pfcp)# local-addr ? - IP_ADDR IP address + A.B.C.D IPv4 address + X:X::X:X IPv6 address OsmoUPF(config-pfcp)# node-id ? node-id - IP_ADDR IPv4 or IPv6 address - FQDN FQDN + A.B.C.D IPv4 address + X:X::X:X IPv6 address + FQDN FQDN OsmoUPF(config-pfcp)# exit OsmoUPF(config)# # ensure its old name "gtp" enters the tunend node -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/44091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I25cad316739600dce6c5c31e1a813c614c399f3f Gerrit-Change-Number: 44091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-upf[master]: vty: Use libosmocore defines for IPv4 and IPv6 addresses
by laforge 16 Nov '26

16 Nov '26
Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-upf/+/44091?usp=email ) Change subject: vty: Use libosmocore defines for IPv4 and IPv6 addresses ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/44091?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I25cad316739600dce6c5c31e1a813c614c399f3f Gerrit-Change-Number: 44091 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 16 Nov 2026 16:26:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 22
  • 23
  • 24
  • 25
  • 26
  • 27
  • 28
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.