lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

November 2026

  • 1 participants
  • 714 discussions
[M] Change in osmo-ttcn3-hacks[master]: sepp: Adapt to newer open5gs behavior
by pespin 17 Nov '26

17 Nov '26
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email ) Change subject: sepp: Adapt to newer open5gs behavior ...................................................................... sepp: Adapt to newer open5gs behavior We should let the SEPP register with the NRF before attempting to negoatiate with it. Add a specific test to check the scenario when negotiating is done without prior NRF registering. Also, since SEPP may not re-register later on again with NRF once it was already registered, Make the NRF handling path in f_TC_security_cap_negotiation_server() optional. Related: https://github.com/open5gs/open5gs/pull/4985#issuecomment-6916101644 Change-Id: I93f7cb08bd2c68005835fc25ec47858db4fa85ab --- M sepp/ConnHdlr.ttcn M sepp/SEPP_Tests.ttcn M sepp/expected-results.xml 3 files changed, 46 insertions(+), 12 deletions(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/sepp/ConnHdlr.ttcn b/sepp/ConnHdlr.ttcn index 8d4a5d0..880b092 100644 --- a/sepp/ConnHdlr.ttcn +++ b/sepp/ConnHdlr.ttcn @@ -220,7 +220,8 @@ } /* 6.1.4.2 Operation: Security Capability Negotiation */ -function f_N32_Handshake_post_sec_cap_neg(template (value) SecurityCapability_enum sec_cap := NONE) +function f_N32_Handshake_post_sec_cap_neg(template (value) SecurityCapability_enum sec_cap := NONE, + integer exp_http2_resp_code := 200) runs on ConnHdlr { var HTTP2_Msg http2_tx; var HTTP2_Msg http2_rx; @@ -236,14 +237,24 @@ f_http2_adapter_connect_send_sepp_n32c(http2_tx, idx := http2_tx.conn_id); /* 3GPP TS 29.521 Table 5.3.2.3.1-3 */ - http2_exp_rx := - tr_HTTP2_Msg(http2_tx.conn_id, - http2_tx.stream_id, - tr_HTTP2_header_block(pseudo_headers := tr_HTTP2_pseudo_headers_Resp(200)), - tr_HTTP2_Data_frame(stream_id := http2_tx.stream_id, - end_stream_flag := true, - data := decmatch tr_SecNegotiateRspData(sender_ := mp_sepp_fqdn_sender, - selectedSecCapability := tr_SecurityCapability(sec_cap)))); + if (exp_http2_resp_code == 200) { /* OK */ + http2_exp_rx := + tr_HTTP2_Msg(http2_tx.conn_id, + http2_tx.stream_id, + tr_HTTP2_header_block(pseudo_headers := tr_HTTP2_pseudo_headers_Resp(200)), + tr_HTTP2_Data_frame(stream_id := http2_tx.stream_id, + end_stream_flag := true, + data := decmatch tr_SecNegotiateRspData(sender_ := mp_sepp_fqdn_sender, + selectedSecCapability := tr_SecurityCapability(sec_cap)))); + } else if (exp_http2_resp_code == 503) { /* Service Unavailable */ + http2_exp_rx := + tr_HTTP2_Msg(http2_tx.conn_id, + http2_tx.stream_id, + tr_HTTP2_header_block(pseudo_headers := tr_HTTP2_pseudo_headers_Resp(503)), + tr_HTTP2_Data_frame(stream_id := http2_tx.stream_id, + end_stream_flag := true, + data := ?)); + } as_http2_adapter_receive(http2_rx, http2_exp_rx, idx := http2_tx.conn_id); f_http2_adapter_close(idx := http2_tx.conn_id); diff --git a/sepp/SEPP_Tests.ttcn b/sepp/SEPP_Tests.ttcn index 8b75273..cd064ab 100644 --- a/sepp/SEPP_Tests.ttcn +++ b/sepp/SEPP_Tests.ttcn @@ -155,7 +155,24 @@ f_shutdown(); } +/* Peer SEPP tries to get IUT serving PLMN list before the IUT registered to its own NRF + * (it gets its PLMN list from there). IUT should answer with 503 Service Unavailable. */ +private function f_TC_security_cap_negotiation_tls_serving_plmn_list_unavailable() runs on ConnHdlr { + f_N32_Handshake_post_sec_cap_neg(TLS, exp_http2_resp_code := 503); + setverdict(pass); +} +testcase TC_security_cap_negotiation_tls_serving_plmn_list_unavailable() runs on MTC_CT { + var ConnHdlr vc_conn; + var ConnHdlrPars pars := f_ConnHdlrPars(0); + f_init(); + vc_conn := f_start_handler(refers(f_TC_security_cap_negotiation_tls_serving_plmn_list_unavailable), pars); + vc_conn.done; + f_shutdown(); +} + private function f_TC_security_cap_negotiation_tls() runs on ConnHdlr { + as_Nnrf_NFM_put_nf_instance(); + as_Nnrf_NFM_get_nf_instances(); f_N32_Handshake_post_sec_cap_neg(TLS); f_N32_Handshake_post_sec_cap_neg(NONE); setverdict(pass); @@ -188,9 +205,13 @@ var HTTP2_Msg http2_rx; var template (present) HTTP2_Msg http2_exp_rx; - as_Nnrf_NFM_put_nf_instance(); - as_Nnrf_NFM_get_nf_instances(); - as_N32_Handshake_post_sec_cap_neg(); + alt { + [] as_Nnrf_NFM_put_nf_instance() { + as_Nnrf_NFM_get_nf_instances(); + repeat; + } + [] as_N32_Handshake_post_sec_cap_neg(); + } /* Test NF sendig data through IUT c-SEPP to our emulated SEPP and back: */ http2_tx := f_n35_prepare_get_authentication_subscription(); @@ -236,6 +257,7 @@ control { execute( TC_security_cap_negotiation_none() ); + execute( TC_security_cap_negotiation_tls_serving_plmn_list_unavailable() ); execute( TC_security_cap_negotiation_tls() ); execute( TC_security_cap_negotiation_prins() ); execute( TC_security_cap_negotiation_server() ); diff --git a/sepp/expected-results.xml b/sepp/expected-results.xml index bd9d091..242936c 100644 --- a/sepp/expected-results.xml +++ b/sepp/expected-results.xml @@ -1,6 +1,7 @@ <?xml version="1.0"?> <testsuite name='Titan' tests='4' failures='0' errors='0' skipped='0' inconc='0' time='MASKED'> <testcase classname='SEPP_Tests' name='TC_security_cap_negotiation_none' time='MASKED'/> + <testcase classname='SEPP_Tests' name='TC_security_cap_negotiation_tls_serving_plmn_list_unavailable' time='MASKED'/> <testcase classname='SEPP_Tests' name='TC_security_cap_negotiation_tls' time='MASKED'/> <testcase classname='SEPP_Tests' name='TC_security_cap_negotiation_prins' time='MASKED'/> <testcase classname='SEPP_Tests' name='TC_security_cap_negotiation_server' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93f7cb08bd2c68005835fc25ec47858db4fa85ab Gerrit-Change-Number: 44095 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmocore[master]: tests/socket: Fix typo in assert
by pespin 17 Nov '26

17 Nov '26
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/44097?usp=email ) Change subject: tests/socket: Fix typo in assert ...................................................................... tests/socket: Fix typo in assert Related: Coverity CID#566068 Fixes: f485047b5704d8a67df71a96bc0f0838130e8657 Change-Id: Id4c52478b15ae6d518b88aa8e25b5c629017860f --- M tests/socket/socket_test.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/tests/socket/socket_test.c b/tests/socket/socket_test.c index ed315b3..a103db5 100644 --- a/tests/socket/socket_test.c +++ b/tests/socket/socket_test.c @@ -463,7 +463,7 @@ rc = osmo_sockaddr_pton("0.0.0.0", sa); OSMO_ASSERT(rc == 1); - OSMO_ASSERT(osa.u.sa.sa_family = AF_INET); + OSMO_ASSERT(osa.u.sa.sa_family == AF_INET); OSMO_ASSERT(osa.u.sin.sin_addr.s_addr == 0); rc = osmo_sockaddr_pton("255.255.255.255", sa); -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id4c52478b15ae6d518b88aa8e25b5c629017860f Gerrit-Change-Number: 44097 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in libosmocore[master]: core/exec: Use close_range() libc API when available
by pespin 17 Nov '26

17 Nov '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/44099?usp=email ) Change subject: core/exec: Use close_range() libc API when available ...................................................................... core/exec: Use close_range() libc API when available Using the libc call (which in turn uses a single system call) is far more efficient. Change-Id: I6589564c406095a1e6584d8c0e65c28594326f31 --- M configure.ac M src/core/exec.c 2 files changed, 15 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/99/44099/1 diff --git a/configure.ac b/configure.ac index cde4446..43bd2c1 100644 --- a/configure.ac +++ b/configure.ac @@ -174,6 +174,11 @@ [[#define _GNU_SOURCE #include <sched.h>]]) +dnl Check whether close_range() is available +AC_CHECK_DECLS([close_range], [], [], + [[#define _GNU_SOURCE + #include <unistd.h>]]) + AC_DEFUN([CHECK_TM_INCLUDES_TM_GMTOFF], [ AC_CACHE_CHECK( [whether struct tm has tm_gmtoff member], diff --git a/src/core/exec.c b/src/core/exec.c index 2d1df82..c87c8cf 100644 --- a/src/core/exec.c +++ b/src/core/exec.c @@ -165,9 +165,17 @@ /* Iterate over files in /proc/self/fd and close all above lst_fd_to_keep */ int osmo_close_all_fds_above(int last_fd_to_keep) { + int rc; + +#if HAVE_DECL_CLOSE_RANGE + rc = close_range(last_fd_to_keep + 1, ~0U, 0); + if (rc) + LOGP(DLGLOBAL, LOGL_ERROR, "Error close_range() fds=[%d..%u]: %s\n", + last_fd_to_keep + 1, ~0U, strerror(errno)); + return 0; +#else struct dirent *ent; DIR *dir; - int rc; dir = opendir("/proc/self/fd"); if (!dir) { @@ -187,6 +195,7 @@ } closedir(dir); return 0; +#endif } /* Seems like POSIX has no header file for this, and even glibc + __USE_GNU doesn't help */ -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I6589564c406095a1e6584d8c0e65c28594326f31 Gerrit-Change-Number: 44099 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-uecups[master]: cups_client: Mark field NULL after destroying it
by pespin 17 Nov '26

17 Nov '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-uecups/+/44098?usp=email ) Change subject: cups_client: Mark field NULL after destroying it ...................................................................... cups_client: Mark field NULL after destroying it We are seeing sporadic crashes around connection teardown, so while this probably doesn't fix the problem, at least may be useful to track if that pointer is reused after either cc or cc->srv are freed. Related: SYS#6997 Change-Id: I014b05a343835b5e401b5e0fb9f8c482bc53bb87 --- M daemon/cups_client.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-uecups refs/changes/98/44098/1 diff --git a/daemon/cups_client.c b/daemon/cups_client.c index a96861f..58f1149 100644 --- a/daemon/cups_client.c +++ b/daemon/cups_client.c @@ -805,6 +805,7 @@ if (cc->srv) { osmo_stream_srv_set_data(cc->srv, NULL); osmo_stream_srv_destroy(cc->srv); + cc->srv = NULL; } talloc_free(cc); } -- To view, visit https://gerrit.osmocom.org/c/osmo-uecups/+/44098?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-uecups Gerrit-Branch: master Gerrit-Change-Id: I014b05a343835b5e401b5e0fb9f8c482bc53bb87 Gerrit-Change-Number: 44098 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: sepp: Adapt to newer open5gs behavior
by fixeria 17 Nov '26

17 Nov '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email ) Change subject: sepp: Adapt to newer open5gs behavior ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44095?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I93f7cb08bd2c68005835fc25ec47858db4fa85ab Gerrit-Change-Number: 44095 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 17:05:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmocore[master]: tests/socket: Fix typo in assert
by fixeria 17 Nov '26

17 Nov '26
Attention is currently required from: laforge, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/44097?usp=email ) Change subject: tests/socket: Fix typo in assert ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/44097?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Id4c52478b15ae6d518b88aa8e25b5c629017860f Gerrit-Change-Number: 44097 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 16:44:17 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: remove outdated counter tcap:asp:failed
by lynxis 17 Nov '26

17 Nov '26
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44086?usp=email ) Change subject: tcap_as_loadshare: remove outdated counter tcap:asp:failed ...................................................................... Patch Set 1: (1 comment) File src/tcap_as_loadshare.c: https://gerrit.osmocom.org/c/libosmo-sigtran/+/44086/comment/32b76b12_b63ab… : PS1, Line 737: rate_ctr_inc2(as->ctrg, SS7_AS_CTR_TCAP_ASP_FALLBACK); > This change looks unrelated? yes should be in the next commit -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44086?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I390cc5b0bd4500ed8f1d674fb13ac5dced5f7c9b Gerrit-Change-Number: 44086 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 16:06:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in libosmo-sigtran[master]: tcap_as_loadshare: fix description of tcap:session:miss
by lynxis 17 Nov '26

17 Nov '26
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44081?usp=email ) Change subject: tcap_as_loadshare: fix description of tcap:session:miss ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > You can simply squash this one in previous commit? You are adding the line there right? No, I renamed the name of the counter in the last commit. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44081?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I193585a7d192df4d0d672578ee09db6655fa9d17 Gerrit-Change-Number: 44081 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 16:05:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in libosmo-sigtran[master]: tcap_as_loadshare: close the ASP connection when receiving an invalid...
by lynxis 17 Nov '26

17 Nov '26
Attention is currently required from: pespin. lynxis has posted comments on this change by lynxis. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/44076?usp=email ) Change subject: tcap_as_loadshare: close the ASP connection when receiving an invalid message ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > I'd rather simply return a NACK or simply drop the packet and log an error... It was requested to work this way to be an unrecoverable error. -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/44076?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iae3d2ebce2e984db497794297696af36ca7f010b Gerrit-Change-Number: 44076 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 17 Nov 2026 16:01:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: ipad: Fix sporadic test failures
by jolly 17 Nov '26

17 Nov '26
jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44096?usp=email ) ( 2 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: ipad: Fix sporadic test failures ...................................................................... ipad: Fix sporadic test failures After ipad has retrieved data from SIM card, it request package from eIM. Therefore the test case registers an HTTP server to receive the package request: f_es10x_init(); <- SIM card process f_http_register(); <- HTTP server registration This leads to a race condition, where the HTTP server emulation is partly initialized, while the request is received. This results in dropping the received request. It is not forwarded and the testsuite times out. The solution is to register the HTTP server before the ipad is started and is retrieving data from SIM card. This test could be reproduced by delaying the HTTP server initialization. Change-Id: I3693352dca648de910f15cdda2e16f618452c8db --- M ipad/IPAd_Tests.ttcn 1 file changed, 10 insertions(+), 10 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/ipad/IPAd_Tests.ttcn b/ipad/IPAd_Tests.ttcn index 4eb6843..e70ef2d 100644 --- a/ipad/IPAd_Tests.ttcn +++ b/ipad/IPAd_Tests.ttcn @@ -607,9 +607,9 @@ f_respond_empty_notifications(); } private function f_TC_proc_indirect_prfle_dwnld(charstring id) runs on IPAd_ConnHdlr { + f_http_register(); f_exec_ipad(); f_es10x_init(); - f_http_register(); f_package_indirect_prfle_dwnld(id); @@ -669,9 +669,9 @@ f_respond_empty_notifications(); } private function f_TC_proc_euicc_pkg_dwnld_exec(charstring id) runs on IPAd_ConnHdlr { + f_http_register(); f_exec_ipad(); f_es10x_init(); - f_http_register(); f_package_euicc_pkg_dwnld_exec(id); @@ -748,9 +748,9 @@ f_respond_empty_notifications(); } private function f_TC_proc_euicc_pkg_dwnld_exec_rollback(charstring id) runs on IPAd_ConnHdlr { + f_http_register(); f_exec_ipad(); f_es10x_init(); - f_http_register(); f_package_euicc_pkg_dwnld_exec_rollback(id); @@ -805,9 +805,9 @@ var integer i; var boolean do_next_eim := false; + f_http_register(); f_exec_ipad("-f skipEIM"); f_es10x_init(); - f_http_register(); for (i := 0; i < sizeof(g_pars.eim_list); i := i + 1) { /* We expect a skipped eIM not to be polled. */ @@ -870,9 +870,9 @@ /* A testcase to try out what happens when the eIM package request is rejected */ private function f_TC_get_eim_pkg_req_rej(charstring id) runs on IPAd_ConnHdlr { + f_http_register(); f_exec_ipad(); f_es10x_init(); - f_http_register(); /* IPAd requests a package, we respond with an eimPackageError code 127 (undefined error) */ f_terminate_poll_cycle(127); @@ -1057,9 +1057,9 @@ /* A testcase to verify if the given device capabilities are set (the lower 3 bits are always set). */ private function f_TC_set_device_capabilities(charstring id) runs on IPAd_ConnHdlr { + f_http_register(); f_exec_ipad("-D 0xF1"); f_es10x_init(dev_capa := 'F1'O); - f_http_register(); /* IPAd will poll for eIM package. */ f_terminate_poll_cycle(); @@ -1107,9 +1107,9 @@ f_respond_empty_notifications(); } private function f_TC_euiccPackageRequest_PSMO(charstring id) runs on IPAd_ConnHdlr { + f_http_register(); f_exec_ipad(); f_es10x_init(); - f_http_register(); f_package_euiccPackageRequest_PSMO(id); @@ -1165,9 +1165,9 @@ f_respond_empty_notifications(); } private function f_TC_proc_indirect_prfle_dwnld_cancel_euicc(charstring id) runs on IPAd_ConnHdlr { + f_http_register(); f_exec_ipad(); f_es10x_init(); - f_http_register(); f_package_indirect_prfle_dwnld_cancel_euicc(id); @@ -1226,9 +1226,9 @@ f_respond_empty_notifications(); } private function f_TC_proc_indirect_prfle_dwnld_cancel_eim(charstring id) runs on IPAd_ConnHdlr { + f_http_register(); f_exec_ipad(); f_es10x_init(); - f_http_register(); f_package_indirect_prfle_dwnld_cancel_eim(id); @@ -1257,9 +1257,9 @@ private function f_TC_multi_packages(charstring id) runs on IPAd_ConnHdlr { var integer i; + f_http_register(); f_exec_ipad(); f_es10x_init(); - f_http_register(); for (i := 0; i < mp_tc_multi_package_rounds; i := i + 1) { log("Test round ", i, " of ", mp_tc_multi_package_rounds); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/44096?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3693352dca648de910f15cdda2e16f618452c8db Gerrit-Change-Number: 44096 Gerrit-PatchSet: 4 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 18
  • 19
  • 20
  • 21
  • 22
  • 23
  • 24
  • ...
  • 72
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.