October 2026 - gerrit-log - lists.osmocom.org

[M] Change in osmo-sgsn[master]: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach
by pespin 12 Oct '26

12 Oct '26

Attention is currently required from: fixeria, lynxis lazus, osmith. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email ) Change subject: gprs_gmm: gsm48_rx_gmm_att_req(): drop stale PDP contexts on re-Attach ...................................................................... Patch Set 5: (1 comment) Patchset: PS4: > https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43440 is a work in progress TTCN-3 testcase. […] @vyanitskiy@sysmocom.de osmo-sgsn patches were merged, in case you want to re-check this patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/42594?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I20c1f5f741275115635188b2f4b1c5fe7c6e40f1 Gerrit-Change-Number: 42594 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Comment-Date: Mon, 12 Oct 2026 10:20:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-sgsn[master]: Drop IMSI based acl
by lynxis lazus 12 Oct '26

12 Oct '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43698?usp=email ) Change subject: Drop IMSI based acl ...................................................................... Abandoned Integrated into a previous commit. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43698?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3288d3551c1a4daeb184f2e950777e5a81bfaddb Gerrit-Change-Number: 43698 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: sigtran: N-NOTICE.ind: Use proper SCCP-User return reason
by pespin 12 Oct '26

12 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43811?usp=email ) Change subject: sigtran: N-NOTICE.ind: Use proper SCCP-User return reason ...................................................................... sigtran: N-NOTICE.ind: Use proper SCCP-User return reason Until recently, libosmo-sigtran was incorrectly expecting low-level wire-format cause in N-NOTICE.ind. Nowadays it supports specific reason values in the SCCP-User SAP, so use those instead. This change is backward-compatible since the value for both enums are the same as per specs. Change-Id: Ic27a7f2e62d3392668e6ffc3b37ab278f343e128 Related: OS#2601 --- M TODO-RELEASE M src/sgsn/sccp.c 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: osmith: Looks good to me, but someone else must approve lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 40cc353..3fa5840 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -14,3 +14,4 @@ osmo-iuh >1.7.0 ranap multiple params are constified, see osmo-iuh Change-Id I667dc2ef377c1ceb5b11315458f00b282c143c81 osmo-iuh >1.8.1 ranap_new_msg_rab_assign_data2() / ranap_new_msg_rab_assign_voice2() libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_* +libosmo-sigtran >2.3.0 OSMO_SCCP_RETURN_REASON_*, osmo_sccp_return_reason_name() diff --git a/src/sgsn/sccp.c b/src/sgsn/sccp.c index 83aa19f..d1a3a1f 100644 --- a/src/sgsn/sccp.c +++ b/src/sgsn/sccp.c @@ -28,7 +28,6 @@ #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/sccp_helpers.h> -#include <osmocom/sccp/sccp_types.h> #include <osmocom/sgsn/debug.h> #include <osmocom/sgsn/iu_client.h> @@ -154,19 +153,19 @@ LOGP(DSUA, LOGL_DEBUG, "(calling_addr=%s) N-NOTICE.ind cause=%u='%s' importance=%u didn't match any RNC, ignoring\n", osmo_sccp_addr_dump(&ni->calling_addr), - ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->cause, osmo_sccp_return_reason_name(ni->cause), ni->importance); return; } LOG_RNC(rnc, LOGL_NOTICE, "N-NOTICE.ind cause=%u='%s' importance=%u\n", - ni->cause, osmo_sccp_return_cause_name(ni->cause), + ni->cause, osmo_sccp_return_reason_name(ni->cause), ni->importance); switch (ni->cause) { - case SCCP_RETURN_CAUSE_SUBSYSTEM_CONGESTION: - case SCCP_RETURN_CAUSE_NETWORK_CONGESTION: + case OSMO_SCCP_RETURN_REASON_SUBSYSTEM_CONGESTION: + case OSMO_SCCP_RETURN_REASON_NETWORK_CONGESTION: /* Transient failures (hopefully), keep going. */ return; default: -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43811?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic27a7f2e62d3392668e6ffc3b37ab278f343e128 Gerrit-Change-Number: 43811 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-sgsn[master]: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason
by pespin 12 Oct '26

12 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43804?usp=email ) Change subject: sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason ...................................................................... sigtran: N-DISCONNECT.req: Use proper SCCP-User release reason Until recently, libosmo-sigtran was incorrectly expecting low-level wire-format cause in N-DISCONNECT.req. Nowadays it supports specific reason values in the SCCP-User SAP, so use those instead. Change-Id: I4bf44c973ae5dbe6fc2164e1ecc314b1cfdaf08c Related: OS#2601 --- M TODO-RELEASE M src/sgsn/iu_client.c M src/sgsn/iu_rnc.c M src/sgsn/iu_rnc_fsm.c 4 files changed, 8 insertions(+), 4 deletions(-) Approvals: Jenkins Builder: Verified lynxis lazus: Looks good to me, approved osmith: Looks good to me, but someone else must approve diff --git a/TODO-RELEASE b/TODO-RELEASE index fa97ecb..40cc353 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -13,3 +13,4 @@ libosmo-gsup-client >1.8.0 osmo_gsup_client_is_connected(), osmo_gsup_client_get_rem_addr(), osmo_gsup_client_get_rem_port() osmo-iuh >1.7.0 ranap multiple params are constified, see osmo-iuh Change-Id I667dc2ef377c1ceb5b11315458f00b282c143c81 osmo-iuh >1.8.1 ranap_new_msg_rab_assign_data2() / ranap_new_msg_rab_assign_voice2() +libosmo-sigtran >2.3.0 OSMO_SCCP_REL_REASON_NSU_* diff --git a/src/sgsn/iu_client.c b/src/sgsn/iu_client.c index 164ff71..18a4e1f 100644 --- a/src/sgsn/iu_client.c +++ b/src/sgsn/iu_client.c @@ -34,7 +34,6 @@ #include <osmocom/gprs/gprs_msgb.h> #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/sccp_helpers.h> -#include <osmocom/sccp/sccp_types.h> #include <osmocom/sgsn/debug.h> #include <osmocom/sgsn/gprs_ranap.h> @@ -94,7 +93,10 @@ return; osmo_timer_del(&ue_ctx->release_timeout); - osmo_sccp_tx_disconn(ue_ctx->rnc->scu_iups->scu, ue_ctx->conn_id, NULL, 0); + osmo_sccp_tx_disconn(ue_ctx->rnc->scu_iups->scu, + ue_ctx->conn_id, + NULL, + OSMO_SCCP_REL_REASON_NSU_DISC_NORMAL); llist_del(&ue_ctx->list); talloc_free(ue_ctx); } diff --git a/src/sgsn/iu_rnc.c b/src/sgsn/iu_rnc.c index 1a15df1..32dfe62 100644 --- a/src/sgsn/iu_rnc.c +++ b/src/sgsn/iu_rnc.c @@ -34,7 +34,6 @@ #include <osmocom/gprs/gprs_msgb.h> #include <osmocom/sigtran/sccp_sap.h> #include <osmocom/sigtran/sccp_helpers.h> -#include <osmocom/sccp/sccp_types.h> #include <osmocom/sgsn/debug.h> #include <osmocom/sgsn/gprs_ranap.h> diff --git a/src/sgsn/iu_rnc_fsm.c b/src/sgsn/iu_rnc_fsm.c index 3e506a3..bfed0c9 100644 --- a/src/sgsn/iu_rnc_fsm.c +++ b/src/sgsn/iu_rnc_fsm.c @@ -182,7 +182,9 @@ LOG_RNC(rnc, LOGL_ERROR, "Receiving CO Initial message on RAN peer that has not done a proper RESET yet." " Disconnecting on incoming message, sending RESET to RAN peer.\n"); osmo_sccp_tx_disconn(ev_msg_up_co_initial_ctx->rnc->scu_iups->scu, - ev_msg_up_co_initial_ctx->conn_id, NULL, 0); + ev_msg_up_co_initial_ctx->conn_id, + NULL, + OSMO_SCCP_REL_REASON_NSU_DISC_END_USER_FAILURE); /* No valid RESET procedure has happened here yet. */ iu_rnc_reset(rnc); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I4bf44c973ae5dbe6fc2164e1ecc314b1cfdaf08c Gerrit-Change-Number: 43804 Gerrit-PatchSet: 4 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: iu_rnc: Remove duplicate return
by pespin 12 Oct '26

12 Oct '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43803?usp=email ) Change subject: iu_rnc: Remove duplicate return ...................................................................... iu_rnc: Remove duplicate return Change-Id: I3b3e75e6afea262978234df86b909e2daa7cc733 --- M src/sgsn/iu_rnc_fsm.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: osmith: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/iu_rnc_fsm.c b/src/sgsn/iu_rnc_fsm.c index 6b0ad41..3e506a3 100644 --- a/src/sgsn/iu_rnc_fsm.c +++ b/src/sgsn/iu_rnc_fsm.c @@ -176,7 +176,6 @@ iu_rnc_state_chg(rnc, IU_RNC_ST_READY); return; - case IU_RNC_EV_MSG_UP_CO_INITIAL: ev_msg_up_co_initial_ctx = data; OSMO_ASSERT(ev_msg_up_co_initial_ctx); @@ -187,7 +186,7 @@ /* No valid RESET procedure has happened here yet. */ iu_rnc_reset(rnc); return; - return; + case IU_RNC_EV_MSG_UP_CO: ev_msg_up_co_ctx = data; OSMO_ASSERT(ev_msg_up_co_ctx); -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43803?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I3b3e75e6afea262978234df86b909e2daa7cc733 Gerrit-Change-Number: 43803 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: pdpctx: sgsn_pdp_ctx_terminate(): free PDP context if GTP side is det...
by lynxis lazus 12 Oct '26

12 Oct '26

lynxis lazus has submitted this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43390?usp=email ) Change subject: pdpctx: sgsn_pdp_ctx_terminate(): free PDP context if GTP side is detached ...................................................................... pdpctx: sgsn_pdp_ctx_terminate(): free PDP context if GTP side is detached When pdp->ggsn is NULL, sgsn_pdp_ctx_terminate() detached the PDP context from its MM context but never freed it: sgsn_delete_pdp_ctx() (which normally triggers the eventual free via the GTP delete confirmation callback) was only called when pdp->ggsn was set. This leaked the PDP context. pdp->ggsn becomes NULL while the PDP context is still attached to a live MM context in sgsn_ggsn_ctx_remove_pdp(), e.g. when a GGSN recovers/disappears while the MS stays GPRS attached. Any later termination of that PDP context (e.g. Detach, or dropping stale PDP contexts on re-Attach) would then leak it instead of freeing it. Mirror the pattern already used in process_ms_ctx_status(): if the GTP side is already detached, free the PDP context right away instead of leaving it dangling. Change-Id: Ia74407c34576bfcc1f4ab9d1940b500da86cfbab Related: OS#6922 --- M src/sgsn/pdpctx.c 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve osmith: Looks good to me, approved lynxis lazus: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/sgsn/pdpctx.c b/src/sgsn/pdpctx.c index da825e6..d65ca4d 100644 --- a/src/sgsn/pdpctx.c +++ b/src/sgsn/pdpctx.c @@ -126,6 +126,8 @@ pdp_ctx_detach_mm_ctx(pdp); if (pdp->ggsn) sgsn_delete_pdp_ctx(pdp); + else /* GTP side already detached, freeing */ + sgsn_pdp_ctx_free(pdp); } /* -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia74407c34576bfcc1f4ab9d1940b500da86cfbab Gerrit-Change-Number: 43390 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-sgsn[master]: pdpctx: sgsn_pdp_ctx_terminate(): free PDP context if GTP side is det...
by lynxis lazus 12 Oct '26

12 Oct '26

Attention is currently required from: fixeria. lynxis lazus has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43390?usp=email ) Change subject: pdpctx: sgsn_pdp_ctx_terminate(): free PDP context if GTP side is detached ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43390?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ia74407c34576bfcc1f4ab9d1940b500da86cfbab Gerrit-Change-Number: 43390 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Oct 2026 10:14:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-sgsn[master]: RFC: libvlr: introduce lfp variable hlr_update_req
by lynxis lazus 12 Oct '26

12 Oct '26

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43467?usp=email ) Change subject: RFC: libvlr: introduce lfp variable hlr_update_req ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: This commit "could" be merged if we really want it. Because of the "distributed HLR" feature, this is currently required by the MSC. We might later want to figure out if we want to have it this way or not. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43467?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ic959c13695c2cfd4e0bfeef336efac1eb4a3418e Gerrit-Change-Number: 43467 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 12 Oct 2026 10:09:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-sgsn[master]: RFC: libvlr: use a talloc_zero instead of OTC_SELECT
by lynxis lazus 12 Oct '26

12 Oct '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43466?usp=email ) Change subject: RFC: libvlr: use a talloc_zero instead of OTC_SELECT ...................................................................... Abandoned sgsn supports OTC_SELECT since fbc0cfd37a979ffd5a10497566155bad467b1c43 -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43466?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I879b7ac6126d896a7bdae7ab4cbfe0655ac35760 Gerrit-Change-Number: 43466 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org>

1 0

[XS] Change in osmo-sgsn[master]: dummy commit
by lynxis lazus 12 Oct '26

12 Oct '26

lynxis lazus has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/43814?usp=email ) Change subject: dummy commit ...................................................................... Abandoned -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/43814?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: abandon Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ibb322d8c048533311f0e84421c3bdf41c5bbd258 Gerrit-Change-Number: 43814 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Reviewer: Jenkins Builder

1 0