lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

October 2026

  • 1 participants
  • 1247 discussions
[S] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid enum2int() conversion in PFCP_Create_PDR
by pespin 13 Oct '26

13 Oct '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43884?usp=email ) Change subject: PFCP_Templates: Avoid enum2int() conversion in PFCP_Create_PDR ...................................................................... PFCP_Templates: Avoid enum2int() conversion in PFCP_Create_PDR The type uses a integer, so better use integer too, otherwise the tr_ template cannot be passed wildcards due to the enum2int() call. Change-Id: Ie4eeb8df5a55dc0b47ebdff0a256d57031eb35df --- M library/PFCP_Templates.ttcn M s1gw/S1GW_ConnHdlr.ttcn M smf/SMF_Session_CT.ttcn M upf/UPF_Tests.ttcn 4 files changed, 25 insertions(+), 24 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/84/43884/1 diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index bf48224..c02ec10 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -1280,17 +1280,18 @@ } } +/* 8.2.36 PDR ID */ template (value) PDR_ID ts_PFCP_PDR_ID(template (value) OCT2 pdr_id) := { - elementIdentifier := 56, - lengthIndicator := 0, - rule_id := pdr_id + elementIdentifier := 56, + lengthIndicator := 0, + rule_id := pdr_id } template (present) PDR_ID -tr_PFCP_PDR_ID(template (present) OCT2 pdr_id) := { - elementIdentifier := 56, - lengthIndicator := ?, - rule_id := pdr_id +tr_PFCP_PDR_ID(template (present) OCT2 pdr_id := ?) := { + elementIdentifier := 56, + lengthIndicator := ?, + rule_id := pdr_id } template (value) Precedence @@ -1307,14 +1308,14 @@ } template (value) Create_PDR -ts_PFCP_Create_PDR(integer pdr_id, +ts_PFCP_Create_PDR(template (value) OCT2 pdr_id, template (value) PDI_IE pdi, template (omit) Outer_Header_Removal ohr := omit, template (value) LIN4_BO_LAST far_id) := { - elementIdentifier := 1, - lengthIndicator := 0, + elementIdentifier := 1, + lengthIndicator := 0, grouped_ie := { - pdr_id := ts_PFCP_PDR_ID(int2oct(pdr_id, 2)), + pdr_id := ts_PFCP_PDR_ID(pdr_id), precedence := ts_PFCP_Precedence(0), pdi := pdi, outer_header_removal := ohr, @@ -1325,14 +1326,14 @@ } } template (present) Create_PDR -tr_PFCP_Create_PDR(integer pdr_id, +tr_PFCP_Create_PDR(template (present) OCT2 pdr_id := ?, template (present) PDI_IE pdi := ?, template Outer_Header_Removal ohr := *, template (present) LIN4_BO_LAST far_id := ?) := { - elementIdentifier := 1, - lengthIndicator := ?, + elementIdentifier := 1, + lengthIndicator := ?, grouped_ie := { - pdr_id := tr_PFCP_PDR_ID(int2oct(pdr_id, 2)), + pdr_id := tr_PFCP_PDR_ID(pdr_id), precedence := tr_PFCP_Precedence(?), pdi := pdi, outer_header_removal := ohr, diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 24dacce..9a045b2 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -1093,11 +1093,11 @@ var template (present) Create_PDR pdr2; ohr := tr_PFCP_Outer_Header_Removal(PFCP_OHR_GTP_U_UDP_IPV4); - pdr1 := tr_PFCP_Create_PDR(pdr_id := 1, /* -- for Core -> Access */ + pdr1 := tr_PFCP_Create_PDR(pdr_id := int2oct(1, 2), /* -- for Core -> Access */ pdi := tr_PFCP_PDI(PFCP_Src_Iface_CORE), ohr := ohr, far_id := c_PFCP_FAR_ID_C2A); - pdr2 := tr_PFCP_Create_PDR(pdr_id := 2, /* -- for Access -> Core */ + pdr2 := tr_PFCP_Create_PDR(pdr_id := int2oct(2, 2), /* -- for Access -> Core */ pdi := tr_PFCP_PDI(PFCP_Src_Iface_ACCESS), ohr := ohr, far_id := c_PFCP_FAR_ID_A2C); diff --git a/smf/SMF_Session_CT.ttcn b/smf/SMF_Session_CT.ttcn index 9120c55..e89fd0c 100644 --- a/smf/SMF_Session_CT.ttcn +++ b/smf/SMF_Session_CT.ttcn @@ -404,7 +404,7 @@ var template octetstring flow_description := '7065726D6974206F75742035382066726F6D20666630323A3A*2F31323820746F2061737369676E6564'O; // ("permit out 58 from ff02::*/128 to assigned"); create_pdr := { *, - tr_PFCP_Create_PDR(pdr_id := 4, + tr_PFCP_Create_PDR(pdr_id := int2oct(4, 2), pdi := tr_PFCP_PDI(src_iface := PFCP_Src_Iface_ACCESS, local_F_TEID := tr_PFCP_F_TEID(?, ?, '1'B, '1'B, omit, omit, omit, ?), network_instance := tr_PFCP_Network_Instance(g_pars.apn), diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index c26925d..a5c7cc9 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -599,7 +599,7 @@ r.pdr := r.pdr & { valueof( ts_PFCP_Create_PDR( - pdr_id, + int2oct(pdr_id, 2), ts_PFCP_PDI( PFCP_Src_Iface_ACCESS, local_F_TEID := ts_PFCP_F_TEID_choose_v4(), @@ -630,7 +630,7 @@ r.pdr := r.pdr & { valueof( ts_PFCP_Create_PDR( - pdr_id, + int2oct(pdr_id, 2), ts_PFCP_PDI( PFCP_Src_Iface_CORE, ue_addr_v4 := ts_PFCP_UE_IP_Address_v4(f_inet_addr(ue_addr_v4), is_destination := true) @@ -666,7 +666,7 @@ r.pdr := r.pdr & { valueof( ts_PFCP_Create_PDR( - pdr_id, + int2oct(pdr_id, 2), ts_PFCP_PDI( src_iface, local_F_TEID := ts_PFCP_F_TEID_choose_v4(), @@ -699,7 +699,7 @@ r.pdr := r.pdr & { valueof( ts_PFCP_Create_PDR( - pdr_id, + int2oct(pdr_id, 2), ts_PFCP_PDI( src_iface, local_F_TEID := ts_PFCP_F_TEID_choose_v4(), @@ -748,7 +748,7 @@ r.pdr := r.pdr & { valueof( ts_PFCP_Create_PDR( - pdr_id, + int2oct(pdr_id, 2), ts_PFCP_PDI( PFCP_Src_Iface_CP_FUNCTION, local_F_TEID := ts_PFCP_F_TEID_choose_v4('17'O)), @@ -774,7 +774,7 @@ r.pdr := r.pdr & { valueof( ts_PFCP_Create_PDR( - pdr_id, + int2oct(pdr_id, 2), ts_PFCP_PDI( PFCP_Src_Iface_CP_FUNCTION, local_F_TEID := ts_PFCP_F_TEID_choose_v4('2a'O)), -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43884?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie4eeb8df5a55dc0b47ebdff0a256d57031eb35df Gerrit-Change-Number: 43884 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid enum2int() conversion in Outer_Header_Removal
by pespin 13 Oct '26

13 Oct '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43883?usp=email ) Change subject: PFCP_Templates: Avoid enum2int() conversion in Outer_Header_Removal ...................................................................... PFCP_Templates: Avoid enum2int() conversion in Outer_Header_Removal The type uses a integer, so better use integer too, otherwise the tr_ template cannot be passed wildcards due to the enum2int() call. Change-Id: I17a97301308af0e77e5693e7dba36d0a07504b0e --- M library/PFCP_Templates.ttcn M s1gw/S1GW_ConnHdlr.ttcn M smf/SMF_Session_CT.ttcn M upf/UPF_Tests.ttcn 4 files changed, 25 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/83/43883/1 diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index 7f3a3b3..bf48224 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -1098,29 +1098,29 @@ udp_port := * } -type enumerated e_PFCP_Outer_Header_Removal { - GTP_U_UDP_IPV4 (0), - GTP_U_UDP_IPV6 (1), - UDP_IPV4 (2), - UDP_IPV6 (3), - IPV4 (4), - IPV6 (5), - GTP_U_UDP_IP (6), - VLAN_S_TAG (7), - S_TAG_AND_C_TAG (8) -}; +/* 8.2.64 Outer Header Removal */ +const integer PFCP_OHR_GTP_U_UDP_IPV4 := 0; +const integer PFCP_OHR_GTP_U_UDP_IPV6 := 1; +const integer PFCP_OHR_UDP_IPV4 := 2; +const integer PFCP_OHR_UDP_IPV6 := 3; +const integer PFCP_OHR_IPV4 := 4; +const integer PFCP_OHR_IPV6 := 5; +const integer PFCP_OHR_GTP_U_UDP_IP := 6; +const integer PFCP_OHR_VLAN_S_TAG := 7; +const integer PFCP_OHR_S_TAG_AND_C_TAG := 8; template (value) Outer_Header_Removal -ts_PFCP_Outer_Header_Removal(e_PFCP_Outer_Header_Removal ohr) := { - elementIdentifier := 95, - lengthIndicator := 0, - ohc_description := enum2int(ohr) +ts_PFCP_Outer_Header_Removal(template (value) integer ohr) := { + elementIdentifier := 95, + lengthIndicator := 0, + ohc_description := ohr } + template (present) Outer_Header_Removal -tr_PFCP_Outer_Header_Removal(e_PFCP_Outer_Header_Removal ohr) := { - elementIdentifier := 95, - lengthIndicator := ?, - ohc_description := enum2int(ohr) +tr_PFCP_Outer_Header_Removal(template (present) integer ohr := ?) := { + elementIdentifier := 95, + lengthIndicator := ?, + ohc_description := ohr } template (value) Forwarding_Parameters diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 98ad911..24dacce 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -1092,7 +1092,7 @@ var template (present) Create_PDR pdr1; var template (present) Create_PDR pdr2; - ohr := tr_PFCP_Outer_Header_Removal(GTP_U_UDP_IPV4); + ohr := tr_PFCP_Outer_Header_Removal(PFCP_OHR_GTP_U_UDP_IPV4); pdr1 := tr_PFCP_Create_PDR(pdr_id := 1, /* -- for Core -> Access */ pdi := tr_PFCP_PDI(PFCP_Src_Iface_CORE), ohr := ohr, diff --git a/smf/SMF_Session_CT.ttcn b/smf/SMF_Session_CT.ttcn index 162b5f1..9120c55 100644 --- a/smf/SMF_Session_CT.ttcn +++ b/smf/SMF_Session_CT.ttcn @@ -411,7 +411,7 @@ sdf_filter_list := { tr_PFCP_SDF_Filter(fd := '1'B, flow_description := flow_description) }, source_interface_type := tr_PFCP_ThreeGPP_Interface_Type(11 /* N3 3GPP Access */)), - ohr := tr_PFCP_Outer_Header_Removal(GTP_U_UDP_IP), + ohr := tr_PFCP_Outer_Header_Removal(PFCP_OHR_GTP_U_UDP_IP), far_id := 3) , * } diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 0fcef8a..c26925d 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -604,7 +604,7 @@ PFCP_Src_Iface_ACCESS, local_F_TEID := ts_PFCP_F_TEID_choose_v4(), network_instance := ts_PFCP_Network_Instance(src_netinst)), - ts_PFCP_Outer_Header_Removal(GTP_U_UDP_IPV4), + ts_PFCP_Outer_Header_Removal(PFCP_OHR_GTP_U_UDP_IPV4), far_id ) ) @@ -671,7 +671,7 @@ src_iface, local_F_TEID := ts_PFCP_F_TEID_choose_v4(), network_instance := ts_PFCP_Network_Instance(src_netinst)), - ts_PFCP_Outer_Header_Removal(GTP_U_UDP_IPV4), + ts_PFCP_Outer_Header_Removal(PFCP_OHR_GTP_U_UDP_IPV4), far_id ) ) @@ -704,7 +704,7 @@ src_iface, local_F_TEID := ts_PFCP_F_TEID_choose_v4(), network_instance := ts_PFCP_Network_Instance(src_netinst)), - ts_PFCP_Outer_Header_Removal(GTP_U_UDP_IPV4), + ts_PFCP_Outer_Header_Removal(PFCP_OHR_GTP_U_UDP_IPV4), far_id ) ) @@ -752,7 +752,7 @@ ts_PFCP_PDI( PFCP_Src_Iface_CP_FUNCTION, local_F_TEID := ts_PFCP_F_TEID_choose_v4('17'O)), - ts_PFCP_Outer_Header_Removal(GTP_U_UDP_IPV4), + ts_PFCP_Outer_Header_Removal(PFCP_OHR_GTP_U_UDP_IPV4), far_id ) ) -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43883?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I17a97301308af0e77e5693e7dba36d0a07504b0e Gerrit-Change-Number: 43883 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface
by pespin 13 Oct '26

13 Oct '26
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43882?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface ...................................................................... PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface The type uses a integer, so better use integer too, otherwise the tr_ template cannot be passed wildcards due to the enum2int() call. Change-Id: I6ed23538660be5ca97df47e66c3b6ab60b39074f --- M library/PFCP_Templates.ttcn M s1gw/S1GW_ConnHdlr.ttcn M smf/SMF_Session_CT.ttcn M upf/UPF_Tests.ttcn 4 files changed, 64 insertions(+), 65 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/43882/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ed23538660be5ca97df47e66c3b6ab60b39074f Gerrit-Change-Number: 43882 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface
by pespin 13 Oct '26

13 Oct '26
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43882?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface ...................................................................... PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface The type uses a integer, so better use integer too, otherwise the tr_ template cannot be passed wildcards due to the enum2int() call. Change-Id: I6ed23538660be5ca97df47e66c3b6ab60b39074f --- M library/PFCP_Templates.ttcn M s1gw/S1GW_ConnHdlr.ttcn M smf/SMF_Session_CT.ttcn M upf/UPF_Tests.ttcn 4 files changed, 55 insertions(+), 56 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/43882/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ed23538660be5ca97df47e66c3b6ab60b39074f Gerrit-Change-Number: 43882 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface
by pespin 13 Oct '26

13 Oct '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43882?usp=email ) Change subject: PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface ...................................................................... PFCP_Templates: Avoid enum2int() conversion in Src/Dst_Iface The type uses a integer, so better use integer too, otherwise the tr_ template cannot be passed wildcards due to the enum2int() call. Change-Id: I6ed23538660be5ca97df47e66c3b6ab60b39074f --- M library/PFCP_Templates.ttcn M s1gw/S1GW_ConnHdlr.ttcn M smf/SMF_Session_CT.ttcn M upf/UPF_Tests.ttcn 4 files changed, 39 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/43882/1 diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index a85b075..ee5497e 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -805,26 +805,24 @@ ipv6_address := omit } -type enumerated e_PFCP_Src_Iface { - ACCESS (0), - CORE (1), - SGI_LAN_N6_LAN (2), - CP_FUNCTION (3), - x_5G_VN_INTERNAL (4) -}; +const integer PFCP_Src_Iface_ACCESS := 0; +const integer PFCP_Src_Iface_CORE := 1; +const integer PFCP_Src_Iface_SGI_LAN_N6_LAN := 2; +const integer PFCP_Src_Iface_CP_FUNCTION := 3; +const integer PFCP_Src_Iface_x_5G_VN_INTERNAL := 4; template (value) Source_Interface -ts_PFCP_Src_Iface(e_PFCP_Src_Iface iface) := { +ts_PFCP_Src_Iface(template (value) integer iface) := { elementIdentifier := 20, lengthIndicator := 0, - interfacevalue := enum2int(iface), + interfacevalue := iface, spare := '0000'B } template (present) Source_Interface -tr_PFCP_Src_Iface(e_PFCP_Src_Iface iface) := { +tr_PFCP_Src_Iface(template (present) integer iface := ?) := { elementIdentifier := 20, lengthIndicator := ?, - interfacevalue := enum2int(iface), + interfacevalue := iface, spare := ? } @@ -938,12 +936,12 @@ } template (value) PDI_IE -ts_PFCP_PDI(e_PFCP_Src_Iface src_iface, +ts_PFCP_PDI(template (value) integer src_iface, template (omit) F_TEID local_F_TEID := omit, template (omit) UE_IP_Address ue_addr_v4 := omit, template (omit) Network_Instance network_instance := omit) := { - elementIdentifier := 2, - lengthIndicator := 0, + elementIdentifier := 2, + lengthIndicator := 0, grouped_ie := { source_interface := ts_PFCP_Src_Iface(src_iface), local_F_TEID := local_F_TEID, @@ -958,7 +956,7 @@ } } template (present) PDI_IE -tr_PFCP_PDI(e_PFCP_Src_Iface src_iface, +tr_PFCP_PDI(template (present) integer src_iface := ?, template F_TEID local_F_TEID := *, template UE_IP_Address ue_addr_v4 := *, template Network_Instance network_instance := *, @@ -1050,27 +1048,25 @@ template (value) Apply_Action ts_PFCP_Apply_Action_BUFF := ts_PFCP_Apply_Action(buff := '1'B); template (present) Apply_Action tr_PFCP_Apply_Action_BUFF := tr_PFCP_Apply_Action(buff := '1'B); -type enumerated e_PFCP_Dest_Iface { - ACCESS (0), - CORE (1), - SGI_LAN_N6_LAN (2), - CP_FUNCTION (3), - LI_FUNCTION (4), - x_5G_VN_INTERNAL (5) -}; +const integer PFCP_Dest_Iface_ACCESS := 0; +const integer PFCP_Dest_Iface_CORE := 1; +const integer PFCP_Dest_Iface_SGI_LAN_N6_LAN := 2; +const integer PFCP_Dest_Iface_CP_FUNCTION := 3; +const integer PFCP_Dest_Iface_LI_FUNCTION := 4; +const integer PFCP_Dest_Iface_x_5G_VN_INTERNAL := 5; template (value) Destination_Interface -ts_PFCP_Destination_Interface(e_PFCP_Dest_Iface di) := { +ts_PFCP_Destination_Interface(template (value) integer di) := { elementIdentifier := 42, lengthIndicator := 0, - interface_value := enum2int(di), + interface_value := di, spare := '0000'B } template (present) Destination_Interface -tr_PFCP_Destination_Interface(e_PFCP_Dest_Iface di) := { +tr_PFCP_Destination_Interface(template (present) integer di := ?) := { elementIdentifier := 42, lengthIndicator := ?, - interface_value := enum2int(di), + interface_value := di, spare := ? } @@ -1125,7 +1121,7 @@ } template (value) Forwarding_Parameters -ts_PFCP_Forwarding_Parameters(e_PFCP_Dest_Iface dest_iface, +ts_PFCP_Forwarding_Parameters(template (value) integer dest_iface, template (omit) Network_Instance network_instance := omit, template (omit) Redirect_Information redirect_information := omit, template (omit) Outer_Header_Creation ohc := omit, @@ -1149,7 +1145,7 @@ } } template (present) Forwarding_Parameters -tr_PFCP_Forwarding_Parameters(e_PFCP_Dest_Iface dest_iface, +tr_PFCP_Forwarding_Parameters(template (present) integer dest_iface := ?, template Network_Instance network_instance := *, template Redirect_Information redirect_information := *, template Outer_Header_Creation ohc := *, diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 9c127d8..0cd6e01 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -1094,11 +1094,11 @@ ohr := tr_PFCP_Outer_Header_Removal(GTP_U_UDP_IPV4); pdr1 := tr_PFCP_Create_PDR(pdr_id := 1, /* -- for Core -> Access */ - pdi := tr_PFCP_PDI(CORE), + pdi := tr_PFCP_PDI(PFCP_Src_Iface_CORE), ohr := ohr, far_id := c_PFCP_FAR_ID_C2A); pdr2 := tr_PFCP_Create_PDR(pdr_id := 2, /* -- for Access -> Core */ - pdi := tr_PFCP_PDI(ACCESS), + pdi := tr_PFCP_PDI(PFCP_Src_Iface_ACCESS), ohr := ohr, far_id := c_PFCP_FAR_ID_A2C); diff --git a/smf/SMF_Session_CT.ttcn b/smf/SMF_Session_CT.ttcn index 58ee1c2..162b5f1 100644 --- a/smf/SMF_Session_CT.ttcn +++ b/smf/SMF_Session_CT.ttcn @@ -405,7 +405,7 @@ create_pdr := { *, tr_PFCP_Create_PDR(pdr_id := 4, - pdi := tr_PFCP_PDI(src_iface := ACCESS, + pdi := tr_PFCP_PDI(src_iface := PFCP_Src_Iface_ACCESS, local_F_TEID := tr_PFCP_F_TEID(?, ?, '1'B, '1'B, omit, omit, omit, ?), network_instance := tr_PFCP_Network_Instance(g_pars.apn), sdf_filter_list := { tr_PFCP_SDF_Filter(fd := '1'B, @@ -419,7 +419,7 @@ *, tr_PFCP_Create_FAR(far_id := 3, aa := tr_PFCP_Apply_Action(forw := '1'B), - fp := tr_PFCP_Forwarding_Parameters(dest_iface := CP_FUNCTION, + fp := tr_PFCP_Forwarding_Parameters(dest_iface := PFCP_Dest_Iface_CP_FUNCTION, ohc := tr_PFCP_Outer_Header_Creation_GTP_ipv4(?, f_inet_addr(mp_smf_hostname)))) , * } diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 159ac83..8212e8a 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -601,7 +601,7 @@ ts_PFCP_Create_PDR( pdr_id, ts_PFCP_PDI( - ACCESS, + PFCP_Src_Iface_ACCESS, local_F_TEID := ts_PFCP_F_TEID_choose_v4(), network_instance := ts_PFCP_Network_Instance(src_netinst)), ts_PFCP_Outer_Header_Removal(GTP_U_UDP_IPV4), @@ -632,7 +632,7 @@ ts_PFCP_Create_PDR( pdr_id, ts_PFCP_PDI( - CORE, + PFCP_Src_Iface_CORE, ue_addr_v4 := ts_PFCP_UE_IP_Address_v4(f_inet_addr(ue_addr_v4), is_destination := true) ), far_id := far_id @@ -658,7 +658,7 @@ /* Add to r a rule set that forwards GTP from one tunnel to another, i.e. one direction of a tunmap */ private function f_ruleset_add_GTP_forw(inout PFCP_Ruleset r, integer pdr_id, - e_PFCP_Src_Iface src_iface, + integer src_iface, charstring src_netinst, integer far_id, e_PFCP_Dest_Iface dest_iface, @@ -692,7 +692,7 @@ /* Add to r a DROP rule from src_iface to dest_iface */ private function f_ruleset_add_GTP_drop(inout PFCP_Ruleset r, integer pdr_id, - e_PFCP_Src_Iface src_iface, + integer src_iface, charstring src_netinst, integer far_id, e_PFCP_Dest_Iface dest_iface) { @@ -727,7 +727,7 @@ gtp.core.tunmap.far_id, ts_PFCP_Apply_Action_FORW, valueof(ts_PFCP_Update_Forwarding_Parameters( - ts_PFCP_Destination_Interface(CORE), + ts_PFCP_Destination_Interface(PFCP_Dest_Iface_CORE), ts_PFCP_Outer_Header_Creation_GTP_ipv4(gtp.core.tunmap.teid_r, f_inet_addr(gtp.core.tunmap.gtp_ip_r)) ) @@ -750,7 +750,7 @@ ts_PFCP_Create_PDR( pdr_id, ts_PFCP_PDI( - CP_FUNCTION, + PFCP_Src_Iface_CP_FUNCTION, local_F_TEID := ts_PFCP_F_TEID_choose_v4('17'O)), ts_PFCP_Outer_Header_Removal(GTP_U_UDP_IPV4), far_id @@ -776,7 +776,7 @@ ts_PFCP_Create_PDR( pdr_id, ts_PFCP_PDI( - CP_FUNCTION, + PFCP_Src_Iface_CP_FUNCTION, local_F_TEID := ts_PFCP_F_TEID_choose_v4('2a'O)), far_id := far_id ) @@ -826,7 +826,7 @@ if (core_gtp_known) { f_ruleset_add_GTP_forw(rules, pdr_id := gtp.access.pdr_id, - src_iface := ACCESS, + src_iface := PFCP_Src_Iface_ACCESS, src_netinst := netinst_access, far_id := gtp.core.tunmap.far_id, dest_iface := CORE, @@ -836,7 +836,7 @@ /* The Core remote GTP will follow in a Session Modification, for now set Core->Access to DROP */ f_ruleset_add_GTP_drop(rules, pdr_id := gtp.access.pdr_id, - src_iface := ACCESS, + src_iface := PFCP_Src_Iface_ACCESS, src_netinst := netinst_access, far_id := gtp.core.tunmap.far_id, dest_iface := CORE); @@ -844,7 +844,7 @@ /* Core to Access */ f_ruleset_add_GTP_forw(rules, pdr_id := gtp.core.tunmap.pdr_id, - src_iface := CORE, + src_iface := PFCP_Src_Iface_CORE, src_netinst := netinst_core, far_id := gtp.access.far_id, dest_iface := ACCESS, -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43882?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6ed23538660be5ca97df47e66c3b6ab60b39074f Gerrit-Change-Number: 43882 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid enum2oct() conversion in PFCP_Cause
by pespin 13 Oct '26

13 Oct '26
Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43881?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: PFCP_Templates: Avoid enum2oct() conversion in PFCP_Cause ...................................................................... PFCP_Templates: Avoid enum2oct() conversion in PFCP_Cause The type uses a OCT1, so better use OCT1 to define the causes, otherwise the tr_ template cannot be passed wildcards due to the enum2oct() call. Change-Id: I94d089bbfbca233fbb2393387eea0ab723e0c708 --- M library/PFCP_Emulation.ttcn M library/PFCP_Templates.ttcn M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn M smf/SMF_Session_CT.ttcn M smf/SMF_Tests.ttcn M upf/UPF_Tests.ttcn 7 files changed, 44 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/43881/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94d089bbfbca233fbb2393387eea0ab723e0c708 Gerrit-Change-Number: 43881 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: smf: Introduce test TC_pfcp_heartbeat_timeout
by pespin 13 Oct '26

13 Oct '26
Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873?usp=email ) Change subject: smf: Introduce test TC_pfcp_heartbeat_timeout ...................................................................... Patch Set 5: (1 comment) File smf/SMF_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873/comment/d5cbdd2c_980d… : PS5, Line 580: t_Metrics_Expect > Is there a reason to have this in the global namespace? Will other TCs use it? Yes, another test is using it (WIP patch). Furthermore, I tried initially putting the definition in the function but ttcn3 compiler told me it's not supported. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27daa6636e45909d6d83a46af094108e71efc552 Gerrit-Change-Number: 43873 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Oct 2026 09:14:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Avoid enum2oct() conversion in PFCP_Cause
by pespin 13 Oct '26

13 Oct '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43881?usp=email ) Change subject: PFCP_Templates: Avoid enum2oct() conversion in PFCP_Cause ...................................................................... PFCP_Templates: Avoid enum2oct() conversion in PFCP_Cause The type uses a OCT1, so better use OCT1 to define the causes, otherwise the tr_ template cannot be passed wildcards due to the enum2oct() call. Change-Id: I94d089bbfbca233fbb2393387eea0ab723e0c708 --- M library/PFCP_Emulation.ttcn M library/PFCP_Templates.ttcn M s1gw/S1GW_ConnHdlr.ttcn M s1gw/S1GW_Tests.ttcn M smf/SMF_Session_CT.ttcn M smf/SMF_Tests.ttcn M upf/UPF_Tests.ttcn 7 files changed, 44 insertions(+), 43 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/81/43881/1 diff --git a/library/PFCP_Emulation.ttcn b/library/PFCP_Emulation.ttcn index f07475a..72b9562 100644 --- a/library/PFCP_Emulation.ttcn +++ b/library/PFCP_Emulation.ttcn @@ -437,7 +437,7 @@ [] PFCP.receive(tr_PFCP_Assoc_Setup_Req()) -> value m { PFCP.send(ts_PFCP_Assoc_Setup_Resp(m.sequence_number, local_node_id, - ts_PFCP_Cause(REQUEST_ACCEPTED), + ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED), rts, up_function_features := up_function_features, cp_function_features := cp_function_features)); @@ -490,7 +490,7 @@ rx_assoc_setup_req := true; PFCP.send(ts_PFCP_Assoc_Setup_Resp(m.sequence_number, local_node_id, - ts_PFCP_Cause(REQUEST_ACCEPTED), + ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED), rts, up_function_features := up_function_features, cp_function_features := cp_function_features)); diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index ae23414..b495555 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -14,38 +14,39 @@ import from Osmocom_Types all; import from PFCP_Types all; -type enumerated e_PFCP_Cause { - RESERVED (0), - REQUEST_ACCEPTED (1), - MORE_USAGE_REPORT_TO_SEND (2), - REQUEST_REJECTED (64), - SESSION_CTX_NOT_FOUND (65), - MANDATORY_IE_MISSING (66), - CONDITIONAL_IE_MISSING (67), - INVALID_LENGTH (68), - MANDATORY_IE_INCORRECT (69), - INVALID_FORW_POLICY (70), - INVALID_F_TEID_ALLOC_OPTION (71), - NO_ESTABLISHED_PFCP_ASSOC (72), - RULE_CREATION_MOD_FAILURE (73), - PFCP_ENTITY_IN_CONGESTION (74), - NO_RESOURCES_AVAILABLE (75), - SERVICE_NOT_SUPPORTED (76), - SYSTEM_FAILURE (77), - REDIRECTION_REQUESTED (78), - ALL_DYNAMIC_ADDRESSES_ARE_OCCUPIED (79) -}; +/* 8.2.1 Cause */ +const OCT1 PFCP_Cause_RESERVED := 0; +const OCT1 PFCP_Cause_REQUEST_ACCEPTED := 1; +const OCT1 PFCP_Cause_MORE_USAGE_REPORT_TO_SEND := 2; +const OCT1 PFCP_Cause_REQUEST_REJECTED := 64; +const OCT1 PFCP_Cause_SESSION_CTX_NOT_FOUND := 65; +const OCT1 PFCP_Cause_MANDATORY_IE_MISSING := 66; +const OCT1 PFCP_Cause_CONDITIONAL_IE_MISSING := 67; +const OCT1 PFCP_Cause_INVALID_LENGTH := 68; +const OCT1 PFCP_Cause_MANDATORY_IE_INCORRECT := 69; +const OCT1 PFCP_Cause_INVALID_FORW_POLICY := 70; +const OCT1 PFCP_Cause_INVALID_F_TEID_ALLOC_OPTION := 71; +const OCT1 PFCP_Cause_NO_ESTABLISHED_PFCP_ASSOC := 72; +const OCT1 PFCP_Cause_RULE_CREATION_MOD_FAILURE := 73; +const OCT1 PFCP_Cause_PFCP_ENTITY_IN_CONGESTION := 74; +const OCT1 PFCP_Cause_NO_RESOURCES_AVAILABLE := 75; +const OCT1 PFCP_Cause_SERVICE_NOT_SUPPORTED := 76; +const OCT1 PFCP_Cause_SYSTEM_FAILURE := 77; +const OCT1 PFCP_Cause_REDIRECTION_REQUESTED := 78; +const OCT1 PFCP_Cause_ALL_DYNAMIC_ADDRESSES_ARE_OCCUPIED := 79; -template (value) Cause ts_PFCP_Cause(e_PFCP_Cause cause) := { +template (value) Cause +ts_PFCP_Cause(template (value) OCT1 cause) := { elementIdentifier := 19, lengthIndicator := 0, - causeValue := int2oct(enum2int(cause), 1) + causeValue := cause }; -template (present) Cause tr_PFCP_Cause(e_PFCP_Cause cause) := { +template (present) Cause +tr_PFCP_Cause(template (present) OCT1 cause := ?) := { elementIdentifier := 19, lengthIndicator := ?, - causeValue := int2oct(enum2int(cause), 1) + causeValue := cause }; const INT4b PFCP_Node_ID_IPv4 := 0; @@ -1478,7 +1479,7 @@ template (value) OCT8 seid, template (value) F_SEID f_seid, template (value) PFCP_Session_Establishment_Response.created_PDR_list created_pdr, - template (value) Cause cause := ts_PFCP_Cause(REQUEST_ACCEPTED)) + template (value) Cause cause := ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED)) modifies ts_PDU_PFCP_ := { seid := seid, sequence_number := seq_nr, @@ -1503,7 +1504,7 @@ template (present) OCT8 seid := ?, template (present) F_SEID f_seid := ?, template (present) PFCP_Session_Establishment_Response.created_PDR_list created_pdr := ?, - template (present) Cause cause := tr_PFCP_Cause(REQUEST_ACCEPTED)) + template (present) Cause cause := tr_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED)) modifies tr_PDU_PFCP_ := { seid := seid, sequence_number := ?, @@ -1597,7 +1598,7 @@ template (value) PDU_PFCP ts_PFCP_Session_Mod_Resp(template (value) LIN3_BO_LAST seq_nr, template (value) OCT8 seid, - template (value) Cause cause := ts_PFCP_Cause(REQUEST_ACCEPTED)) + template (value) Cause cause := ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED)) modifies ts_PDU_PFCP_ := { seid := seid, sequence_number := seq_nr, @@ -1617,7 +1618,7 @@ } template (present) PDU_PFCP tr_PFCP_Session_Mod_Resp(template (present) OCT8 seid := ?, - template (present) Cause cause := tr_PFCP_Cause(REQUEST_ACCEPTED)) + template (present) Cause cause := tr_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED)) modifies tr_PDU_PFCP_ := { seid := seid, message_body := { @@ -1658,7 +1659,7 @@ template (value) PDU_PFCP ts_PFCP_Session_Del_Resp(template (value) LIN3_BO_LAST seq_nr, template (value) OCT8 seid, - template (value) Cause cause := ts_PFCP_Cause(REQUEST_ACCEPTED), + template (value) Cause cause := ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED), template (omit) Usage_Report_Deletion_Response_list usage_report := omit) modifies ts_PDU_PFCP_ := { seid := seid, @@ -1675,7 +1676,7 @@ } template (present) PDU_PFCP tr_PFCP_Session_Del_Resp(template (present) OCT8 seid, - template (present) Cause cause := tr_PFCP_Cause(REQUEST_ACCEPTED), + template (present) Cause cause := tr_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED), template Usage_Report_Deletion_Response_list usage_report := *) modifies tr_PDU_PFCP_ := { seid := seid, @@ -1785,7 +1786,7 @@ template (present) PDU_PFCP tr_PFCP_Session_Report_Resp(template (present) OCT8 seid := ?, - template (present) Cause cause := tr_PFCP_Cause(REQUEST_ACCEPTED)) + template (present) Cause cause := tr_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED)) modifies tr_PDU_PFCP_ := { seid := seid, message_body := { diff --git a/s1gw/S1GW_ConnHdlr.ttcn b/s1gw/S1GW_ConnHdlr.ttcn index 423c05d..9c127d8 100644 --- a/s1gw/S1GW_ConnHdlr.ttcn +++ b/s1gw/S1GW_ConnHdlr.ttcn @@ -405,7 +405,7 @@ f_PFCPEM_unsubscribe_bcast(); /* ask PFCPEM to *not* route all PDUs to us */ PFCP.send(ts_PFCP_Assoc_Setup_Resp(rx.sequence_number, ts_PFCP_Node_ID_fqdn("\07osmocom\03org"), - ts_PFCP_Cause(REQUEST_ACCEPTED), + ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED), f_PFCPEM_get_recovery_timestamp())); } diff --git a/s1gw/S1GW_Tests.ttcn b/s1gw/S1GW_Tests.ttcn index 61f2a61..b8f9e78 100644 --- a/s1gw/S1GW_Tests.ttcn +++ b/s1gw/S1GW_Tests.ttcn @@ -522,7 +522,7 @@ seid := erab0.pfcp_rem_seid, f_seid := ts_PFCP_F_SEID_ipv4(addr, erab0.pfcp_loc_seid), created_pdr := {}, - cause := ts_PFCP_Cause(REQUEST_REJECTED)); + cause := ts_PFCP_Cause(PFCP_Cause_REQUEST_REJECTED)); PFCP.send(resp); /* see comments in f_ConnHdlr_erab_setup_req() */ diff --git a/smf/SMF_Session_CT.ttcn b/smf/SMF_Session_CT.ttcn index bb617cb..58ee1c2 100644 --- a/smf/SMF_Session_CT.ttcn +++ b/smf/SMF_Session_CT.ttcn @@ -513,12 +513,12 @@ var template (value) PDU_PFCP resp; resp := ts_PFCP_Session_Mod_Resp(seq_nr := req.sequence_number, seid := g_pars.pfcp_pars.remote_cp_f_seid.seid, - cause := ts_PFCP_Cause(REQUEST_ACCEPTED)); + cause := ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED)); PFCP.send(resp); } -altstep as_pfcp_sess_del_req(template (value) PFCP_Types.Cause resp_cause := ts_PFCP_Cause(REQUEST_ACCEPTED)) +altstep as_pfcp_sess_del_req(template (value) PFCP_Types.Cause resp_cause := ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED)) runs on SMF_Session_CT { var PDU_PFCP req; [] PFCP.receive(tr_PFCP_Session_Del_Req(g_pars.pfcp_pars.local_f_seid.seid)) -> value req { @@ -527,7 +527,7 @@ } private function f_pfcp_sess_del_resp(PDU_PFCP req, - template (value) PFCP_Types.Cause resp_cause := ts_PFCP_Cause(REQUEST_ACCEPTED)) + template (value) PFCP_Types.Cause resp_cause := ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED)) runs on SMF_Session_CT { var template (present) PDU_PFCP resp; var template (omit) Usage_Report_Deletion_Response_list usage_reports := omit; @@ -554,7 +554,7 @@ as_pfcp_sess_report_resp(); } -private altstep as_pfcp_sess_report_resp(template (present) PFCP_Types.Cause resp_cause := tr_PFCP_Cause(REQUEST_ACCEPTED)) +private altstep as_pfcp_sess_report_resp(template (present) PFCP_Types.Cause resp_cause := tr_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED)) runs on SMF_Session_CT { var PDU_PFCP resp; [] PFCP.receive(tr_PFCP_Session_Report_Resp(g_pars.pfcp_pars.local_f_seid.seid, diff --git a/smf/SMF_Tests.ttcn b/smf/SMF_Tests.ttcn index 9afb1d7..44bf25b 100644 --- a/smf/SMF_Tests.ttcn +++ b/smf/SMF_Tests.ttcn @@ -604,7 +604,7 @@ f_prometheus_expect(valueof(t_Metrics_Expect(0, 1)), wait_converge := true); PFCP.send(ts_PFCP_Assoc_Setup_Resp(m.sequence_number, ts_PFCP_Node_ID_ipv4(f_inet_addr(mp_pfcp_ip_local)), - ts_PFCP_Cause(REQUEST_ACCEPTED), + ts_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED), rts, up_function_features := ts_PFCP_UP_Function_Features(ftup := '1'B, vtime := '1'B))); diff --git a/upf/UPF_Tests.ttcn b/upf/UPF_Tests.ttcn index 59550a8..159ac83 100644 --- a/upf/UPF_Tests.ttcn +++ b/upf/UPF_Tests.ttcn @@ -574,13 +574,13 @@ /* Run a PFCP Association procedure */ private function f_assoc_setup() runs on CPF_ConnHdlr { PFCP.send(ts_PFCP_Assoc_Setup_Req(g_pars.local_node_id, g_recovery_timestamp)); - PFCP.receive(tr_PFCP_Assoc_Setup_Resp(cause := tr_PFCP_Cause(REQUEST_ACCEPTED))); + PFCP.receive(tr_PFCP_Assoc_Setup_Resp(cause := tr_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED))); } /* Release a PFCP Association */ private function f_assoc_release() runs on CPF_ConnHdlr { PFCP.send(ts_PFCP_Assoc_Release_Req(g_pars.local_node_id)); - PFCP.receive(tr_PFCP_Assoc_Release_Resp(cause := tr_PFCP_Cause(REQUEST_ACCEPTED))); + PFCP.receive(tr_PFCP_Assoc_Release_Resp(cause := tr_PFCP_Cause(PFCP_Cause_REQUEST_ACCEPTED))); } /* Collection of what a test intends to send to osmo-upf */ -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43881?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I94d089bbfbca233fbb2393387eea0ab723e0c708 Gerrit-Change-Number: 43881 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Support passing PFCPSEReq_Flags IE to tr_PFCP_Session...
by fixeria 13 Oct '26

13 Oct '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43879?usp=email ) Change subject: PFCP_Templates: Support passing PFCPSEReq_Flags IE to tr_PFCP_Session_Est_Req() ...................................................................... Patch Set 1: (1 comment) File library/PFCP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43879/comment/b890b298_f7a7… : PS1, Line 612: '0000'B It's again the same problem with expecting spare bits to be all 0...If you really-really want to make sure that the IUT sends all 0, then just parametrize this field, but IMO `?` should be used by default. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc7fc117d25940f9e032dc347141a2fada57c912 Gerrit-Change-Number: 43879 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Oct 2026 09:03:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: smf: Introduce test TC_pfcp_heartbeat_timeout
by fixeria 13 Oct '26

13 Oct '26
Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873?usp=email ) Change subject: smf: Introduce test TC_pfcp_heartbeat_timeout ...................................................................... Patch Set 5: Code-Review+1 (1 comment) File smf/SMF_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873/comment/1eb506f9_25e8… : PS5, Line 580: t_Metrics_Expect Is there a reason to have this in the global namespace? Will other TCs use it? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43873?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I27daa6636e45909d6d83a46af094108e71efc552 Gerrit-Change-Number: 43873 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Oct 2026 09:00:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 60
  • 61
  • 62
  • 63
  • 64
  • 65
  • 66
  • ...
  • 125
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.