lists.osmocom.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

gerrit-log

Thread Start a new thread
Download
Threads by month
  • ----- 2026 -----
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2025 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
gerrit-log@lists.osmocom.org

October 2026

  • 1 participants
  • 1247 discussions
[XS] Change in osmo-ttcn3-hacks[master]: PFCP_Emulation: Support repeat in as_pfcp_handle_heartbeat_req()
by fixeria 13 Oct '26

13 Oct '26
Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43878?usp=email ) Change subject: PFCP_Emulation: Support repeat in as_pfcp_handle_heartbeat_req() ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I99b8f63e558197d70273fd6b89adaa0470da772d Gerrit-Change-Number: 43878 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Oct 2026 08:53:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes
1 0
0 0
[XL] Change in pysim[master]: Remote Card Procedure Framework
by Hoernchen 13 Oct '26

13 Oct '26
Attention is currently required from: dexter, laforge, lynxis lazus, pespin. Hoernchen has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/42996?usp=email ) Change subject: Remote Card Procedure Framework ...................................................................... Patch Set 5: (19 comments) Patchset: PS5: so after a first quick look apparently the right now the untrusted card holder can: 1) fake every response and "drive" the rsp server due to no r-mac with scp02 / not implemented in pysim 2) read all scp02 responses (no r-enc in the spec) 3) alwayys read 00 class commands like verify adm 4) enumerate valid iccid/eids since these are client supplied and the error response differs 5) return sw != 9000 and the resulting crash leaks keys to the openobserve log 6) flood openobserve despite having a rate limiter, which will still forward... File contrib/rcp/rcp_client.py: https://gerrit.osmocom.org/c/pysim/+/42996/comment/4dad4954_7320540d?usp=em… : PS5, Line 107: log.info(str(self) + " -- %s", rx_json['rcpc_instr']['print']) module/server-controlled print string logged raw (terminal escape injection) https://gerrit.osmocom.org/c/pysim/+/42996/comment/5db5253d_a9e3dc15?usp=em… : PS5, Line 156: client = RcpcCltConnHdlr(sl, websocket, SERVER_TIMEOUT, json_validator) does this properly enforce wss:// and reject ws://? File contrib/rcp/rcp_module_utils.py: https://gerrit.osmocom.org/c/pysim/+/42996/comment/fd65d929_46e7b403?usp=em… : PS5, Line 234: SrvSyncConnHdlr.__init__(self, *args, *kwargs) **kwargs ? File contrib/rcp/rcp_server.py: https://gerrit.osmocom.org/c/pysim/+/42996/comment/73968555_21179b78?usp=em… : PS5, Line 77: option_parser.add_argument("--rcpc-request-limit", help="number of RCP Client requests per minute", missing type=int and therefore crash way way below. https://gerrit.osmocom.org/c/pysim/+/42996/comment/ed5b0344_1509fe2e?usp=em… : PS5, Line 141: raise ValueError("command %s not found in command description %s" % (cmd_name, str(self.cmd_descr))) undefined cmd_name https://gerrit.osmocom.org/c/pysim/+/42996/comment/e566b6fc_53b467e9?usp=em… : PS5, Line 219: if module_runtime_state.name == module_name: this matches the last suitable module so empty list -> UnboundLocalError on module_name https://gerrit.osmocom.org/c/pysim/+/42996/comment/15334064_a4ed95f6?usp=em… : PS5, Line 397: await self._reset() cant we at least check that the reset atr equals the client supplied atr instead of discarding it? https://gerrit.osmocom.org/c/pysim/+/42996/comment/87386899_a9867da0?usp=em… : PS5, Line 411: # Forward messages between RCP Module Command Server and RCP Client until the procedure ends. client imeout is per recv but this loop has no timeout at all? sounds like a problem... https://gerrit.osmocom.org/c/pysim/+/42996/comment/61288cac_04f1b4d5?usp=em… : PS5, Line 479: Remove RCPM from internal list when the connection is closed (and the handler is deleted) the del depends on garbage collection timing which means this might live longer than intended... https://gerrit.osmocom.org/c/pysim/+/42996/comment/22100faf_f7127c8f?usp=em… : PS5, Line 570: rc = requests.post(self.url, auth=self.service_auth, data=report_json) synchronous post with no timeout called from the async handler below sounds pretty bad because this stalls everything? https://gerrit.osmocom.org/c/pysim/+/42996/comment/64a5195a_5c0f1d86?usp=em… : PS5, Line 586: if rate_limiter.limit(websocket.remote_address[0]): closes socket but does not return, falls through to create a recorder and post, which completely defeats the rate limit? https://gerrit.osmocom.org/c/pysim/+/42996/comment/ea297aa4_9e8ac192?usp=em… : PS5, Line 607: await websocket.close(code=1011) # Internal Error if the iccid is not in the db this raises and returns the error -> lookup oracle. better to lookup garbage so it proceeds like a proper case and the client learns absolutely nothing. File contrib/rcp/rcp_utils.py: https://gerrit.osmocom.org/c/pysim/+/42996/comment/64515bbd_075fb235?usp=em… : PS5, Line 76: raise ValueError("invalid type in command argument specification: %s" % arg['spec']['type']) undefined arg https://gerrit.osmocom.org/c/pysim/+/42996/comment/14ec7839_70922a7d?usp=em… : PS5, Line 89: def load_server_cert(what: str, filename: str) -> SSLContext: no verify_mode/CA ? File contrib/rcp/rcpm_to_rcps_schema.json: https://gerrit.osmocom.org/c/pysim/+/42996/comment/d6aa8dfc_6b70bc74?usp=em… : PS5, Line 68: "get_keys": { no restrictions on columns? File contrib/rcp/usage_example/rcp_module.py: https://gerrit.osmocom.org/c/pysim/+/42996/comment/3d437208_52ff8d8e?usp=em… : PS5, Line 106: security_level = 3 very important to not pick unencrypted using this framework, ever... https://gerrit.osmocom.org/c/pysim/+/42996/comment/adedf6f3_e0cf3ae9?usp=em… : PS5, Line 110: scp = SCP02(card_keys=kset) scp02 was deprecated in 2019 for a reason, which is the padding oracle. this whole rpcs is literally the example from the padding oracle paper, with the example "smartphone" replaced by this. another problem here for this is that scp02 supports 1) no r-enc 2) r-mac is optional (we should check this for our cards, GP get data tag 66) 3) pysim currently does not support scp02 r-mac, needs fixing. without r-mac a malicious client can basically return and therefore steer our server with any kind of garbage and a chosen status word without ever actually forwarding our commands to the card and we can't check anything. File docs/rcpf.rst: https://gerrit.osmocom.org/c/pysim/+/42996/comment/e504909c_e5bf9d11?usp=em… : PS5, Line 74: `RCP Server` and the `RCP Modules`, all links use SSL/TLS encrypted channels. i guess here should be a big note with the network isolation requirements, not just implicitly by stating that the client is from the big bad internet. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/42996?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I8500a98492328ed5b3eb4bb177af2a4a8e481f80 Gerrit-Change-Number: 42996 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Hoernchen <ewild(a)sysmocom.de> Gerrit-CC: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis(a)fe80.eu> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Tue, 13 Oct 2026 03:35:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: bts: drop non-existent friend module BTS_Tests_virtphy
by fixeria 12 Oct '26

12 Oct '26
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43861?usp=email ) Change subject: bts: drop non-existent friend module BTS_Tests_virtphy ...................................................................... bts: drop non-existent friend module BTS_Tests_virtphy Change-Id: I4a08680e65d14c1092e8c5a1caa69f80b2334936 --- M bts/BTS_Tests.ttcn 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index ff8500c..719d8e3 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -77,7 +77,6 @@ friend module BTS_Tests_ASCI; friend module BTS_Tests_SMSCB; friend module BTS_Tests_VAMOS; -friend module BTS_Tests_virtphy; friend module BTS_Tests_LAPDm; friend module BTS_Tests_perf; friend module BTS_Tests_OML; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43861?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I4a08680e65d14c1092e8c5a1caa69f80b2334936 Gerrit-Change-Number: 43861 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: bts/oml: remove old osmo-bts <= 1.6.0 comment
by fixeria 12 Oct '26

12 Oct '26
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43859?usp=email ) Change subject: bts/oml: remove old osmo-bts <= 1.6.0 comment ...................................................................... bts/oml: remove old osmo-bts <= 1.6.0 comment Change-Id: I59d1aae03dc597bf6de412e2c0a84bdd0b6e829f --- M bts/BTS_Tests_OML.ttcn 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/bts/BTS_Tests_OML.ttcn b/bts/BTS_Tests_OML.ttcn index e1b75e6..db55b27 100644 --- a/bts/BTS_Tests_OML.ttcn +++ b/bts/BTS_Tests_OML.ttcn @@ -814,10 +814,7 @@ execute( TC_ts_opstart() ); execute( TC_ts_opstart_noattr() ); execute( TC_initial_state_reports() ); - execute( TC_ipa_osmo_pcu_anr_fwd() ); - - /* This one makes osmo-bts <= 1.6.0 crash, keep it at the end: */ execute( TC_ipa_rsl_connect_nack() ); } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43859?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I59d1aae03dc597bf6de412e2c0a84bdd0b6e829f Gerrit-Change-Number: 43859 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: bts/expected-results.xml: add BTS_Tests_OML.TC_wrong_msgtype
by fixeria 12 Oct '26

12 Oct '26
fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43860?usp=email ) Change subject: bts/expected-results.xml: add BTS_Tests_OML.TC_wrong_msgtype ...................................................................... bts/expected-results.xml: add BTS_Tests_OML.TC_wrong_msgtype Change-Id: I430b6f7dc04b245a23cbb00e527de34cf47fbe8c --- M bts/expected-results.xml 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/bts/expected-results.xml b/bts/expected-results.xml index 1de0652..aba58dd 100644 --- a/bts/expected-results.xml +++ b/bts/expected-results.xml @@ -279,6 +279,7 @@ <testcase classname='BTS_Tests_ASCI' name='TC_vgcs_talker_est_rel' time='MASKED'/> <testcase classname='BTS_Tests_ASCI' name='TC_vgcs_listener_det' time='MASKED'/> <testcase classname='BTS_Tests_OML' name='TC_wrong_mdisc' time='MASKED'/> + <testcase classname='BTS_Tests_OML' name='TC_wrong_msgtype' time='MASKED'/> <testcase classname='BTS_Tests_OML' name='TC_short_length' time='MASKED'/> <testcase classname='BTS_Tests_OML' name='TC_long_length' time='MASKED'/> <testcase classname='BTS_Tests_OML' name='TC_wrong_placement' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43860?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I430b6f7dc04b245a23cbb00e527de34cf47fbe8c Gerrit-Change-Number: 43860 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Support passing PFCPSEReq_Flags IE to tr_PFCP_Session...
by pespin 12 Oct '26

12 Oct '26
pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43879?usp=email ) Change subject: PFCP_Templates: Support passing PFCPSEReq_Flags IE to tr_PFCP_Session_Est_Req() ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: Depends on this MR I just submitted upstream: https://gitlab.eclipse.org/eclipse/titan/titan.ProtocolModules.PFCP_v15.1.0… -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc7fc117d25940f9e032dc347141a2fada57c912 Gerrit-Change-Number: 43879 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Comment-Date: Mon, 12 Oct 2026 16:21:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
1 0
0 0
[XS] Change in osmo-ttcn3-hacks[master]: PFCP_Emulation: Support repeat in as_pfcp_handle_heartbeat_req()
by pespin 12 Oct '26

12 Oct '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43878?usp=email ) Change subject: PFCP_Emulation: Support repeat in as_pfcp_handle_heartbeat_req() ...................................................................... PFCP_Emulation: Support repeat in as_pfcp_handle_heartbeat_req() This is needed for instance when activating the altstep and then doing an explicit receive alt on another message on the same port, otherwise a received HB REQ will skip receiving the explicit message. Change-Id: I99b8f63e558197d70273fd6b89adaa0470da772d --- M library/PFCP_Emulation.ttcn 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/78/43878/1 diff --git a/library/PFCP_Emulation.ttcn b/library/PFCP_Emulation.ttcn index ad00561..f07475a 100644 --- a/library/PFCP_Emulation.ttcn +++ b/library/PFCP_Emulation.ttcn @@ -404,7 +404,7 @@ } /* Wait for peer to send a PFCP HEARTBEAT REQ to us, answer it */ -altstep as_pfcp_handle_heartbeat_req(integer tx_recovery_timestamp) +altstep as_pfcp_handle_heartbeat_req(integer tx_recovery_timestamp, boolean do_repeat := false) runs on PFCP_ConnHdlr { var PDU_PFCP m; @@ -413,6 +413,9 @@ tx_pfcp := valueof(ts_PFCP_Heartbeat_Resp(tx_recovery_timestamp)); tx_pfcp.sequence_number := m.sequence_number; PFCP.send(tx_pfcp); + if (do_repeat) { + repeat; + } } } @@ -495,7 +498,7 @@ repeat; } } - [] as_pfcp_handle_heartbeat_req(rts) { repeat; } + [] as_pfcp_handle_heartbeat_req(rts, do_repeat := true); [fail_rx_others] PFCP.receive(PDU_PFCP:?) -> value m { Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, log2str("Got an unexpected PFCP message ", m, " vs exp ", tr_PFCP_Assoc_Setup_Req())); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43878?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I99b8f63e558197d70273fd6b89adaa0470da772d Gerrit-Change-Number: 43878 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[M] Change in osmo-ttcn3-hacks[master]: WIP: smf: Introduce test TC_pfcp_heartbeat_recovery_timestamp
by pespin 12 Oct '26

12 Oct '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43880?usp=email ) Change subject: WIP: smf: Introduce test TC_pfcp_heartbeat_recovery_timestamp ...................................................................... WIP: smf: Introduce test TC_pfcp_heartbeat_recovery_timestamp Change-Id: I15ad5c295fc47ed9f38b91b6392b674bd0b4c4d7 --- M smf/SMF_Session_CT.ttcn M smf/SMF_Tests.ttcn M smf/expected-results.xml 3 files changed, 79 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/43880/1 diff --git a/smf/SMF_Session_CT.ttcn b/smf/SMF_Session_CT.ttcn index bb617cb..6de76b2 100644 --- a/smf/SMF_Session_CT.ttcn +++ b/smf/SMF_Session_CT.ttcn @@ -392,11 +392,12 @@ return rx; } -function f_Session_tr_PFCP_Session_Est_Req() runs on SMF_Session_CT return template (present) PDU_PFCP +function f_Session_tr_PFCP_Session_Est_Req(boolean exp_sess_restoration := false) runs on SMF_Session_CT return template (present) PDU_PFCP { var template (present) Create_PDR_list create_pdr := ?; var template (present) Create_FAR_list create_far := ?; var template Create_URR_list create_urr := *; + var template PFCPSEReq_Flags pfcpSEReq_flags := *; if (g_pars.pfcp_pars.pdn_type == c_PFCP_PDN_Type_IPv6 or g_pars.pfcp_pars.pdn_type == c_PFCP_PDN_Type_IPv4v6) { @@ -435,17 +436,39 @@ }; } + if (exp_sess_restoration) { + pfcpSEReq_flags := tr_PFCPSEReq_Flags(resti := '1'B); + } + return tr_PFCP_Session_Est_Req(create_pdr := create_pdr, create_far := create_far, create_urr := create_urr, - pdn_type := tr_PFCP_PDN_Type(g_pars.pfcp_pars.pdn_type)); + pdn_type := tr_PFCP_PDN_Type(g_pars.pfcp_pars.pdn_type), + pfcpSEReq_flags := pfcpSEReq_flags); } -altstep as_pfcp_sess_est_req() +altstep as_pfcp_sess_est_req(boolean exp_sess_restoration := false) runs on SMF_Session_CT { - var template (present) PDU_PFCP exp_req := f_Session_tr_PFCP_Session_Est_Req(); + var template (present) PDU_PFCP exp_req := f_Session_tr_PFCP_Session_Est_Req(exp_sess_restoration := exp_sess_restoration); var PDU_PFCP req; [] PFCP.receive(exp_req) -> value req { + var PFCP_Session_Establishment_Request serq := req.message_body.pfcp_session_establishment_request; + if (exp_sess_restoration) { + /* "NOTE 4: The UP function shall accept the CP function allocated GTP-U + * F-TEID and/or UE IP address in the PFCP Session Establishment Request + * message with the RESTI flag set to "1", if the requested GTP-U F-TEID + * and/or UE IP address are available." */ + for (var integer i := 0; i < lengthof(serq.create_PDR_list); i := i + 1) { + var template (present) Create_PDR exp_pdr; + exp_pdr := tr_PFCP_Create_PDR(pdr_id := i + 1, + pdi := tr_PFCP_PDI(src_iface := (tr_PFCP_PDI(ACCESS), tr_PFCP_PDI(CORE), tr_PFCP_PDI(CP_FUNCTION)), + local_F_TEID := ?)); + if (not match(serq.create_PDR_list[i], exp_pdr)){ + Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, + log2str("Got CreatePDR ", req.create_PDR_list[i], " vs exp ", exp_pdr)); + } + } + } f_pfcp_sess_est_resp(req); } } diff --git a/smf/SMF_Tests.ttcn b/smf/SMF_Tests.ttcn index 9afb1d7..f695b08 100644 --- a/smf/SMF_Tests.ttcn +++ b/smf/SMF_Tests.ttcn @@ -625,6 +625,56 @@ } +/* Validate IUT detects PFCP Heartbeat Recovery Timestamp change and recovers from it restoring + * existing subscriber connections: */ +private function f_TC_pfcp_heartbeat_recovery_timestamp() runs on SMF_Session_CT { + var PDU_PFCP m; + var integer rts := f_PFCPEM_get_recovery_timestamp(); + + f_prometheus_expect(valueof(t_Metrics_Expect(1, 0)), wait_converge := true); + + f_PFCPEM_subscribe_bcast(); + as_pfcp_handle_heartbeat_req(rts); + + f_s5s8_create_session(); + f_prometheus_expect(valueof(t_Metrics_Expect(1, 1)), wait_converge := true); + + rts := rts + 1; + as_pfcp_handle_heartbeat_req(rts); + activate(as_pfcp_handle_heartbeat_req(rts, do_repeat := true)); + + /* Wait for IUT to detect during rx of Heartbeat Response that peer restarted, ie. wait for a + * 2nd ASSOC SETUP REQ after Heartbeat timeout: */ + PFCP.receive(tr_PFCP_Assoc_Setup_Req()) -> value m; + + f_prometheus_expect(valueof(t_Metrics_Expect(0, 1)), wait_converge := true); + PFCP.send(ts_PFCP_Assoc_Setup_Resp(m.sequence_number, + ts_PFCP_Node_ID_ipv4(f_inet_addr(mp_pfcp_ip_local)), + ts_PFCP_Cause(REQUEST_ACCEPTED), + rts, + up_function_features := ts_PFCP_UP_Function_Features(ftup := '1'B, + vtime := '1'B))); + + /* IUT restores existing subscriber connections */ + as_pfcp_sess_est_req(exp_sess_restoration := true); + /* Ask PFCPEM to route PDUs with to be indicated F-SEID to us. */ + //f_PFCPEM_subscribe_seid(g_pars.pfcp_pars.local_f_seid.seid); + + f_sleep(3.0); + f_s5s8_delete_session(omit, Request_accepted); + + setverdict(pass); +} +testcase TC_pfcp_heartbeat_recovery_timestamp() runs on SMF_Test_CT { + var SMF_Session_CT vc_conn; + var SessionPars pars := f_SessionPars(800); + g_pfcp_answer_heartbeat_req := false; + f_init(guard_timeout := 60.0); + vc_conn := f_start_handler(refers(f_TC_pfcp_heartbeat_recovery_timestamp), pars); + vc_conn.done; + f_shutdown(); +} + /* create an IPv4 session from 5G AMF, then delete it again */ private function f_TC_n11_createSession_deleteSession() runs on SMF_Session_CT { var PrometheusExpects expects0 := valueof({ @@ -727,6 +777,7 @@ execute( TC_s2b_createSession_v4_apco() ); execute( TC_pfcp_heartbeat_timeout() ); + execute( TC_pfcp_heartbeat_recovery_timestamp() ); execute( TC_n11_createSession_deleteSession() ); execute( TC_n11_createSession_deleteSession_ipv6() ); diff --git a/smf/expected-results.xml b/smf/expected-results.xml index 1deaf2c..aab8202 100644 --- a/smf/expected-results.xml +++ b/smf/expected-results.xml @@ -13,6 +13,7 @@ <testcase classname='SMF_Tests' name='TC_s2b_createSession_v4_noapco' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_s2b_createSession_v4_apco' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_pfcp_heartbeat_timeout' time='MASKED'/> + <testcase classname='SMF_Tests' name='TC_pfcp_heartbeat_recovery_timestamp' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_n11_createSession_deleteSession' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_n11_createSession_deleteSession_ipv6' time='MASKED'/> <testcase classname='SMF_Tests' name='TC_n11_createSession_deleteSession_ipv4v6' time='MASKED'/> -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43880?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I15ad5c295fc47ed9f38b91b6392b674bd0b4c4d7 Gerrit-Change-Number: 43880 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: PFCP_Templates: Support passing PFCPSEReq_Flags IE to tr_PFCP_Session...
by pespin 12 Oct '26

12 Oct '26
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43879?usp=email ) Change subject: PFCP_Templates: Support passing PFCPSEReq_Flags IE to tr_PFCP_Session_Est_Req() ...................................................................... PFCP_Templates: Support passing PFCPSEReq_Flags IE to tr_PFCP_Session_Est_Req() Change-Id: Idc7fc117d25940f9e032dc347141a2fada57c912 --- M library/PFCP_Templates.ttcn 1 file changed, 20 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/43879/1 diff --git a/library/PFCP_Templates.ttcn b/library/PFCP_Templates.ttcn index ae23414..34dc77a 100644 --- a/library/PFCP_Templates.ttcn +++ b/library/PFCP_Templates.ttcn @@ -597,6 +597,20 @@ validity_time_value := validity_time_value } +/* 8.2.136 PFCPSEReq-Flags */ +template (present) PFCPSEReq_Flags +tr_PFCPSEReq_Flags(template (present) BIT1 resti := ?, + template (present) BIT1 sumpc := ?, + template (present) BIT1 hrsbom := ?, + template (present) BIT1 epri := ?) := { + elementIdentifier := 186, + lengthIndicator := ?, + resti := resti, + sumpc := sumpc, + hrsbom := hrsbom, + epri := epri, + spare := '0000'B +} template (value) PDU_PFCP ts_PDU_PFCP_ := { s_flag := '0'B, @@ -1430,7 +1444,8 @@ node_list := omit, up_inactivity_timer := omit, user_id := omit, - apn_dnn := omit + apn_dnn := omit, + pfcpSEReq_flags := omit } } } @@ -1440,7 +1455,8 @@ template (present) Create_PDR_list create_pdr := ?, template (present) Create_FAR_list create_far := ?, template Create_URR_list create_urr := *, - template PDN_Type pdn_type := *) + template PDN_Type pdn_type := *, + template PFCPSEReq_Flags pfcpSEReq_flags := *) modifies tr_PDU_PFCP_ := { seid := '0000000000000000'O, /* shall be set to 0 as per 7.2.2.4.2 */ message_body := { @@ -1457,7 +1473,8 @@ node_list := *, up_inactivity_timer := *, user_id := *, - apn_dnn := * + apn_dnn := *, + pfcpSEReq_flags := pfcpSEReq_flags } } } -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43879?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Idc7fc117d25940f9e032dc347141a2fada57c912 Gerrit-Change-Number: 43879 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>
1 0
0 0
[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add tr/ts_profileInstallationResultData_err
by dexter 12 Oct '26

12 Oct '26
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43877?usp=email ) Change subject: RSPDefinitions_Templates: add tr/ts_profileInstallationResultData_err ...................................................................... RSPDefinitions_Templates: add tr/ts_profileInstallationResultData_err We already have a tr/ts_profileInstallationResultData temlate for the success case (successResult), let's now add a coresponding template for the error case (errorResult). Change-Id: Ib927cdea65adc633a8e4b93739f894b4adabffb5 Related: SYS#8203 --- M library/euicc/RSPDefinitions_Templates.ttcn 1 file changed, 36 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/77/43877/1 diff --git a/library/euicc/RSPDefinitions_Templates.ttcn b/library/euicc/RSPDefinitions_Templates.ttcn index ee93d1f..10116c5 100644 --- a/library/euicc/RSPDefinitions_Templates.ttcn +++ b/library/euicc/RSPDefinitions_Templates.ttcn @@ -648,6 +648,42 @@ } } } +template (present) ProfileInstallationResultData +tr_profileInstallationResultData_err(template (present) charstring notificationAddress := ?) := { + transactionId := ?, + notificationMetadata := { + seqNumber := ?, + profileManagementOperation := ?, + notificationAddress := notificationAddress, + iccid := * + }, + smdpOid := ?, + finalResult := { + errorResult := { + bppCommandId := ?, + errorReason := ?, + simaResponse := * + } + } +} +template (value) ProfileInstallationResultData +ts_profileInstallationResultData_err(template (value) charstring notificationAddress := SGP23_TEST_DP_ADDRESS1) := { + transactionId := SGP23_S_TRANSACTION_ID, + notificationMetadata := { + seqNumber := 1234, + profileManagementOperation := '1'B, /* notificationInstall */ + notificationAddress := notificationAddress, + iccid := SGP23_ICCID_OP_PROF1 + }, + smdpOid := SGP23_S_SM_DPp_OID, + finalResult := { + errorResult := { + bppCommandId := 5, /* loadProfileElements */ + errorReason := 1, /* incorrectInputValues */ + simaResponse := omit + } + } +} template (present) ProfileInstallationResult tr_profileInstallationResult(template (present) ProfileInstallationResultData profileInstallationResultData := tr_profileInstallationResultData, template (present) octetstring euiccSignPIR := ?) := { -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43877?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ib927cdea65adc633a8e4b93739f894b4adabffb5 Gerrit-Change-Number: 43877 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 61
  • 62
  • 63
  • 64
  • 65
  • 66
  • 67
  • ...
  • 125
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.