Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43908?usp=email )
Change subject: SGP32Definitions_Templates: add parameters to tr/ts_SGP32_cancelSessionResponse
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43908?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2b0bf75ad89e15c4ae2e002facce0b6a54a204bc
Gerrit-Change-Number: 43908
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 17 Oct 2026 11:33:46 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43911?usp=email )
Change subject: ss7_as_vty: Warn user that AS routing-key filtering based on SSN is not implemented
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43911?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I8ff07699e3436c76b1859f0a02cf1279d3c2399d
Gerrit-Change-Number: 43911
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 17 Oct 2026 11:33:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43845?usp=email )
Change subject: Support AS routing filtering based on its routing-key SI
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43845?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Iec4af5d9a3607747006c26e2baa61ab945f88532
Gerrit-Change-Number: 43845
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 17 Oct 2026 11:33:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: pespin.
laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43912?usp=email )
Change subject: tests/vty/osmo_stp_test.vty: validate routing-key opc and si fields
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43912?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Iaebef65b0630546aab56abf58c3c69633b2aa55d
Gerrit-Change-Number: 43912
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sat, 17 Oct 2026 11:31:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43858?usp=email )
Change subject: contrib/jenkins.sh: osmocon: enable -Werror and distcheck
......................................................................
contrib/jenkins.sh: osmocon: enable -Werror and distcheck
Change-Id: I8dff43ae12dca93ab6adb6e0fd09b738389c5d18
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 11 deletions(-)
Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, approved
diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index cd36e2f..c4b409f 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -37,8 +37,7 @@
set -x
-# building those sub-projects where 'distcheck' is known-working
-for dir in gprsdecode layer23 trxcon virt_phy; do
+for dir in gprsdecode layer23 osmocon trxcon virt_phy; do
cd $base/src/host/$dir
autoreconf -fi
./configure --enable-werror
@@ -46,15 +45,6 @@
DISTCHECK_CONFIGURE_FLAGS="--enable-werror" $MAKE $PARALLEL_MAKE distcheck
done
-# TODO: make sure 'distcheck' passes also for these
-# TODO: make sure '--enable-werror' passes also for these
-for dir in osmocon; do
- cd $base/src/host/$dir
- autoreconf -fi
- ./configure
- $MAKE $PARALLEL_MAKE
-done
-
# Build and publish manuals
if [ "$WITH_MANUALS" = "1" ]; then
make -C "$base/doc/manuals"
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43858?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I8dff43ae12dca93ab6adb6e0fd09b738389c5d18
Gerrit-Change-Number: 43858
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43857?usp=email )
Change subject: osmocon: fix make distcheck: symlink firmware files
......................................................................
osmocon: fix make distcheck: symlink firmware files
Relative paths to the firmware related files do not work when
building out of the source tree (e.g. during distcheck). Let's
symlink the necessary files instead, like we already do in trxcon.
Change-Id: I4566d907642375f72ae98a37e0b8193b02981b81
---
M src/host/osmocon/Makefile.am
A src/host/osmocon/loader_protocol.h
M src/host/osmocon/osmoload.c
A src/host/osmocon/sercomm.c
A src/host/osmocon/sercomm.h
5 files changed, 10 insertions(+), 5 deletions(-)
Approvals:
laforge: Looks good to me, approved
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
diff --git a/src/host/osmocon/Makefile.am b/src/host/osmocon/Makefile.am
index 9b02ca1..bcafb20 100644
--- a/src/host/osmocon/Makefile.am
+++ b/src/host/osmocon/Makefile.am
@@ -8,15 +8,17 @@
dist-hook:
echo $(VERSION) > $(distdir)/.tarball-version
-INCLUDES = $(all_includes) -I$(top_srcdir)/include
+AM_CPPFLAGS = -I$(srcdir) -DHOST_BUILD
AM_CFLAGS=-Wall $(LIBOSMOCORE_CFLAGS)
+# headers are actually symlinks to the firmware
+noinst_HEADERS = sercomm.h loader_protocol.h
+
sbin_PROGRAMS = osmocon osmoload
# FIXME: sercomm needs to move into libosmocore or another shared lib
-INCLUDES += -I$(srcdir)/../../target/firmware/include/comm -I$(srcdir)/../../target/firmware/apps -DHOST_BUILD
-osmocon_SOURCES = osmocon.c tpu_debug.c $(srcdir)/../../target/firmware/comm/sercomm.c
+osmocon_SOURCES = osmocon.c tpu_debug.c sercomm.c
osmocon_LDADD = $(LIBOSMOCORE_LIBS)
-osmoload_SOURCE = osmoload.c $(srcdir)/../../target/firmware/comm/sercomm.c
+osmoload_SOURCE = osmoload.c sercomm.c
osmoload_LDADD = $(LIBOSMOCORE_LIBS)
diff --git a/src/host/osmocon/loader_protocol.h b/src/host/osmocon/loader_protocol.h
new file mode 120000
index 0000000..a3e3bfc
--- /dev/null
+++ b/src/host/osmocon/loader_protocol.h
@@ -0,0 +1 @@
+../../target/firmware/apps/loader/protocol.h
\ No newline at end of file
diff --git a/src/host/osmocon/osmoload.c b/src/host/osmocon/osmoload.c
index 097cc84..14961f5 100644
--- a/src/host/osmocon/osmoload.c
+++ b/src/host/osmocon/osmoload.c
@@ -38,7 +38,7 @@
#include <osmocom/core/crc16.h>
#include <osmocom/core/socket.h>
-#include <loader/protocol.h>
+#include <loader_protocol.h>
#define MSGB_MAX 256
diff --git a/src/host/osmocon/sercomm.c b/src/host/osmocon/sercomm.c
new file mode 120000
index 0000000..2e07b7d
--- /dev/null
+++ b/src/host/osmocon/sercomm.c
@@ -0,0 +1 @@
+../../target/firmware/comm/sercomm.c
\ No newline at end of file
diff --git a/src/host/osmocon/sercomm.h b/src/host/osmocon/sercomm.h
new file mode 120000
index 0000000..9570947
--- /dev/null
+++ b/src/host/osmocon/sercomm.h
@@ -0,0 +1 @@
+../../target/firmware/include/comm/sercomm.h
\ No newline at end of file
--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43857?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: I4566d907642375f72ae98a37e0b8193b02981b81
Gerrit-Change-Number: 43857
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>