October 2026 - gerrit-log - lists.osmocom.org

[M] Change in libosmo-sigtran[master]: Support AS routing filtering based on its routing-key SI
by pespin 17 Oct '26

17 Oct '26

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43845?usp=email ) Change subject: Support AS routing filtering based on its routing-key SI ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43845?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: Iec4af5d9a3607747006c26e2baa61ab945f88532 Gerrit-Change-Number: 43845 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Oct 2026 21:03:02 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-msc[master]: mm-info: properly encode length 8n-1 network names
by tempest 17 Oct '26

17 Oct '26

tempest has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/43918?usp=email ) Change subject: mm-info: properly encode length 8n-1 network names ...................................................................... mm-info: properly encode length 8n-1 network names Because of the way CBS-format GSM messages are encoded (see 3GPP TS 23.038 6.1.2.3.1), messages of length 8n-1 require an special padding character to avoid being interpreted as a message of length 8n with some extra character postpended (commonly an @ character in the case of all zeroes, this case is explicitly mentioned in the aformentioned spec). Using the already existing gsm_7bit_encode_n_ussd instead of the SMS format gsm_7bit_encode_n resolves this issue of network names of length 8n-1 (commonly 7) showing with an erroneous @ character postpended on the end of the network name. Note: because gsm_7bit_encode_n_ussd relies on the returned octets pointer from gsm_7bit_encode_n, osmo-msc will segfault if NULL is passed to the USSD encode function. Unless a patch is wanted in libosmocore, a temporary octets variable works fine. Change-Id: Ib8328cd2c9984b490951d39f21e86a4ef63e35d5 Related: OS#6847 --- M src/libmsc/gsm_04_08.c 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/18/43918/1 diff --git a/src/libmsc/gsm_04_08.c b/src/libmsc/gsm_04_08.c index 0347f63..8a303d4 100644 --- a/src/libmsc/gsm_04_08.c +++ b/src/libmsc/gsm_04_08.c @@ -469,7 +469,7 @@ struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 MM INF"); struct gsm48_hdr *gh; uint8_t *ptr8; - int name_len, name_pad; + int name_len, name_pad, octets; time_t cur_t; struct tm* gmt_time; @@ -508,7 +508,7 @@ ptr8[2] = 0x80 | name_pad; /* Cell Broadcast DCS, no CI */ ptr8 = msgb_put(msg, name_len); - gsm_7bit_encode_n(ptr8, name_len, net->name_long, NULL); + gsm_7bit_encode_n_ussd(ptr8, name_len, net->name_long, &octets); } @@ -536,7 +536,7 @@ ptr8[2] = 0x80 | name_pad; /* Cell Broadcast DCS, no CI */ ptr8 = msgb_put(msg, name_len); - gsm_7bit_encode_n(ptr8, name_len, net->name_short, NULL); + gsm_7bit_encode_n_ussd(ptr8, name_len, net->name_short, &octets); } -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/43918?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ib8328cd2c9984b490951d39f21e86a4ef63e35d5 Gerrit-Change-Number: 43918 Gerrit-PatchSet: 1 Gerrit-Owner: tempest <jackleea1b(a)gmail.com>

1 0

[L] Change in osmocom-bb[master]: trxcon/trx_if: migrate to libosmo-trx
by fixeria 17 Oct '26

17 Oct '26

Attention is currently required from: laforge, osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email ) Change subject: trxcon/trx_if: migrate to libosmo-trx ...................................................................... Patch Set 3: (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/c41fbe1f_b1f220a0?u… : PS1, Line 17: flag (default auto), so that building the rest of osmocom-bb doesn't > I agree with @pespin@sysmocom. […] Removed the `auto`. `yes` is now the default. File contrib/jenkins.sh: https://gerrit.osmocom.org/c/osmocom-bb/+/43828/comment/0066a743_6d059b6f?u… : PS1, Line 29: osmo-build-dep.sh osmo-trx "" --disable-doxygen --disable-multi-arfcn --without-proxy > AFAIU since we are adding new configure flag, we should change the jenkins. […] `--without-proxy` is a configure flag of osmo-trx (not osmocom-bb) and I am passing it to speed up the build (we only need libosmo-trx and could also skip more unneeded stuff). I see no reason to add a configuration matrix for a configure flag of a library that we depend on. If you meant `--with-trxcon` / `--without-trxcon`, I don't think it's worth it. I've tested manually that the trxcon binary does not show up (and that libosmo-trx dependency is not enforced) when `--without-trxcon` or `--with-trxcon=no` is passed. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4604f4b12ca903e936dedf167b478455bd28a2e8 Gerrit-Change-Number: 43828 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Oct 2026 20:36:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osmith(a)sysmocom.de> Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[L] Change in osmocom-bb[master]: trxcon/trx_if: migrate to libosmo-trx
by fixeria 17 Oct '26

17 Oct '26

Attention is currently required from: osmith, pespin. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email ) Change subject: trxcon/trx_if: migrate to libosmo-trx ...................................................................... Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43828?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I4604f4b12ca903e936dedf167b478455bd28a2e8 Gerrit-Change-Number: 43828 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Oct 2026 20:22:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No

1 0

[S] Change in osmocom-bb[master]: trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1)
by fixeria 17 Oct '26

17 Oct '26

Attention is currently required from: fixeria. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmocom-bb/+/43829?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder The change is no longer submittable: Verified is unsatisfied now. Change subject: trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1) ...................................................................... trxcon/trx_if: negotiate TRXD PDU version 1 (TRXDv1) Now that trx_if.c is built against libosmo-trx, enable TRXDv1 by negotiating it (SETFORMAT) before every POWERON, since the transceiver may reset its active format back to legacy on the preceding POWEROFF. This significantly improves the ttcn3-bts-test pass/fail ratio in the frequency hopping configuration: TRXDv1 lets the transceiver (osmo-trx-proxy) send us NOPE.ind, which we rely on to keep driving uplink bursts even when no downlink burst was received. Change-Id: I08d588f74925bb7a85e131defc0fa82158d90680 Related: OS#6638 --- M src/host/trxcon/src/trx_if.c M src/host/trxcon/src/trxcon_shim.c 2 files changed, 36 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/29/43829/4 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43829?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I08d588f74925bb7a85e131defc0fa82158d90680 Gerrit-Change-Number: 43829 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: contrib/jenkins: upload to downloads.osmocom.org
by fixeria 17 Oct '26

17 Oct '26

Attention is currently required from: osmith. fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43916?usp=email ) Change subject: contrib/jenkins: upload to downloads.osmocom.org ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > @vyanitskiy@sysmocom. […] For most of the targets, the firmware does read and apply the calibration data. The Tx signal is probably still not as good as it is with the original firmware, but should be much better than it was before we merged Mychaela's patches. Related tickets: https://osmocom.org/issues/3582 https://osmocom.org/issues/5822 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ice48e7cc347c822aab19bb6646726591d2841cc3 Gerrit-Change-Number: 43916 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Oct 2026 12:04:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add parameters to tr/ts_cancelSessionRespon...
by laforge 17 Oct '26

17 Oct '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43910?usp=email ) Change subject: RSPDefinitions_Templates: add parameters to tr/ts_cancelSessionResponseOk ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43910?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Iaf396e4a9df6d03ef83f309d25d7cf20babfdbc4 Gerrit-Change-Number: 43910 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Oct 2026 11:34:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: RSPDefinitions_Templates: add parameters to tr/ts_cancelSessionResponse
by laforge 17 Oct '26

17 Oct '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43909?usp=email ) Change subject: RSPDefinitions_Templates: add parameters to tr/ts_cancelSessionResponse ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43909?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I0a4e580620b9ae098aedb4c311cfb514f389464b Gerrit-Change-Number: 43909 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Oct 2026 11:33:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ttcn3-hacks[master]: SGP32Definitions_Templates: add parameters to tr/ts_SGP32_cancelSessi...
by laforge 17 Oct '26

17 Oct '26

Attention is currently required from: dexter. laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43908?usp=email ) Change subject: SGP32Definitions_Templates: add parameters to tr/ts_SGP32_cancelSessionResponse ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43908?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I2b0bf75ad89e15c4ae2e002facce0b6a54a204bc Gerrit-Change-Number: 43908 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Oct 2026 11:33:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in libosmo-sigtran[master]: ss7_as_vty: Warn user that AS routing-key filtering based on SSN is n...
by laforge 17 Oct '26

17 Oct '26

Attention is currently required from: pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43911?usp=email ) Change subject: ss7_as_vty: Warn user that AS routing-key filtering based on SSN is not implemented ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43911?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I8ff07699e3436c76b1859f0a02cf1279d3c2399d Gerrit-Change-Number: 43911 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Sat, 17 Oct 2026 11:33:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log October 2026