October 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmocom-bb[master]: contrib/jenkins: build all with werr + distcheck
by pespin 16 Oct '26

16 Oct '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43915?usp=email ) Change subject: contrib/jenkins: build all with werr + distcheck ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I902262a9e6ab0e6279cc1da09992701925ea87ea Gerrit-Change-Number: 43915 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:52:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: osmocon: fix "make distcheck"
by pespin 16 Oct '26

16 Oct '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43914?usp=email ) Change subject: osmocon: fix "make distcheck" ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2008312609eaa0cf60233b0e95818a2fc76ae48b Gerrit-Change-Number: 43914 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:52:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmocom-bb[master]: osmocon: fix -Werror=old-style-definition
by pespin 16 Oct '26

16 Oct '26

Attention is currently required from: osmith. pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43913?usp=email ) Change subject: osmocon: fix -Werror=old-style-definition ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9bdb9439685c00403b5a09a81ef7bf556c709b7b Gerrit-Change-Number: 43913 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:51:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in osmo-ci[master]: jobs/master-builds: osmocom-bb: allow binaries upload
by osmith 16 Oct '26

16 Oct '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43917?usp=email ) Change subject: jobs/master-builds: osmocom-bb: allow binaries upload ...................................................................... jobs/master-builds: osmocom-bb: allow binaries upload Make the SSH key for uploading binaries available for the osmocom-bb job, so it can upload the binaries at the end. Related: OS#6879 Change-Id: I566bd56a95087907bd5b794d900a387cc0d534c2 --- M jobs/master-builds.yml 1 file changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/17/43917/1 diff --git a/jobs/master-builds.yml b/jobs/master-builds.yml index d915ccb..a0c0ad7 100644 --- a/jobs/master-builds.yml +++ b/jobs/master-builds.yml @@ -572,7 +572,11 @@ -e WITH_MANUALS="$WITH_MANUALS" \ "$DOCKER_IMG" {wrapper_cmd} $SETARCH_CMD /build/contrib/jenkins.sh - - osmocom-bb + - osmocom-bb: + ssh: + - binaries_ftp.osmocom.org + - docs_ftp.osmocom.org + - osmo-sysmon - osmo-remsim - osmo-asf4-dfu: -- To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43917?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ci Gerrit-Branch: master Gerrit-Change-Id: I566bd56a95087907bd5b794d900a387cc0d534c2 Gerrit-Change-Number: 43917 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: osmocon: fix "make distcheck"
by osmith 16 Oct '26

16 Oct '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43914?usp=email ) Change subject: osmocon: fix "make distcheck" ...................................................................... osmocon: fix "make distcheck" Change-Id: I2008312609eaa0cf60233b0e95818a2fc76ae48b --- M src/host/osmocon/.gitignore M src/host/osmocon/Makefile.am 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/14/43914/1 diff --git a/src/host/osmocon/.gitignore b/src/host/osmocon/.gitignore index ad061b7..1fd18e3 100644 --- a/src/host/osmocon/.gitignore +++ b/src/host/osmocon/.gitignore @@ -34,3 +34,7 @@ *.dump *.bin *.log + +# make distcheck +sercomm.h +loader/protocol.h diff --git a/src/host/osmocon/Makefile.am b/src/host/osmocon/Makefile.am index de4e575..020e65f 100644 --- a/src/host/osmocon/Makefile.am +++ b/src/host/osmocon/Makefile.am @@ -1,4 +1,10 @@ AUTOMAKE_OPTIONS = foreign dist-bzip2 1.6 +EXTRA_DIST = \ + .version \ + git-version-gen \ + loader/protocol.h \ + sercomm.h \ + $(NULL) # versioning magic BUILT_SOURCES = $(top_srcdir)/.version @@ -13,6 +19,17 @@ sbin_PROGRAMS = osmocon osmoload # FIXME: sercomm needs to move into libosmocore or another shared lib +sercomm.h: + ( echo "/* This file was copied from"; \ + echo " ../../target/firmware/include/comm/sercomm.h,"; \ + echo " do not modify! */"; \ + cat ../../target/firmware/include/comm/sercomm.h )> sercomm.h +loader/protocol.h: + mkdir -p loader + ( echo "/* This file was copied from"; \ + echo " ../../target/firmware/apps/loader/protocol.h,"; \ + echo " do not modify! */"; \ + cat ../../target/firmware/apps/loader/protocol.h )> loader/protocol.h INCLUDES += -I$(srcdir)/../../target/firmware/include/comm -I$(srcdir)/../../target/firmware/apps -DHOST_BUILD osmocon_SOURCES = osmocon.c tpu_debug.c $(srcdir)/../../target/firmware/comm/sercomm.c osmocon_LDADD = $(LIBOSMOCORE_LIBS) -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43914?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I2008312609eaa0cf60233b0e95818a2fc76ae48b Gerrit-Change-Number: 43914 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[master]: contrib/jenkins: build all with werr + distcheck
by osmith 16 Oct '26

16 Oct '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43915?usp=email ) Change subject: contrib/jenkins: build all with werr + distcheck ...................................................................... contrib/jenkins: build all with werr + distcheck Change-Id: I902262a9e6ab0e6279cc1da09992701925ea87ea --- M contrib/jenkins.sh 1 file changed, 1 insertion(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/15/43915/1 diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index cd36e2f..adead91 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -36,9 +36,8 @@ echo set -x - # building those sub-projects where 'distcheck' is known-working -for dir in gprsdecode layer23 trxcon virt_phy; do +for dir in gprsdecode layer23 osmocon trxcon virt_phy; do cd $base/src/host/$dir autoreconf -fi ./configure --enable-werror @@ -46,15 +45,6 @@ DISTCHECK_CONFIGURE_FLAGS="--enable-werror" $MAKE $PARALLEL_MAKE distcheck done -# TODO: make sure 'distcheck' passes also for these -# TODO: make sure '--enable-werror' passes also for these -for dir in osmocon; do - cd $base/src/host/$dir - autoreconf -fi - ./configure - $MAKE $PARALLEL_MAKE -done - # Build and publish manuals if [ "$WITH_MANUALS" = "1" ]; then make -C "$base/doc/manuals" -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43915?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I902262a9e6ab0e6279cc1da09992701925ea87ea Gerrit-Change-Number: 43915 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmocom-bb[master]: contrib/jenkins: upload to downloads.osmocom.org
by osmith 16 Oct '26

16 Oct '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43916?usp=email ) Change subject: contrib/jenkins: upload to downloads.osmocom.org ...................................................................... contrib/jenkins: upload to downloads.osmocom.org Related: OS#6879 Change-Id: Ice48e7cc347c822aab19bb6646726591d2841cc3 --- M .gitignore M contrib/jenkins.sh A contrib/upload_firmware.sh 3 files changed, 95 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/16/43916/1 diff --git a/.gitignore b/.gitignore index 2232749..de644c9 100644 --- a/.gitignore +++ b/.gitignore @@ -41,3 +41,6 @@ doc/manuals/osmocombb-usermanual.xml doc/manuals/common doc/manuals/build + +osmo-ci +.copy-done diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh index adead91..a243bce 100755 --- a/contrib/jenkins.sh +++ b/contrib/jenkins.sh @@ -69,4 +69,9 @@ cd "$base/src/target/trx_toolkit" python3 -m unittest discover -v +# Upload firmware to downloads.osmocom.org +if [ "$PUBLISH" = "1" ]; then + "$base"/contrib/upload_firmware.sh +fi + osmo-clean-workspace.sh diff --git a/contrib/upload_firmware.sh b/contrib/upload_firmware.sh new file mode 100755 index 0000000..18914f3 --- /dev/null +++ b/contrib/upload_firmware.sh @@ -0,0 +1,87 @@ +#!/bin/sh -e +TOPDIR="$(realpath $(dirname "$0")/..)" +GIT_VERSION="$("$TOPDIR"/src/shared/libosmocore/git-version-gen .tarball-version)" + +copy_with_latest_and_version() { + local marker="$TOPDIR"/.copy-done + + if [ -e "$marker" ]; then + return + fi + + echo "Copying binaries with "-latest" and "-$GIT_VERSION" appended..." + + # Example paths: + # * src/target/firmware/board/se_k2xx/hello_world.highram.elf + # * src/target/firmware/board/se_k2xx/hello_world.highram.bin + cd "$TOPDIR"/src/target/firmware/board + for ext in bin elf; do + for file in */*."$ext"; do + without_ext="${file%.*}" + cp -v "$file" "$without_ext-latest.$ext" + cp -v "$file" "$without_ext-$GIT_VERSION.$ext" + done + done + + touch "$marker" +} + +prepare_ssh_cmd() { + if ! [ -d "$TOPDIR"/osmo-ci ]; then + # Get known_hosts from osmo-ci + git -C "$TOPDIR" clone -q --depth=1 https://gerrit.osmocom.org/osmo-ci + fi + export SSH_COMMAND="ssh -o UserKnownHostsFile=$TOPDIR/osmo-ci/contrib/known_hosts -p 48" +} + +ssh_mkdir_p() { + $SSH_COMMAND binaries(a)ftp.osmocom.org -- mkdir -p -v /downloads/home/binaries/"$1" +} + +upload_board_latest() { + echo "[$BOARD] Uploading latest files" + + ssh_mkdir_p web-files/osmocom-bb/firmware/"$BOARD"/latest + + rsync \ + --archive \ + --verbose \ + --compress \ + --delete \ + --rsh "$SSH_COMMAND" \ + "$BOARD"/*-latest.bin \ + "$BOARD"/*-latest.elf \ + binaries@ftp.osmocom.org:web-files/osmocom-bb/firmware/"$BOARD"/latest/ +} + +upload_board_versioned() { + echo "[$BOARD] Uploading $GIT_VERSION files" + + ssh_mkdir_p web-files/osmocom-bb/firmware/"$BOARD"/all + + rsync \ + --archive \ + --verbose \ + --compress \ + --rsh "$SSH_COMMAND" \ + --exclude "$BOARD/*-latest.{bin,elf}" \ + "$BOARD"/*-*-*.bin \ + "$BOARD"/*-*-*.elf \ + binaries@ftp.osmocom.org:web-files/osmocom-bb/firmware/"$BOARD"/all/ +} + +upload_boards_all() { + cd "$TOPDIR"/src/target/firmware/board + for BOARD in *; do + if [ -z "$(find "$BOARD" -name '*.elf')" ]; then + echo "[$BOARD] has no elf files, skipping" + continue + fi + upload_board_latest + upload_board_versioned + done +} + +copy_with_latest_and_version +prepare_ssh_cmd +upload_boards_all -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43916?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Ice48e7cc347c822aab19bb6646726591d2841cc3 Gerrit-Change-Number: 43916 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[XS] Change in osmocom-bb[master]: osmocon: fix -Werror=old-style-definition
by osmith 16 Oct '26

16 Oct '26

osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmocom-bb/+/43913?usp=email ) Change subject: osmocon: fix -Werror=old-style-definition ...................................................................... osmocon: fix -Werror=old-style-definition Fix for: osmoload.c:636:1: error: old-style function definition [-Werror=old-style-definition] Change-Id: I9bdb9439685c00403b5a09a81ef7bf556c709b7b --- M src/host/osmocon/osmoload.c 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/13/43913/1 diff --git a/src/host/osmocon/osmoload.c b/src/host/osmocon/osmoload.c index b2f14bb..47c62da 100644 --- a/src/host/osmocon/osmoload.c +++ b/src/host/osmocon/osmoload.c @@ -205,8 +205,8 @@ } static void loader_do_memdump(uint16_t crc, void *address, size_t length); -static void loader_do_memload(); -static void loader_do_fprogram(); +static void loader_do_memload(void); +static void loader_do_fprogram(void); static void loader_do_flashrange(uint8_t cmd, struct msgb *msg, uint8_t chip, uint32_t address, uint32_t status); static void memop_timeout(void *dummy) { @@ -633,7 +633,7 @@ } static void -loader_do_memload() { +loader_do_memload(void) { uint32_t rembytes = osmoload.memlen - osmoload.memoff; if(!rembytes) { @@ -673,7 +673,7 @@ } static void -loader_do_fprogram() { +loader_do_fprogram(void) { uint32_t rembytes = osmoload.memlen - osmoload.memoff; if(!rembytes) { -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/43913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I9bdb9439685c00403b5a09a81ef7bf556c709b7b Gerrit-Change-Number: 43913 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osmith(a)sysmocom.de>

1 0

[M] Change in osmo-ttcn3-hacks[master]: smf: Introduce test TC_createSession_pfcp_sess_est_timeout
by osmith 16 Oct '26

16 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43902?usp=email ) Change subject: smf: Introduce test TC_createSession_pfcp_sess_est_timeout ...................................................................... Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43902?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I005cc6c6afd3f9aba15790e8cd67eeaa2f4d4b89 Gerrit-Change-Number: 43902 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:49:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-ttcn3-hacks[master]: smf: Introduce test TC_n11_createSession_pfcp_sess_est_timeout
by osmith 16 Oct '26

16 Oct '26

Attention is currently required from: pespin. osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43907?usp=email ) Change subject: smf: Introduce test TC_n11_createSession_pfcp_sess_est_timeout ...................................................................... Patch Set 3: Code-Review+1 Copied votes on follow-up patch sets have been updated: * Code-Review+1 has been copied to patch set 4 (copy condition: "changekind:NO_CHANGE OR changekind:TRIVIAL_REBASE OR is:MIN"). -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43907?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8edbfb261b8dfe629326410ced3dbf63491ad029 Gerrit-Change-Number: 43907 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 16 Oct 2026 14:49:04 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0