Attention is currently required from: dexter.
pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email )
Change subject: SGP23_Constants: use a reasonable default for sm_dp_oid
......................................................................
Patch Set 1:
(1 comment)
File library/Misc_Helpers.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930/comment/264cba27_7d70… :
PS1, Line 166: function objid2char(objid oid) return charstring {
> since this is not a builtin function, please prepend f_(). […]
I see in Osmocom_Types.ttcn we have similar functions without f_, so you can skip that part if you want, but I still think it's better to add a f_ to understand it's a TTCN-3 function defined somewhere.
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadf45954f18685c96d46b7df37c103eac3654332
Gerrit-Change-Number: 43930
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Oct 2026 08:20:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Attention is currently required from: dexter.
pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email )
Change subject: SGP23_Constants: use a reasonable default for sm_dp_oid
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
File library/Misc_Helpers.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930/comment/008482c4_1631… :
PS1, Line 166: function objid2char(objid oid) return charstring {
since this is not a builtin function, please prepend f_().
BTW, I think this function belongs better to Osmocom_Types.ttcn
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43930?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iadf45954f18685c96d46b7df37c103eac3654332
Gerrit-Change-Number: 43930
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Oct 2026 08:18:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43921?usp=email )
Change subject: onomondo_eim_app: use individual instance name per HTTP server
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43921?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I43be5666658c407fa1c1fe1a93ae61e428393218
Gerrit-Change-Number: 43921
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Oct 2026 20:25:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43920?usp=email )
Change subject: onomondo_eim_app: rename function start_esipa_server
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43920?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Ia8ffded7cdf82ea4a85e2b3708aa6429c4c46996
Gerrit-Change-Number: 43920
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Oct 2026 20:24:24 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43919?usp=email )
Change subject: eim_cfg: make the eimFqdn configurable
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43919?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: Idcee405b0a3096ce8fb1630816ad4353bebfe150
Gerrit-Change-Number: 43919
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Oct 2026 20:24:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: dexter.
laforge has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43817?usp=email )
Change subject: es9p_client: use atom undefinedError instead of 127
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43817?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I70ee698a73a7e57d6818a606b0af81ef455e4348
Gerrit-Change-Number: 43817
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Attention: dexter <pmaier(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 20 Oct 2026 20:23:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes