October 2026 - gerrit-log - lists.osmocom.org

[XS] Change in onomondo-eim[master]: eim_cfg: rename parameter "Style"
by dexter 21 Oct '26

21 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43936?usp=email ) Change subject: eim_cfg: rename parameter "Style" ...................................................................... eim_cfg: rename parameter "Style" The function gen_eim_configuration_data has a parameter "Style". This parameter sets which format the generated eIM configuration should have. Let's call this parameter "Format", which describes better what it is for. Let's also put a comment that explains how the function works. Related: SYS#8287 Change-Id: I34e2d1a7267d766b599da484c113f8e0bf68af21 --- M src/eim_cfg.erl 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/36/43936/1 diff --git a/src/eim_cfg.erl b/src/eim_cfg.erl index d026eee..dc2adac 100644 --- a/src/eim_cfg.erl +++ b/src/eim_cfg.erl @@ -9,7 +9,10 @@ -include_lib("public_key/include/public_key.hrl"). -export([gen_eim_configuration_data/1]). -gen_eim_configuration_data(Style) -> +% Generate an encoded eIM configuration string, which can be used to program the eIM configuration into an eUICC, +% either via ES10b:AddInitialEim or ESep:addEim (eUICC package, eCO). The Format parameter selects how the output data +% shall be formatted. Two formats are possible: request: AddInitialEimRequest, single: EimConfigurationData +gen_eim_configuration_data(Format) -> {ok, EimId} = application:get_env(onomondo_eim, eim_id), {ok, EimFqdn} = application:get_env(onomondo_eim, eim_fqdn), {ok, EimCertPath} = utils:get_env_priv_file_path(onomondo_eim, eim_cert), @@ -58,7 +61,7 @@ AddInitialEimRequest = #{eimConfigurationDataList => EimConfigurationDataList}, Encoded = - case Style of + case Format of request -> % Formatted as AddInitialEimRequest {ok, Asn1Encoded} = 'SGP32Definitions':encode( -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43936?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I34e2d1a7267d766b599da484c113f8e0bf68af21 Gerrit-Change-Number: 43936 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in onomondo-eim[master]: eim_cfg: split eimPublicKey loading into separete function
by dexter 21 Oct '26

21 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43937?usp=email ) Change subject: eim_cfg: split eimPublicKey loading into separete function ...................................................................... eim_cfg: split eimPublicKey loading into separete function When the eIM configuration is generated, the public eIM key is loaded from the eIM certificate. Let's put this part into a separate function and make this function public. (We will need the function to be public in a follow up patch). Related: SYS#8287 Change-Id: I6b62603e581ea204a55de6bcdb10adcd785642ca --- M src/eim_cfg.erl 1 file changed, 21 insertions(+), 14 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/37/43937/1 diff --git a/src/eim_cfg.erl b/src/eim_cfg.erl index dc2adac..1104853 100644 --- a/src/eim_cfg.erl +++ b/src/eim_cfg.erl @@ -7,24 +7,20 @@ -module(eim_cfg). -include_lib("public_key/include/public_key.hrl"). --export([gen_eim_configuration_data/1]). +-export([get_eimPublicKey_from_eim_cert/0, gen_eim_configuration_data/1]). -% Generate an encoded eIM configuration string, which can be used to program the eIM configuration into an eUICC, -% either via ES10b:AddInitialEim or ESep:addEim (eUICC package, eCO). The Format parameter selects how the output data -% shall be formatted. Two formats are possible: request: AddInitialEimRequest, single: EimConfigurationData -gen_eim_configuration_data(Format) -> - {ok, EimId} = application:get_env(onomondo_eim, eim_id), - {ok, EimFqdn} = application:get_env(onomondo_eim, eim_fqdn), +% Load the eimPublicKey from the configured eIM certificate (see sys.config). +get_eimPublicKey_from_eim_cert() -> + % Load eIM certificate and extract public key. {ok, EimCertPath} = utils:get_env_priv_file_path(onomondo_eim, eim_cert), {ok, EimCertPem} = file:read_file(EimCertPath), [{'Certificate', EimCertBer, not_encrypted}] = public_key:pem_decode(EimCertPem), {ok, EimCert} = 'PKIX1Explicit88':decode('Certificate', EimCertBer), - EimCert_TbsCertificate = maps:get(tbsCertificate, EimCert), - EimCert_SubjectPublicKeyInfo = maps:get(subjectPublicKeyInfo, EimCert_TbsCertificate), - {ok, CounterValue} = application:get_env(onomondo_eim, counter_value), + EimCertTbsCertificate = maps:get(tbsCertificate, EimCert), + EimCertSubjectPublicKeyInfo = maps:get(subjectPublicKeyInfo, EimCertTbsCertificate), - % Check certificate type - EimCert_algorithm = maps:get(algorithm, EimCert_SubjectPublicKeyInfo), + % Make sure that the algorithm is suitable and supported by this eIM. + EimCertAlgorithm = maps:get(algorithm, EimCertSubjectPublicKeyInfo), BrainpoolP256r1 = #{ algorithm => {1, 2, 840, 10045, 2, 1}, parameters => <<6, 9, 43, 36, 3, 3, 2, 8, 1, 1, 7>> @@ -33,12 +29,23 @@ algorithm => {1, 2, 840, 10045, 2, 1}, parameters => <<6, 8, 42, 134, 72, 206, 61, 3, 1, 7>> }, - case EimCert_algorithm of + case EimCertAlgorithm of BrainpoolP256r1 -> ok; Prime256v1 -> ok; _ -> throw("Incorrect eIM certificate, only BrainpoolP256r1 or Prime256v1 may be used!") end, + EimCertSubjectPublicKeyInfo. + +% Generate an encoded eIM configuration string, which can be used to program the eIM configuration into an eUICC, +% either via ES10b:AddInitialEim or ESep:addEim (eUICC package, eCO). The Format parameter selects how the output data +% shall be formatted. Two formats are possible: request: AddInitialEimRequest, single: EimConfigurationData +gen_eim_configuration_data(Format) -> + {ok, EimId} = application:get_env(onomondo_eim, eim_id), + {ok, EimFqdn} = application:get_env(onomondo_eim, eim_fqdn), + EimCertSubjectPublicKeyInfo = get_eimPublicKey_from_eim_cert(), + {ok, CounterValue} = application:get_env(onomondo_eim, counter_value), + % Generate eIM configuration EimConfigurationData = #{ eimId => EimId, @@ -49,7 +56,7 @@ % Optional: instruct the eUICC to calculate an association token associationToken => -1, % Mandatory - eimPublicKeyData => {eimPublicKey, EimCert_SubjectPublicKeyInfo}, + eimPublicKeyData => {eimPublicKey, EimCertSubjectPublicKeyInfo}, % This eIM implementation currently only supports ESipa via HTTPs where the only supported eIM Package % transfer procedure is the eIM Package Retrieval procedure (see also SGP.32, section 3.1.1.1. eimSupportedProtocol => [eimRetrieveHttps], -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43937?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I6b62603e581ea204a55de6bcdb10adcd785642ca Gerrit-Change-Number: 43937 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-eim[master]: contrib: improve script to re-generate the eIM certificate
by dexter 21 Oct '26

21 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43939?usp=email ) Change subject: contrib: improve script to re-generate the eIM certificate ...................................................................... contrib: improve script to re-generate the eIM certificate The eIM ships with a pre-generated eIM certificate and a script that can be used to re-generate the certificates. Let's apply some improvements and re-generate the certificates using the improved script. Related: SYS#8287 Change-Id: I0dc88c14492121fac955fc96b321fcf7ea326ae4 --- M contrib/make_eim_certificate.sh M priv/sample_eim_cert_brainpool.crt M priv/sample_eim_cert_brainpool.key M priv/sample_eim_cert_nist.crt M priv/sample_eim_cert_nist.key 5 files changed, 58 insertions(+), 34 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/39/43939/1 diff --git a/contrib/make_eim_certificate.sh b/contrib/make_eim_certificate.sh index ab25cbe..0fca310 100755 --- a/contrib/make_eim_certificate.sh +++ b/contrib/make_eim_certificate.sh @@ -1,13 +1,31 @@ #!/bin/bash -# This script is to illustrate how an eIM certificate could be generated using -# openssl. See also: GSMA SGP.32, section 2.6.4.2 +# This script may be used to generate an eIM certificate, which can be used to +# sign and verify eUICC packages (eCOs and PSMOs). The public key of the eIM +# certificate will be part of the eIM configuration, which is loaded onto the +# eUCCC. The private key is used by the eIM to sign the eUICC packages before +# sending them to the eUICC. (See also: GSMA SGP.32, section 2.6.4.2) + +C="EC" +ST="ExampleState" +L="ExampleLocality" +O="ExampleOrganization" +OU="ExampleOrganizationalUnit" +CN="ExampeCommonName" + +DAYS=365000 #1000 Years +OUTPUT_DIR=../priv/ #prime256v1: X9.62/SECG curve over a 256 bit prime field -openssl ecparam -genkey -name prime256v1 -noout -out sample_eim_cert_nist.key -openssl req -key sample_eim_cert_nist.key -new -x509 -days 36500 -out sample_eim_cert_nist.crt +openssl ecparam -name prime256v1 -genkey -noout -out sample_eim_cert_nist.key +openssl req -x509 -key sample_eim_cert_nist.key -out sample_eim_cert_nist.crt \ + -sha256 -days $DAYS -nodes -subj "/C=$C/ST=$ST/L=$L/O=$O/OU=$OU/CN=$CN" #brainpoolP256r1: RFC 5639 curve over a 256 bit prime field -openssl ecparam -genkey -name brainpoolP256r1 -noout -out sample_eim_cert_brainpool.key -openssl req -key sample_eim_cert_brainpool.key -new -x509 -days 36500 -out sample_eim_cert_brainpool.crt +openssl ecparam -name brainpoolP256r1 -genkey -noout -out sample_eim_cert_brainpool.key +openssl req -x509 -key sample_eim_cert_brainpool.key -out sample_eim_cert_brainpool.crt \ + -sha256 -days $DAYS -nodes -subj "/C=$C/ST=$ST/L=$L/O=$O/OU=$OU/CN=$CN" +#move certificates to output directory +mv ./*.key $OUTPUT_DIR +mv ./*.crt $OUTPUT_DIR diff --git a/priv/sample_eim_cert_brainpool.crt b/priv/sample_eim_cert_brainpool.crt index 541d9e4..6ae4825 100644 --- a/priv/sample_eim_cert_brainpool.crt +++ b/priv/sample_eim_cert_brainpool.crt @@ -1,13 +1,16 @@ -----BEGIN CERTIFICATE----- -MIIB4jCCAYigAwIBAgIUWIrJWeBmzulu5yt5ZHLGw6s5K/gwCgYIKoZIzj0EAwIw -RTELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoMGElu -dGVybmV0IFdpZGdpdHMgUHR5IEx0ZDAgFw0yNDA1MjIxMTEwNTZaGA8yMTI0MDQy -ODExMTA1NlowRTELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAf -BgNVBAoMGEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDBaMBQGByqGSM49AgEGCSsk -AwMCCAEBBwNCAASW2IBLRkBSZlg9nl6H4zps3z2HVfaahPVAXjfnP3bkYwXxaOyQ -zEnPFRYeq9uECTdj7tHWX7g8imqZq7N+86Sdo1MwUTAdBgNVHQ4EFgQUF0w8WS6N -x8qe1jwd/jxdg11lBSIwHwYDVR0jBBgwFoAUF0w8WS6Nx8qe1jwd/jxdg11lBSIw -DwYDVR0TAQH/BAUwAwEB/zAKBggqhkjOPQQDAgNIADBFAiBXmCDELWMTJN47FB82 -IpIqx2nFsZI/gJ12njrXBOzi/QIhAIyuRef27bLlFH6EWa8kxAyLpevJ4OZvPs95 -lFJzbFfq +MIICjzCCAjagAwIBAgIUAaOfZ6nHXz6Lnts4eOp/q5RpBFQwCgYIKoZIzj0EAwIw +gZsxCzAJBgNVBAYTAkVDMRUwEwYDVQQIDAxFeGFtcGxlU3RhdGUxGDAWBgNVBAcM +D0V4YW1wbGVMb2NhbGl0eTEcMBoGA1UECgwTRXhhbXBsZU9yZ2FuaXphdGlvbjEi +MCAGA1UECwwZRXhhbXBsZU9yZ2FuaXphdGlvbmFsVW5pdDEZMBcGA1UEAwwQRXhh +bXBlQ29tbW9uTmFtZTAgFw0yNjEwMjExMTI5MjBaGA8zMDI2MDIyMTExMjkyMFow +gZsxCzAJBgNVBAYTAkVDMRUwEwYDVQQIDAxFeGFtcGxlU3RhdGUxGDAWBgNVBAcM +D0V4YW1wbGVMb2NhbGl0eTEcMBoGA1UECgwTRXhhbXBsZU9yZ2FuaXphdGlvbjEi +MCAGA1UECwwZRXhhbXBsZU9yZ2FuaXphdGlvbmFsVW5pdDEZMBcGA1UEAwwQRXhh +bXBlQ29tbW9uTmFtZTBaMBQGByqGSM49AgEGCSskAwMCCAEBBwNCAAQylzPTz26D +cdaCzZWucNVFv1riwAqVfhpREWdh3DYSsqPjzMrWkBkbLFWP/k1myKwMANE47OMd +HX99XNq1OKzWo1MwUTAdBgNVHQ4EFgQUDVHVtDjsh4mYKDfpoZhyFCE/St8wHwYD +VR0jBBgwFoAUDVHVtDjsh4mYKDfpoZhyFCE/St8wDwYDVR0TAQH/BAUwAwEB/zAK +BggqhkjOPQQDAgNHADBEAiBv0SCPh+kO+4Jrn+2fYUsPUdLKie8QyGXNcofW7ET+ +PAIgWt0LaFWGPyt0GadJbjl5qAvqk01x/blax8Lv0WQTIj0= -----END CERTIFICATE----- diff --git a/priv/sample_eim_cert_brainpool.key b/priv/sample_eim_cert_brainpool.key index 2ff709c..4cce90b 100644 --- a/priv/sample_eim_cert_brainpool.key +++ b/priv/sample_eim_cert_brainpool.key @@ -1,5 +1,5 @@ -----BEGIN EC PRIVATE KEY----- -MHgCAQEEIIIH8O86z5njgI67CXMEVcIpw61LNJvYi7NW2mCka9lvoAsGCSskAwMC -CAEBB6FEA0IABJbYgEtGQFJmWD2eXofjOmzfPYdV9pqE9UBeN+c/duRjBfFo7JDM -Sc8VFh6r24QJN2Pu0dZfuDyKapmrs37zpJ0= +MHgCAQEEIGVrvICVkI4aMeTuW/pBKADyW6mOdGglgAUoYszS61QyoAsGCSskAwMC +CAEBB6FEA0IABDKXM9PPboNx1oLNla5w1UW/WuLACpV+GlERZ2HcNhKyo+PMytaQ +GRssVY/+TWbIrAwA0Tjs4x0df31c2rU4rNY= -----END EC PRIVATE KEY----- diff --git a/priv/sample_eim_cert_nist.crt b/priv/sample_eim_cert_nist.crt index c6725ad..85f2959 100644 --- a/priv/sample_eim_cert_nist.crt +++ b/priv/sample_eim_cert_nist.crt @@ -1,13 +1,16 @@ -----BEGIN CERTIFICATE----- -MIIB4jCCAYegAwIBAgIUTGB6P8Y9qfPRcs3sOh1rF5qalk4wCgYIKoZIzj0EAwIw -RTELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAfBgNVBAoMGElu -dGVybmV0IFdpZGdpdHMgUHR5IEx0ZDAgFw0yNDA1MjIxMTEwNTVaGA8yMTI0MDQy -ODExMTA1NVowRTELMAkGA1UEBhMCQVUxEzARBgNVBAgMClNvbWUtU3RhdGUxITAf -BgNVBAoMGEludGVybmV0IFdpZGdpdHMgUHR5IEx0ZDBZMBMGByqGSM49AgEGCCqG -SM49AwEHA0IABP5YSm9FBFlXSuyhldAplzf3TIm6LTbfkobsJdlzA3oPunDRTfPh -99CjBeV7lbcxxN4hjS1/nyIRPtXRjC493xyjUzBRMB0GA1UdDgQWBBSuLb4g6A1R -7Yj+arQrJbcEJEB9djAfBgNVHSMEGDAWgBSuLb4g6A1R7Yj+arQrJbcEJEB9djAP -BgNVHRMBAf8EBTADAQH/MAoGCCqGSM49BAMCA0kAMEYCIQDPDDvfcV0F/f+JPg0j -tmNNXH7CY91XEAcjKMWJmYJjdwIhAIfF6YbEcAIyY5129StjAB/xtXAS4JgBHok1 -o3NsXrXx +MIICkDCCAjWgAwIBAgIUWJ4+3BbLpKI8kv+deHlrDNnP6aowCgYIKoZIzj0EAwIw +gZsxCzAJBgNVBAYTAkVDMRUwEwYDVQQIDAxFeGFtcGxlU3RhdGUxGDAWBgNVBAcM +D0V4YW1wbGVMb2NhbGl0eTEcMBoGA1UECgwTRXhhbXBsZU9yZ2FuaXphdGlvbjEi +MCAGA1UECwwZRXhhbXBsZU9yZ2FuaXphdGlvbmFsVW5pdDEZMBcGA1UEAwwQRXhh +bXBlQ29tbW9uTmFtZTAgFw0yNjEwMjExMTI5MjBaGA8zMDI2MDIyMTExMjkyMFow +gZsxCzAJBgNVBAYTAkVDMRUwEwYDVQQIDAxFeGFtcGxlU3RhdGUxGDAWBgNVBAcM +D0V4YW1wbGVMb2NhbGl0eTEcMBoGA1UECgwTRXhhbXBsZU9yZ2FuaXphdGlvbjEi +MCAGA1UECwwZRXhhbXBsZU9yZ2FuaXphdGlvbmFsVW5pdDEZMBcGA1UEAwwQRXhh +bXBlQ29tbW9uTmFtZTBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABELbNTAi0XTB +jVFCOQwkVRXP2gi3FoQivnaun3qKaAo2g7q07EuFhe/Dc8hEXZDdq7BBunAfIkr0 +zp4Z1fCkUR6jUzBRMB0GA1UdDgQWBBTNOK98JKC5SENja2a3tncCl9gpnDAfBgNV +HSMEGDAWgBTNOK98JKC5SENja2a3tncCl9gpnDAPBgNVHRMBAf8EBTADAQH/MAoG +CCqGSM49BAMCA0kAMEYCIQDgXoYoqrZn5ood8iXPdpnrYFw2Cygu78z1/Byax4FI +QQIhAN9FDkGw/ioUgFizGYtXQJZXRSM3V1vvtehbDS2MSW3R -----END CERTIFICATE----- diff --git a/priv/sample_eim_cert_nist.key b/priv/sample_eim_cert_nist.key index 119cf81..07440f4 100644 --- a/priv/sample_eim_cert_nist.key +++ b/priv/sample_eim_cert_nist.key @@ -1,5 +1,5 @@ -----BEGIN EC PRIVATE KEY----- -MHcCAQEEIJTota/YsWhFhwHqEcDiFhTN+V/oRjUQNmF3qI0RPeFLoAoGCCqGSM49 -AwEHoUQDQgAE/lhKb0UEWVdK7KGV0CmXN/dMibotNt+Shuwl2XMDeg+6cNFN8+H3 -0KMF5XuVtzHE3iGNLX+fIhE+1dGMLj3fHA== +MHcCAQEEIImxzoQUnpvWsfoYQQpv8W6Dnj3v2Bk7BXR6nnV0uePGoAoGCCqGSM49 +AwEHoUQDQgAEQts1MCLRdMGNUUI5DCRVFc/aCLcWhCK+dq6feopoCjaDurTsS4WF +78NzyERdkN2rsEG6cB8iSvTOnhnV8KRRHg== -----END EC PRIVATE KEY----- -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43939?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: I0dc88c14492121fac955fc96b321fcf7ea326ae4 Gerrit-Change-Number: 43939 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in onomondo-eim[master]: onomondo_eim_app: check eIM certificate on startup
by dexter 21 Oct '26

21 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43938?usp=email ) Change subject: onomondo_eim_app: check eIM certificate on startup ...................................................................... onomondo_eim_app: check eIM certificate on startup The public key from the eIM certificate is used to generate the eIM configuration, which is quieried by REST-API users to provision the eIM configuration into new and existing eUICCs. The related private key is then used to sign eCOs and PSMOs which are sent to remote eUICCs. Since the provisioning of invalid key material may lead to catastrophic failures, let's implement a check ensures that the configured key material is correctly configured and valid. Related: SYS#8287 Change-Id: Ib4463ef29bc39c4c11a7c78c2135ec28ba6a2e1f --- M src/crypto_utils.erl M src/onomondo_eim_app.erl 2 files changed, 59 insertions(+), 26 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/38/43938/1 diff --git a/src/crypto_utils.erl b/src/crypto_utils.erl index d07b931..ee7e6d3 100644 --- a/src/crypto_utils.erl +++ b/src/crypto_utils.erl @@ -11,7 +11,8 @@ verify_euiccPackageResultSigned/2, verify_euiccPackageErrorSigned/2, store_euicc_pubkey_from_authenticateResponseOk/2, - store_euicc_pubkey_from_ipaEuiccDataResponse/2 + store_euicc_pubkey_from_ipaEuiccDataResponse/2, + test_eim_certificate/0 ]). %Convert from DER encoded signature format to plain format (see also BSI TR03111 5.2.1) @@ -36,6 +37,18 @@ AssociationTokenLength = utils:integer_to_bytes(byte_size(AssociationTokenBinary)), utils:join_binary_list([<<132>>, AssociationTokenLength, AssociationTokenBinary]). +sign_with_private_eim_key(MsgToBeSigned) -> + % Load private key from eIM certificate + {ok, EimKeyPath} = utils:get_env_priv_file_path(onomondo_eim, eim_key), + {ok, EimKeyPem} = file:read_file(EimKeyPath), + [EimKeyPemEntry] = public_key:pem_decode(EimKeyPem), + EimKeyECPrivateKey = public_key:pem_entry_decode(EimKeyPemEntry), + + % Sign message + % We use SHA-256 as signature hash/digest, see also GSMA SGP.22, section 2.6.5 and + % https://www.erlang.org/doc/apps/public_key/public_key#sign/4 + der_to_plain(public_key:sign(MsgToBeSigned, sha256, EimKeyECPrivateKey)). + sign_euiccPackageSigned(EuiccPackageSigned, EidValue) -> % Read the AssociationToken {ok, AssociationToken} = mnesia_db_euicc:state_get(EidValue, associationToken), @@ -48,16 +61,8 @@ EuiccPackageSignedEnc, enc_association_token(AssociationToken) ]), - % Load private key from eIM certificate - {ok, EimKeyPath} = utils:get_env_priv_file_path(onomondo_eim, eim_key), - {ok, EimKeyPem} = file:read_file(EimKeyPath), - [EimKeyPemEntry] = public_key:pem_decode(EimKeyPem), - EimKeyECPrivateKey = public_key:pem_entry_decode(EimKeyPemEntry), - % Sign message - % We use SHA-256 as signature hash/digest, see also GSMA SGP.22, section 2.6.5 and - % https://www.erlang.org/doc/apps/public_key/public_key#sign/4 - der_to_plain(public_key:sign(MsgToBeSigned, sha256, EimKeyECPrivateKey)). + sign_with_private_eim_key(MsgToBeSigned). verify_signature(Message, Signature, EidValue) -> DERSignature = plain_to_der(Signature), @@ -164,11 +169,7 @@ ok end. -pubkey_from_cert(Cert) -> - TbsCertificate = maps:get(tbsCertificate, Cert), - SubjectPublicKeyInfo = maps:get(subjectPublicKeyInfo, TbsCertificate), - Algorithm = maps:get(algorithm, SubjectPublicKeyInfo), - SubjectPublicKey = maps:get(subjectPublicKey, SubjectPublicKeyInfo), +namedCurve_from_algorithm(Algorithm) -> BrainpoolP256r1 = #{ algorithm => {1, 2, 840, 10045, 2, 1}, parameters => <<6, 9, 43, 36, 3, 3, 2, 8, 1, 1, 7>> @@ -177,17 +178,23 @@ algorithm => {1, 2, 840, 10045, 2, 1}, parameters => <<6, 8, 42, 134, 72, 206, 61, 3, 1, 7>> }, - NamedCurve = - case Algorithm of - Prime256v1 -> - {1, 2, 840, 10045, 3, 1, 7}; - BrainpoolP256r1 -> - {1, 3, 36, 3, 3, 2, 8, 1, 1, 7}; - _ -> - throw( - "Incorrect root CI certificate, only BrainpoolP256r1 or Prime256v1 may be used!" - ) - end, + case Algorithm of + Prime256v1 -> + {1, 2, 840, 10045, 3, 1, 7}; + BrainpoolP256r1 -> + {1, 3, 36, 3, 3, 2, 8, 1, 1, 7}; + _ -> + throw( + "Incorrect root CI certificate, only BrainpoolP256r1 or Prime256v1 may be used!" + ) + end. + +pubkey_from_cert(Cert) -> + TbsCertificate = maps:get(tbsCertificate, Cert), + SubjectPublicKeyInfo = maps:get(subjectPublicKeyInfo, TbsCertificate), + Algorithm = maps:get(algorithm, SubjectPublicKeyInfo), + SubjectPublicKey = maps:get(subjectPublicKey, SubjectPublicKeyInfo), + NamedCurve = namedCurve_from_algorithm(Algorithm), {{'ECPoint', SubjectPublicKey}, {namedCurve, NamedCurve}}. verify_cert(TrustedCert, VerifyCert) -> @@ -325,3 +332,26 @@ % There is already a public key stored for this eUICC ok end. + +% Make sure that the key material (eIM certificate) for signing eUICC packages is correctly configured and valid. +test_eim_certificate() -> + % Sign an arbitrary message using the eIM private key + Message = list_to_binary("The quick brown fox jumps over the lazy dog."), + Signature = sign_with_private_eim_key(Message), + DERSignature = plain_to_der(Signature), + + % Retrieve the eIM public key from the eIM certificate and verify the signature of the message we have signed above. + EimCertSubjectPublicKeyInfo = eim_cfg:get_eimPublicKey_from_eim_cert(), + Algorithm = maps:get(algorithm, EimCertSubjectPublicKeyInfo), + SubjectPublicKey = maps:get(subjectPublicKey, EimCertSubjectPublicKeyInfo), + NamedCurve = namedCurve_from_algorithm(Algorithm), + ECPublicKey = {{'ECPoint', SubjectPublicKey}, {namedCurve, NamedCurve}}, + Result = public_key:verify(Message, sha256, DERSignature, ECPublicKey), + case Result of + false -> + throw( + "eIM certificate (eUICC package signing) unuseable, check key material and algorithm (sys.config)!~n" + ); + true -> + ok + end. diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl index 688f83a..227c938 100644 --- a/src/onomondo_eim_app.erl +++ b/src/onomondo_eim_app.erl @@ -104,6 +104,9 @@ % effective than fumbling with string format arguments. logger:notice("eIM! version: ~s~n", [Vsn]), + % Ensure that the key material that is used for signing PSMOs and eCOs is correctly configured and valid. + crypto_utils:test_eim_certificate(), + % Startup database ok = mnesia_db:init(), -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43938?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Ib4463ef29bc39c4c11a7c78c2135ec28ba6a2e1f Gerrit-Change-Number: 43938 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: es10b_add_init_eim: improve log output
by dexter 21 Oct '26

21 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43935?usp=email ) Change subject: es10b_add_init_eim: improve log output ...................................................................... es10b_add_init_eim: improve log output When the IoT eUICC emulation is active, the AddInitialEim has to complete the eIM configuration before storing it. The completion process assignes values to fields that are normally populated by the eUICC. Let's print a log line to make the user aware that this process happens, so that there is no confusion about the completed eIM configuration that is printed in the log lines after. Let's also add another comment that explains what the completion is about. Related: SYS#8287 Change-Id: Ife69835b378ae67c021bd1ad7dddd9f7259ebc47 --- M src/ipa/libipa/es10b_add_init_eim.c 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/35/43935/1 diff --git a/src/ipa/libipa/es10b_add_init_eim.c b/src/ipa/libipa/es10b_add_init_eim.c index 2efa02d..a63cc22 100644 --- a/src/ipa/libipa/es10b_add_init_eim.c +++ b/src/ipa/libipa/es10b_add_init_eim.c @@ -130,10 +130,17 @@ struct AddInitialEimRequest *complete_eim_cfg_list(struct ipa_context *ctx, const struct AddInitialEimRequest *req) { + /* The eIM configuration that is supplied with an AddInitialEimRequest is typically only a template and may + * lack certain values, which are normally computed by the eUICC (e.g. the associationToken). This function + * goes through all eIM configurations in the supplied AddInitialEimRequest and completes them. (This function + * must only be called from the IoT eUICC emulation code paths. It has no relevance for native IoT eUICCs) */ + struct AddInitialEimRequest *req_dup; unsigned int i; int rc; + IPA_LOGP_ES10X("AddInitialEim", LINFO, "IoT eUICC emulation active, completing eIM configuration...\n"); + req_dup = ipa_asn1c_dup(&asn_DEF_AddInitialEimRequest, req); for (i = 0; i < req_dup->eimConfigurationDataList.list.count; i++) { -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43935?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: Ife69835b378ae67c021bd1ad7dddd9f7259ebc47 Gerrit-Change-Number: 43935 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in onomondo-ipa[master]: es10b_add_init_eim: display original eIM config before loading
by dexter 21 Oct '26

21 Oct '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-ipa/+/43934?usp=email ) Change subject: es10b_add_init_eim: display original eIM config before loading ...................................................................... es10b_add_init_eim: display original eIM config before loading The log displays the messages exchanged between the host and the eUICC. However, when the IoT eUICC emulation is active, the AddInitialEim will display the eIM configuration as it is stored. This is a modified version of the eIM configuration. In some cases it is very important to monitor the exact eIM configuration as it is loaded from the input file. So let's log the unmodifed eIM configuration before carrying out any action. Related: SYS#8287 Change-Id: I8d9600c8701ea98258dd035ab0fd32a9ab96efa2 --- M src/ipa/libipa/es10b_add_init_eim.c 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/onomondo-ipa refs/changes/34/43934/1 diff --git a/src/ipa/libipa/es10b_add_init_eim.c b/src/ipa/libipa/es10b_add_init_eim.c index ba9e3c1..2efa02d 100644 --- a/src/ipa/libipa/es10b_add_init_eim.c +++ b/src/ipa/libipa/es10b_add_init_eim.c @@ -238,6 +238,10 @@ struct ipa_es10b_add_init_eim_res *ipa_es10b_add_init_eim(struct ipa_context *ctx, const struct ipa_es10b_add_init_eim_req *req) { + IPA_LOGP_ES10X("AddInitialEim", LDEBUG, + "The following eIM configuration is programmed into the eUICC:\n"); + ipa_asn1c_dump(&asn_DEF_AddInitialEimRequest, &req->req, 1, SES10X, LDEBUG); + if (ctx->cfg->iot_euicc_emu_enabled) return add_init_eim_iot_emu(ctx, req); else -- To view, visit https://gerrit.osmocom.org/c/onomondo-ipa/+/43934?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: onomondo-ipa Gerrit-Branch: master Gerrit-Change-Id: I8d9600c8701ea98258dd035ab0fd32a9ab96efa2 Gerrit-Change-Number: 43934 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[M] Change in osmo-e1d[master]: Use VTY node definition from libosmocore
by jolly 21 Oct '26

21 Oct '26

jolly has submitted this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/43686?usp=email ) Change subject: Use VTY node definition from libosmocore ...................................................................... Use VTY node definition from libosmocore Depends-on: I497ee1503fed1681fae217bfe4d7be9b1580448f (libosmocore) Change-Id: I1e176362eba4966ad6c249831d6a82d0ed4ea6d5 --- M TODO-RELEASE M src/octoi/octoi.c M src/octoi/octoi.h M src/octoi/octoi_clnt_vty.c M src/octoi/octoi_srv_vty.c 5 files changed, 43 insertions(+), 51 deletions(-) Approvals: pespin: Looks good to me, approved Jenkins Builder: Verified diff --git a/TODO-RELEASE b/TODO-RELEASE index 0ed7189..eb0e5c7 100644 --- a/TODO-RELEASE +++ b/TODO-RELEASE @@ -7,3 +7,4 @@ # If any interfaces have been added since the last public release: c:r:a + 1. # If any interfaces have been removed or changed since the last public release: c:r:0. #library what description / commit summary line +libosmocore >1.14.2 new VTY nodes L_OCTOI_* added diff --git a/src/octoi/octoi.c b/src/octoi/octoi.c index 8d8d3da..9a80f11 100644 --- a/src/octoi/octoi.c +++ b/src/octoi/octoi.c @@ -46,16 +46,16 @@ struct octoi_client *clnt; switch (vty->node) { - case OCTOI_ACCOUNT_NODE: - vty->node = OCTOI_SRV_NODE; + case L_OCTOI_ACCOUNT_NODE: + vty->node = L_OCTOI_SRV_NODE; vty->index = g_octoi->server; break; - case OCTOI_CLNT_ACCOUNT_NODE: + case L_OCTOI_CLNT_ACCOUNT_NODE: acc = vty->index; - vty->node = OCTOI_CLNT_NODE; + vty->node = L_OCTOI_CLNT_NODE; vty->index = client4account(acc); break; - case OCTOI_CLNT_NODE: + case L_OCTOI_CLNT_NODE: clnt = vty->index; /* check if we have a (new?) line for this client */ if (g_octoi->ops->client_updated) diff --git a/src/octoi/octoi.h b/src/octoi/octoi.h index 589c208..4505e3c 100644 --- a/src/octoi/octoi.h +++ b/src/octoi/octoi.h @@ -8,15 +8,6 @@ #include <osmocom/octoi/octoi.h> -/* FIXME: migrate to libosmocore/vty/command.h */ -enum octoi_vty_node { - OCTOI_SRV_NODE = RESERVED1_NODE, - OCTOI_ACCOUNT_NODE, - OCTOI_CLNT_NODE, - OCTOI_CLNT_ACCOUNT_NODE, -}; - - extern struct osmo_fsm octoi_server_fsm; extern struct osmo_fsm octoi_client_fsm; diff --git a/src/octoi/octoi_clnt_vty.c b/src/octoi/octoi_clnt_vty.c index 3ea3a9a..7323c71 100644 --- a/src/octoi/octoi_clnt_vty.c +++ b/src/octoi/octoi_clnt_vty.c @@ -76,13 +76,13 @@ ***********************************************************************/ static struct cmd_node clnt_node = { - (enum node_type) OCTOI_CLNT_NODE, + (enum node_type) L_OCTOI_CLNT_NODE, "%s(config-octoi-client)# ", 1, }; static struct cmd_node clnt_account_node = { - (enum node_type) OCTOI_CLNT_ACCOUNT_NODE, + (enum node_type) L_OCTOI_CLNT_ACCOUNT_NODE, "%s(config-octoi-client-account)# ", 1, }; @@ -104,7 +104,7 @@ llist_add_tail(&clnt->list, &g_octoi->clients); } - vty->node = OCTOI_CLNT_NODE; + vty->node = L_OCTOI_CLNT_NODE; vty->index = clnt; return CMD_SUCCESS; @@ -227,7 +227,7 @@ } else osmo_talloc_replace_string(ac, &ac->user_id, user_id); - vty->node = OCTOI_CLNT_ACCOUNT_NODE; + vty->node = L_OCTOI_CLNT_ACCOUNT_NODE; vty->index = ac; return CMD_SUCCESS; @@ -277,23 +277,23 @@ install_element_ve(&show_clnt_cmd); install_node(&clnt_account_node, NULL); - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_ice1_serno_cmd); - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_ice1_line_cmd); - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_mode_cmd); - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_batching_factor_cmd); - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_force_all_ts_cmd); - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_no_force_all_ts_cmd); - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_prefill_frame_count_cmd); - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_buffer_reset_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_ice1_serno_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_ice1_line_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_mode_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_batching_factor_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_force_all_ts_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_no_force_all_ts_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_prefill_frame_count_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_buffer_reset_cmd); #ifdef HAVE_DAHDI_TRUNKDEV - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_trunkdev_name_cmd); - install_element(OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_trunkdev_line_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_trunkdev_name_cmd); + install_element(L_OCTOI_CLNT_ACCOUNT_NODE, &cfg_account_trunkdev_line_cmd); #endif /* HAVE_DAHDI_TRUNKDEV */ install_node(&clnt_node, config_write_octoi_clnt); install_element(CONFIG_NODE, &cfg_client_cmd); - install_element(OCTOI_CLNT_NODE, &cfg_clnt_local_cmd); - install_element(OCTOI_CLNT_NODE, &cfg_clnt_dscp_cmd); - install_element(OCTOI_CLNT_NODE, &cfg_clnt_prio_cmd); - install_element(OCTOI_CLNT_NODE, &cfg_clnt_account_cmd); + install_element(L_OCTOI_CLNT_NODE, &cfg_clnt_local_cmd); + install_element(L_OCTOI_CLNT_NODE, &cfg_clnt_dscp_cmd); + install_element(L_OCTOI_CLNT_NODE, &cfg_clnt_prio_cmd); + install_element(L_OCTOI_CLNT_NODE, &cfg_clnt_account_cmd); } diff --git a/src/octoi/octoi_srv_vty.c b/src/octoi/octoi_srv_vty.c index 05a99a4..32fe3c6 100644 --- a/src/octoi/octoi_srv_vty.c +++ b/src/octoi/octoi_srv_vty.c @@ -123,13 +123,13 @@ ***********************************************************************/ static struct cmd_node srv_node = { - (enum node_type) OCTOI_SRV_NODE, + (enum node_type) L_OCTOI_SRV_NODE, "%s(config-octoi-server)# ", 1, }; static struct cmd_node account_node = { - (enum node_type) OCTOI_ACCOUNT_NODE, + (enum node_type) L_OCTOI_ACCOUNT_NODE, "%s(config-octoi-server-account)# ", 1, }; @@ -144,7 +144,7 @@ srv = g_octoi->server = octoi_server_alloc(g_octoi); OSMO_ASSERT(srv); - vty->node = OCTOI_SRV_NODE; + vty->node = L_OCTOI_SRV_NODE; vty->index = srv; return CMD_SUCCESS; @@ -264,7 +264,7 @@ if (!ac) return CMD_WARNING; - vty->node = OCTOI_ACCOUNT_NODE; + vty->node = L_OCTOI_ACCOUNT_NODE; vty->index = ac; return CMD_SUCCESS; @@ -566,26 +566,26 @@ install_element_ve(&show_server_cmd); install_node(&account_node, NULL); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_mode_cmd); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_ice1_serno_cmd); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_ice1_line_cmd); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_redir_cmd); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_batching_factor_cmd); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_force_all_ts_cmd); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_no_force_all_ts_cmd); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_prefill_frame_count_cmd); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_buffer_reset_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_mode_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_ice1_serno_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_ice1_line_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_redir_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_batching_factor_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_force_all_ts_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_no_force_all_ts_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_prefill_frame_count_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_buffer_reset_cmd); #ifdef HAVE_DAHDI_TRUNKDEV - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_trunkdev_name_cmd); - install_element(OCTOI_ACCOUNT_NODE, &cfg_account_trunkdev_line_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_trunkdev_name_cmd); + install_element(L_OCTOI_ACCOUNT_NODE, &cfg_account_trunkdev_line_cmd); #endif /* HAVE_DAHDI_TRUNKDEV */ install_node(&srv_node, config_write_octoi_srv); install_element(CONFIG_NODE, &cfg_server_cmd); //install_element(CONFIG_NODE, &cfg_no_server_cmd); - install_element(OCTOI_SRV_NODE, &cfg_srv_local_cmd); - install_element(OCTOI_SRV_NODE, &cfg_srv_dscp_cmd); - install_element(OCTOI_SRV_NODE, &cfg_srv_prio_cmd); - install_element(OCTOI_SRV_NODE, &cfg_srv_account_cmd); + install_element(L_OCTOI_SRV_NODE, &cfg_srv_local_cmd); + install_element(L_OCTOI_SRV_NODE, &cfg_srv_dscp_cmd); + install_element(L_OCTOI_SRV_NODE, &cfg_srv_prio_cmd); + install_element(L_OCTOI_SRV_NODE, &cfg_srv_account_cmd); //install_element(CONFIG_SRV_NODE, &cfg_srv_no_account_cmd); } -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/43686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I1e176362eba4966ad6c249831d6a82d0ed4ea6d5 Gerrit-Change-Number: 43686 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-e1d[master]: Use VTY node definition from libosmocore
by pespin 21 Oct '26

21 Oct '26

Attention is currently required from: jolly, osmith. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-e1d/+/43686?usp=email ) Change subject: Use VTY node definition from libosmocore ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/43686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I1e176362eba4966ad6c249831d6a82d0ed4ea6d5 Gerrit-Change-Number: 43686 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Wed, 21 Oct 2026 12:18:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-e1d[master]: Use VTY node definition from libosmocore
by jolly 21 Oct '26

21 Oct '26

Attention is currently required from: jolly, osmith, pespin. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/43686?usp=email to look at the new patch set (#3). Change subject: Use VTY node definition from libosmocore ...................................................................... Use VTY node definition from libosmocore Depends-on: I497ee1503fed1681fae217bfe4d7be9b1580448f (libosmocore) Change-Id: I1e176362eba4966ad6c249831d6a82d0ed4ea6d5 --- M TODO-RELEASE M src/octoi/octoi.c M src/octoi/octoi.h M src/octoi/octoi_clnt_vty.c M src/octoi/octoi_srv_vty.c 5 files changed, 43 insertions(+), 51 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/86/43686/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/43686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I1e176362eba4966ad6c249831d6a82d0ed4ea6d5 Gerrit-Change-Number: 43686 Gerrit-PatchSet: 3 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[M] Change in osmo-e1d[master]: Use VTY node defintion from libosmocore
by jolly 21 Oct '26

21 Oct '26

Attention is currently required from: jolly, osmith, pespin. Hello Jenkins Builder, osmith, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-e1d/+/43686?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Code-Review+1 by osmith, Code-Review+1 by pespin, Verified+1 by Jenkins Builder Change subject: Use VTY node defintion from libosmocore ...................................................................... Use VTY node defintion from libosmocore Depends-on: I497ee1503fed1681fae217bfe4d7be9b1580448f (libosmocore) Change-Id: I1e176362eba4966ad6c249831d6a82d0ed4ea6d5 --- M TODO-RELEASE M src/octoi/octoi.c M src/octoi/octoi.h M src/octoi/octoi_clnt_vty.c M src/octoi/octoi_srv_vty.c 5 files changed, 43 insertions(+), 51 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-e1d refs/changes/86/43686/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/43686?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I1e176362eba4966ad6c249831d6a82d0ed4ea6d5 Gerrit-Change-Number: 43686 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log October 2026