Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43770?usp=email )
Change subject: jobs/ttcn3: ns: set init-osmo-dev to true
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
why is this needed here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43770?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I1eada70c6c27dca13fe69728007d6bcfa8ef02da
Gerrit-Change-Number: 43770
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Oct 2026 15:29:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43769?usp=email )
Change subject: jobs/ttcn3: sccp: set init-osmo-dev to true
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
why is this needed here?
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43769?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I4def3fa4d88d2f58696b20255b9b0f9fede5536e
Gerrit-Change-Number: 43769
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Oct 2026 15:28:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Attention is currently required from: osmith.
pespin has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43768?usp=email )
Change subject: jobs/ttcn3: bts: set init-osmo-dev to true
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43768?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id7521e9941f651608b39e8b7b2a6437a0e483022
Gerrit-Change-Number: 43768
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Mon, 05 Oct 2026 15:28:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43781?usp=email )
Change subject: es9p_client: fix decoding of euiccCiPKIdToBeUsed (JSON)
......................................................................
es9p_client: fix decoding of euiccCiPKIdToBeUsed (JSON)
At the moment, the es9p_client decodes the euiccCiPKIdToBeUsed as
BASE64 encoded octetstring, with no further decoding on top.
The specification (SGP.22) is a bit vague whether or not an
additional decoding should be applied. However, observations in
the wild have shown that the JSON encoded euiccCiPKIdToBeUsed is
indeed prepended with a BER-TLV header (e.g. 0414). This means
that it is likely correct to decode it as SubjectKeyIdentifier
before passing it on to higher layers.
This assumption is also further confirmed by the fact that the
ASN.1 and JSON API should be symmetric. In the ASN.1 specification
we find euiccCiPKIdToBeUsed specified as SubjectKeyIdentifier, so
the same should also be true for the JSON API like it is with any
other encoded JSON object that is not a basic type.
Related: SYS#8203
Change-Id: I490f984055faddb02b68e0717077ef7ddcd63b67
---
M src/es9p_client.erl
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/onomondo-eim refs/changes/81/43781/1
diff --git a/src/es9p_client.erl b/src/es9p_client.erl
index 4f79110..13ca93b 100644
--- a/src/es9p_client.erl
+++ b/src/es9p_client.erl
@@ -202,7 +202,9 @@
maps:get(<<"serverSigned1">>, JsonResp)
),
serverSignature1 => base64:decode(maps:get(<<"serverSignature1">>, JsonResp)),
- euiccCiPKIdToBeUsed => base64:decode(
+ euiccCiPKIdToBeUsed => dec_asn1_b64(
+ 'PKIX1Implicit88',
+ 'SubjectKeyIdentifier',
maps:get(<<"euiccCiPKIdToBeUsed">>, JsonResp)
),
serverCertificate => dec_asn1_b64(
--
To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43781?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: onomondo-eim
Gerrit-Branch: master
Gerrit-Change-Id: I490f984055faddb02b68e0717077ef7ddcd63b67
Gerrit-Change-Number: 43781
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43779?usp=email )
Change subject: es9p_Types_JSON: add comment about the encoding of euiccCiPKIdToBeUsed
......................................................................
es9p_Types_JSON: add comment about the encoding of euiccCiPKIdToBeUsed
The spec (SGP.22) is not 100% clear about how euiccCiPKIdToBeUsed shall
be encoded as JSON object. However, observations on a productive SM-DP+
confirm that the implementation in es9p_Types_JSON.ttcn is correct.
To prevent further confusion about this, let's add a comment that
explains our implementation choice.
Related: SYS#8203
Change-Id: I4cb2c9c7e098aa42ae040c5eef0f24eb16a361f7
---
M library/euicc/es9p_Types_JSON.ttcn
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/79/43779/1
diff --git a/library/euicc/es9p_Types_JSON.ttcn b/library/euicc/es9p_Types_JSON.ttcn
index 3e13c42..f7e6587 100644
--- a/library/euicc/es9p_Types_JSON.ttcn
+++ b/library/euicc/es9p_Types_JSON.ttcn
@@ -227,6 +227,11 @@
str2oct(json_pdu.initiateAuthenticationResponse.transactionId),
dec_ServerSigned1(decode_base64(json_pdu.initiateAuthenticationResponse.serverSigned1)),
decode_base64(json_pdu.initiateAuthenticationResponse.serverSignature1),
+ /* The specification (SGP.22) is a bit vague about if the euiccCiPKIdToBeUsed JSON object shall
+ * be encoded as SubjectKeyIdentifier or if it is to be sent as plain octetstring. However,
+ * observations in the wild show that we typically find the SubjectKeyIdentifier with a BER-TLV
+ * header prepended (e.g. 0x0414), which means the encoded form is likely the correct one to
+ * use. */
dec_SubjectKeyIdentifier(decode_base64(json_pdu.initiateAuthenticationResponse.euiccCiPKIdToBeUsed)),
dec_Certificate(decode_base64(json_pdu.initiateAuthenticationResponse.serverCertificate))));
} else if (ispresent(json_pdu.getBoundProfilePackageResponse)) {
@@ -271,6 +276,7 @@
encode_base64(enc_ServerSigned1(asn1_pdu_dec.initiateAuthenticationResponse.initiateAuthenticationOk.serverSigned1));
json_pdu.initiateAuthenticationResponse.serverSignature1 :=
encode_base64(asn1_pdu_dec.initiateAuthenticationResponse.initiateAuthenticationOk.serverSignature1);
+ /* See comment in dec_RemoteProfileProvisioningResponse_from_JSON (above) */
json_pdu.initiateAuthenticationResponse.euiccCiPKIdToBeUsed :=
encode_base64(enc_SubjectKeyIdentifier(asn1_pdu_dec.initiateAuthenticationResponse.initiateAuthenticationOk.euiccCiPKIdToBeUsed));
json_pdu.initiateAuthenticationResponse.serverCertificate :=
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43779?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I4cb2c9c7e098aa42ae040c5eef0f24eb16a361f7
Gerrit-Change-Number: 43779
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43780?usp=email )
Change subject: esipa_Types_JSON: encode/decode euiccCiPKIdentifierToBeUsed as octetstring
......................................................................
esipa_Types_JSON: encode/decode euiccCiPKIdentifierToBeUsed as octetstring
The SGP.22 ASN.1 object InitiateAuthenticationOkEsipa defines the member
euiccCiPKIdentifierToBeUsed as OCTET STRING. The JSON bindings for ESipa,
also handle euiccCiPKIdentifierToBeUsed the same way by encoding/decoding
it with BASE64 without further encoding on top.
This means that it is not correct to apply an extra
enc/dec_SubjectKeyIdentifier function call when encoding/decoding
euiccCiPKIdentifierToBeUsed to/from JSON. From the perspective of
InitiateAuthenticationOkEsipa, euiccCiPKIdentifierToBeUsed is just a plain
octetstring without further context.
Related: SYS#8203
Change-Id: I1f38c5a864c168f1fac0742a72b60de2abd25d49
---
M library/euicc/esipa_Types_JSON.ttcn
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/80/43780/1
diff --git a/library/euicc/esipa_Types_JSON.ttcn b/library/euicc/esipa_Types_JSON.ttcn
index 132aaa8..18f28ce 100644
--- a/library/euicc/esipa_Types_JSON.ttcn
+++ b/library/euicc/esipa_Types_JSON.ttcn
@@ -379,7 +379,7 @@
transactionId,
dec_ServerSigned1(decode_base64(json_pdu.initiateAuthenticationResponse.serverSigned1)),
decode_base64(json_pdu.initiateAuthenticationResponse.serverSignature1),
- dec_SubjectKeyIdentifier(decode_base64(json_pdu.initiateAuthenticationResponse.euiccCiPKIdentifierToBeUsed)),
+ decode_base64(json_pdu.initiateAuthenticationResponse.euiccCiPKIdentifierToBeUsed),
dec_Certificate(decode_base64(json_pdu.initiateAuthenticationResponse.serverCertificate)),
matchingId,
ctxParams1));
@@ -481,7 +481,7 @@
json_pdu.initiateAuthenticationResponse.serverSignature1 :=
encode_base64(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.serverSignature1);
json_pdu.initiateAuthenticationResponse.euiccCiPKIdentifierToBeUsed :=
- encode_base64(enc_SubjectKeyIdentifier(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.euiccCiPKIdentifierToBeUsed));
+ encode_base64(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.euiccCiPKIdentifierToBeUsed);
json_pdu.initiateAuthenticationResponse.serverCertificate :=
encode_base64(enc_Certificate(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.serverCertificate));
if (ispresent(asn1_pdu_dec.initiateAuthenticationResponseEsipa.initiateAuthenticationOkEsipa.matchingId)) {
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43780?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I1f38c5a864c168f1fac0742a72b60de2abd25d49
Gerrit-Change-Number: 43780
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
osmith has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43775?usp=email )
Change subject: bts: use osmo-dev to build osmo-trx-proxy, trxcon
......................................................................
Set Ready For Review
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43775?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ifb6761b3fc15a29404dd0ea17b039fde30053d13
Gerrit-Change-Number: 43775
Gerrit-PatchSet: 3
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Comment-Date: Mon, 05 Oct 2026 13:35:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Attention is currently required from: fixeria, pespin.
Hello Jenkins Builder, fixeria, pespin,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43771?usp=email
to look at the new patch set (#2).
The following approvals got outdated and were removed:
Verified+1 by Jenkins Builder
Change subject: testenv: podman: always mount osmo-dev dir
......................................................................
testenv: podman: always mount osmo-dev dir
Prepare to be able to use osmo-dev for building some test components
from source even if running with --binary-packages. This is needed for
e.g. the bts testsuite, where we should always use master for both
trxcon and osmo-trx-proxy, regardless of the osmo-bts version
(nightly/latest/asan). These are part of the testsuite and not SUT.
Related: OS#6638#note-12
Change-Id: Ie470be84dd7b9f34dfe8ed461710c1964b481984
---
M _testenv/testenv/podman.py
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/71/43771/2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43771?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie470be84dd7b9f34dfe8ed461710c1964b481984
Gerrit-Change-Number: 43771
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>