Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43771?usp=email )
Change subject: testenv: podman: always mount osmo-dev dir
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43771?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ie470be84dd7b9f34dfe8ed461710c1964b481984
Gerrit-Change-Number: 43771
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Oct 2026 10:58:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: osmith.
fixeria has posted comments on this change by osmith. ( https://gerrit.osmocom.org/c/osmo-ci/+/43768?usp=email )
Change subject: jobs/ttcn3: bts: set init-osmo-dev to true
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43768?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Id7521e9941f651608b39e8b7b2a6437a0e483022
Gerrit-Change-Number: 43768
Gerrit-PatchSet: 1
Gerrit-Owner: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Oct 2026 10:57:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria.
osmith has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ci/+/43786?usp=email )
Change subject: scripts/osmocom-api-doxygen.sh: upload doxygen output only
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43786?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I41eeafedfa2105a8c127d73d3fc37c1130009b3b
Gerrit-Change-Number: 43786
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Oct 2026 10:55:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43785?usp=email )
Change subject: scripts/osmocom-api-doxygen.sh: fix upliading libosmo-trx docs
......................................................................
scripts/osmocom-api-doxygen.sh: fix upliading libosmo-trx docs
libosmo-trx lives in osmo-trx.git and has its own doc directory:
./libosmo-trx/doc
Upload this directory instead of the repository root ./doc that
contains no API documentation at all.
Change-Id: Ia5add0cdcb2fd24f113c7050cb7efb579b50d8e5
Fixes: 29da2f1 ("scripts/osmocom-api-doxygen.sh: add libusrp, osmo-e1d, osmo-trx")
---
M scripts/osmocom-api-doxygen.sh
1 file changed, 15 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/85/43785/1
diff --git a/scripts/osmocom-api-doxygen.sh b/scripts/osmocom-api-doxygen.sh
index 018e1fc..6713b9a 100755
--- a/scripts/osmocom-api-doxygen.sh
+++ b/scripts/osmocom-api-doxygen.sh
@@ -44,7 +44,19 @@
# Upload all docs
for i in $repos_api; do
- if ! [ -d "$i"/doc ]; then
+ # Some repos ship their API docs in a subdirectory, under a different name
+ case "$i" in
+ osmo-trx)
+ doc_dir="$i/libosmo-trx/doc"
+ dest="$i/libosmo-trx"
+ ;;
+ *)
+ doc_dir="$i/doc"
+ dest="$i"
+ ;;
+ esac
+
+ if ! [ -d "$doc_dir" ]; then
# e.g. libosmo-abis is built as dependency for others but doesn't
# have its own doxygen documentation as of writing
continue
@@ -54,6 +66,6 @@
-avz \
--delete \
-e "$SSH_CMD" \
- ./"$i"/doc/ \
- api@ftp.osmocom.org:web-files/latest/"$i"/
+ ./"$doc_dir"/ \
+ api@ftp.osmocom.org:web-files/latest/"$dest"/
done
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43785?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: Ia5add0cdcb2fd24f113c7050cb7efb579b50d8e5
Gerrit-Change-Number: 43785
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ci/+/43786?usp=email )
Change subject: scripts/osmocom-api-doxygen.sh: upload doxygen output only
......................................................................
scripts/osmocom-api-doxygen.sh: upload doxygen output only
So far the whole doc/ directory was uploaded, including files that
have nothing to do with the API documentation: Makefile{,.am,.in},
examples/, manuals/, *.tag.prep stamp files, etc.
Use rsync filter rules to upload only the doxygen output: html/ and
latex/ trees (possibly nested in a per-library subdirectory, like
doc/core/html in libosmocore), plus *.tag files and html.tar. Pass
--delete-excluded, so that the files uploaded previously by mistake
get removed from the server.
Change-Id: I41eeafedfa2105a8c127d73d3fc37c1130009b3b
---
M scripts/osmocom-api-doxygen.sh
1 file changed, 12 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/86/43786/1
diff --git a/scripts/osmocom-api-doxygen.sh b/scripts/osmocom-api-doxygen.sh
index 6713b9a..47d83e3 100755
--- a/scripts/osmocom-api-doxygen.sh
+++ b/scripts/osmocom-api-doxygen.sh
@@ -62,9 +62,21 @@
continue
fi
+ # Upload only doxygen output (html/ and latex/ trees, possibly nested in
+ # a per-library subdirectory, plus tag files and html.tar), but not the
+ # other files in doc/ (Makefiles, examples, manuals, ...). Excluded
+ # files that were uploaded previously get deleted on the server.
rsync \
-avz \
--delete \
+ --delete-excluded \
+ --prune-empty-dirs \
+ --include='html/***' \
+ --include='latex/***' \
+ --include='/*.tag' \
+ --include='/html.tar' \
+ --include='*/' \
+ --exclude='*' \
-e "$SSH_CMD" \
./"$doc_dir"/ \
api@ftp.osmocom.org:web-files/latest/"$dest"/
--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/43786?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: newchange
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I41eeafedfa2105a8c127d73d3fc37c1130009b3b
Gerrit-Change-Number: 43786
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de>
Attention is currently required from: pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43761?usp=email )
Change subject: xua_msg: Drop __thread attribute on static buf
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43761?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: Ia023b8df32494bc705326106753f17e7eeaf89cf
Gerrit-Change-Number: 43761
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Oct 2026 09:55:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Attention is currently required from: fixeria, pespin.
osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email )
Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf()
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS3:
would you mind adding tests showing that this works as expected?
File src/ss7_asp_peer.c:
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753/comment/cd2fe9a0_8a6f6… :
PS3, Line 73: |
this looks like it would always add an extra |?
--
To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: libosmo-sigtran
Gerrit-Branch: master
Gerrit-Change-Id: I115951627adb0c6778a9a36159237c3eea130300
Gerrit-Change-Number: 43753
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: jolly <andreas(a)eversberg.eu>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 06 Oct 2026 09:52:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No