January 2026 - gerrit-log - lists.osmocom.org

[S] Change in pysim[master]: transport/init: use PySimLogger to print messages
by dexter 09 Jan '26

09 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41812?usp=email ) Change subject: transport/init: use PySimLogger to print messages ...................................................................... transport/init: use PySimLogger to print messages The module still uses print to output information. Let's replace those print calls with the more modern PySimLogger method calls. Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 --- M pySim/transport/__init__.py 1 file changed, 11 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/12/41812/1 diff --git a/pySim/transport/__init__.py b/pySim/transport/__init__.py index f82f4df..39c9886 100644 --- a/pySim/transport/__init__.py +++ b/pySim/transport/__init__.py @@ -29,6 +29,9 @@ from pySim.exceptions import * from pySim.utils import SwHexstr, SwMatchstr, ResTuple, sw_match, parse_command_apdu from pySim.cat import ProactiveCommand, CommandDetails, DeviceIdentities, Result +from pySim.log import PySimLogger + +log = PySimLogger.get("TRANSPORT") class ApduTracer: def trace_command(self, cmd): @@ -43,11 +46,11 @@ class StdoutApduTracer(ApduTracer): """Minimalistic APDU tracer, printing commands to stdout.""" def trace_response(self, cmd, sw, resp): - print("-> %s %s" % (cmd[:10], cmd[10:])) - print("<- %s: %s" % (sw, resp)) + log.info("-> %s %s" % (cmd[:10], cmd[10:])) + log.info("<- %s: %s" % (sw, resp)) def trace_reset(self): - print("-- RESET") + log.info("-- RESET") class ProactiveHandler(abc.ABC): """Abstract base class representing the interface of some code that handles @@ -174,7 +177,7 @@ if self.apdu_strict: raise ValueError(exeption_str) else: - print('Warning: %s' % exeption_str) + log.warning(exeption_str) return (data, sw) @@ -208,7 +211,7 @@ # parse the proactive command pcmd = ProactiveCommand() parsed = pcmd.from_tlv(h2b(fetch_rv[0])) - print("FETCH: %s (%s)" % (fetch_rv[0], type(parsed).__name__)) + log.info("FETCH: %s (%s)" % (fetch_rv[0], type(parsed).__name__)) if self.proactive_handler: # Extension point: If this does return a list of TLV objects, # they could be appended after the Result; if the first is a @@ -358,13 +361,13 @@ from pySim.transport.modem_atcmd import ModemATCommandLink sl = ModemATCommandLink(opts, **kwargs) else: # Serial reader is default - print("No reader/driver specified; falling back to default (Serial reader)") + log.warning("No reader/driver specified; falling back to default (Serial reader)") from pySim.transport.serial import SerialSimLink sl = SerialSimLink(opts, **kwargs) if os.environ.get('PYSIM_INTEGRATION_TEST') == "1": - print("Using %s reader interface" % (sl.name)) + log.info("Using %s reader interface" % (sl.name)) else: - print("Using reader %s" % sl) + log.info("Using reader %s" % sl) return sl -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 Gerrit-Change-Number: 41812 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: pass SELECT parameter P2 to OMAPI
by dexter 09 Jan '26

09 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41805?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: OmapiCallbackHandlerVpcd: pass SELECT parameter P2 to OMAPI ...................................................................... OmapiCallbackHandlerVpcd: pass SELECT parameter P2 to OMAPI The OMAPI method openLogicalChannel may take an optional parameter p2, This parameter. Among other function, this paramter in particular controls how to deal with short DF-Names that match the AIDs of several applications. Since we always know this parameter from the TPDU that we receive from VPCD, let's pass it on to OMAPI when we create a new channel. Related: OS#6836 Change-Id: Ibab2cc197284e6177a83338007a0b7f77e0ab8b9 --- M app/src/main/java/org/osmocom/androidApduProxy/Omapi.java M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java 2 files changed, 14 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/05/41805/2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41805?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Ibab2cc197284e6177a83338007a0b7f77e0ab8b9 Gerrit-Change-Number: 41805 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: fetch SELECT response from OMAPI
by dexter 09 Jan '26

09 Jan '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41804?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: OmapiCallbackHandlerVpcd: fetch SELECT response from OMAPI ...................................................................... OmapiCallbackHandlerVpcd: fetch SELECT response from OMAPI At the moment we get the select response by selecting 7FFF, which is an alias for the currently selected application. This returns a select response when an ISIM or USIM application is selected. Other applications may react differently here. OMAPI has a getSelectResponse method through which we can get the actual response that was received from the card when the application was selected when openLogicalChannel was called. This is far more accurate, so lets use getSelectResponse instead of selecting 7FFF. Change-Id: Iacbc907ef157f20bed88325fcf6b58717990005a --- M app/src/main/java/org/osmocom/androidApduProxy/Omapi.java M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java 2 files changed, 23 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/04/41804/3 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Iacbc907ef157f20bed88325fcf6b58717990005a Gerrit-Change-Number: 41804 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: fetch SELECT response from OMAPI
by dexter 09 Jan '26

09 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41804?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: OmapiCallbackHandlerVpcd: fetch SELECT response from OMAPI ...................................................................... OmapiCallbackHandlerVpcd: fetch SELECT response from OMAPI At the moment we get the select response by selecting 7FFF, which is an alias for the currently selected application. This returns a select response when an ISIM or USIM application is selected. Other applications may react differently here. OMAPI has a getSelectResponse method through which we can get the actual response that was received from the card when the application was selected when openLogicalChannel was called. This is far more accurate, so lets use getSelectResponse instead of selecting 7FFF. Change-Id: Iacbc907ef157f20bed88325fcf6b58717990005a --- M app/src/main/java/org/osmocom/androidApduProxy/Omapi.java M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java 2 files changed, 24 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/04/41804/2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41804?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Iacbc907ef157f20bed88325fcf6b58717990005a Gerrit-Change-Number: 41804 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: improve log output
by dexter 09 Jan '26

09 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41802?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: OmapiCallbackHandlerVpcd: improve log output ...................................................................... OmapiCallbackHandlerVpcd: improve log output When we select the currently selected ADF, we actually select 7fff, which is an alias for the currently selected ADF. Let's express this also more clearly in the log output. Change-Id: I7004bec25f07b1a7498003231070205d2d659717 Related: OS#6836 --- M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/02/41802/2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41802?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I7004bec25f07b1a7498003231070205d2d659717 Gerrit-Change-Number: 41802 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[XS] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: use appropriate status word to reject MANAG...
by dexter 09 Jan '26

09 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41800?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: OmapiCallbackHandlerVpcd: use appropriate status word to reject MANAGE CHANNEL ...................................................................... OmapiCallbackHandlerVpcd: use appropriate status word to reject MANAGE CHANNEL ISO/IEC 7816-4 specifies a status word to reject MANAGE CHANNEL instructions in case the card does not support multiple channels. Let's also print an error message in the log to simplify debugging for users who aren't aware of OMAPI's logical channel limitation. Change-Id: I42529a6ae61378e41f33f1ec34124e346d4805df Related: OS#6836 --- M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/00/41800/2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41800?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I42529a6ae61378e41f33f1ec34124e346d4805df Gerrit-Change-Number: 41800 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by pespin 09 Jan '26

09 Jan '26

Attention is currently required from: fixeria, laforge. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... Patch Set 2: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785/comment/5c18d34c_a887… : PS2, Line 3860: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, > Please revert this change. It's not strictly needed here and makes the code harder to read. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 15:01:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes ...
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email ) Change subject: bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering ...................................................................... bts: TC_tx_power_ramp_adm_state_change: Fix Tguard too low sometimes triggering One can see with the following failing output below that the Tguard is too low: """ 13:36:12.459089 5684 BTS_Tests.ttcn:2836 Reached full power, wating a bit more until success 13:36:12.459097 5684 BTS_Tests.ttcn:2837 Start timer T: 2 s 13:36:14.358525 5684 Misc_Helpers.ttcn:35 setverdict(fail): pass -> fail reason: ""BTS_Tests.ttcn:729 : Tguard timeout"", new component reason: ""BTS_Tests.ttcn:729 : Tguard timeout"" """ Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb --- M bts/BTS_Tests.ttcn 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/41809/1 diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index c681da9..b060cbd 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -3035,7 +3035,7 @@ var ConnHdlr vc_conn; var ConnHdlrPars pars; f_init(); - pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN)); + pars := valueof(t_Pars(t_RslChanNr_Bm(0), ts_RSL_ChanMode_SIGN, t_guard := 60.0)); vc_conn := f_start_handler(refers(f_TC_tx_power_ramp_adm_state_change), pars, pcu_comp := false, trxc_comp := true); vc_conn.done; -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41809?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I95448c732d08a30893cb958af79bf21c39ff10cb Gerrit-Change-Number: 41809 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by pespin 09 Jan '26

09 Jan '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Code-Review+1 by laforge, Verified+1 by Jenkins Builder Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl Fix following sporadic race condition: TTCN-MS IUTS-BTS TTCN-BSC | |<----CHAN_ACT------| |<--SACCH(A)-- | | | |<--MS_PWR_CTRL(B)- | |<--SACCH(B)---| Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 --- M bts/BTS_Tests.ttcn 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/41785/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: fix sourcecode formatting
by dexter 09 Jan '26

09 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41808?usp=email ) Change subject: OmapiCallbackHandlerVpcd: fix sourcecode formatting ...................................................................... OmapiCallbackHandlerVpcd: fix sourcecode formatting Change-Id: If52cc2ddc18d510c014a46a0f12057f70901670c --- M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java index ff63928..c71581c 100644 --- a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java +++ b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java @@ -147,7 +147,7 @@ //Block all attempts to manage a channel, this is a feature we do not support here. //(OMAPI also does not support the MANAGE CHANNEL command) - if (Arrays.equals(Arrays.copyOf( tpdu,2), Utils.h2b("0070") ) ) { + if (Arrays.equals(Arrays.copyOf(tpdu, 2), Utils.h2b("0070"))) { return (Utils.h2b("6D00")); } -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: If52cc2ddc18d510c014a46a0f12057f70901670c Gerrit-Change-Number: 41808 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026