January 2026 - gerrit-log - lists.osmocom.org

[S] Change in osmo-bts[master]: ms_power_control: Apply defaults during reset
by pespin 09 Jan '26

09 Jan '26

Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: ms_power_control: Apply defaults during reset ...................................................................... ms_power_control: Apply defaults during reset lchan_ms_pwr_ctrl_reset() is already called furhter above in rsl_rx_chan_activ(), so simplify mode the default values there and no need to re-apply them twice. Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3 --- M src/common/power_control.c M src/common/rsl.c 2 files changed, 8 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/95/41795/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3 Gerrit-Change-Number: 41795 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[M] Change in osmo-bts[master]: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
by pespin 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ...................................................................... {bs,ms}_power_control: Move params inside lchan_power_ctrl_state Those fields are also part of the power control state, since they are modified through the lifecycle of the lchan eg. during rx of CHAN (RE)ACT, MS POWER CONTROL, etc. Those should also be reset together with other fields. Moreover, with this patch we get rid of an extra indirection pointer which could be NULL (under static configuration) and hence create potential problems. Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df --- M include/osmo-bts/lchan.h M src/common/power_control.c M src/common/rsl.c M src/common/vty.c M tests/power/bs_power_loop_test.c M tests/power/ms_power_loop_test.c 6 files changed, 74 insertions(+), 88 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/07/41807/3 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df Gerrit-Change-Number: 41807 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-ttcn3-hacks[master]: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count
by fixeria 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email ) Change subject: bts: TC_pcu_{rts_req,time_ind}: Relax expectancies on rx primitive count ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41783?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I887bd80a90e3ef8142cc29acde2ac9a3ea4869d6 Gerrit-Change-Number: 41783 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 14:31:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: ms_power_control: Apply defaults during reset
by pespin 09 Jan '26

09 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email ) Change subject: ms_power_control: Apply defaults during reset ...................................................................... Patch Set 1: (2 comments) File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/05499164_4fb9f53b?usp… : PS1, Line 150: /* XXX: should we use the maximum power level instead of 0 dBm? */ > Not critical, but I would prefer to see this comment before the `state->max = ms_pwr_ctl_lvl(... […] Done File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/b8e59836_8d718612?usp… : PS1, Line 2054: XXX: should we use the maximum power level instead of 0 dBm > This comment does not belong here anymore. It's related to that line: […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3 Gerrit-Change-Number: 41795 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 14:30:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by fixeria 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... Patch Set 2: (2 comments) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785/comment/1b5e4913_0cc5… : PS2, Line 3853: if (first_after_wait) { : /* It may happen that BTS transmits SACCH before it receives our RSL MS POWER CONTROL: */ : log("Power level := ", l1h.ms_power_lvl, " does not ", : "match the signaled (RSL) power level := ", power_level); : first_after_wait := false; : repeat; : AFAIU, the idea of this patch is to ignore the first DL SACCH block. This can be done in a slightly more elegant way by doing this before the alt-statement: ``` /* ignore the first DL SACCH block */ L1CTL.trigger(tr_L1CTL_DATA_IND(g_chan_nr, tr_RslLinkID_SACCH(?))); ``` The `trigger` statement will keep blocking and discarding messages until a message matching the given template is received. Here's an extract from the language specification: > Stand-alone trigger > > The trigger operation can be used as a stand-alone statement in a behaviour description. In this latter case the trigger operation is considered to be shorthand for an alt statement with two alternatives (one alternative expecting the message and another alternative consuming all other messages and repeating the alt statement, see ETSI ES 201 873-4 [1]). https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785/comment/b8d749a9_d522… : PS2, Line 3860: Misc_Helpers.f_shutdown(__BFILE__, __LINE__, fail, Please revert this change. It's not strictly needed here and makes the code harder to read. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 14:30:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-ttcn3-hacks[master]: Move function to calculate next PDTCH block FN to library
by fixeria 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41780?usp=email ) Change subject: Move function to calculate next PDTCH block FN to library ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49289029c89367c8c6a5db7fafda099748ec15b6 Gerrit-Change-Number: 41780 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 14:13:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bts[master]: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
by fixeria 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email ) Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: I would like to review this patch more carefully when I am back from vacation (next week), so please don't rush merging it. So far I had a quick look and I don't really understand/see what do we benefit from this refactoring. From what I remember, I intentionally wanted to have the power control parameters separated from the power control state. And using the pointer allows to avoid memcpy()ing parameters which are identical for all lchans in 99% cases. I don't see how this pointer being `NULL` can crate problems in static mode: one shall simply never need to access dynamic power control parameters in static mode. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df Gerrit-Change-Number: 41807 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 14:10:26 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[XS] Change in osmo-bts[master]: ta_power_control: reset during lchan activation
by fixeria 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41796?usp=email ) Change subject: ta_power_control: reset during lchan activation ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41796?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I149fffa73ef651fd21e52e5423b31f8e95e57941 Gerrit-Change-Number: 41796 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 13:58:28 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-bts[master]: ms_power_control: Apply defaults during reset
by fixeria 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email ) Change subject: ms_power_control: Apply defaults during reset ...................................................................... Patch Set 1: (2 comments) File src/common/power_control.c: https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/78b081f1_ca9e2c32?usp… : PS1, Line 150: /* XXX: should we use the maximum power level instead of 0 dBm? */ Not critical, but I would prefer to see this comment before the `state->max = ms_pwr_ctl_lvl(...)` since it's related exactly to that line. File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/41795/comment/21658902_2e7f4e1b?usp… : PS1, Line 2054: XXX: should we use the maximum power level instead of 0 dBm This comment does not belong here anymore. It's related to that line: ``` lchan->ms_power_ctrl.max = ms_pwr_ctl_lvl(lchan->ts->trx->bts->band, 0); // 0 dBm ``` so I suggest removing it. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41795?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5c0137ba8bf1e057abdc1911716e3d1bf8c61ea3 Gerrit-Change-Number: 41795 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 13:57:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in osmo-bts[master]: bs_power_control: Apply defaults during reset
by fixeria 09 Jan '26

09 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41794?usp=email ) Change subject: bs_power_control: Apply defaults during reset ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/common/rsl.c: https://gerrit.osmocom.org/c/osmo-bts/+/41794/comment/be371197_2a115d0f?usp… : PS1, Line 1992: lchan_ms_pwr_ctrl_reset(lchan); Suggestion: move this below closer to the if-block handling `RSL_IE_MS_POWER` for the sake of consistency? Ah, I see you're doing this in a follow-up patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41794?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I00d9205d114b2d507c1048375693de4aa06bebbe Gerrit-Change-Number: 41794 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 13:51:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026