January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: fix sourcecode formatting
by dexter 09 Jan '26

09 Jan '26

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41808?usp=email ) Change subject: OmapiCallbackHandlerVpcd: fix sourcecode formatting ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: If52cc2ddc18d510c014a46a0f12057f70901670c Gerrit-Change-Number: 41808 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 15:00:59 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[XS] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: fix sourcecode formatting
by dexter 09 Jan '26

09 Jan '26

dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41808?usp=email ) Change subject: OmapiCallbackHandlerVpcd: fix sourcecode formatting ...................................................................... OmapiCallbackHandlerVpcd: fix sourcecode formatting Change-Id: If52cc2ddc18d510c014a46a0f12057f70901670c --- M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/08/41808/1 diff --git a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java index 76bf230..0b880fb 100644 --- a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java +++ b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java @@ -157,7 +157,7 @@ //Block all attempts to manage a channel, this is a feature we do not support here. //(OMAPI also does not support the MANAGE CHANNEL command) - if (Arrays.equals(Arrays.copyOf( tpdu,2), Utils.h2b("0070") ) ) { + if (Arrays.equals(Arrays.copyOf(tpdu, 2), Utils.h2b("0070"))) { return (Utils.h2b("6D00")); } -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41808?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: If52cc2ddc18d510c014a46a0f12057f70901670c Gerrit-Change-Number: 41808 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in android-apdu-proxy[master]: OmapiCallbackHandlerVpcd: add check to filter shortTPDUs
by dexter 09 Jan '26

09 Jan '26

Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41801?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: OmapiCallbackHandlerVpcd: add check to filter shortTPDUs ...................................................................... OmapiCallbackHandlerVpcd: add check to filter shortTPDUs Related: OS#6836 Change-Id: I4e76afd7cf4d63c67b1525202fbe74e0796b2ba3 --- M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java 1 file changed, 10 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/01/41801/2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41801?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: I4e76afd7cf4d63c67b1525202fbe74e0796b2ba3 Gerrit-Change-Number: 41801 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by pespin 09 Jan '26

09 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... Patch Set 2: (1 comment) File bts/BTS_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785/comment/7605981f_880b… : PS2, Line 3853: if (first_after_wait) { : /* It may happen that BTS transmits SACCH before it receives our RSL MS POWER CONTROL: */ : log("Power level := ", l1h.ms_power_lvl, " does not ", : "match the signaled (RSL) power level := ", power_level); : first_after_wait := false; : repeat; : > AFAIU, the idea of this patch is to ignore the first DL SACCH block. […] This seems to be discard+repeat all the time, while I only want to discard only *once after each RSL.send() changing the MS POWER if the MS POWER doesn't match*. I doubt something as specific as this actually exists in ttcn3. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 14:43:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in android-apdu-proxy[master]: cosmetic: fix sourcecode formatting
by dexter 09 Jan '26

09 Jan '26

dexter has submitted this change. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41798?usp=email ) Change subject: cosmetic: fix sourcecode formatting ...................................................................... cosmetic: fix sourcecode formatting Change-Id: Iab233cdff33d686d6715abe3cb2b0c4f2a74dd0d --- M app/src/main/java/org/osmocom/androidApduProxy/Omapi.java M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java M app/src/main/java/org/osmocom/androidApduProxy/Vpcd.java 3 files changed, 4 insertions(+), 5 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java b/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java index 765d888..afd4515 100644 --- a/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java +++ b/app/src/main/java/org/osmocom/androidApduProxy/Omapi.java @@ -135,7 +135,7 @@ } session.close(); } else { - Log.d("OMAPI","found reader: " + reader.getName() + " (empty)\n"); + Log.d("OMAPI", "found reader: " + reader.getName() + " (empty)\n"); } } return usable_readers; diff --git a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java index d5b4043..ff63928 100644 --- a/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java +++ b/app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java @@ -16,7 +16,6 @@ private String remoteHost = null; private int remotePort = 0; private Handler uiHandler = null; - private int omapiChannel = -1; private byte[] omapiAid = null; @@ -107,7 +106,7 @@ //we just use the FID 7FFF, which is an alias for the currently selected application. In case the //AID is different, we close the OMAPI channel and re-open it with the new AID. If this fails, we //we just pretend that we haven't found the file. - if (Arrays.equals(Arrays.copyOf( tpdu,3), Utils.h2b("00A404") ) ) { + if (Arrays.equals(Arrays.copyOf(tpdu, 3), Utils.h2b("00A404"))) { byte[] aidReq = Arrays.copyOfRange(tpdu, 5, tpdu.length - 1); int compareLength = 0; if (omapiAid != null) { diff --git a/app/src/main/java/org/osmocom/androidApduProxy/Vpcd.java b/app/src/main/java/org/osmocom/androidApduProxy/Vpcd.java index 002803b..d4b65d0 100644 --- a/app/src/main/java/org/osmocom/androidApduProxy/Vpcd.java +++ b/app/src/main/java/org/osmocom/androidApduProxy/Vpcd.java @@ -204,7 +204,7 @@ //TPDU data byte[] reqTpdu = new byte[messageLen]; byte[] resTpdu; - System.arraycopy(message, 0, reqTpdu,0, messageLen); + System.arraycopy(message, 0, reqTpdu, 0, messageLen); Log.d("VPCD", String.format("remote end asks to send TPDU: %s\n", Utils.b2h(reqTpdu))); resTpdu = callback.vpcdTransact(reqTpdu); @@ -243,4 +243,4 @@ this.receiving = false; } -} \ No newline at end of file +} -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Iab233cdff33d686d6715abe3cb2b0c4f2a74dd0d Gerrit-Change-Number: 41798 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de>

1 0

[XS] Change in android-apdu-proxy[master]: cosmetic: fix sourcecode formatting
by dexter 09 Jan '26

09 Jan '26

dexter has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/android-apdu-proxy/+/41798?usp=email ) Change subject: cosmetic: fix sourcecode formatting ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Iab233cdff33d686d6715abe3cb2b0c4f2a74dd0d Gerrit-Change-Number: 41798 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 14:40:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[M] Change in osmo-bts[master]: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state
by pespin 09 Jan '26

09 Jan '26

Attention is currently required from: fixeria. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email ) Change subject: {bs,ms}_power_control: Move params inside lchan_power_ctrl_state ...................................................................... Patch Set 3: (1 comment) Patchset: PS2: > So far I had a quick look and I don't really understand/see what do we benefit from this refactoring. As mentioned in the commit message, these params follow the same lifecycle than that the state, ie. they get per-lchan modified over RSL. By having it inside the struct, we reset the whole state together, so the logic is simplified. > And using the pointer allows to avoid memcpy()ing parameters which are identical for all lchans in 99% cases. You are still holding a copy on each lchan. All I'm doing is getting rid of one extra pointer field. > I don't see how this pointer being NULL can crate problems in static mode: one shall simply never need to access dynamic power control parameters in static mode. Yes, that's usually how crashes happen: One ends up doing something should never need to do 😊 -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41807?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I0e2a6c2c33e0ac9a0bc1734d83eaeafc27f2f4df Gerrit-Change-Number: 41807 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Fri, 09 Jan 2026 14:38:59 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>

1 0

[XS] Change in android-apdu-proxy[master]: cosmetic: fix sourcecode formatting
by dexter 09 Jan '26

09 Jan '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41798?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: cosmetic: fix sourcecode formatting ...................................................................... cosmetic: fix sourcecode formatting Change-Id: Iab233cdff33d686d6715abe3cb2b0c4f2a74dd0d --- M app/src/main/java/org/osmocom/androidApduProxy/Omapi.java M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java M app/src/main/java/org/osmocom/androidApduProxy/Vpcd.java 3 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/98/41798/3 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Iab233cdff33d686d6715abe3cb2b0c4f2a74dd0d Gerrit-Change-Number: 41798 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in osmo-ttcn3-hacks[master]: Move function to calculate next PDTCH block FN to library
by pespin 09 Jan '26

09 Jan '26

pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41780?usp=email ) Change subject: Move function to calculate next PDTCH block FN to library ...................................................................... Move function to calculate next PDTCH block FN to library It will be used in a follow-up patch to validate RTS.req in BTS_Tests testsuite. Take the chance to rename the function since it actually calculates PDTCH blocks. Change-Id: I49289029c89367c8c6a5db7fafda099748ec15b6 --- M library/GSM_Types.ttcn M pcu/GPRS_Components.ttcn M pcu/PCU_Tests.ttcn 3 files changed, 20 insertions(+), 20 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve fixeria: Looks good to me, approved diff --git a/library/GSM_Types.ttcn b/library/GSM_Types.ttcn index 6d3e170..8333e58 100644 --- a/library/GSM_Types.ttcn +++ b/library/GSM_Types.ttcn @@ -535,5 +535,16 @@ /* TS 24.008 10.5.1.1 */ type uint16_t CellIdentity; +/* 3GPP TS 45.002 Table 6 */ +private function fn2bn(GsmFrameNumber fn) return uint32_t { + return (fn mod 52) / 4; +} +function f_next_pdtch_block(GsmFrameNumber fn) return GsmFrameNumber +{ + var uint32_t bn := fn2bn(fn) + 1; + fn := fn - (fn mod 52); + fn := fn + bn * 4 + bn / 3; + return fn mod GsmMaxFrameNumber; +} } with { encode "RAW"; variant "FIELDORDER(msb)" } diff --git a/pcu/GPRS_Components.ttcn b/pcu/GPRS_Components.ttcn index c48497a..50b552d 100644 --- a/pcu/GPRS_Components.ttcn +++ b/pcu/GPRS_Components.ttcn @@ -242,17 +242,6 @@ return 51 * ((st.t3 - st.t2) mod 26) + st.t3 + 51 * 26 * st.t1; } -function fn2bn(GsmFrameNumber fn) return uint32_t { - return (fn mod 52) / 4; -} -function f_next_pdch_block(GsmFrameNumber fn) return GsmFrameNumber -{ - var uint32_t bn := fn2bn(fn) + 1; - fn := fn - (fn mod 52); - fn := fn + bn * 4 + bn / 3; - return fn mod GsmMaxFrameNumber; -} - function f_ultbf_new_from_rr_imm_ass(in GsmRrMessage rr_imm_ass) runs on MS_BTS_IFACE_CT return UlTbf { var UlTbf ul_tbf := valueof(t_UlTbf_def); diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 23709dc..98fbbf6 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -1433,7 +1433,7 @@ if (rx_usf == ms.ul_tbf.usf[valueof(nr.ts_nr)]) { /* PCU requests our USF, transmit WITHOUT tlli to avoid contention resolution success */ ul_tbf_usf_req := true; - f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 15, with_tlli := false, fn := f_next_pdch_block(data_msg.raw.fn)) + f_ms_tx_ul_data_block(ms, f_rnd_octstring(10), cv := 15, with_tlli := false, fn := f_next_pdtch_block(data_msg.raw.fn)) } else if (rx_usf == USF_UNUSED) { if (data_msg.raw.fn >= ms.ul_tbf.start_time_fn) { if (ul_tbf_usf_req) { @@ -2240,7 +2240,7 @@ /* Wait until PCU starts requesting for UL block on this TBF: */ dl_fn := f_ms_wait_usf(ms, nr := f_ms_tx_TsTrxBtsNum(ms)); - sched_fn := f_next_pdch_block(dl_fn); + sched_fn := f_next_pdtch_block(dl_fn); /* Send one UL block (with TLLI since we are in One-Phase Access * contention resolution) and make sure it is ACKED fine. */ @@ -3448,7 +3448,7 @@ /* Wait until PCU starts requesting for UL block on this TBF: */ dl_fn := f_ms_wait_usf(ms, nr := f_ms_tx_TsTrxBtsNum(ms)); - sched_fn := f_next_pdch_block(dl_fn); + sched_fn := f_next_pdtch_block(dl_fn); /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine */ @@ -3514,7 +3514,7 @@ /* Wait until PCU starts requesting for UL block on this TBF: */ dl_fn := f_ms_wait_usf(ms, nr := f_ms_tx_TsTrxBtsNum(ms)); - sched_fn := f_next_pdch_block(dl_fn); + sched_fn := f_next_pdtch_block(dl_fn); /* Send one UL block (with TLLI since we are in One-Phase Access * contention resolution) and make sure it is ACKED fine. */ @@ -3929,7 +3929,7 @@ /* Wait until PCU starts requesting for UL block on this TBF: */ dl_fn := f_ms_wait_usf(ms); - sched_fn := f_next_pdch_block(dl_fn); + sched_fn := f_next_pdtch_block(dl_fn); /* Send one UL block (with TLLI since we are in One-Phase Access contention resolution) and make sure it is ACKED fine. */ @@ -4459,7 +4459,7 @@ contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); dl_fn := f_rx_rlcmac_dl_block_exp_dummy(dl_block); - f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdtch_block(dl_fn)); f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, false)); @@ -4528,7 +4528,7 @@ contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); dl_fn := f_rx_rlcmac_dl_block_exp_dummy(dl_block); - f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdtch_block(dl_fn)); f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, false)); @@ -4554,7 +4554,7 @@ /* Send one UL block (with TLLI since we are in One-Phase Access * contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); - f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdtch_block(dl_fn)); /* UL ACK/NACK sets poll+rrbp requesting PACKET CONTROL ACK */ f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); @@ -4608,7 +4608,7 @@ contention resolution) and make sure it is ACKED fine. */ payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, true)); dl_fn := f_rx_rlcmac_dl_block_exp_dummy(dl_block); - f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdch_block(dl_fn)); + f_ms_tx_ul_data_block(ms, payload, cv := 1, with_tlli := true, fn := f_next_pdtch_block(dl_fn)); f_rx_rlcmac_dl_block_exp_ack_nack(dl_block, sched_fn); payload := f_rnd_octstring(f_ultbf_payload_fill_length(ms.ul_tbf, false)); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41780?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I49289029c89367c8c6a5db7fafda099748ec15b6 Gerrit-Change-Number: 41780 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in android-apdu-proxy[master]: cosmetic: fix sourcecode formatting
by dexter 09 Jan '26

09 Jan '26

Attention is currently required from: dexter. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41798?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: cosmetic: fix sourcecode formatting ...................................................................... cosmetic: fix sourcecode formatting Change-Id: Iab233cdff33d686d6715abe3cb2b0c4f2a74dd0d --- M app/src/main/java/org/osmocom/androidApduProxy/Omapi.java M app/src/main/java/org/osmocom/androidApduProxy/OmapiCallbackHandlerVpcd.java M app/src/main/java/org/osmocom/androidApduProxy/Vpcd.java 3 files changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.osmocom.org:29418/android-apdu-proxy refs/changes/98/41798/2 -- To view, visit https://gerrit.osmocom.org/c/android-apdu-proxy/+/41798?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: android-apdu-proxy Gerrit-Branch: master Gerrit-Change-Id: Iab233cdff33d686d6715abe3cb2b0c4f2a74dd0d Gerrit-Change-Number: 41798 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026