January 2026 - gerrit-log - lists.osmocom.org

[XS] Change in osmo-bts[master]: ta_control: Move variable declaration to the top of the function
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41788?usp=email ) Change subject: ta_control: Move variable declaration to the top of the function ...................................................................... ta_control: Move variable declaration to the top of the function Change-Id: Ia5ada61d74f5b17c4d1479123462104650a6ed0f --- M src/common/ta_control.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/88/41788/1 diff --git a/src/common/ta_control.c b/src/common/ta_control.c index c3e4d67..10b04a9 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -65,13 +65,13 @@ */ void lchan_ms_ta_ctrl(struct gsm_lchan *lchan, uint8_t ms_tx_ta, int16_t toa256) { - int16_t new_ta; + int16_t new_ta, delta_ta; /* Shall we skip current block based on configured interval? */ if (ctrl_interval_skip_block(lchan)) return; - int16_t delta_ta = toa256/256; + delta_ta = toa256/256; if (toa256 >= 0) { if ((toa256 - (256 * delta_ta)) > TOA256_THRESH) delta_ta++; -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41788?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ia5ada61d74f5b17c4d1479123462104650a6ed0f Gerrit-Change-Number: 41788 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: ta_control: Move skip_block logic to helper function
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41787?usp=email ) Change subject: ta_control: Move skip_block logic to helper function ...................................................................... ta_control: Move skip_block logic to helper function This makes it more similar to code in power_control.c. Change-Id: I174f2f941fbedbe0793cc0b93d01e53e23328cf2 --- M src/common/ta_control.c 1 file changed, 21 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/87/41787/1 diff --git a/src/common/ta_control.c b/src/common/ta_control.c index 6fe409a..c3e4d67 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -22,6 +22,9 @@ /* Related specs: 3GPP TS 45.010 sections 5.5, 5.6 */ +#include <stdint.h> +#include <stdbool.h> + #include <osmo-bts/gsm_data.h> #include <osmo-bts/bts_trx.h> #include <osmo-bts/logging.h> @@ -39,6 +42,22 @@ #define TA_MAX_DEC_STEP 2 +/* Shall we skip current block based on configured interval? */ +static bool ctrl_interval_skip_block(struct gsm_lchan *lchan) +{ + /* TA control interval: how many blocks do we skip? */ + if (lchan->ta_ctrl.skip_block_num-- > 0) + return true; + + /* Reset the number of SACCH blocks to be skipped: + * ctrl_interval=0 => 0 blocks to skip, + * ctrl_interval=1 => 1 blocks to skip, + * ctrl_interval=2 => 3 blocks to skip, + * so basically ctrl_interval * 2 - 1. */ + lchan->ta_ctrl.skip_block_num = lchan->ts->trx->ta_ctrl_interval * 2 - 1; + return false; +} + /*! compute the new "Ordered Timing Advance" communicated to the MS and store it in lchan. * \param lchan logical channel for which to compute (and in which to store) new power value. * \param[in] ms_tx_ta The TA used by the MS and reported in L1SACCH, see struct gsm_sacch_l1_hdr field "ta". @@ -47,19 +66,11 @@ void lchan_ms_ta_ctrl(struct gsm_lchan *lchan, uint8_t ms_tx_ta, int16_t toa256) { int16_t new_ta; + /* Shall we skip current block based on configured interval? */ - - /* TA control interval: how many blocks do we skip? */ - if (lchan->ta_ctrl.skip_block_num-- > 0) + if (ctrl_interval_skip_block(lchan)) return; - /* Reset the number of SACCH blocks to be skipped: - * ctrl_interval=0 => 0 blocks to skip, - * ctrl_interval=1 => 1 blocks to skip, - * ctrl_interval=2 => 3 blocks to skip, - * so basically ctrl_interval * 2 - 1. */ - lchan->ta_ctrl.skip_block_num = lchan->ts->trx->ta_ctrl_interval * 2 - 1; - int16_t delta_ta = toa256/256; if (toa256 >= 0) { if ((toa256 - (256 * delta_ta)) > TOA256_THRESH) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41787?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I174f2f941fbedbe0793cc0b93d01e53e23328cf2 Gerrit-Change-Number: 41787 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: ta_control: Add missing include for lchan.h
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41789?usp=email ) Change subject: ta_control: Add missing include for lchan.h ...................................................................... ta_control: Add missing include for lchan.h Change-Id: Iea1f7ed303ebd0c12a48bb3edf73a494b8736a39 --- M src/common/ta_control.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/89/41789/1 diff --git a/src/common/ta_control.c b/src/common/ta_control.c index 10b04a9..64c44be 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -27,6 +27,7 @@ #include <osmo-bts/gsm_data.h> #include <osmo-bts/bts_trx.h> +#include <osmo-bts/lchan.h> #include <osmo-bts/logging.h> /* 3GPP TS 45.010 sec 5.6.3 Delay assessment error: -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41789?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Iea1f7ed303ebd0c12a48bb3edf73a494b8736a39 Gerrit-Change-Number: 41789 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmo-bts[master]: ta_control: Fix skip_block_num not reset when switching TS to PDCH
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email ) Change subject: ta_control: Fix skip_block_num not reset when switching TS to PDCH ...................................................................... ta_control: Fix skip_block_num not reset when switching TS to PDCH Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d --- M include/osmo-bts/ta_control.h M src/common/rsl.c M src/common/ta_control.c 3 files changed, 14 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/90/41790/1 diff --git a/include/osmo-bts/ta_control.h b/include/osmo-bts/ta_control.h index bf99331..e003245 100644 --- a/include/osmo-bts/ta_control.h +++ b/include/osmo-bts/ta_control.h @@ -2,4 +2,6 @@ #include <osmo-bts/gsm_data.h> +void lchan_ms_ta_ctrl_reset(struct gsm_lchan *lchan); + void lchan_ms_ta_ctrl(struct gsm_lchan *lchan, uint8_t ms_tx_ta, int16_t toa256); diff --git a/src/common/rsl.c b/src/common/rsl.c index f16fe7c..ba403bc 100644 --- a/src/common/rsl.c +++ b/src/common/rsl.c @@ -58,6 +58,7 @@ #include <osmo-bts/pcuif_proto.h> #include <osmo-bts/notification.h> #include <osmo-bts/asci.h> +#include <osmo-bts/ta_control.h> //#define FAKE_CIPH_MODE_COMPL @@ -1765,7 +1766,7 @@ memset(&lchan->ho, 0, sizeof(lchan->ho)); memset(&lchan->ms_power_ctrl, 0, sizeof(lchan->ms_power_ctrl)); memset(&lchan->bs_power_ctrl, 0, sizeof(lchan->bs_power_ctrl)); - lchan->ta_ctrl.current = 0; + lchan_ms_ta_ctrl_reset(lchan); copy_sacch_si_to_lchan(lchan); memset(&lchan->tch, 0, sizeof(lchan->tch)); } diff --git a/src/common/ta_control.c b/src/common/ta_control.c index 64c44be..0fae5a4 100644 --- a/src/common/ta_control.c +++ b/src/common/ta_control.c @@ -42,6 +42,16 @@ #define TA_MAX_INC_STEP 2 #define TA_MAX_DEC_STEP 2 +void lchan_ms_ta_ctrl_reset(struct gsm_lchan *lchan) +{ + /* Reset the number of SACCH blocks to be skipped: + * ctrl_interval=0 => 0 blocks to skip, + * ctrl_interval=1 => 1 blocks to skip, + * ctrl_interval=2 => 3 blocks to skip, + * so basically ctrl_interval * 2 - 1. */ + lchan->ta_ctrl.skip_block_num = lchan->ts->trx->ta_ctrl_interval * 2 - 1; + lchan->ta_ctrl.current = 0; +} /* Shall we skip current block based on configured interval? */ static bool ctrl_interval_skip_block(struct gsm_lchan *lchan) -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41790?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Id3e81ebec04042dd7d8e4805762e3e518790706d Gerrit-Change-Number: 41790 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[XS] Change in osmo-bts[master]: ta_control: Reset state during lchan deactivation
by pespin 09 Jan '26

09 Jan '26

pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/41791?usp=email ) Change subject: ta_control: Reset state during lchan deactivation ...................................................................... ta_control: Reset state during lchan deactivation Otherwise next time the lchan is activated, its ta_ctrl.skip_block_num will be different based on previous lchan state. Change-Id: I2aacbbc5b2db46c17b1266b5b5e84d8286d0cf83 --- M src/common/lchan.c 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/91/41791/1 diff --git a/src/common/lchan.c b/src/common/lchan.c index 0afc294..7123cee 100644 --- a/src/common/lchan.c +++ b/src/common/lchan.c @@ -34,6 +34,7 @@ #include <osmo-bts/l1sap.h> #include <osmo-bts/bts_model.h> #include <osmo-bts/asci.h> +#include <osmo-bts/ta_control.h> #include <errno.h> static const struct value_string lchan_s_names[] = { @@ -325,6 +326,7 @@ lchan->pending_rel_ind_msg = NULL; msgb_free(lchan->pending_chan_activ); lchan->pending_chan_activ = NULL; + lchan_ms_ta_ctrl_reset(lchan); /* fall through */ default: if (lchan->early_rr_ia) { -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41791?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I2aacbbc5b2db46c17b1266b5b5e84d8286d0cf83 Gerrit-Change-Number: 41791 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: Print SMSC in read mode
by laforge 09 Jan '26

09 Jan '26

Attention is currently required from: phcoder. laforge has posted comments on this change by phcoder. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in read mode ...................................................................... Patch Set 2: Code-Review-1 (1 comment) Patchset: PS2: I don't think we want to merge this, sorry. `pySim-{read,prog}` are legacy tools that are virtually unmaintained except major bugfixes for many years by now. The proper thing to do is to reimplement the same functionality based on `pySim.filesystem` and all the powerful encoder/decoder functionality we have in `pySim-shell`. But sadly we haven't seen anyone volunteering fo that yet ;) Meanwhilw, if we were to add a new decoder for a file (like SMSP here), it should use the class `pySim.ts_51_011.EF_SMSP()` for decoding and not implement another open-coded/manual encoder. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 2 Gerrit-Owner: phcoder <phcoder(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: phcoder <phcoder(a)gmail.com> Gerrit-Comment-Date: Fri, 09 Jan 2026 10:25:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: Print SMSC in read mode
by phcoder 09 Jan '26

09 Jan '26

Attention is currently required from: phcoder. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins Builder Change subject: Print SMSC in read mode ...................................................................... Print SMSC in read mode Change-Id: I17067b68086316d51fd71ba77049874605594e3f --- M pySim-read.py M pySim/legacy/utils.py 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/41786/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 2 Gerrit-Owner: phcoder <phcoder(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Attention: phcoder <phcoder(a)gmail.com>

1 0

[S] Change in pysim[master]: Print SMSC in read mode
by phcoder 09 Jan '26

09 Jan '26

phcoder has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/41786?usp=email ) Change subject: Print SMSC in read mode ...................................................................... Print SMSC in read mode Change-Id: I17067b68086316d51fd71ba77049874605594e3f --- M pySim-read.py M pySim/legacy/utils.py 2 files changed, 12 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/86/41786/1 diff --git a/pySim-read.py b/pySim-read.py index 9829a15..ab2049b 100755 --- a/pySim-read.py +++ b/pySim-read.py @@ -43,7 +43,7 @@ from pySim.exceptions import SwMatchError from pySim.legacy.cards import card_detect, SimCard, UsimCard, IsimCard from pySim.utils import dec_imsi, dec_iccid -from pySim.legacy.utils import format_xplmn_w_act, dec_st, dec_msisdn +from pySim.legacy.utils import format_xplmn_w_act, dec_st, dec_msisdn, dec_smsc_from_smsp option_parser = argparse.ArgumentParser(description='Legacy tool for reading some parts of a SIM card', formatter_class=argparse.ArgumentDefaultsHelpFormatter) @@ -141,6 +141,7 @@ (res, sw) = card.read_record('SMSP', 1) if sw == '9000': print("SMSP: %s" % (res,)) + print("SMSC: %s" % (dec_smsc_from_smsp(res),)) else: print("SMSP: Can't read, response code = %s" % (sw,)) diff --git a/pySim/legacy/utils.py b/pySim/legacy/utils.py index 49c8633..f96e318 100644 --- a/pySim/legacy/utils.py +++ b/pySim/legacy/utils.py @@ -334,6 +334,16 @@ return s +def dec_smsc_from_smsp(smsp): + y = (len(smsp) // 2) - 28 + if y <= 0: + return (None, sw) + tp_sca = smsp[((y+14)*2):((y+25)*2)] + prefix = '+' if tp_sca[0:2] == '91' else '' + + return prefix + swap_nibbles(tp_sca[2:]).rstrip('f') + + def dec_msisdn(ef_msisdn: Hexstr) -> Optional[Tuple[int, int, Optional[str]]]: """ Decode MSISDN from EF.MSISDN or EF.ADN (same structure). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41786?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I17067b68086316d51fd71ba77049874605594e3f Gerrit-Change-Number: 41786 Gerrit-PatchSet: 1 Gerrit-Owner: phcoder <phcoder(a)gmail.com>

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by laforge 08 Jan '26

08 Jan '26

Attention is currently required from: fixeria, pespin. laforge has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email ) Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jan 2026 20:25:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl
by pespin 08 Jan '26

08 Jan '26

Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email to look at the new patch set (#2). Change subject: bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl ...................................................................... bts: Fix sporadic failure in TC_rsl_ms_pwr_ctrl Fix following sporadic race condition: TTCN-MS IUTS-BTS TTCN-BSC | |<----CHAN_ACT------| |<--SACCH(A)-- | | | |<--MS_PWR_CTRL(B)- | |<--SACCH(B)---| Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 --- M bts/BTS_Tests.ttcn 1 file changed, 12 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/85/41785/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41785?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I088b58bf76765c8a5bd167590c5afc5055fbdbf8 Gerrit-Change-Number: 41785 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026