January 2026 - gerrit-log - lists.osmocom.org

[S] Change in libosmo-netif[master]: stream: Fix build with --disable-libsctp
by pespin 27 Jan '26

27 Jan '26

Attention is currently required from: Timur Davydov. pespin has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email ) Change subject: stream: Fix build with --disable-libsctp ...................................................................... Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/41952?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I07ef25f3fcc39f9bee023d9264a72c4381b82b65 Gerrit-Change-Number: 41952 Gerrit-PatchSet: 4 Gerrit-Owner: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: Timur Davydov <dtv.comp(a)gmail.com> Gerrit-Comment-Date: Mon, 26 Jan 2026 21:06:54 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmo-ttcn3-hacks[master]: sccp: Introduce test TC_local_unavailable_user_part_dupu
by fixeria 27 Jan '26

27 Jan '26

Attention is currently required from: pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41954?usp=email ) Change subject: sccp: Introduce test TC_local_unavailable_user_part_dupu ...................................................................... Patch Set 1: (1 comment) File sccp/SCCP_Tests_RAW.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41954/comment/70ebaef6_3042… : PS1, Line 543: var integer conn_id := 1234; : v unused? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41954?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia0e71cc98c267692bc9230be8d15bbc861d5daad Gerrit-Change-Number: 41954 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 21:03:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No

1 0

[S] Change in pysim[master]: pySim-trace: pySim.apdu_source.stdin_hex
by fixeria 27 Jan '26

27 Jan '26

Attention is currently required from: dexter, laforge. fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim-trace: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 20:57:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[ttcn3-bts-test]: fake_trx: reset settings on CMD POWEROFF
by fixeria 27 Jan '26

27 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email ) Change subject: fake_trx: reset settings on CMD POWEROFF ...................................................................... fake_trx: reset settings on CMD POWEROFF When running ttcn3-bts-test, parameters such as SETTA, FAKE_RSSI, FAKE_TOA, and others may persist across testcases if not explicitly reset, leading to unintended cross-test interference. Reset all transceiver settings on CMD POWEROFF to ensure proper test isolation and predictable behavior between testcases. Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 (cherry picked from commit 754d5ebb1e120e661fd3b1e025abfc5b5216ac80) --- M src/target/trx_toolkit/fake_trx.py M src/target/trx_toolkit/transceiver.py 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: pespin: Looks good to me, but someone else must approve fixeria: Looks good to me, approved; Verified diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 7dc80d1..1aba866 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -116,7 +116,12 @@ CI_NOISE_DEFAULT = -30 def __init__(self, *trx_args, **trx_kwargs): - Transceiver.__init__(self, *trx_args, **trx_kwargs) + super().__init__(*trx_args, **trx_kwargs) + self.reset_params() + + def reset_params(self): + """ Reset/initialize all parameters """ + super().reset_params() # fake RSSI is disabled by default, only enabled through TRXC FAKE_RSSI. # When disabled, RSSI is calculated based on Tx power and Rx path loss diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index ffd18ab..d0ff955 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -205,6 +205,13 @@ log.info("(%s) Frequency hopping disabled" % self) self.fh = None + def reset_params(self): + """ Reset/initialize all parameters """ + self.running = False + self._rx_freq = None + self._tx_freq = None + self.disable_fh() + # To be overwritten if required, # no custom command handlers by default def ctrl_cmd_handler(self, request): @@ -220,7 +227,7 @@ for trx in trx_list: trx.running = poweron if not poweron: - trx.disable_fh() + trx.reset_params() # Trigger clock generator if required if self.clck_gen is not None: -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: ttcn3-bts-test Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 Gerrit-Change-Number: 41946 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in osmocom-bb[ttcn3-bts-test]: fake_trx: reset settings on CMD POWEROFF
by fixeria 27 Jan '26

27 Jan '26

Attention is currently required from: osmith. fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email ) Change subject: fake_trx: reset settings on CMD POWEROFF ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41946?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmocom-bb Gerrit-Branch: ttcn3-bts-test Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 Gerrit-Change-Number: 41946 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: osmith <osmith(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 20:52:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in osmocom-bb[master]: fake_trx: reset settings on CMD POWEROFF
by fixeria 27 Jan '26

27 Jan '26

fixeria has submitted this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/41945?usp=email ) Change subject: fake_trx: reset settings on CMD POWEROFF ...................................................................... fake_trx: reset settings on CMD POWEROFF When running ttcn3-bts-test, parameters such as SETTA, FAKE_RSSI, FAKE_TOA, and others may persist across testcases if not explicitly reset, leading to unintended cross-test interference. Reset all transceiver settings on CMD POWEROFF to ensure proper test isolation and predictable behavior between testcases. Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 --- M src/target/trx_toolkit/fake_trx.py M src/target/trx_toolkit/transceiver.py 2 files changed, 14 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve diff --git a/src/target/trx_toolkit/fake_trx.py b/src/target/trx_toolkit/fake_trx.py index 711ad21..ebb8c23 100755 --- a/src/target/trx_toolkit/fake_trx.py +++ b/src/target/trx_toolkit/fake_trx.py @@ -116,7 +116,12 @@ CI_NOISE_DEFAULT = -30 def __init__(self, *trx_args, **trx_kwargs): - Transceiver.__init__(self, *trx_args, **trx_kwargs) + super().__init__(*trx_args, **trx_kwargs) + self.reset_params() + + def reset_params(self): + """ Reset/initialize all parameters """ + super().reset_params() # fake RSSI is disabled by default, only enabled through TRXC FAKE_RSSI. # When disabled, RSSI is calculated based on Tx power and Rx path loss diff --git a/src/target/trx_toolkit/transceiver.py b/src/target/trx_toolkit/transceiver.py index ce71bb1..20d9cde 100644 --- a/src/target/trx_toolkit/transceiver.py +++ b/src/target/trx_toolkit/transceiver.py @@ -241,6 +241,13 @@ log.info("(%s) Frequency hopping disabled" % self) self.fh = None + def reset_params(self): + """ Reset/initialize all parameters """ + self.running = False + self._rx_freq = None + self._tx_freq = None + self.disable_fh() + # To be overwritten if required, # no custom command handlers by default def ctrl_cmd_handler(self, request): @@ -257,7 +264,7 @@ trx.running = poweron if not poweron: trx.tx_queue_clear() - trx.disable_fh() + trx.reset_params() # Trigger clock generator if required if self.clck_gen is not None: -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/41945?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I5c58bc684acc7a58d7aa940bb2ae7597d4a282f2 Gerrit-Change-Number: 41945 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: osmith <osmith(a)sysmocom.de> Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>

1 0

[S] Change in pysim[master]: pySimLogger: user __name__ of the module when creating a new logger
by fixeria 27 Jan '26

27 Jan '26

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41890?usp=email ) Change subject: pySimLogger: user __name__ of the module when creating a new logger ...................................................................... Patch Set 2: (2 comments) File contrib/csv-to-pgsql.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/5dfca265_536b2b24?usp=em… : PS1, Line 38: log = PySimLogger.get(__name__) > this is odd, the code should have acces to global variabls of the same module. […] Indeed, `log` should be accessible globally. Having a dedicated logger just for the `__init__()` method is weird and makes even less sense with this patch applied. Not blocking here, though. You can address this in a separate patch. File pySim/card_key_provider.py: https://gerrit.osmocom.org/c/pysim/+/41890/comment/725711da_08ecf9cb?usp=em… : PS1, Line 41: PySimLogger.get > I gave this a try, but as it seems it is not the same. […] I was wrong about inheriting configuration of the parent loggers then. Perhaps you need to configure the `root` logger in `pySim-shell.py` and `pySim-trace.py` then. Anyways, not blocking here. Can be done in a separate patch (I can work on it). -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I49a9beb98845f66247edd42ed548980c97a7151a Gerrit-Change-Number: 41890 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-CC: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 20:51:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge(a)osmocom.org> Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

[S] Change in pysim[master]: transport/init: use PySimLogger to print messages
by fixeria 27 Jan '26

27 Jan '26

Attention is currently required from: dexter. fixeria has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/pysim/+/41812?usp=email ) Change subject: transport/init: use PySimLogger to print messages ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/41812?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I2e2ec2b84f3b84dbd8a029ae9bb64b7a96ddbde3 Gerrit-Change-Number: 41812 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 20:38:50 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes

1 0

[S] Change in pysim[master]: pySim-trace: pySim.apdu_source.stdin_hex
by laforge 27 Jan '26

27 Jan '26

Attention is currently required from: dexter, fixeria. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37925?usp=email ) Change subject: pySim-trace: pySim.apdu_source.stdin_hex ...................................................................... Patch Set 6: Code-Review+2 (1 comment) Patchset: PS6: re-add +2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/37925?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I5aacf13b7c27cea9efd42f01dacca61068c3aa33 Gerrit-Change-Number: 37925 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 20:21:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes

1 0

[M] Change in pysim[master]: pySim.esim.saip: Implement optimized file content encoding
by laforge 27 Jan '26

27 Jan '26

Attention is currently required from: dexter, neels. laforge has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/38014?usp=email ) Change subject: pySim.esim.saip: Implement optimized file content encoding ...................................................................... Patch Set 6: (2 comments) File pySim/esim/saip/__init__.py: https://gerrit.osmocom.org/c/pysim/+/38014/comment/27bf2d19_6aa2f9e9?usp=em… : PS6, Line 61: assert match.a >= cur > maybe return also return a ValueError? (The caller does not have to check for the ValueError and rai […] Done https://gerrit.osmocom.org/c/pysim/+/38014/comment/f8d738cf_a5e14c4e?usp=em… : PS6, Line 463: ret.append(('fillFileOffset', block.a - cur)) > cur is set to 0 at the beginning but it does not get re-assigned. […] thanks, I fixed it in the next version. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38014?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I61e4a5e04beba5c9092979fc546292d5ef3d7aad Gerrit-Change-Number: 38014 Gerrit-PatchSet: 6 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Mon, 26 Jan 2026 20:19:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: dexter <pmaier(a)sysmocom.de>

1 0

2026

2025

2024

2023

2022

gerrit-log January 2026